diff options
| author |  Christoph Hertzberg <chtz@informatik.uni-bremen.de> | 2018-04-15 10:15:28 +0200 |
|---|---|---|
| committer | Christoph Hertzberg <chtz@informatik.uni-bremen.de> | 2018-04-15 10:15:28 +0200 |
| commit | 42715533f1bff346d024edce4f79c5fdef7dba04 (patch) | |
| tree | 890933ca37855451588e4dbc05ea4b94b8e694c3 /Eigen/src/QR/HouseholderQR.h | |
| parent | c9ecfff2e6ab3e68bc4569e05f3e29503e756da2 (diff) | |
bug #1493: Make representation of HouseholderSequence consistent and working for complex numbers. Made corresponding unit test actually test that. Also simplify implementation of QR decompositions
Diffstat (limited to 'Eigen/src/QR/HouseholderQR.h')
| -rw-r--r-- | Eigen/src/QR/HouseholderQR.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/Eigen/src/QR/HouseholderQR.h b/Eigen/src/QR/HouseholderQR.h index 762b21c36..13c02685d 100644 --- a/Eigen/src/QR/HouseholderQR.h +++ b/Eigen/src/QR/HouseholderQR.h @@ -353,11 +353,7 @@ void HouseholderQR<_MatrixType>::_solve_impl(const RhsType &rhs, DstType &dst) c typename RhsType::PlainObject c(rhs); - // Note that the matrix Q = H_0^* H_1^*... so its inverse is Q^* = (H_0 H_1 ...)^T - c.applyOnTheLeft(householderSequence( - m_qr.leftCols(rank), - m_hCoeffs.head(rank)).transpose() - ); + c.applyOnTheLeft(householderQ().setLength(rank).adjoint() ); m_qr.topLeftCorner(rank, rank) .template triangularView<Upper>() |