diff options
| author |  Rasmus Munk Larsen <rmlarsen@google.com> | 2016-04-04 14:20:01 -0700 |
|---|---|---|
| committer | Rasmus Munk Larsen <rmlarsen@google.com> | 2016-04-04 14:20:01 -0700 |
| commit | 86e0ed81f8db5a0c9562b62a67a9ba60ec58dec0 (patch) | |
| tree | 10d4e195015009b69a76bff39bc824f0e1e8fb09 /Eigen/src/LU | |
| parent | 30242b75653fa4128181dba364f540184beff5ac (diff) | |
Addresses comments on Eigen pull request PR-174.
* Get rid of code-duplication for real vs. complex matrices.
* Fix flipped arguments to select.
* Make the condition estimation functions free functions.
* Use Vector::Unit() to generate canonical unit vectors.
* Misc. cleanup.
Diffstat (limited to 'Eigen/src/LU')
| -rw-r--r-- | Eigen/src/LU/FullPivLU.h | 2 | ||||
| -rw-r--r-- | Eigen/src/LU/PartialPivLU.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/Eigen/src/LU/FullPivLU.h b/Eigen/src/LU/FullPivLU.h index ff0b78c35..978a54eff 100644 --- a/Eigen/src/LU/FullPivLU.h +++ b/Eigen/src/LU/FullPivLU.h @@ -237,7 +237,7 @@ template<typename _MatrixType> class FullPivLU inline RealScalar rcond() const { eigen_assert(m_isInitialized && "PartialPivLU is not initialized."); - return ConditionEstimator<FullPivLU<_MatrixType> >::rcond(m_l1_norm, *this); + return ReciprocalConditionNumberEstimate(m_l1_norm, *this); } /** \returns the determinant of the matrix of which diff --git a/Eigen/src/LU/PartialPivLU.h b/Eigen/src/LU/PartialPivLU.h index 5d71a66d0..b22dd75fe 100644 --- a/Eigen/src/LU/PartialPivLU.h +++ b/Eigen/src/LU/PartialPivLU.h @@ -157,7 +157,7 @@ template<typename _MatrixType> class PartialPivLU inline RealScalar rcond() const { eigen_assert(m_isInitialized && "PartialPivLU is not initialized."); - return ConditionEstimator<PartialPivLU<_MatrixType> >::rcond(m_l1_norm, *this); + return ReciprocalConditionNumberEstimate(m_l1_norm, *this); } /** \returns the inverse of the matrix of which *this is the LU decomposition. |