diff options
author | Benoit Jacob <jacob.benoit.1@gmail.com> | 2008-08-09 04:37:09 +0000 |
---|---|---|
committer | Benoit Jacob <jacob.benoit.1@gmail.com> | 2008-08-09 04:37:09 +0000 |
commit | a41f2b4216eda0181db6cc33fb064a368a900591 (patch) | |
tree | 97050ff1d9ed025c420224ac5de2cb64a29c76d9 /Eigen/src/LU/Determinant.h | |
parent | 9bbe396939c925854cdce8aabcff1ebe0a8f23bc (diff) |
* fix bug in SwapWrapper : store the wrapped expression by reference
* optimize setIdentity: when the matrix is large enough it is better to
setZero() and overwrite the diagonal
* start of LU solver, disabled for now
Diffstat (limited to 'Eigen/src/LU/Determinant.h')
-rw-r--r-- | Eigen/src/LU/Determinant.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Eigen/src/LU/Determinant.h b/Eigen/src/LU/Determinant.h index c1746e1ab..9b90f4235 100644 --- a/Eigen/src/LU/Determinant.h +++ b/Eigen/src/LU/Determinant.h @@ -26,7 +26,7 @@ #define EIGEN_DETERMINANT_H template<typename Derived> -const typename Derived::Scalar ei_bruteforce_det3_helper +inline const typename Derived::Scalar ei_bruteforce_det3_helper (const MatrixBase<Derived>& matrix, int a, int b, int c) { return matrix.coeff(0,a) @@ -86,7 +86,7 @@ template<typename Derived> struct ei_determinant_impl<Derived, 2> template<typename Derived> struct ei_determinant_impl<Derived, 3> { - static inline typename ei_traits<Derived>::Scalar run(const Derived& m) + static typename ei_traits<Derived>::Scalar run(const Derived& m) { return ei_bruteforce_det3_helper(m,0,1,2) - ei_bruteforce_det3_helper(m,1,0,2) @@ -96,7 +96,7 @@ template<typename Derived> struct ei_determinant_impl<Derived, 3> template<typename Derived> struct ei_determinant_impl<Derived, 4> { - static inline typename ei_traits<Derived>::Scalar run(const Derived& m) + static typename ei_traits<Derived>::Scalar run(const Derived& m) { // trick by Martin Costabel to compute 4x4 det with only 30 muls return ei_bruteforce_det4_helper(m,0,1,2,3) @@ -113,7 +113,7 @@ template<typename Derived> struct ei_determinant_impl<Derived, 4> * \returns the determinant of this matrix */ template<typename Derived> -typename ei_traits<Derived>::Scalar MatrixBase<Derived>::determinant() const +inline typename ei_traits<Derived>::Scalar MatrixBase<Derived>::determinant() const { assert(rows() == cols()); return ei_determinant_impl<Derived>::run(derived()); |