diff options
author | Gael Guennebaud <g.gael@free.fr> | 2013-02-25 18:05:57 +0100 |
---|---|---|
committer | Gael Guennebaud <g.gael@free.fr> | 2013-02-25 18:05:57 +0100 |
commit | 12a1313b09bcfdddc2cda311d6cb29b2accc2763 (patch) | |
tree | f0a58aa37bd9f162502f052897c749d3d5790f5f /Eigen/src/Jacobi/Jacobi.h | |
parent | cc35c4425698f8a9b8293af0c02dfc385442ad6b (diff) |
bug #482: pass scalar arguments by const references. Still remains a few cases that might affect the ABI (see the bug entry)
Diffstat (limited to 'Eigen/src/Jacobi/Jacobi.h')
-rw-r--r-- | Eigen/src/Jacobi/Jacobi.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Eigen/src/Jacobi/Jacobi.h b/Eigen/src/Jacobi/Jacobi.h index 20e227640..d9d75196c 100644 --- a/Eigen/src/Jacobi/Jacobi.h +++ b/Eigen/src/Jacobi/Jacobi.h @@ -63,7 +63,7 @@ template<typename Scalar> class JacobiRotation template<typename Derived> bool makeJacobi(const MatrixBase<Derived>&, typename Derived::Index p, typename Derived::Index q); - bool makeJacobi(RealScalar x, Scalar y, RealScalar z); + bool makeJacobi(const RealScalar& x, const Scalar& y, const RealScalar& z); void makeGivens(const Scalar& p, const Scalar& q, Scalar* z=0); @@ -80,7 +80,7 @@ template<typename Scalar> class JacobiRotation * \sa MatrixBase::makeJacobi(const MatrixBase<Derived>&, Index, Index), MatrixBase::applyOnTheLeft(), MatrixBase::applyOnTheRight() */ template<typename Scalar> -bool JacobiRotation<Scalar>::makeJacobi(RealScalar x, Scalar y, RealScalar z) +bool JacobiRotation<Scalar>::makeJacobi(const RealScalar& x, const Scalar& y, const RealScalar& z) { using std::sqrt; using std::abs; |