diff options
author | Gael Guennebaud <g.gael@free.fr> | 2015-04-15 14:47:08 +0200 |
---|---|---|
committer | Gael Guennebaud <g.gael@free.fr> | 2015-04-15 14:47:08 +0200 |
commit | 5dbe758dc337c9d28b0fee83d009b43b4c38aedd (patch) | |
tree | 505ba8b935b45b4a508bcc61428d884e8a453032 /Eigen/src/Geometry | |
parent | 04c8c5d9efdf1f29901b6f1db266b1caf4853b12 (diff) |
Backed out changeset 04c8c5d9efdf1f29901b6f1db266b1caf4853b12
Diffstat (limited to 'Eigen/src/Geometry')
-rw-r--r-- | Eigen/src/Geometry/OrthoMethods.h | 3 | ||||
-rw-r--r-- | Eigen/src/Geometry/Quaternion.h | 4 |
2 files changed, 2 insertions, 5 deletions
diff --git a/Eigen/src/Geometry/OrthoMethods.h b/Eigen/src/Geometry/OrthoMethods.h index 655622e90..6b2e57392 100644 --- a/Eigen/src/Geometry/OrthoMethods.h +++ b/Eigen/src/Geometry/OrthoMethods.h @@ -18,9 +18,6 @@ namespace Eigen { * \returns the cross product of \c *this and \a other * * Here is a very good explanation of cross-product: http://xkcd.com/199/ - * - * With complex numbers, the cross product is implemented as \f$ \mathbf{a}+\mathrm{i}\mathbf{b}) \times \f$ - * * \sa MatrixBase::cross3() */ template<typename Derived> diff --git a/Eigen/src/Geometry/Quaternion.h b/Eigen/src/Geometry/Quaternion.h index 99b65c231..a89d75958 100644 --- a/Eigen/src/Geometry/Quaternion.h +++ b/Eigen/src/Geometry/Quaternion.h @@ -637,7 +637,7 @@ inline Quaternion<typename internal::traits<Derived>::Scalar> QuaternionBase<Der { // FIXME should this function be called multiplicativeInverse and conjugate() be called inverse() or opposite() ?? Scalar n2 = this->squaredNorm(); - if (n2 > Scalar(0)) + if (n2 > 0) return Quaternion<Scalar>(conjugate().coeffs() / n2); else { @@ -723,7 +723,7 @@ QuaternionBase<Derived>::slerp(const Scalar& t, const QuaternionBase<OtherDerive scale0 = sin( ( Scalar(1) - t ) * theta) / sinTheta; scale1 = sin( ( t * theta) ) / sinTheta; } - if(d<Scalar(0)) scale1 = -scale1; + if(d<0) scale1 = -scale1; return Quaternion<Scalar>(scale0 * coeffs() + scale1 * other.coeffs()); } |