diff options
author | Benoit Jacob <jacob.benoit.1@gmail.com> | 2008-12-03 21:01:55 +0000 |
---|---|---|
committer | Benoit Jacob <jacob.benoit.1@gmail.com> | 2008-12-03 21:01:55 +0000 |
commit | c1e2156d8a45e28a07474c483af7580e055feb70 (patch) | |
tree | 9898a7e039393908fd99b68f13d433ec02567794 /Eigen/src/Geometry/OrthoMethods.h | |
parent | 84cc69f0f3fb0e232435d2318006500f47277e4d (diff) |
* Much better, consistent error msgs when mixing different scalar types:
- in matrix-matrix product, static assert on the two scalar types to be the same.
- Similarly in CwiseBinaryOp. POTENTIALLY CONTROVERSIAL: we don't allow anymore binary
ops to take two different scalar types. The functors that we defined take two args
of the same type anyway; also we still allow the return type to be different.
Again the reason is that different scalar types are incompatible with vectorization.
Better have the user realize explicitly what mixing different numeric types costs him
in terms of performance.
See comment in CwiseBinaryOp constructor.
- This allowed to fix a little mistake in test/regression.cpp, mixing float and double
- Remove redundant semicolon (;) after static asserts
Diffstat (limited to 'Eigen/src/Geometry/OrthoMethods.h')
-rw-r--r-- | Eigen/src/Geometry/OrthoMethods.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Eigen/src/Geometry/OrthoMethods.h b/Eigen/src/Geometry/OrthoMethods.h index f545f176d..d60664cc0 100644 --- a/Eigen/src/Geometry/OrthoMethods.h +++ b/Eigen/src/Geometry/OrthoMethods.h @@ -37,7 +37,7 @@ template<typename OtherDerived> inline typename MatrixBase<Derived>::EvalType MatrixBase<Derived>::cross(const MatrixBase<OtherDerived>& other) const { - EIGEN_STATIC_ASSERT_VECTOR_SPECIFIC_SIZE(Derived,3); + EIGEN_STATIC_ASSERT_VECTOR_SPECIFIC_SIZE(Derived,3) // Note that there is no need for an expression here since the compiler // optimize such a small temporary very well (even within a complex expression) @@ -112,7 +112,7 @@ template<typename Derived> typename MatrixBase<Derived>::EvalType MatrixBase<Derived>::unitOrthogonal() const { - EIGEN_STATIC_ASSERT_VECTOR_ONLY(Derived); + EIGEN_STATIC_ASSERT_VECTOR_ONLY(Derived) return ei_unitOrthogonal_selector<Derived>::run(derived()); } |