diff options
author | 2015-10-18 22:15:01 +0200 | |
---|---|---|
committer | 2015-10-18 22:15:01 +0200 | |
commit | fe630c98739186c1dd3faf7a06b52a64baa5ea23 (patch) | |
tree | dee931dcbc4ddbc803b5ed25e7316cbd01267a2f /Eigen/src/Core/products | |
parent | e99279f444232c81901a84b4d15dae5fcf6d7d37 (diff) |
Improve numerical accuracy in LLT and triangular solve by using true scalar divisions (instead of x * (1/y))
Diffstat (limited to 'Eigen/src/Core/products')
-rw-r--r-- | Eigen/src/Core/products/TriangularSolverMatrix.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/Eigen/src/Core/products/TriangularSolverMatrix.h b/Eigen/src/Core/products/TriangularSolverMatrix.h index a9a198d64..208593718 100644 --- a/Eigen/src/Core/products/TriangularSolverMatrix.h +++ b/Eigen/src/Core/products/TriangularSolverMatrix.h @@ -304,9 +304,12 @@ EIGEN_DONT_INLINE void triangular_solve_matrix<Scalar,Index,OnTheRight,Mode,Conj for (Index i=0; i<actual_mc; ++i) r[i] -= a[i] * b; } - Scalar b = (Mode & UnitDiag) ? Scalar(1) : Scalar(1)/conj(rhs(j,j)); - for (Index i=0; i<actual_mc; ++i) - r[i] *= b; + if((Mode & UnitDiag)==0) + { + Scalar b = conj(rhs(j,j)); + for (Index i=0; i<actual_mc; ++i) + r[i] /= b; + } } // pack the just computed part of lhs to A |