diff options
author | Antonio Sanchez <cantonios@google.com> | 2020-11-18 13:23:13 -0800 |
---|---|---|
committer | Rasmus Munk Larsen <rmlarsen@google.com> | 2020-11-18 23:15:33 +0000 |
commit | a8fdcae55d1f002966fc9b963597a404f30baa09 (patch) | |
tree | 55578884327d442e933d9f975eae0ba798c8966e /Eigen/src/Core/arch/Default | |
parent | 11e4056f6bbcc5dff23d051f662a4e5b91ee36a7 (diff) |
Fix sparse_extra_3, disable counting temporaries for testing DynamicSparseMatrix.
Multiplication of column-major `DynamicSparseMatrix`es involves three
temporaries:
- two for transposing twice to sort the coefficients
(`ConservativeSparseSparseProduct.h`, L160-161)
- one for a final copy assignment (`SparseAssign.h`, L108)
The latter is avoided in an optimization for `SparseMatrix`.
Since `DynamicSparseMatrix` is deprecated in favor of `SparseMatrix`, it's not
worth the effort to optimize further, so I simply disabled counting
temporaries via a macro.
Note that due to the inclusion of `sparse_product.cpp`, the `sparse_extra`
tests actually re-run all the original `sparse_product` tests as well.
We may want to simply drop the `DynamicSparseMatrix` tests altogether, which
would eliminate the test duplication.
Related to #2048
Diffstat (limited to 'Eigen/src/Core/arch/Default')
0 files changed, 0 insertions, 0 deletions