diff options
author | Benoit Jacob <jacob.benoit.1@gmail.com> | 2009-09-22 12:20:45 -0400 |
---|---|---|
committer | Benoit Jacob <jacob.benoit.1@gmail.com> | 2009-09-22 12:20:45 -0400 |
commit | c1c780a94f148c618a74cfcccf40037442ae2d7c (patch) | |
tree | e12cabb53fef344865631c7c9360d995000ea463 /Eigen/src/Core/ReturnByValue.h | |
parent | 1df54e3ac23780cd67c91c50f27052199902f81f (diff) |
* ReturnByValue:
-- simpplify by removing the 2nd template parameter
-- rename Functor to Derived, as now it's a usual CRTP
* Homogeneous:
-- in products, honor the Max sizes etc.
Diffstat (limited to 'Eigen/src/Core/ReturnByValue.h')
-rw-r--r-- | Eigen/src/Core/ReturnByValue.h | 38 |
1 files changed, 15 insertions, 23 deletions
diff --git a/Eigen/src/Core/ReturnByValue.h b/Eigen/src/Core/ReturnByValue.h index 3f2b478ff..4a5d5c105 100644 --- a/Eigen/src/Core/ReturnByValue.h +++ b/Eigen/src/Core/ReturnByValue.h @@ -28,45 +28,37 @@ /** \class ReturnByValue * */ -template<typename Functor, typename _Scalar,int _Rows,int _Cols,int _Options,int _MaxRows,int _MaxCols> -struct ei_traits<ReturnByValue<Functor,Matrix<_Scalar,_Rows,_Cols,_Options,_MaxRows,_MaxCols> > > - : public ei_traits<Matrix<_Scalar,_Rows,_Cols,_Options,_MaxRows,_MaxCols> > +template<typename Derived> +struct ei_traits<ReturnByValue<Derived> > + : public ei_traits<typename ei_traits<Derived>::ReturnMatrixType> { enum { - Flags = ei_traits<Matrix<_Scalar,_Rows,_Cols,_Options,_MaxRows,_MaxCols> >::Flags | EvalBeforeNestingBit + Flags = ei_traits<typename ei_traits<Derived>::ReturnMatrixType>::Flags | EvalBeforeNestingBit }; }; -template<typename Functor,typename EvalTypeDerived,int n> -struct ei_nested<ReturnByValue<Functor,MatrixBase<EvalTypeDerived> >, n, EvalTypeDerived> -{ - typedef EvalTypeDerived type; -}; - -template<typename Functor, typename EvalType> class ReturnByValue +template<typename Derived,int n,typename PlainMatrixType> +struct ei_nested<ReturnByValue<Derived>, n, PlainMatrixType> { - public: - template<typename Dest> inline void evalTo(Dest& dst) const - { static_cast<const Functor*>(this)->evalTo(dst); } + typedef typename ei_traits<Derived>::ReturnMatrixType type; }; -template<typename Functor, typename _Scalar,int _Rows,int _Cols,int _Options,int _MaxRows,int _MaxCols> - class ReturnByValue<Functor,Matrix<_Scalar,_Rows,_Cols,_Options,_MaxRows,_MaxCols> > - : public MatrixBase<ReturnByValue<Functor,Matrix<_Scalar,_Rows,_Cols,_Options,_MaxRows,_MaxCols> > > +template<typename Derived> + class ReturnByValue : public MatrixBase<ReturnByValue<Derived> > { - typedef Matrix<_Scalar,_Rows,_Cols,_Options,_MaxRows,_MaxCols> EvalType; + typedef typename ei_traits<Derived>::ReturnMatrixType ReturnMatrixType; public: EIGEN_GENERIC_PUBLIC_INTERFACE(ReturnByValue) template<typename Dest> inline void evalTo(Dest& dst) const - { static_cast<const Functor* const>(this)->evalTo(dst); } - inline int rows() const { return static_cast<const Functor* const>(this)->rows(); } - inline int cols() const { return static_cast<const Functor* const>(this)->cols(); } + { static_cast<const Derived* const>(this)->evalTo(dst); } + inline int rows() const { return static_cast<const Derived* const>(this)->rows(); } + inline int cols() const { return static_cast<const Derived* const>(this)->cols(); } }; template<typename Derived> -template<typename OtherDerived,typename OtherEvalType> -Derived& MatrixBase<Derived>::operator=(const ReturnByValue<OtherDerived,OtherEvalType>& other) +template<typename OtherDerived> +Derived& MatrixBase<Derived>::operator=(const ReturnByValue<OtherDerived>& other) { other.evalTo(derived()); return derived(); |