big huge changes, so i dont remember everything.

* renaming, e.g. LU ---> FullPivLU
* split tests framework: more robust, e.g. dont generate empty tests if a number is skipped
* make all remaining tests use that splitting, as needed.
* Fix 4x4 inversion (see stable branch)
* Transform::inverse() and geo_transform test : adapt to new inverse() API, it was also trying to instantiate inverse() for 3x4 matrices.
* CMakeLists: more robust regexp to parse the version number
* misc fixes in unit tests

1 files changed, 8 insertions, 1 deletions

diff --git a/Eigen/src/Core/ReturnByValue.h b/Eigen/src/Core/ReturnByValue.h
index 55652db48..87b057f86 100644
--- a/Eigen/src/Core/ReturnByValue.h
+++ b/Eigen/src/Core/ReturnByValue.h
@@ -34,7 +34,14 @@ struct ei_traits<ReturnByValue<Derived> >
   : public ei_traits<typename ei_traits<Derived>::ReturnMatrixType>
 {
   enum {
-    Flags = ei_traits<typename ei_traits<Derived>::ReturnMatrixType>::Flags | EvalBeforeNestingBit
+    // FIXME had to remove the DirectAccessBit for usage like
+    //   matrix.inverse().block(...)
+    // because the Block ctor with direct access
+    // wants to call coeffRef() to get an address, and that fails (infinite recursion) as ReturnByValue
+    // doesnt implement coeffRef(). The better fix is probably rather to make Block work directly
+    // on the nested type, right?
+    Flags = (ei_traits<typename ei_traits<Derived>::ReturnMatrixType>::Flags
+             | EvalBeforeNestingBit) & ~DirectAccessBit
   };
 };