* add CommaInitializer::finished to allow the use of (Matrix3() << v0, v1, v2).finished()

  as an argument of a function. Other possibilities for the name could be "end" or "matrix" ??
* various update in Quaternion, in particular I added a lot of FIXME about the API options,
  these have to be discussed and fixed.

1 files changed, 9 insertions, 0 deletions

diff --git a/Eigen/src/Core/CommaInitializer.h b/Eigen/src/Core/CommaInitializer.h
index 0a555e1b7..61a004780 100644
--- a/Eigen/src/Core/CommaInitializer.h
+++ b/Eigen/src/Core/CommaInitializer.h
@@ -93,6 +93,15 @@ struct MatrixBase<Derived>::CommaInitializer
          && "Too few coefficients passed to Matrix::operator<<");
   }
 
+  /** \returns the built matrix once all its coefficients have been set.
+    * Calling finished is 100% optional. Its purpose is to write expressions
+    * like this:
+    * \code
+    * quaternion.fromRotationMatrix((Matrix3f() << axis0, axis1, axis2).finished());
+    * \endcode
+    */
+  inline Derived& finished() { return m_matrix; }
+
   Derived& m_matrix;
   int m_row; // current row id
   int m_col; // current col id