diff options
author | Antonio Sanchez <cantonios@google.com> | 2021-03-25 12:37:25 -0700 |
---|---|---|
committer | Antonio Sánchez <cantonios@google.com> | 2021-03-30 18:01:27 +0000 |
commit | 78ee3d6261ec6971fcd8fdda6ee040962edde1dc (patch) | |
tree | 77cdb5976e9dc4a8ec7630ed235ac37a8b561b36 /.gitlab | |
parent | af1247fbc160868d124f7f1047a62026eb785d68 (diff) |
Fix CUDA constexpr issues for numeric_limits.
Some CUDA/HIP constants fail on device with `constexpr` since they
internally rely on non-constexpr functions, e.g.
```
\#define CUDART_INF_F __int_as_float(0x7f800000)
```
This fails for cuda-clang (though passes with nvcc). These constants are
currently used by `device::numeric_limits`. For portability, we
need to remove `constexpr` from the affected functions.
For C++11 or higher, we should be able to rely on the `std::numeric_limits`
versions anyways, since the methods themselves are now `constexpr`, so
should be supported on device (clang/hipcc natively, nvcc with
`--expr-relaxed-constexpr`).
Diffstat (limited to '.gitlab')
0 files changed, 0 insertions, 0 deletions