big thanks to charles for the feedback and patches! fixes for building against older libnotify (issue 1+4), use AM_SILENT_RULES (6), compiler warning fixes (5), use GDK_Delete instead of GDK_KEY_Delete (3)

1 files changed, 24 insertions, 17 deletions

diff --git a/src/trg-files-tree-view.c b/src/trg-files-tree-view.c
index d4367c6..d5d705f 100644
--- a/src/trg-files-tree-view.c
+++ b/src/trg-files-tree-view.c
@@ -47,38 +47,45 @@ static void trg_files_tree_view_class_init(TrgFilesTreeViewClass * klass)
 }
 
 static void set_unwanted_foreachfunc(GtkTreeModel * model,
-				     GtkTreePath * path,
-				     GtkTreeIter * iter, gpointer data)
+				     GtkTreePath * path G_GNUC_UNUSED,
+				     GtkTreeIter * iter,
+                                     gpointer data G_GNUC_UNUSED)
 {
     gtk_list_store_set(GTK_LIST_STORE(model), iter, FILESCOL_WANTED,
 		       FALSE, FILESCOL_ICON, GTK_STOCK_CANCEL, -1);
 }
 
 static void set_wanted_foreachfunc(GtkTreeModel * model,
-				   GtkTreePath * path, GtkTreeIter * iter,
-				   gpointer data)
+				   GtkTreePath * path G_GNUC_UNUSED,
+                                   GtkTreeIter * iter,
+				   gpointer data G_GNUC_UNUSED)
 {
     gtk_list_store_set(GTK_LIST_STORE(model), iter, FILESCOL_WANTED,
 		       TRUE, FILESCOL_ICON, GTK_STOCK_FILE, -1);
 }
 
-static void set_low_foreachfunc(GtkTreeModel * model, GtkTreePath * path,
-				GtkTreeIter * iter, gpointer data)
+static void set_low_foreachfunc(GtkTreeModel * model,
+                                GtkTreePath * path G_GNUC_UNUSED,
+				GtkTreeIter * iter,
+                                gpointer data G_GNUC_UNUSED)
 {
     gtk_list_store_set(GTK_LIST_STORE(model), iter, FILESCOL_PRIORITY,
 		       T_PRIORITY_LOW, -1);
 }
 
 static void set_normal_foreachfunc(GtkTreeModel * model,
-				   GtkTreePath * path, GtkTreeIter * iter,
-				   gpointer data)
+				   GtkTreePath * path G_GNUC_UNUSED,
+                                   GtkTreeIter * iter,
+				   gpointer data G_GNUC_UNUSED)
 {
     gtk_list_store_set(GTK_LIST_STORE(model), iter, FILESCOL_PRIORITY,
 		       T_PRIORITY_NORMAL, -1);
 }
 
-static void set_high_foreachfunc(GtkTreeModel * model, GtkTreePath * path,
-				 GtkTreeIter * iter, gpointer data)
+static void set_high_foreachfunc(GtkTreeModel * model,
+                                 GtkTreePath * path G_GNUC_UNUSED,
+				 GtkTreeIter * iter,
+                                 gpointer data G_GNUC_UNUSED)
 {
     gtk_list_store_set(GTK_LIST_STORE(model), iter, FILESCOL_PRIORITY,
 		       T_PRIORITY_HIGH, -1);
@@ -92,7 +99,7 @@ static void add_file_id_to_array(JsonObject * args, gchar * key,
 }
 
 static void send_updated_file_prefs_foreachfunc(GtkTreeModel * model,
-						GtkTreePath * path,
+						GtkTreePath * path G_GNUC_UNUSED,
 						GtkTreeIter * iter,
 						gpointer data)
 {
@@ -169,7 +176,7 @@ static void send_updated_file_prefs(TrgFilesTreeView * tv)
 		   priv->win);
 }
 
-static void set_low(GtkWidget * w, gpointer data)
+static void set_low(GtkWidget * w G_GNUC_UNUSED, gpointer data)
 {
     TrgFilesTreeView *tv = TRG_FILES_TREE_VIEW(data);
     GtkTreeSelection *selection =
@@ -179,7 +186,7 @@ static void set_low(GtkWidget * w, gpointer data)
     send_updated_file_prefs(tv);
 }
 
-static void set_normal(GtkWidget * w, gpointer data)
+static void set_normal(GtkWidget * w G_GNUC_UNUSED, gpointer data)
 {
     TrgFilesTreeView *tv = TRG_FILES_TREE_VIEW(data);
     GtkTreeSelection *selection =
@@ -189,7 +196,7 @@ static void set_normal(GtkWidget * w, gpointer data)
     send_updated_file_prefs(tv);
 }
 
-static void set_high(GtkWidget * w, gpointer data)
+static void set_high(GtkWidget * w G_GNUC_UNUSED, gpointer data)
 {
     TrgFilesTreeView *tv = TRG_FILES_TREE_VIEW(data);
     GtkTreeSelection *selection =
@@ -199,7 +206,7 @@ static void set_high(GtkWidget * w, gpointer data)
     send_updated_file_prefs(tv);
 }
 
-static void set_unwanted(GtkWidget * w, gpointer data)
+static void set_unwanted(GtkWidget * w G_GNUC_UNUSED, gpointer data)
 {
     TrgFilesTreeView *tv = TRG_FILES_TREE_VIEW(data);
     GtkTreeSelection *selection =
@@ -209,7 +216,7 @@ static void set_unwanted(GtkWidget * w, gpointer data)
     send_updated_file_prefs(tv);
 }
 
-static void set_wanted(GtkWidget * w, gpointer data)
+static void set_wanted(GtkWidget * w G_GNUC_UNUSED, gpointer data)
 {
     TrgFilesTreeView *tv = TRG_FILES_TREE_VIEW(data);
     GtkTreeSelection *selection =
@@ -221,7 +228,7 @@ static void set_wanted(GtkWidget * w, gpointer data)
 
 static void
 view_popup_menu(GtkWidget * treeview, GdkEventButton * event,
-		gpointer data)
+		gpointer data G_GNUC_UNUSED)
 {
     GtkWidget *menu, *menuitem;