diff options
author | Alexey Yakovenko <waker@users.sourceforge.net> | 2014-06-30 13:51:00 +0200 |
---|---|---|
committer | Alexey Yakovenko <waker@users.sourceforge.net> | 2014-06-30 13:51:00 +0200 |
commit | 161d2babfd950cb46c771c2679925b389c0583db (patch) | |
tree | e1e9d2956f68d322e265359f2176a097b0a57290 | |
parent | 344bb1ee8a3eed6d5a6e315e5ed8c70b8c31bacf (diff) |
added name comparison to plugin duplicate check, to avoid duplicate plugins when ID is not set
-rw-r--r-- | plugins.c | 8 |
1 files changed, 5 insertions, 3 deletions
@@ -507,9 +507,11 @@ plug_init_plugin (DB_plugin_t* (*loadfunc)(DB_functions_t *), void *handle) { // check if same plugin with the same or bigger version is loaded already plugin_t *prev = NULL; for (plugin_t *p = plugins; p; prev = p, p = p->next) { - if (p->plugin->id && plugin_api->id && !strcmp (p->plugin->id, plugin_api->id)) { + int same_id = p->plugin->id && plugin_api->id && !strcmp (p->plugin->id, plugin_api->id); + int same_name = p->plugin->name && plugin_api->name && !strcmp (p->plugin->name, plugin_api->name); + if (same_id || same_name) { if (plugin_api->version_major > p->plugin->version_major || (plugin_api->version_major == p->plugin->version_major && plugin_api->version_minor > p->plugin->version_minor)) { - trace ("found newer version of plugin \"%s\", replacing\n", plugin_api->id); + trace ("found newer version of plugin \"%s\" (%s), replacing\n", plugin_api->id, plugin_api->name); // unload older plugin before replacing dlclose (p->handle); if (prev) { @@ -524,7 +526,7 @@ plug_init_plugin (DB_plugin_t* (*loadfunc)(DB_functions_t *), void *handle) { free (p); } else { - trace ("found copy of plugin \"%s\", but newer version is already loaded\n", plugin_api->id) + trace ("found copy of plugin \"%s\" (%s), but newer version is already loaded\n", plugin_api->id, plugin_api->name) return -1; } } |