diff options
| author |  Abseil Team <absl-team@google.com> | 2020-05-08 10:36:00 -0700 |
|---|---|---|
| committer |  vslashg <gfalcon@google.com> | 2020-05-08 15:22:38 -0400 |
| commit | c45d1c09d517e145d722e00deea9be6c8be8dd57 (patch) | |
| tree | 6db7d9f18aeb714064b25fd11ade71f3d2fbe3ae /absl/strings/internal/str_format/arg.cc | |
| parent | a35ef8a62ce7cded2f131ccbd2b5c4a81d622507 (diff) | |
Export of internal Abseil changes
--
47f13ea42ae272c995b1cd5073a45e046fa325eb by Matthew Brown <matthewbr@google.com>:
absl::StrFormat: Centralize FormatConversionCharSet vs FormatConversionSpec checking
- Move it into a central location, rather than requiring individual overloads to
validate.
PiperOrigin-RevId: 310583805
--
a567c8fc8032031d551d6b457755851f442e65ad by Gennadiy Rozental <rogeeff@google.com>:
Internal change
PiperOrigin-RevId: 310427635
--
49848f7fab9b0f528d33f60cbccf688e2ea68afa by Gennadiy Rozental <rogeeff@google.com>:
Make Get/Set private methods of absl::Flag<T>.
PiperOrigin-RevId: 310413908
GitOrigin-RevId: 47f13ea42ae272c995b1cd5073a45e046fa325eb
Change-Id: I6530c754731c1a9463877561fa61786460ed60af
Diffstat (limited to 'absl/strings/internal/str_format/arg.cc')
| -rw-r--r-- | absl/strings/internal/str_format/arg.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/absl/strings/internal/str_format/arg.cc b/absl/strings/internal/str_format/arg.cc index 964f25f7..02646add 100644 --- a/absl/strings/internal/str_format/arg.cc +++ b/absl/strings/internal/str_format/arg.cc @@ -302,7 +302,7 @@ bool ConvertIntArg(T v, const FormatConversionSpecImpl conv, return ConvertFloatImpl(static_cast<double>(v), conv, sink); default: - return false; + ABSL_INTERNAL_ASSUME(false); } if (conv.is_basic()) { @@ -321,7 +321,6 @@ bool ConvertFloatArg(T v, const FormatConversionSpecImpl conv, inline bool ConvertStringArg(string_view v, const FormatConversionSpecImpl conv, FormatSinkImpl *sink) { - if (conv.conversion_char() != FormatConversionCharInternal::s) return false; if (conv.is_basic()) { sink->Append(v); return true; @@ -366,7 +365,6 @@ FormatConvertImpl(const char *v, const FormatConversionSpecImpl conv, // ==================== Raw pointers ==================== ArgConvertResult<FormatConversionCharSetInternal::p> FormatConvertImpl( VoidPtr v, const FormatConversionSpecImpl conv, FormatSinkImpl *sink) { - if (conv.conversion_char() != FormatConversionCharInternal::p) return {false}; if (!v.value) { sink->Append("(nil)"); return {true}; |