diff options
| author |  Derek Mauro <dmauro@google.com> | 2024-07-01 09:32:18 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-worker@google.com> | 2024-07-01 09:33:14 -0700 |
| commit | 649f58927db8f223098be81ab5d8a70469848806 (patch) | |
| tree | 13ab5d607e85a7947e58e330ea2dbf4389ad7707 /absl/log/internal/nullstream.h | |
| parent | 57f04ad892729f798da520a80394cf25afe085e8 (diff) | |
Deprecate `ABSL_ATTRIBUTE_NORETURN` in favor of the `[[noreturn]]`
standardized in C++11
Migrate all Abseil code to `[[noreturn]]`. Notably,
https://github.com/abseil/abseil-cpp/issues/1698 reports that
`[[noreturn]]` works better here.
We can't migrate `ABSL_ATTRIBUTE_NORETURN` to use `[[noreturn]]`
because the difference in accepted attribute placement
breaks some code.
PiperOrigin-RevId: 648395324
Change-Id: Icd3e9b837aac25f128e8994de099f1edb3cabccf
Diffstat (limited to 'absl/log/internal/nullstream.h')
| -rw-r--r-- | absl/log/internal/nullstream.h | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/absl/log/internal/nullstream.h b/absl/log/internal/nullstream.h index 9266852e..973e91ab 100644 --- a/absl/log/internal/nullstream.h +++ b/absl/log/internal/nullstream.h @@ -117,16 +117,7 @@ class NullStreamMaybeFatal final : public NullStream { class NullStreamFatal final : public NullStream { public: NullStreamFatal() = default; - // ABSL_ATTRIBUTE_NORETURN doesn't seem to work on destructors with msvc, so - // disable msvc's warning about the d'tor never returning. -#if defined(_MSC_VER) && !defined(__clang__) -#pragma warning(push) -#pragma warning(disable : 4722) -#endif - ABSL_ATTRIBUTE_NORETURN ~NullStreamFatal() { _exit(1); } -#if defined(_MSC_VER) && !defined(__clang__) -#pragma warning(pop) -#endif + [[noreturn]] ~NullStreamFatal() { _exit(1); } }; } // namespace log_internal |