diff options
| author |  Saleem Abdulrasool <abdulras@google.com> | 2022-06-08 12:42:23 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-worker@google.com> | 2022-06-08 12:43:17 -0700 |
| commit | 7a8d20b7841b43cc685230058130bd0f019e4004 (patch) | |
| tree | 7de1a38c0fc21da4d1ed71d4b260aa94e385b863 /absl/flags | |
| parent | ef799d337201e02688c6e07b0cac8912b86f505d (diff) | |
absl: correct the stack trace path on RISCV
When we would perform a stacktrace using the frame pointer walking, because we
did the adjustment for the return address separately, we were misaligning the
stack size and frame. Simplify the logic and correct the offset.
The recovered frame pointer provides us with the return address of the current
frame and the previous frame's frame pointer. Subsequently, we decide if we
want to record this frame or not. The value in `next_frame_pointer` already
points to the value from the previous stack frame (that is the next frame
pointer to iterate). As such, the value computed by `ComputeStackFrameSize` is
the value for the current frame. This was offset by one previously.
Take the opportunity to clean up some of the local comments, fixing typos and
splitting up the comments to reflect the lines that they are associated with.
PiperOrigin-RevId: 453744059
Change-Id: If14813e0ac36f327f4b7594472f2222d05c478aa
Diffstat (limited to 'absl/flags')
0 files changed, 0 insertions, 0 deletions