diff options
| author |  Arkady Shapkin <arkady.shapkin@gmail.com> | 2022-11-03 00:20:28 +0300 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2022-11-03 00:20:28 +0300 |
| commit | d36d20c0511daaa17886c9a6982862840391d974 (patch) | |
| tree | 6280e9580ea3ea387da08956820ad27ce72a6f36 | |
| parent | 1649c037c556bdaca7241bc0113275506bdb9638 (diff) | |
Fix MSVC version checking in lifetime_test.cc
| -rw-r--r-- | absl/synchronization/lifetime_test.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/absl/synchronization/lifetime_test.cc b/absl/synchronization/lifetime_test.cc index cc973a32..1067a331 100644 --- a/absl/synchronization/lifetime_test.cc +++ b/absl/synchronization/lifetime_test.cc @@ -123,10 +123,9 @@ class OnDestruction { }; // These tests require that the compiler correctly supports C++11 constant -// initialization... but MSVC has a known regression since v19.10: +// initialization... but MSVC has a known regression since v19.10 till v19.25: // https://developercommunity.visualstudio.com/content/problem/336946/class-with-constexpr-constructor-not-using-static.html -// TODO(epastor): Limit the affected range once MSVC fixes this bug. -#if defined(__clang__) || !(defined(_MSC_VER) && _MSC_VER > 1900) +#if defined(__clang__) || !(defined(_MSC_VER) && _MSC_VER > 1900 && _MSC_VER < 1925) // kConstInit // Test early usage. (Declaration comes first; definitions must appear after // the test runner.) |