aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar bunnei <bunneidev@gmail.com>2015-02-18 17:36:34 -0500
committerGravatar bunnei <bunneidev@gmail.com>2015-02-18 17:36:34 -0500
commitec8f2210e3d437b93313f2565170fde393fcaae5 (patch)
tree26ac08576ebd4b00e9ed8224fada208288c555de
parent4a48b017ca7fe8fe68dfc84d70864ef6aea6a266 (diff)
parent5d2366e1e9adaa5b4275127dff5005f2ef2f8ff8 (diff)
Merge pull request #580 from lioncash/emplace
core/video_core: Use in-place construction where possible
-rw-r--r--src/core/core_timing.cpp2
-rw-r--r--src/video_core/debug_utils/debug_utils.cpp4
-rw-r--r--src/video_core/gpu_debugger.h4
3 files changed, 5 insertions, 5 deletions
diff --git a/src/core/core_timing.cpp b/src/core/core_timing.cpp
index 60487516..cabe2a07 100644
--- a/src/core/core_timing.cpp
+++ b/src/core/core_timing.cpp
@@ -129,7 +129,7 @@ static void FreeTsEvent(Event* event) {
}
int RegisterEvent(const char* name, TimedCallback callback) {
- event_types.push_back(EventType(callback, name));
+ event_types.emplace_back(callback, name);
return (int)event_types.size() - 1;
}
diff --git a/src/video_core/debug_utils/debug_utils.cpp b/src/video_core/debug_utils/debug_utils.cpp
index 8c4ec104..0beb72e6 100644
--- a/src/video_core/debug_utils/debug_utils.cpp
+++ b/src/video_core/debug_utils/debug_utils.cpp
@@ -189,7 +189,7 @@ void DumpShader(const u32* binary_data, u32 binary_size, const u32* swizzle_data
);
if (it == output_info_table.end()) {
- output_info_table.push_back({});
+ output_info_table.emplace_back();
output_info_table.back().type = type;
output_info_table.back().component_mask = component_mask;
output_info_table.back().id = i;
@@ -285,7 +285,7 @@ void OnPicaRegWrite(u32 id, u32 value)
if (!is_pica_tracing)
return;
- pica_trace->writes.push_back({id, value});
+ pica_trace->writes.emplace_back(id, value);
}
std::unique_ptr<PicaTrace> FinishPicaTracing()
diff --git a/src/video_core/gpu_debugger.h b/src/video_core/gpu_debugger.h
index 03641d93..48ac269e 100644
--- a/src/video_core/gpu_debugger.h
+++ b/src/video_core/gpu_debugger.h
@@ -58,8 +58,8 @@ public:
if (observers.empty())
return;
- gx_command_history.push_back(GSP_GPU::Command());
- GSP_GPU::Command& cmd = gx_command_history[gx_command_history.size()-1];
+ gx_command_history.emplace_back();
+ GSP_GPU::Command& cmd = gx_command_history.back();
memcpy(&cmd, command_data, sizeof(GSP_GPU::Command));