aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Lioncash <mathew1800@gmail.com>2014-08-18 01:58:59 -0400
committerGravatar Lioncash <mathew1800@gmail.com>2014-08-18 01:59:03 -0400
commita49a5fa4d94e48e1f049365a8071ab5207ac5eee (patch)
tree362964ce0d437e8026d634158f41f5fbda229e92
parent68c81f28d947193d050cb04bbcfd42b6ef1307f3 (diff)
Common: Don't return a reference to a string when calling GetName in symbols.cpp
Returning a copy of the string is what was likely meant to be done.
-rw-r--r--src/common/symbols.cpp2
-rw-r--r--src/common/symbols.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/common/symbols.cpp b/src/common/symbols.cpp
index dcc9eeac..d61f4c0c 100644
--- a/src/common/symbols.cpp
+++ b/src/common/symbols.cpp
@@ -40,7 +40,7 @@ namespace Symbols
return symbol;
}
- const std::string& GetName(u32 _address)
+ const std::string GetName(u32 _address)
{
return GetSymbol(_address).name;
}
diff --git a/src/common/symbols.h b/src/common/symbols.h
index b7674965..e59bc5dd 100644
--- a/src/common/symbols.h
+++ b/src/common/symbols.h
@@ -32,7 +32,7 @@ namespace Symbols
void Add(u32 _address, const std::string& _name, u32 _size, u32 _type);
TSymbol GetSymbol(u32 _address);
- const std::string& GetName(u32 _address);
+ const std::string GetName(u32 _address);
void Remove(u32 _address);
void Clear();
};