aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/build_rules/genproto.bzl
Commit message (Collapse)AuthorAge
* Format all bzl files with buildifierGravatar vladmos2018-06-01
| | | | | | This CL aslo enables a presubmit check for correct formatting of all bzl files in //third_party/bazel. PiperOrigin-RevId: 198857055
* protobuf: Use bazel's native java_proto_library rules.Gravatar Jakob Buchgraber2017-06-06
| | | | | | | | | Additional changes: - Introduce a Skylark macro java_library_srcs that provides the source jars of a java_*_library rule. - Remove bazel's own java_proto_library implementation. Change-Id: I18f2259bc75ca0fb32dcd8a6a857c609bd2c7773 PiperOrigin-RevId: 158146210
* Use //third_party/protobuf:protobuf_java instead of ↵Gravatar Carmi Grushko2017-02-09
| | | | | | | | | | | | //third_party/protobuf:protobuf to refer to the Java proto runtime. (second attempt) This is the name in the upstream protobuf repo. -- PiperOrigin-RevId: 147057949 MOS_MIGRATED_REVID=147057949
* Only add the runfiles of artifacts that are actual inputs of the spawn action.Gravatar Florian Weikert2016-10-11
| | | | | | | The previous solution added too many unneeded runfiles, which caused problems with our workers. -- MOS_MIGRATED_REVID=135782773
* Global cleanup change.Gravatar Vladimir Moskva2016-09-12
| | | | | -- MOS_MIGRATED_REVID=132675557
* Global cleanup change.Gravatar Laurent Le Brun2016-07-07
| | | | | -- MOS_MIGRATED_REVID=126687108
* Cut dependency on BoringSSL.Gravatar Lukacs Berki2016-05-09
| | | | | | | gRPC is only used for intra-machine communications, for which not using crypto is perfectly fine. -- MOS_MIGRATED_REVID=121825070
* Make the genproto rules of Bazel usable from other repositories.Gravatar Lukacs Berki2016-04-13
| | | | | | | | | This is mainly so that Dash can be fixed. It's not the optimal solution because then Dash will pull in the whole Bazel repository for a tiny little part of it, though. The optimal solution would be to make Bazel use WORKSPACE dependencies and then factor it out to a separate repository, but this will be good enough to unbreak Dash for the time being. Progress toward fixing https://github.com/bazelbuild/dash/issues/12 . -- MOS_MIGRATED_REVID=119633183
* Support gRPC in the Bazel-internal protobuf rules.Gravatar Lukacs Berki2016-04-11
| | | | | -- MOS_MIGRATED_REVID=119518388
* Remove te protocol compiler rules from @bazel_tools.Gravatar Lukacs Berki2016-04-11
| | | | | | | | | | | | The immmediate reason for this change is that we also need to add gRPC support to the proto rules, and we don't want to also support gRPC in a half-baked way. This makes the Bazel binary much smaller and avoid giving false signals that we (for now) support protobuf compilation. The protobuf rules are only for compiling Bazel itself. RELNOTES[INC]: Bazel does not embed protocol buffer-related rules anymore. -- MOS_MIGRATED_REVID=119516246
* Rollback of commit 3248a5ea6ecb9f5f2080876a70de016825f54707.Gravatar Lukacs Berki2016-04-07
| | | | | | | | | | | | | *** Reason for rollback *** Breaks //src/test/shell/bazel:bazel_example_test because that relies on the protobuf rules depending on @bazel_tools . The correct solution is probably to eliminate the protobuf dependencies from @bazel_tools altogether, but let's make the continuous build green and then think. *** Original change description *** Update our rudimentary proto rules to be able to handle gRPC. -- MOS_MIGRATED_REVID=119271980
* Update our rudimentary proto rules to be able to handle gRPC.Gravatar Lukacs Berki2016-04-07
| | | | | -- MOS_MIGRATED_REVID=119265313
* Add Python protobuf to Bazel third_party and move all protobuf targets intoGravatar David Chen2016-03-17
| | | | | | | //third_party/protobuf. -- MOS_MIGRATED_REVID=117336377
* Restore allow_files and single_file attributes.Gravatar Julio Merino2016-02-23
| | | | | | | | | | | | | | | //src/test/shell/bazel:bazel_example_test broke because of commit a6e448253c289f3d5a353f038a5ea47227515a66, which removed the allow_files and single_file properties of a bunch of attributes in the belief that they were stale. However, //third_party:protoc is in fact a filegroup and thus requires single_file. I still think some of them are unnecessary... but because I do not yet know all possible cases in which these are involved, and to prevent further breakage, let's restore them all just in case. I may reevaluate this at a later stage to clean them up. -- MOS_MIGRATED_REVID=115297686
* Split out Java proto compilation logic to a helper script (take 2).Gravatar Julio Merino2016-02-22
| | | | | | | | | | | | | | | | | | | This is just for clarity and should be a no-op. Maintaining long shell command lines embedded in genrules is not pretty. This change is a combination of commit 8ec3866d9e5d28f6c09546269ec82731c45c28ad and commit ffc891c4efbf498fdb8eaf4d2c922e7e7a58f99d with additional fixes. In particular I have removed unnecessary properties from all rule attributes, have made the rule respect any runfiles, and have reinstanted the explicit dependency on the JDK. The latter is what fixes the breakage we observed in #938, though it seems clear that we are missing a dependency somewhere. I have verified that this now works by running this change on a clean Ubuntu 15.10 VM. -- MOS_MIGRATED_REVID=115081830
* Rollback of commit 8ec3866d9e5d28f6c09546269ec82731c45c28ad.Gravatar Damien Martin-Guillerez2016-02-19
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** Break Jenkins build. See https://github.com/bazelbuild/bazel/issues/938 *** Original change description *** Split out Java proto compilation logic to a helper script. This is just for clarity and should be a no-op. Maintaining long shell command lines embedded in genrules is not pretty. -- MOS_MIGRATED_REVID=115048759
* Rename proto_java_library to java_proto_library.Gravatar Julio Merino2016-02-19
| | | | | | | | RELNOTES[INC]: Renamed proto_java_library to java_proto_library. The former is now deprecated and will print out a warning when used. -- MOS_MIGRATED_REVID=115012027
* Use ctx.executable to get references to the binaries.Gravatar Julio Merino2016-02-19
| | | | | | | | | | This fixes the build of Bazel with itself. Using ctx.file instead of executable may yield a reference of the form external/blahblah/ which does not exist in the file system. Using ctx.executable does point to the right binary. -- MOS_MIGRATED_REVID=114990955
* Split out Java proto compilation logic to a helper script.Gravatar Julio Merino2016-02-19
| | | | | | | | This is just for clarity and should be a no-op. Maintaining long shell command lines embedded in genrules is not pretty. -- MOS_MIGRATED_REVID=114967410
* Reformat genproto.bzl to comply with the style guide.Gravatar Julio Merino2016-02-17
| | | | | | | | This is a preparatory change for a follow-up commit so that the diff of that commit is easy to review. -- MOS_MIGRATED_REVID=114857369
* Make Bazel use tools that are embedded in its binary.Gravatar Lukacs Berki2015-10-12
| | | | | | | This requires changing all "//tools/language:target" implicit dependencies to "@tools//tools/language:target". -- MOS_MIGRATED_REVID=105193805
* Rationalize copyright headersGravatar Damien Martin-Guillerez2015-09-25
| | | | | | | | | | | The headers were modified with `find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'` And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan. The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand. -- MOS_MIGRATED_REVID=103938715
* Get rid of javac warning spam when building java protos.Gravatar Nathan Harmata2015-09-02
| | | | | | | | | Idea courtesy of @pgr0ss. Fixes #416 -- MOS_MIGRATED_REVID=102161620
* Improve the JDK and JRE filegroups to include all the necessary parts. Then ↵Gravatar Philipp Wollermann2015-08-24
| | | | | | | fix the Skylark rules and tests that so far failed to declare dependencies on the JVM. -- MOS_MIGRATED_REVID=101215495
* Simplify genproto.bzl.Gravatar Han-Wen Nienhuys2015-06-02
| | | | | | | | | | | | | | | | Generate a srcjar artifact, and use native.java_library to emit the actual jar file. Post-review modifications: - Formatted genproto.bzl - Use //external:jar instead of relying on PATH - Make proto library a java_import instead of a filegroup in test setup. -- Change-Id: I005f801f09439bbca43e483ad4a47da4588fea94 Reviewed-on: https://bazel-review.googlesource.com/1362 MOS_MIGRATED_REVID=94914935
* Make Skylark genproto deterministicGravatar Damien Martin-Guillerez2015-03-31
| | | | | | | | Using JavaBuilder instead of the JDK makes generated jar files timestampless. -- MOS_MIGRATED_REVID=89950774
* Add symlinks to third_party/ and tools/ to base_workspaceGravatar Kristina Chodorow2015-02-19
While attempting to clean up the Bazel examples, I noticed that the example tests don't actually work because they expect a third_party directory. We could link third_party/ from the top-level bazel directory, but then we'd have crossing symlinks (base_workspace/tools->tools and third_party->base_workspace/third_party). Linking everything in one direction seemed like a better option, but alternative suggestions are welcome. -- MOS_MIGRATED_REVID=86703332