| Commit message (Collapse) | Author | Age |
|
|
|
| |
PiperOrigin-RevId: 206130934
|
|
|
|
|
|
|
|
| |
`estimated_size_` and `kMaximumOutputSize` are in `size_t` (`unsigned long long`) for 64-bit processor, but `%lu` only accept `unsigned long`. `%zu` will handle `size_t` for 32-bit and 64-bit processors correctly.
Closes #5473.
PiperOrigin-RevId: 202291659
|
|
|
|
|
|
|
| |
As //tools/defaults will be deprecated soon. All usages of //tools/defaults:jdk and //tools/defaults:java_toolchain should be replaced by corresponding targets in //tools/jdk/BUILD package
RELNOTES:none
PiperOrigin-RevId: 202114489
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert most `COMPILER_MSVC` to `_WIN32` (as they apply to Windows platform, not MSVC compiler). Only `src/tools/singlejar/zip_headers.h` and `src/main/cpp/util/md5.h` actually need `_MSC_VER`.
`COMPILER_MSVC` in `third_party/protobuf` are not removed. They can be fixed by updating dependency to newer version.
/cc @meteorcloudy
Closes #5350.
Change-Id: Ibc131abfaf34a0cb2bd338549983ea9d28eaabfe
PiperOrigin-RevId: 200019793
|
|
|
|
|
|
|
|
|
|
|
| |
Leave functions that make file accesses in the file library, and general blaze utilities in the blaze_util file, but move the functions that boil down to string manipulation and path formatting to their own file. (With the exception of getCWD, since absolute path syntax is relevant here.)
Doing this largely to consolidate all Windows path control into a single place, so that it's easier to notice inconsistencies. For instance, ConvertPath currently makes Windows paths absolute, but not Posix paths, and MakeAbsolute relies on this behavior. In addition, JoinPath assumes Posix path syntax, which leads to some odd looking paths. These will be fixed in a followup change.
(Found these issues while working on #4502, trying to fix the windows-specific system bazelrc.)
RELNOTES: None.
PiperOrigin-RevId: 199368226
|
|
|
|
|
|
| |
extension functions.
PiperOrigin-RevId: 198579700
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
portability bug is that sysconf() returns a long unsigned int but size_t is unsigned int (on the Pi 3) unsigned int causing a compilation failure (see below). Fixing the code to be portable, in this case, seems harmless in the common case where size_t is 64 bits AFAICT.
(I don't know your org so please feel free to reassign.)
The compilation error I received is:
ERROR: /home/hallorant/src/bazel-0.13.1/third_party/ijar/BUILD:10:1: C++ compilation of rule '//third_party/ijar:zip' failed (Exit 1): gcc failed: error executing command
(cd /tmp/bazel_TMQ6Ae45/out/execroot/io_bazel && \
exec env - \
PWD=/proc/self/cwd \
/usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -B/usr/bin -B/usr/bin -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections '-std=c++0x' -MD -MF bazel-out/host/bin/third_party/ijar/_objs/zip/third_party/ijar/mapped_file_unix.d '-frandom-seed=bazel-out/host/bin/third_party/ijar/_objs/zip/third_party/ijar/mapped_file_unix.o' -DBLAZE_OPENSOURCE -iquote . -iquote bazel-out/host/genfiles -iquote external/bazel_tools -iquote bazel-out/host/genfiles/external/bazel_tools -isystem third_party/zlib -isystem bazel-out/host/genfiles/third_party/zlib -isystem bazel-out/host/bin/third_party/zlib -g0 -g0 -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c third_party/ijar/mapped_file_unix.cc -o bazel-out/host/bin/third_party/ijar/_objs/zip/third_party/ijar/mapped_file_unix.o)
third_party/ijar/mapped_file_unix.cc: In constructor 'devtools_ijar::MappedOutputFile::MappedOutputFile(const char*, size_t)':
third_party/ijar/mapped_file_unix.cc:114:67: error: no matching function for call to 'min(long unsigned int, unsigned int)'
std::numeric_limits<size_t>::max());
PiperOrigin-RevId: 198405201
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix error reporting in the path conversion methods
of the Bazel client. Previously the error
reporting logic used GetLastErrorString in places
where it was not appropriate (i.e. it was not a
failed Windows API call that caused an error).
This cleanup prepares removing the concept of the
MSYS root from the Bazel client, since MSYS paths
are no longer supported and we want to cut Bazel's
dependency on Bash (thus MSYS) completely.
See https://github.com/bazelbuild/bazel/issues/4319
Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088
Closes #5072.
Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088
PiperOrigin-RevId: 194052665
|
|
|
|
|
|
|
| |
This will mean the messages will make it to the right output stream.
RELNOTES:
PiperOrigin-RevId: 191925662
|
|
|
|
|
|
| |
This is done by adding a --[no]strip_classes flag to ijar.
PiperOrigin-RevId: 191184258
|
|
|
|
| |
PiperOrigin-RevId: 190977545
|
|
|
|
|
|
|
| |
pdie and die are pretty similar, pdie just adds the errno string or equivalent from GetLastErrorString(). Make this explicit. This makes message formatting more clear in preparation for moving these all to BAZEL_LOG.
RELNOTES: None.
PiperOrigin-RevId: 190957255
|
|
|
|
|
|
|
|
| |
This was preventing ijar and singlejar from building when included in
@bazel_tools in our repo.
Change-Id: I1553e4f3615965cb997579e7d277fb2a08f9b91b
PiperOrigin-RevId: 190840090
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Bazel on Windows: https://buildkite.com/bazel/bazel-bazel/builds/1041
*** Original change description ***
Fix a warning about comparing signed and unsigned values
PiperOrigin-RevId: 190593548
|
|
|
|
| |
PiperOrigin-RevId: 190580907
|
|
|
|
|
|
|
| |
This is the convention, and tools that only read manifests may optimize
assuming that the manifest is at the beginning.
PiperOrigin-RevId: 190167351
|
|
|
|
| |
PiperOrigin-RevId: 190010996
|
|
|
|
| |
PiperOrigin-RevId: 185381597
|
|
|
|
| |
PiperOrigin-RevId: 185215813
|
|
|
|
|
|
| |
codec, but whose parent classes have codecs. This is ok because the polymorphic strategy doesn't need an instance of the grandchild class: the parent class is fine, so long as it has a codec.
PiperOrigin-RevId: 185200943
|
|
|
|
| |
Change-Id: Id636879aeab94916fcaed3c067e4077215ebc6df
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a rollforward with fixes.
The values (if present) are written into the manifest with this format:
Target-Label: <label>
Injecting-Rule-Kind: <kind>
In the future, JavaBuilder will make sure of this instead of command line arguments to find owners for jars for its add_dep commands.
PiperOrigin-RevId: 185159950
|
|
|
|
| |
PiperOrigin-RevId: 185153485
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Cascade rollback to unbreak bazel tests
*** Original change description ***
Update ijar tests to verify time stamp.
***
PiperOrigin-RevId: 185147605
|
|
|
|
| |
PiperOrigin-RevId: 185009133
|
|
|
|
|
|
|
|
|
|
|
| |
The values (if present) are written into the manifest with this format:
Target-Label: <label>
Injecting-Rule-Kind: <kind>
In the future, JavaBuilder will make sure of this instead of command line arguments to find owners for jars for its add_dep commands.
PiperOrigin-RevId: 185006704
|
|
|
|
|
|
|
|
|
| |
instead of removing them, since builds that use modules need them to be
visible across compilation boundaries. Note that the module-infos don't
contain any implementation that needs to be removed, so ijar just copies
the entire file through.
PiperOrigin-RevId: 184562080
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 181149284
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
FreeBSD should work again, so re-enable it.
*** Original change description ***
Remove FreeBSD from our CI temporarily.
RELNOTES: None.
PiperOrigin-RevId: 181140165
|
|
|
|
| |
Change-Id: Ic3d2331b7ccb5ca7db6b0fe83a12c7a6d1b58a9a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Roll forward of commit 86b4532769c22cca2ed7068a60f3326beaad34af after fixing bad import.
+small misc fixes suggested by critique
*** Original change description ***
Automated rollback of commit 86b4532769c22cca2ed7068a60f3326beaad34af.
*** Reason for rollback ***
Probably breaking //javatests/com/google/devtools/build/lib:Query2Tests
*** Original change description ***
Restructure how universeScope is used when testing configured query to mimick impending changes to the configured query interface (CL/179872445) which will pull build targets out of the query expression.
Fill in testTopLevelTransitions on the way!
PiperOrigin-RevId: 180930388
|
|
|
|
| |
Change-Id: I14256e583d07ebad9a0b525917d25e5cb5f7f684
|
|
|
|
|
|
|
|
| |
@damienmg Here are a few more changes. (`third_party` only)
Closes #4164.
PiperOrigin-RevId: 177278511
|
|
|
|
| |
PiperOrigin-RevId: 176987812
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use try-with-resources to close all streams.
I hope this will fix the spurious file deletion
failures on Windows, where the persistent
JavaBuilder worker cannot delete outputs from
previous builds because, supposedly, they are
still open, because a stale object that's ready
to be GC'd hasn't yet been actually GC'd.
Change-Id: Ia57b8bd0ba1b6ee0691d34467c92e86e35d4d71d
PiperOrigin-RevId: 175941520
|
|
|
|
|
|
| |
Closes #4052.
Change-Id: I30c4dc047195404a6ff63338ac4a944bb2755a1f
|
|
|
|
| |
PiperOrigin-RevId: 168789962
|
|
|
|
|
|
|
|
|
|
|
| |
Replace blaze_util::AsWindowsPathWithUncPrefix
with AsAbsoluteWindowsPath, which always returns
an absolute path.
Fixes https://github.com/bazelbuild/bazel/issues/2935
RELNOTES: none
PiperOrigin-RevId: 162727218
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this commit:
- remove blaze::PrintError in favor of
blaze_util::PrintError
- remove Ijar's PrintLastErrorMessage in favor of
blaze_util::PrintError
- use pdie every time path conversion fails,
because that indicates a fatal error (bad user
input for a path flag, or downright bug)
- remove explicitly printing GetLastErrror; pdie
and PrintError do it already
- unify the pdie/PrintError message formats
Fixes https://github.com/bazelbuild/bazel/issues/2935
Change-Id: I5feaf73885cab95c43a28c529ada6942e037b162
PiperOrigin-RevId: 162587490
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 161785358
|
|
|
|
|
|
|
|
|
|
| |
Please refer to patch set 9 and its CI run for usage and test
results. In practice, users should create their own java_toolchain
rule in their project's BUILD file, and set the two attributes like
above instead of modifying //tools/jdk/BUILD.
Change-Id: Ic880f243086b00a58d453a8139ba4c957fe54bc7
PiperOrigin-RevId: 159694649
|
|
|
|
|
|
|
|
|
|
|
| |
This affects only the tuple that appears after 'if' inside a list
comprehension. Since a truth value is expected, it's very unlikely to break
existing code. It's technically a breaking change, but it's not worth
introducing a flag for this.
RELNOTES:
Parentheses around the tuple are now mandatory in [a for b in c if 1, 2]
PiperOrigin-RevId: 159218397
|
|
|
|
|
|
| |
This is part of https://bazel-review.googlesource.com/#/c/11590/.
Change-Id: Id4a7fd459013e3f25a5a99684ea04295e3b68fb4
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a follow-up to a recent change which allowed LLVM raw profile files
to be directly used with blaze. This change allows zipped LLVM raw profile
files.
This uses //tools/zip:zipper to extract the zipped file contents.
This also adds a new option to //tools/zip:zipper, 'j', to junk directories while
unzipping.
Tested:
blaze test //devtools/blaze/integration:fdo_test
blaze test //third_party/ijar/test:zip_test
RELNOTES[NEW]: Zipped LLVM profiles are now supported.
PiperOrigin-RevId: 158849516
|
|
|
|
|
|
|
| |
This is a prerequisite for the next javac update, and mirrors the
approach used for other javac-based tests in Bazel (e.g.
BazelJavaCompilerTest).
PiperOrigin-RevId: 152779250
|
|
|
|
| |
PiperOrigin-RevId: 151461345
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Fixed all errors.
*** Original change description ***
Automated [] rollback of commit 69a127b8f4e353ecb163688ed3271fb47e0f385d.
--
PiperOrigin-RevId: 149092038
MOS_MIGRATED_REVID=149092038
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
[] has detected that 500 or more targets failed to build at commit 69a127b8f4e353ecb163688ed3271fb47e0f385d, each of which successfully built at the prior CL that affected them.
[] double-checked that //javatests/com/google/apphosting/tests/usercode:Security_StubTest
built at 148995024. The verification run was:
[]
but the same target failed to build at 148995025. The [] link for this run is available here: []
To see all targets that ran, along with their final status, visit: []
Questions? Comments? See the URL.
go/autorollback
*** Original change description ***
ijar: use bazel's file utilities
This change not only implements ijar for Windows
(with MSVC), but also fixes a bug in
mapped_file_windows (path conversion didn't make
the input path absolute, so we could not build
java code with the MSYS-less bazel).
Fixes https://github.com/bazelbuild/bazel/issues/2157
--
PiperOrigin-RevId: 148998092
MOS_MIGRATED_REVID=148998092
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change not only implements ijar for Windows
(with MSVC), but also fixes a bug in
mapped_file_windows (path conversion didn't make
the input path absolute, so we could not build
java code with the MSYS-less bazel).
Fixes https://github.com/bazelbuild/bazel/issues/2157
--
PiperOrigin-RevId: 148995025
MOS_MIGRATED_REVID=148995025
|
|
|
|
|
|
|
|
| |
--
Change-Id: I6ce9c6afe14dfaff8a60ae90ee1504684d9cc61c
Reviewed-on: https://cr.bazel.build/9117
PiperOrigin-RevId: 148891361
MOS_MIGRATED_REVID=148891361
|