aboutsummaryrefslogtreecommitdiffhomepage
path: root/third_party/ijar/mapped_file_windows.cc
Commit message (Collapse)AuthorAge
* Move path-manipulation functions to own library file.Gravatar ccalvarin2018-06-05
| | | | | | | | | | | Leave functions that make file accesses in the file library, and general blaze utilities in the blaze_util file, but move the functions that boil down to string manipulation and path formatting to their own file. (With the exception of getCWD, since absolute path syntax is relevant here.) Doing this largely to consolidate all Windows path control into a single place, so that it's easier to notice inconsistencies. For instance, ConvertPath currently makes Windows paths absolute, but not Posix paths, and MakeAbsolute relies on this behavior. In addition, JoinPath assumes Posix path syntax, which leads to some odd looking paths. These will be fixed in a followup change. (Found these issues while working on #4502, trying to fix the windows-specific system bazelrc.) RELNOTES: None. PiperOrigin-RevId: 199368226
* windows,client: fix error reportingGravatar Laszlo Csomor2018-04-24
| | | | | | | | | | | | | | | | | | | | | | Fix error reporting in the path conversion methods of the Bazel client. Previously the error reporting logic used GetLastErrorString in places where it was not appropriate (i.e. it was not a failed Windows API call that caused an error). This cleanup prepares removing the concept of the MSYS root from the Bazel client, since MSYS paths are no longer supported and we want to cut Bazel's dependency on Bash (thus MSYS) completely. See https://github.com/bazelbuild/bazel/issues/4319 Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088 Closes #5072. Change-Id: Ie50a20e0ee0c572592f637340a2f2948c7f53088 PiperOrigin-RevId: 194052665
* Remove die() and replace it with BAZEL_DIE, part of the logging framework.Gravatar ccalvarin2018-04-06
| | | | | | | This will mean the messages will make it to the right output stream. RELNOTES: PiperOrigin-RevId: 191925662
* Fix a warning about comparing signed and unsigned valuesGravatar cushon2018-03-29
| | | | PiperOrigin-RevId: 190977545
* Remove pdie.Gravatar ccalvarin2018-03-29
| | | | | | | pdie and die are pretty similar, pdie just adds the errno string or equivalent from GetLastErrorString(). Make this explicit. This makes message formatting more clear in preparation for moving these all to BAZEL_LOG. RELNOTES: None. PiperOrigin-RevId: 190957255
* Windows: add blaze_util::AsAbsoluteWindowsPathGravatar laszlocsomor2017-07-24
| | | | | | | | | | | Replace blaze_util::AsWindowsPathWithUncPrefix with AsAbsoluteWindowsPath, which always returns an absolute path. Fixes https://github.com/bazelbuild/bazel/issues/2935 RELNOTES: none PiperOrigin-RevId: 162727218
* Windows: clean up error reportingGravatar Laszlo Csomor2017-07-20
| | | | | | | | | | | | | | | | | | | In this commit: - remove blaze::PrintError in favor of blaze_util::PrintError - remove Ijar's PrintLastErrorMessage in favor of blaze_util::PrintError - use pdie every time path conversion fails, because that indicates a fatal error (bad user input for a path flag, or downright bug) - remove explicitly printing GetLastErrror; pdie and PrintError do it already - unify the pdie/PrintError message formats Fixes https://github.com/bazelbuild/bazel/issues/2935 Change-Id: I5feaf73885cab95c43a28c529ada6942e037b162 PiperOrigin-RevId: 162587490
* Rollback of commit 14b53897b499da457e26aa779c3b63c85838f204.Gravatar Laszlo Csomor2017-03-03
| | | | | | | | | | | | | | *** Reason for rollback *** Fixed all errors. *** Original change description *** Automated [] rollback of commit 69a127b8f4e353ecb163688ed3271fb47e0f385d. -- PiperOrigin-RevId: 149092038 MOS_MIGRATED_REVID=149092038
* Rollback of commit 69a127b8f4e353ecb163688ed3271fb47e0f385d.Gravatar Googler2017-03-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** [] has detected that 500 or more targets failed to build at commit 69a127b8f4e353ecb163688ed3271fb47e0f385d, each of which successfully built at the prior CL that affected them. [] double-checked that //javatests/com/google/apphosting/tests/usercode:Security_StubTest built at 148995024. The verification run was: [] but the same target failed to build at 148995025. The [] link for this run is available here: [] To see all targets that ran, along with their final status, visit: [] Questions? Comments? See the URL. go/autorollback *** Original change description *** ijar: use bazel's file utilities This change not only implements ijar for Windows (with MSVC), but also fixes a bug in mapped_file_windows (path conversion didn't make the input path absolute, so we could not build java code with the MSYS-less bazel). Fixes https://github.com/bazelbuild/bazel/issues/2157 -- PiperOrigin-RevId: 148998092 MOS_MIGRATED_REVID=148998092
* ijar: use bazel's file utilitiesGravatar Laszlo Csomor2017-03-03
| | | | | | | | | | | | | | This change not only implements ijar for Windows (with MSVC), but also fixes a bug in mapped_file_windows (path conversion didn't make the input path absolute, so we could not build java code with the MSYS-less bazel). Fixes https://github.com/bazelbuild/bazel/issues/2157 -- PiperOrigin-RevId: 148995025 MOS_MIGRATED_REVID=148995025
* Ijar: make some targets compilable with MSVCGravatar Laszlo Csomor2016-09-30
| | | | | | | | Particulary third_party/ijar:{zip,zlib_client} now compile with --cpu=x64_windows_msvc. -- MOS_MIGRATED_REVID=134771232
* Add prefix to file path in ijar to allow file path longer than 260 on WindowsGravatar Yun Peng2016-04-11
| | | | | | | -- Change-Id: Ia176408e9b59caa85da7eb63fd3d9251a1d3fb40 Reviewed-on: https://bazel-review.googlesource.com/#/c/3328/ MOS_MIGRATED_REVID=119522458
* Implement memory-mapped zip files in ijar for Windows.Gravatar Lukacs Berki2016-02-17
Progress towards #276. -- MOS_MIGRATED_REVID=114829911
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-24 12:04:42 +0000