| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provider wraps the other android data providers, as well as artifacts that
should only be made available for top-level Android targets.
This provider is required for some output (such as final data APK) to be
exposed to Skylark, and also makes it easy to pass information from
android_binary data processing to postprocessing actions, most notably resource
shrinking (next reviews).
RELNOTES: none
PiperOrigin-RevId: 196135042
|
|
|
|
| |
PiperOrigin-RevId: 196127040
|
|
|
|
| |
PiperOrigin-RevId: 196113268
|
|
|
|
|
|
|
|
|
| |
CompileResources: generate pseudo locales into a separate compiled resource file when the pseudo locale flag is true and the locale is default (e.g. absent). The generated resources must be first in the returned list of compiled resource paths. This allows the user to define custom values to the pseudo locales (which, for some obscure reason, is accepted as a reasonable practice by aapt{,2})
AndroidResourceOutputs: record the type of compiled resource in the comment field of the zip entry for fast comparison.
ResourceLinker: only include the generated resources when the pseudo locale is explicitly asked for. It's important to note that the ordering for compiled resources in the zip goes <generated>...<normal>...<default>. This means the default locale will overwrite the generated locale values. Annoying, but necessary, as that is current order before introducing this cl.
RELNOTES:None
PiperOrigin-RevId: 196111843
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 196024071
|
|
|
|
|
|
|
|
| |
Explicitly work with rele attributes at (or closer to) the top level rather
than deep in the code.
RELNOTES: none
PiperOrigin-RevId: 196004542
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make AndroidSkylarkData abstract and add a getAndroidSemantics() method
The Skylark stamp_manifest rule should properly use AndroidSemantics to rename
the manifest as well, in keeping with the android_library rule.
AndroidLocalTest should do the same manifest renaming regardless of which
AndroidSemantics it is run under. Have it use a seperate method to do so.
RELNOTES: none
PiperOrigin-RevId: 195992300
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 195977060
|
|
|
|
| |
PiperOrigin-RevId: 195973862
|
|
|
|
| |
PiperOrigin-RevId: 195971237
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a previous review, I left some setting controlled only by rule attributes.
Now actually specify them in Skylark method params.
Data binding and should mimic behavior in existing android_* rules.
For library, aapt_version cannot be passed in; we use the flag value.
I left the SDK attribute intact as it's private. People should be setting
defaults in rules but otherwise overriding SDK with flags, not parameters. This
mimics existing behavior.
RELNOTES: none
PiperOrigin-RevId: 195970351
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The R.class file, when available, is used in Java compilation. So it should be
exposed in its own provider as an output of resource processing.
The R.class file is marked as Neverlink and compiletime-only to ensure it
doesn't get inherited.
Change resource processing to return a SkylarkDict of providers. That way,
callers can easily get the provider they want, or use values() to get all the
providers.
Stop exposing R.class in AndroidResourcesInfo since we're exposing it in an
easier-to-consume way now.
Will update other methods that return multiple providers to do the same in
future reviews.
RELNOTES: none
PiperOrigin-RevId: 195871587
|
|
|
|
|
|
|
| |
values resources.
RELNOTES:None
PiperOrigin-RevId: 195821595
|
|
|
|
|
|
|
|
|
| |
This is to simplify the API that will eventually be exposed to Skylark.
Working towards #4571.
RELNOTES: None.
PiperOrigin-RevId: 195785588
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 195777400
|
|
|
|
| |
PiperOrigin-RevId: 195732395
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 195719735
|
|
|
|
|
|
| |
contention and use a striped lock.
PiperOrigin-RevId: 195717688
|
|
|
|
|
|
|
| |
This provider needs to be the new type so we can expose Aar information in Skylark
RELNOTES: none
PiperOrigin-RevId: 195710606
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are a bunch of reasons this shouldn't be exposed:
- ResourceContainer is a glob of several unrelated bits of functionality
- We are working on getting rid of ResourceContainer in favor of things like
AndroidResources
- We should pass information between targets using providers, not internal
state like ResourceContainer
RELNOTES: none
PiperOrigin-RevId: 195704044
|
|
|
|
|
|
|
| |
This collapsing should be avoided when possible, and punted on until execution when needed.
RELNOTES: none
PiperOrigin-RevId: 195695290
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the R.class to the provider, but keep it nullable in case no
resource/manifest attributes were specified, in which case the R.class would
not be generated.
A previous change tried to actually generate it in that case, but even though I
think that's probably the right strategy for the long term, it's substantially
different behavior and out of scope of this migration.
RELNOTES: none
PiperOrigin-RevId: 195682271
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
execution on Windows from Java launcher.
Previously the test case would fail because it tried to run a path like this:
C:/temp/build-1dad9dd4-ee96-40c5-b551-c8ae12461e45/bazel-out/x64_windows-fastbuild/bin/foo/foo_test.exe.runfiles/C:/openjdk/bin/java.exe
Passing presubmit: https://buildkite.com/bazel/google-bazel-presubmit/builds/2558#b83dbc25-d9ad-4d49-8f78-cde9d6810741
RELNOTES: N/A
PiperOrigin-RevId: 195675424
|
|
|
|
|
|
|
|
|
| |
Staticness is confusing, I always have to investigate which is Staticness and
which is LinkStaticness, and even in isolation staticness is not a great name. I
believe LinkerOrArchiver is a better name :)
RELNOTES: None.
PiperOrigin-RevId: 195674810
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 195664306
|
|
|
|
|
|
|
| |
Closes #4628
Closes #5155.
PiperOrigin-RevId: 195662967
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 195659799
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Memory regression (b/79331026)
*** Original change description ***
Some fixup for R.class files
Expose R.class file in AndroidResourcesInfo, to allow Java compilation.
Include documentation that the R.class should not be used in other targets.
Actually generate the R.class file in the case of an android_library with no
manifest, resources, or assets, rather than compiling it from the R.java
RELNOTES: none
PiperOrigin-RevId: 195659672
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, introduce caching for duplicated qualifiers.
Rolling Forward:
Fixed attempting to parse non-resource directories with dashes as resource directories.
Added test for this case.
RELNOTES: None
PiperOrigin-RevId: 195658978
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 195658252
|
|
|
|
|
|
|
| |
To handle a common debugging workflow where you want to pause
execution of one/all threads.
PiperOrigin-RevId: 195657472
|
|
|
|
|
|
|
| |
There are still a few global @SkylarkSignature-annotated top-level objects that need to be migrated in SkylarkRuleClassFunctions, but this migrates everything else.
RELNOTES: None.
PiperOrigin-RevId: 195652038
|
|
|
|
|
|
|
| |
removal, but for the test.
RELNOTES: None
PiperOrigin-RevId: 195651521
|
|
|
|
|
|
|
| |
Since configuration fragments will extend from build API classes, @SkylarkConfigurationField no longer needs to annotate a method defined on a @SkylarkModule class. Ideally, we would ensure that a configuration fragment with a @SkylarkConfigurationField method implements an interface with @SkylarkModule, but this seems impossible to perform at the level of an annotation processor.
RELNOTES: None.
PiperOrigin-RevId: 195651344
|
|
|
|
|
|
|
|
| |
Only the last commit needs to be reviewed, as it's rebased on https://github.com/bazelbuild/bazel/pull/5101
Closes #5117.
PiperOrigin-RevId: 195649921
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory structures.
When building a parent node from action inputs, the paths to the files are
sorted. These paths are then broken down into segments and a tree structure
is created from the segments.
Problem is, the segments at each level of the tree structure are not sorted
before they are added to the parent node. This can result in an unordered
directory tree.
For example, the sort order of this list of files
```
/foo/bar-client/bar-client_ijar.jar
/foo/bar/bar_ijar.jar
```
is maintained when it becomes a tree structure
```
foo ->
bar-client ->
bar-client_ijar.jar
bar
bar_ijar.jar
```
which is out of order.
Resolves: #5109
Closes #5110.
PiperOrigin-RevId: 195649710
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 195586974
|
|
|
|
|
| |
RELNOTES: none.
PiperOrigin-RevId: 195497740
|
|
|
|
| |
PiperOrigin-RevId: 195486836
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 195486038
|
|
|
|
|
|
|
|
|
| |
Mostly this is removing a needless restriction on proto_library to have java_api_version and j2objc_api_version set. The rest was already working.
Tons of tests had to be updated.
RELNOTES: None
PiperOrigin-RevId: 195450685
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 195428899
|
|
|
|
|
|
|
|
|
|
|
| |
We allow repository rules to return a reproducible version of themselves,
or a list of fully reproducible rules they expand to. Add a module collecting
all those answers, logging them at each invocation, if requested; this
collection can also be used by the upcoming 'sync' command to generate
a WORKSPACE.resolved file.
Change-Id: Iac1358de1b74633810d300ba2bf45bba8b3992dc
PiperOrigin-RevId: 195427096
|
|
|
|
|
|
|
| |
CcToolchainFeatureSelection class
RELNOTES: None.
PiperOrigin-RevId: 195425336
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 195422399
|
|
|
|
|
|
|
|
|
|
|
| |
- add 'start debugging' request/response messages. The debug server will
block until this request is received, allowing the client to perform
initial setup (e.g. setting breakpoints)
- support conditional breakpoints
- add a column index to the Location message
- rename 'line number' to 'line index', and specify that it's 0-based
PiperOrigin-RevId: 195420363
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expose R.class file in AndroidResourcesInfo, to allow Java compilation.
Include documentation that the R.class should not be used in other targets.
Actually generate the R.class file in the case of an android_library with no
manifest, resources, or assets, rather than compiling it from the R.java
RELNOTES: none
PiperOrigin-RevId: 195419781
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks a few thousands targets
*** Original change description ***
Remove fully static linking part of ctx.fragments.cpp.fully_static_link_options
Since we always pass true as argument (meaning it's for dynamic library), we
don't need the part for executable. And we don't want more users of this method,
therefore removing.
RELNOTES: None.
PiperOrigin-RevId: 195411765
|
|
|
|
|
|
|
|
|
|
|
|
| |
This effectively subsumes all existing memory estimation, as it no
longer matters too much how much memory is assigned to each action.
WIP: This is a hack, and if it goes in, should almost certainly be
hidden behind a configuration option.
Closes #4938.
PiperOrigin-RevId: 195378568
|
|
|
|
| |
PiperOrigin-RevId: 195321054
|