aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Automated g4 rollback of commit 99a5a30d17d920de323d1cc37e3fe25a0749ae41.Gravatar philwo2017-03-31
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks Java 7 tests: ERROR: missing input file '@bazel_tools//tools/jdk:JavaBuilder_deploy.jar' http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD-jdk7,PLATFORM_NAME=linux-x86_64/670/console *** Original change description *** Make Java tool jars available from @bazel_tools. Now users can point to default Java tool jars in custmized java_toolchain rule defined in project's BUILD file. PiperOrigin-RevId: 151699090
* Disable test_sandbox_mount_customized_path because it segfaults on Ubuntu 16.04.Gravatar philwo2017-03-31
| | | | | | | | | | | | | | | | | | The test fails in the last action, where it tries to run the bazel-bin/hello-world binary with the linux-sandbox while mounting "source" to "target": philwo@philwo-test:~/test$ $linux_sandbox -D \ > -M ${source} \ > -m ${target} \ > -- bazel-bin/hello-world src/main/tools/linux-sandbox.cc:169: linux-sandbox-pid1 has PID 28912 [...] src/main/tools/linux-sandbox-pid1.cc:260: remount ro: /home/philwo/test/mount_targets/x86_64-unknown-linux-gnu/sysroot/lib64/ld-2.19.so src/main/tools/linux-sandbox-pid1.cc:349: sigaction(32, &sa, NULL) failed src/main/tools/linux-sandbox-pid1.cc:349: sigaction(33, &sa, NULL) failed src/main/tools/linux-sandbox-pid1.cc:459: waitpid returned 2 src/main/tools/linux-sandbox-pid1.cc:476: child died due to signal 11 PiperOrigin-RevId: 151693791
* Bazel client: simplify ReadDirectorySymlinkGravatar laszlocsomor2017-03-31
| | | | | | | | | | | | | | | This is a bugfixed version of https://cr.bazel.build/9520 which broke some Google-internal tests. This change allows removing duplicate code: ReadDirectorySymlink was implemented on Windows as a junction resolver, which is also implemented in file_windows.cc. Now it uses the JunctionResolver. RELNOTES: none PiperOrigin-RevId: 151691895
* Extract --sysroot flag from blaze and move it into crosstoolGravatar hlopko2017-03-31
| | | | | | RELNOTES: None. PiperOrigin-RevId: 151688820
* Drop loading-phase values if --discard_analysis_cache is true and we're not ↵Gravatar janakr2017-03-31
| | | | | | keeping incremental state. PiperOrigin-RevId: 151639711
* Partial rollback of commit 5e1a420f1b385382a2df5359faf3ae773aa8d61e.Gravatar Googler2017-03-31
| | | | | | | | | | *** Reason for rollback *** Breaks tests that expected previous id generation order. RELNOTES: None. PiperOrigin-RevId: 151638886
* Actually clear the per-build syscall cache after loading. Setting it to null ↵Gravatar janakr2017-03-31
| | | | | | doesn't work because the PackageFactory keeps a reference to it. PiperOrigin-RevId: 151632473
* Improve the error message for simple values by including the value.Gravatar Googler2017-03-31
| | | | | | RELNOTES: None PiperOrigin-RevId: 151630049
* BuildView#getConfiguredTargetForTesting respects null transitions.Gravatar mstaib2017-03-31
| | | | | | | | RuleTransitionFactory#buildTransitionFor is @Nullable, but the SkyframeExecutor expects a non-null Transition. If the factory returns null, the SkyframeExecutor should be passed NONE, not null. PiperOrigin-RevId: 151615724
* Move more Android tools' tests into Bazel.Gravatar ajmichael2017-03-31
| | | | | | RELNOTES: None PiperOrigin-RevId: 151602497
* Make Bazel resilient to files in /sdk/system-images.Gravatar ajmichael2017-03-31
| | | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/2739. RELNOTES: None PiperOrigin-RevId: 151592983
* Clone the remote execution implementation into a new classGravatar ulfjack2017-03-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new RemoteExecutionClient class only performs remote execution, and nothing else; all higher-level functions, local rety, etc. will live outside of the client. In order to add unit tests, I had to add another layer of indirection between the Grpc{RemoteExecutor,ActionCache} and GRPC, since GRPC generates final, non-mockable classes. While a testing approach that uses a fake server can also get some test coverage (as in GrpcActionCacheTest), it doesn't allow us to test the full range of bad things that can happen at the GRPC layer. The cloned implementation uses a single GRPC channel, as was recommended to me by Jakob, who worked on GRPC. A single channel should be sufficiently scalable, it's thread-safe, and it performs chunking internally. On the server-side, the requests from a single channel can be dispatched to a thread pool, so this should not be a blocker for server-side parallelism. I also changed it to throw an exception whenever anything bad happens - this makes it much more obvious if there's still bug in this code; the old code silently swallows many errors, falling back to local execution, which papers over many issues. Furthermore, we now return a RemoteExecutionResult to indicate whether the action ran at all (regardless of exit code), as well as the exit code. All in all, this implementation is closer to the production code we're using internally, although quite a few things are still missing. The cloned implementation is not hooked up to RemoteSpawnStrategy yet. It also does not support combining remote caching with local execution, but note that RemoteSpawnStrategy regressed in that respect and currently also does not support that mode. PiperOrigin-RevId: 151578409
* Init absent action configs for CppCompile actionsGravatar hlopko2017-03-29
| | | | | | | | | | | So far only link actions were initialized in CppLinkActionConfigs. This cl changes this class to also initialize CppCompile actions. This is needed for our ongoing work removing hard-coded flags from Bazel and moving them into Crosstool. RELNOTES: None. PiperOrigin-RevId: 151575045
* fix typo in Bazel documentationGravatar steren2017-03-29
| | | | PiperOrigin-RevId: 151574562
* Resolve special provider names when checking for mandatory providersGravatar vladmos2017-03-29
| | | | | | | | | | If a rule requires a special provider that's (maybe) not provided explicitly but nevertheless available from a target, i.e. "files", the mandatory providers check should pass. Fixes #1490 PiperOrigin-RevId: 151571187
* Change print(artifact) to return "File" instead of "Artifact"Gravatar vladmos2017-03-29
| | | | | | | | | RELNOTES[INC]: Converting artifacts to strings and printing them now return "File" instead of "Artifact" to be consistent with the type name. Fixes #2715 PiperOrigin-RevId: 151563252
* Bazel client, Windows: fix version check []Gravatar laszlocsomor2017-03-29
| | | | | | | GetVersionEx is discouraged by MSDN, so use the recommended method to check the Windows version. PiperOrigin-RevId: 151553827
* Stop returning JavaSourceJarsProvider from java_libraryGravatar elenairina2017-03-29
| | | | | | since it's already returned via JavaProvider. PiperOrigin-RevId: 151550286
* Add JavaRunfilesProvider to JavaProvider.Gravatar elenairina2017-03-29
| | | | PiperOrigin-RevId: 151547892
* Clear AspectValues when discarding analysis cache, along with ↵Gravatar janakr2017-03-29
| | | | | | | | ConfiguredTargetValues. Also clear transitive packages for both, even for top-level targets. This is not expected to save significant memory, but is expected to reduce the number of references to Packages, allowing them to be dropped more easily when discarding analysis cache and running in batch mode. PiperOrigin-RevId: 151508877
* Fix downloader so reset connections can resumeGravatar jart2017-03-29
| | | | | | RELNOTES: A downloader bug was fixed that prevented RFC 7233 Range connection resumes from working with certain HTTP servers PiperOrigin-RevId: 151508000
* Remove configurability of abrupt exit code behavior.Gravatar ccalvarin2017-03-29
| | | | | | | | Ability to configure this was added to provide an easy correction in case writing the exit code to a file proved problematic. This feature has been out for 3 months with no reported issues, no reason to keep the extraneous flag. PiperOrigin-RevId: 151496431
* Catch cases where exec fails before WaitForCompletionCommand starts.Gravatar mstaib2017-03-29
| | | | | | | | | | | | | | | | | It's possible for cases to happen where the BlazeCommandDispatcher fails before starting the WaitForCompletionCommand. In these cases, the test's command state handoff will never take place because no command state will be created to be handed off (obviously). This means that runIn will wait forever. Instead, if the command completes and the command state has still not been handed off, set an exception into the command state so that the test will fail without further troubles. RELNOTES: None. PiperOrigin-RevId: 151495494
* Log the server pid to java logging.Gravatar janakr2017-03-29
| | | | PiperOrigin-RevId: 151489034
* Add a disabled test that will be enabled once #2709 is fixed.Gravatar ajmichael2017-03-29
| | | | PiperOrigin-RevId: 151486661
* Split out the InvocationPolicy parser from the enforcer.Gravatar ccalvarin2017-03-29
| | | | | | The encapsulation was off, since the format in which we accept policy has nothing to do with how we then enforce the policy. PiperOrigin-RevId: 151471747
* Actions arising from experimental_objc_library in opt mode do not use "-g0" ifGravatar cpeyser2017-03-29
| | | | | | --apple_generate_dsym is set, as in the legacy case. PiperOrigin-RevId: 151468688
* Remove the remote_cache_test target, which refers to a non-existing file.Gravatar Philipp Wollermann2017-03-28
| | | | | | -- PiperOrigin-RevId: 151456059 MOS_MIGRATED_REVID=151456059
* Apple binary configures actions not just with it's child's config and provider,Gravatar Cal Peyser2017-03-28
| | | | | | | | but also its toolchain. -- PiperOrigin-RevId: 151444602 MOS_MIGRATED_REVID=151444602
* Dump the classpaths in a separate file and read the classpaths from that ↵Gravatar Kush Chakraborty2017-03-28
| | | | | | | | | | file, so that each test run can have the latest version of the Classpaths. This does not tackle the case where runfiles are not present, such as windows. -- PiperOrigin-RevId: 151440999 MOS_MIGRATED_REVID=151440999
* Refactor simple distributed caching support Gravatar Alpha Lam2017-03-28
| | | | | | | | | | | | | | | | | | | The simple distributed caching in Bazel used ConcurrentMap as a blob store. It is incorrect to use an overloaded interface for this purpose. This change defines a SimpleBlobStore interface that only has put(), get() and containsKey() methods and allows a simple implementation of a blob store as remote cache for Bazel. Also updated documentation to summarize the options available in the remote spwan strategy. There is no functional change. TESTED=shell integration tests -- Change-Id: Iedff0bc4f06c4a93c398c53801014d998c3df13b Reviewed-on: https://cr.bazel.build/9330 PiperOrigin-RevId: 151439467 MOS_MIGRATED_REVID=151439467
* DataSource FixesGravatar Googler2017-03-28
| | | | | | | | | | * Fix the overwrite algorithm to be handled entirely in the accumulators. * Improve the conflict error messages for attributes and simple values. * Refactor the UnwrittenDataSubject to top level for reuse. -- PiperOrigin-RevId: 151439084 MOS_MIGRATED_REVID=151439084
* Bazel client, Windows: path casing bugfixes Gravatar László Csomor2017-03-28
| | | | | | | | | | | | | | | | | | | | | | | | | Change blaze::ConvertPath to lower-case its result for sake of deterministic comparison later. Change blaze::CompareAbsolutePaths to call blaze::ConvertPath before comparison. The ConvertPath method normalizes its input then converts it to lowercase, meaning ConvertPath("c:/Foo") and ConvertPath("C:\FOO\.") will give the same result. Thanks to this we will no longer kill the Bazel server if the --output_user_root changes but only in casing, or by adding/removing trailing slash/backslash. Fixes https://github.com/bazelbuild/bazel/issues/2714 -- Change-Id: I36c13378a9e3567862ee1c611f56b0c3ab465da8 Reviewed-on: https://cr.bazel.build/9517 PiperOrigin-RevId: 151425571 MOS_MIGRATED_REVID=151425571
* Make Java tool jars available from @bazel_tools. Gravatar Xin Gao2017-03-28
| | | | | | | | | | | Now users can point to default Java tool jars in custmized java_toolchain rule defined in project's BUILD file. -- Change-Id: I064c9646e8681a3f5669d7163b1b3cb5cc0b16b7 Reviewed-on: https://cr.bazel.build/9250 PiperOrigin-RevId: 151422924 MOS_MIGRATED_REVID=151422924
* Description redacted.Gravatar Adam Michael2017-03-28
| | | | | | -- PiperOrigin-RevId: 151407958 MOS_MIGRATED_REVID=151407958
* Sign all android_binarys with both the v1 and v2 signature schemes by default.Gravatar Adam Michael2017-03-28
| | | | | | | | RELNOTES: All android_binarys are now signed with both Apk Signature V1 and V2. See https://source.android.com/security/apksigning/v2.html for more details. -- PiperOrigin-RevId: 151404899 MOS_MIGRATED_REVID=151404899
* A flag to control the outputs that cc_proto_library expects from proto-compiler.Gravatar Carmi Grushko2017-03-28
| | | | | | -- PiperOrigin-RevId: 151381769 MOS_MIGRATED_REVID=151381769
* Genrules only depend on the C++ toolchain if they have C++ make variables. Gravatar Greg Estren2017-03-28
| | | | | | | | | | e.g.: cmd = "$(CC) foo.cc > $@" Fixes #2729 -- PiperOrigin-RevId: 151369889 MOS_MIGRATED_REVID=151369889
* BEP: Unconditionally report ExtraActions Gravatar Klaus Aehlig2017-03-28
| | | | | | | | | | | | ...irrespective of their success status. While a build typically contains too many successful actions to report them all, extra actions included in a build are worth reporting. -- Change-Id: I6b20935895aa7b16836d6271f456176a7113317e Reviewed-on: https://cr.bazel.build/9519 PiperOrigin-RevId: 151328633 MOS_MIGRATED_REVID=151328633
* Rename ToolchainLookup rule to ToolchainType, to better explain the usage ofGravatar John Cater2017-03-28
| | | | | | | | | | | | | | | | | | | | the rule. Example: tools/newlang/BUILD: toolchain_type(name = "toolchain_type") Allows users to refer to //tools/newlang:toolchain_type when discussing the newlang toolchain. The previous usage: tools/newlang/BUILD: toolchain_lookup(name = "lookup") Lead to labels like //tools/newlang:lookup, which was unclear that each language's toolchain needs one unique instance of toolchain_(lookup|type). -- PiperOrigin-RevId: 151326827 MOS_MIGRATED_REVID=151326827
* Clarify InvocationPolicy origins.Gravatar Chloe Calvarin2017-03-28
| | | | | | | | | Some policies can come from the module API, and some come from the user via startup argument. Clarify which one is which. -- PiperOrigin-RevId: 151324618 MOS_MIGRATED_REVID=151324618
* Make swift-stdlib-tool less verboseGravatar Dmitry Shevchenko2017-03-28
| | | | | | -- PiperOrigin-RevId: 151322384 MOS_MIGRATED_REVID=151322384
* Fix broken test_sandbox_mount_customized_path test.Gravatar Philipp Wollermann2017-03-27
| | | | | | | | http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/lastCompletedBuild/testReport/(root)/(empty)/test_sandbox_mount_customized_path/ -- PiperOrigin-RevId: 151306949 MOS_MIGRATED_REVID=151306949
* Separate charts for Java target and Cpp target, or the page is too long.Gravatar Yue Gan2017-03-27
| | | | | | -- PiperOrigin-RevId: 151302544 MOS_MIGRATED_REVID=151302544
* Move -Wl,--gdb-index into crosstoolGravatar Marcel Hlopko2017-03-27
| | | | | | -- PiperOrigin-RevId: 151302418 MOS_MIGRATED_REVID=151302418
* Add support to read classpath entries from directoriesGravatar Googler2017-03-27
| | | | | | -- PiperOrigin-RevId: 151297803 MOS_MIGRATED_REVID=151297803
* BEP: Also report options Gravatar Klaus Aehlig2017-03-27
| | | | | | | | | | | | Additionally to reporting on the originally received command line, also report it in a parsed form. This, in particular, includes reconstructing the options originally provided by the user. -- Change-Id: I5a1c6ed57874f1d37d10bf11d597256d63bc5516 Reviewed-on: https://cr.bazel.build/9459 PiperOrigin-RevId: 151288656 MOS_MIGRATED_REVID=151288656
* split the long method Desugar.desugar() into smaller pieces.Gravatar Chengnian Sun2017-03-27
| | | | | | | | RELNOTES: n/a -- PiperOrigin-RevId: 151203625 MOS_MIGRATED_REVID=151203625
* Remove disabled fallback logic from DexFileMerger.Gravatar Kevin Bierhoff2017-03-27
| | | | | | -- PiperOrigin-RevId: 151201374 MOS_MIGRATED_REVID=151201374
* turn on --experimental_incremental_dexing_error_on_missed_jars by default.Gravatar Kevin Bierhoff2017-03-27
| | | | | | | | | This has no effect unless --incremental_dexing is used. RELNOTES: turn on --experimental_incremental_dexing_error_on_missed_jars by default. -- PiperOrigin-RevId: 151198031 MOS_MIGRATED_REVID=151198031