| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
| |
--
PiperOrigin-RevId: 145119990
MOS_MIGRATED_REVID=145119990
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 145091484
MOS_MIGRATED_REVID=145091484
|
|
|
|
|
|
|
|
| |
with the internal GenRule implementation.
--
PiperOrigin-RevId: 145087704
MOS_MIGRATED_REVID=145087704
|
|
|
|
|
|
|
|
|
| |
The code has been untouched and unused for over a year (it's very likely
broken) and we have other priorities for now.
--
PiperOrigin-RevId: 145087310
MOS_MIGRATED_REVID=145087310
|
|
|
|
|
|
|
|
| |
ExecutionInfoProvider.
--
PiperOrigin-RevId: 145084927
MOS_MIGRATED_REVID=145084927
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out, we couldn't run jarjar because the Java launcher script looks for the .jars in the runfiles and build-runfiles is stubbed out during bootstrapping.
The only reason why this worked at all is that sandboxing *also* doesn't work during bootstrapping but it causes the creation of symlinks that happened to be just in the right place for the Java launcher to find the .jars .
The fix is:
- Explicitly disable sandboxing during bootstrapping so that coincidences like this don't happen again
- Pass a --javabase and --host_javabase option during the bootstrap build so that we don't need any symlinks to access to JVM
- Invoke jarjar using its deploy jar instead of the launcher script.
That was fun.
--
PiperOrigin-RevId: 145083357
MOS_MIGRATED_REVID=145083357
|
|
|
|
|
|
|
|
|
| |
This functionality is never used, have never been exposed to Skylark
and is a continuous pain to maintain and test.
--
PiperOrigin-RevId: 145079832
MOS_MIGRATED_REVID=145079832
|
|
|
|
|
|
|
|
|
|
| |
Specifying both options can cause OOM on OSX.
--
Change-Id: I52daf194a8840f9e63f1d537f13152e53f8436a7
Reviewed-on: https://cr.bazel.build/8220
PiperOrigin-RevId: 145079331
MOS_MIGRATED_REVID=145079331
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When looking up the .bazelrc file in the workspace or the home directory,
construct its name using the built-in product name instead of hardcoding
the name in the WorkspaceLayout class.
This removes an additional hardcoded value and changes the code to do the
right thing based on the product name.
--
PiperOrigin-RevId: 145077783
MOS_MIGRATED_REVID=145077783
|
|
|
|
|
|
|
|
|
|
| |
This seems like an obvious cleanup, and I also want to move most of the
test-specific environment setup to TestRunnerAction, which is simpler after
this change.
--
PiperOrigin-RevId: 145076829
MOS_MIGRATED_REVID=145076829
|
|
|
|
|
|
|
|
|
|
|
| |
For example, on FreeBSD, ${PREFIX}/bin/python is a symlink
to the correct python version.
--
Change-Id: Iae79caae8d98530a6d8656b1915a8d5de9c132ea
Reviewed-on: https://cr.bazel.build/8396
PiperOrigin-RevId: 145068920
MOS_MIGRATED_REVID=145068920
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Unwrapping JavaCompilationArgsProvider from JavaProvider when collecting compile time dependencies artifacts (in addition to JavaCompilationArgsProvider), so that java_library could depend on Skylark rules that return java_common.provider. (this makes java sandwich complete \o/)
* Added a new param (source_files) to java_common.compile to allow compilation of source files in addition to source jars.
* Added a new sourceFiles field to JavaLibraryHelper in order to pass them to JavaCompilationHelper.
* Added a new method (java_common.default_javac_opts) for default Java compilation.
* Added a test for a basic java sandwich.
--
PiperOrigin-RevId: 145064700
MOS_MIGRATED_REVID=145064700
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move JNI code from windows_file_operations.cc to
windows_processes.cc, so all the JNI code is now
in the latter.
This lets us expose windows_file_operations.* to
the Bazel client (via the ":windows_jni_lib"
target), so we can finally share file handling
logic between the Bazel client and the JNI
library.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 145063140
MOS_MIGRATED_REVID=145063140
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract a WinAPI call from the JNI method's body.
In a subsequent change I'll move all JNI methods
to a common location (windows_processes.cc) and
that will be the only file dealing with JNI stuff.
The rest of the windows_* sources will be exposed
in the //src/main/native:windows_jni_util library
so the Bazel client can also depend on it later.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 145062890
MOS_MIGRATED_REVID=145062890
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement ForEachDirectoryEntry on Windows using
FindFirstFileW / FindNextFileW.
Supports long paths and traversing junctions.
See https://github.com/bazelbuild/bazel/issues/2107
See https://github.com/bazelbuild/bazel/issues/2181
--
PiperOrigin-RevId: 145062749
MOS_MIGRATED_REVID=145062749
|
|
|
|
|
|
|
|
|
|
| |
...while we have the problem with the hard-coded path to /bin/bash.
--
Change-Id: Icba0030458da42d1847fa68d6bf312195ff083f9
Reviewed-on: https://cr.bazel.build/8393
PiperOrigin-RevId: 145062669
MOS_MIGRATED_REVID=145062669
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a simple refactoring, no change in
functionality.
Create a windows_file_operations.h file, declare
windows_util::IsJunctionOrDirectorySymlink there,
We will include this file in the cc_library
//src/main/native:windows_jni_lib later and use
it from the Bazel client.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 145062164
MOS_MIGRATED_REVID=145062164
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 145059124
MOS_MIGRATED_REVID=145059124
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not intended to be a user-visible semantic change, aside from error messages.
This is to help avoid unintentional flattening of depsets, and to narrow down the number of call sites where this can occur, to help us print warning/deprecation messages.
EvalUtils#toIterable will now return an ImmutableList in place of SkylarkNestedSet. This should be ok since the caller shouldn't be relying on the result being a Skylark-safe type. Code that takes Iterable because it accepts either a list or set, can instead be changed to take Object and use EvalUtils#toIterableStrict for validation.
Note that NestedSet still implements Iterable, so native code can still easily and accidentally flatten sets.
--
PiperOrigin-RevId: 145044023
MOS_MIGRATED_REVID=145044023
|
|
|
|
|
|
|
|
|
|
| |
These exceptions are typically handled in javac and result in a diagnostic, but
it's possible for them to be thrown to the top-level by plugins or annotation
processors. If that happens they will be printed to the error output stream.
--
PiperOrigin-RevId: 145032097
MOS_MIGRATED_REVID=145032097
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 145030082
MOS_MIGRATED_REVID=145030082
|
|
|
|
|
|
|
|
| |
Fixes bazelbuild/bazel#1405
--
PiperOrigin-RevId: 145015113
MOS_MIGRATED_REVID=145015113
|
|
|
|
|
|
|
|
| |
the AppleCrosstoolTransition.
--
PiperOrigin-RevId: 145006581
MOS_MIGRATED_REVID=145006581
|
|
|
|
|
|
|
|
|
|
| |
The old names are deprecated but still supported for now. A flag for enforcing the deprecation will come in a later change.
RELNOTES[INC]: The traversal orders for depsets have been renamed. The old names are deprecated and will be removed in the future. New names: "stable" -> "default", "compile" -> "postorder", "link" -> "topological", "naive_link" -> "preorder".
--
PiperOrigin-RevId: 145004718
MOS_MIGRATED_REVID=145004718
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144992642
MOS_MIGRATED_REVID=144992642
|
|
|
|
|
|
|
|
|
|
|
| |
As pointed out in the new review comments on commit df726eae7b6ef11df3b962d720df36f63d5cd3a3, the
SpawnAction members did not need to be changed from private to
protected, they just needed to be accessed via accessor methods
in the derived LTOBackendAction class.
--
PiperOrigin-RevId: 144989490
MOS_MIGRATED_REVID=144989490
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144986187
MOS_MIGRATED_REVID=144986187
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144983864
MOS_MIGRATED_REVID=144983864
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144980245
MOS_MIGRATED_REVID=144980245
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Didn't fix the problem.
*** Original change description ***
Tag targets as jdk8 to avoid building them for jdk7
--
PiperOrigin-RevId: 144974286
MOS_MIGRATED_REVID=144974286
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Classifier should be provided in the form:
"groupId:artifactId:version[:packaging][:classifier]"
because that's what maven-dependency-plugin expects and not in the form:
"groupId:artifactId[:packaging][:classifier]:version"
as documented here: [1]. Also it was missed to reflect the classifier in
the output artifact name.
TEST PLAN:
WORKSPACE:
load("//tools:maven_rules.bzl", "maven_jar",
"maven_dependency_plugin")
maven_dependency_plugin()
maven_jar(
name = "jetty_server_sources",
artifact = "org.eclipse.jetty:jetty-server:9.3.11.v20160721:jar:sources",
sha1 = "b23cac190808baed928260b2c9beca3b1ed232b4",
)
BUILD:
java_library(
name = "jetty-server-sources",
exports = ["@jetty_server_sources//jar"],
)
$ bazel build :jetty-server-sources
[...]
Target //:jetty-server-sources up-to-date:
bazel-bin/libjetty-server-sources.jar
[1] https://maven.apache.org/pom.html#Maven_Coordinates
Fixes #2049.
--
Change-Id: I3297fb3676324cc6b4bb6ff6b2b6e18ce33f633c
Reviewed-on: https://cr.bazel.build/7213
PiperOrigin-RevId: 144972944
MOS_MIGRATED_REVID=144972944
|
|
|
|
|
|
|
|
| |
preferable to disabling the test, but of course the ideal thing to do is actually fix the code.
--
PiperOrigin-RevId: 144970101
MOS_MIGRATED_REVID=144970101
|
|
|
|
|
|
|
|
| |
Fixed: https://github.com/bazelbuild/bazel/issues/2376
--
PiperOrigin-RevId: 144969681
MOS_MIGRATED_REVID=144969681
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144965845
MOS_MIGRATED_REVID=144965845
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144964816
MOS_MIGRATED_REVID=144964816
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create an IFileMtime class and platform-specific
implementations to deal with mtime handling.
Since epochs and time granularity vary from
platform to platform, and we only care about
setting a file's/directory's mtime to the current
time or to a future time plus querying whether
something is in the future, we can easily create
an interface for these operations and that's
exactly what IFileMtime is.
Implement PosixFileMtime and WindowsFileMtime.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144956966
MOS_MIGRATED_REVID=144956966
|
|
|
|
|
|
|
|
|
|
|
| |
This dependency is actually inside the embedded tools of Bazel
and no longer needed and cause issue with JDK 7 builds.
--
Change-Id: I4810de68f0cc9c8d05a1aedbfb0594a69dc48d20
Reviewed-on: https://cr.bazel.build/8391
PiperOrigin-RevId: 144956010
MOS_MIGRATED_REVID=144956010
|
|
|
|
|
|
|
|
|
|
|
| |
This digest make sure that we produce a different RepositoryDirectoryValue
for different marker data, thus invalidating the node.
--
Change-Id: Ibc6286c76de7a8d07ece2bb8125bfb75095f7784
Reviewed-on: https://cr.bazel.build/8136
PiperOrigin-RevId: 144948233
MOS_MIGRATED_REVID=144948233
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this change:
- rename //src/main/native:windows_jni_utils to
//src/main/native:windows_jni_lib and make it
visible to //src/main/cpp:__subpackages__ because
we will use some methods there from this library
- move AutoHandle into windows_util.h, we'll use
it from blaze_util_windows.cc / file_windows.cc
later
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144946842
MOS_MIGRATED_REVID=144946842
|
|
|
|
|
|
|
|
|
| |
instead of producing text output containing formatted diagnostics. This is
necessary to support robust, locale-independent diagnostic post-processing.
--
PiperOrigin-RevId: 144907133
MOS_MIGRATED_REVID=144907133
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144890965
MOS_MIGRATED_REVID=144890965
|
|
|
|
|
|
|
|
|
| |
This matters when the same rule (or other exportable) is bound to multiple
variables, since the identifier of the first variable will become its name.
--
PiperOrigin-RevId: 144881310
MOS_MIGRATED_REVID=144881310
|
|
|
|
|
|
|
|
| |
* This allows xcrunwrapper to set the correct SDKROOT when building darwin targets.
--
PiperOrigin-RevId: 144874291
MOS_MIGRATED_REVID=144874291
|
|
|
|
|
|
|
|
|
|
| |
--experimental_objc_library and --experimental_objc_use_crosstool_for_binary.
This flag will allow testing of the complete (compilation and linking) rollout
of the objc crosstool.
--
PiperOrigin-RevId: 144864301
MOS_MIGRATED_REVID=144864301
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144858495
MOS_MIGRATED_REVID=144858495
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144857011
MOS_MIGRATED_REVID=144857011
|
|
|
|
|
|
|
|
| |
javac enabled end positions by default when invoke using the API.
--
PiperOrigin-RevId: 144850857
MOS_MIGRATED_REVID=144850857
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the code below was first written, the default value for @Option cpu was null. This value was then overwritten with whatever target_cpu got loaded from the CROSSTOOL, which became the basis for all code queries of the value "cpu".
This behavior was deprecated some months ago after the default @Option cpu was changed to auto-read from the host machine. So the CROSSTOOL "override" no longer ever happens.
Also made the relevant test more hermetic.
--
PiperOrigin-RevId: 144850329
MOS_MIGRATED_REVID=144850329
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144849686
MOS_MIGRATED_REVID=144849686
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144849308
MOS_MIGRATED_REVID=144849308
|