| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We suggest our users to regularly test their code base
with --all_incompatible_chages to have time to adapt their
code base to upcoming incompatible changes. When doing so,
it is annoying if that breaks due to the Skylark code embedded
in bazel not being ready for the upcoming incompatible changes.
Therefore, add tests exercising the embedded code enabling
all incompatible changes. This way, hopefully, changes like
f1ad0e6df1528894b will come before the deprecation is added.
Change-Id: Iea60ff6a4019db310d1f1a1ad6a7b2bb53101c6d
PiperOrigin-RevId: 190766449
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 190759949
|
|
|
|
|
|
|
| |
Since it's not used anywhere else outside of CcCompilationHelper.java
RELNOTES:
PiperOrigin-RevId: 190755588
|
|
|
|
|
|
|
| |
This can avoid passing targetBuilder to CompilationSupport.java
RELNOTES: None
PiperOrigin-RevId: 190743994
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifications of cc_library attribute nonconfigurability for linkstatic
and alwayslink were introduced in d08b27f and have been stale since the
ImplicitOutputsFunction specification was removed in 8a995b4. These
attributes should have no problem interpreting configured specifications
for their values.
Closes #4917.
PiperOrigin-RevId: 190743836
|
|
|
|
|
|
| |
are now internal, and the one that https://github.com/bazelbuild/bazel/commit/d350a897f6182d637ea819c41cd292a50c2db53d just snuck in...
PiperOrigin-RevId: 190705224
|
|
|
|
|
|
|
|
|
|
| |
utility method getConfiguration(ConfiguredTarget). Done using IntelliJ structural replace, with
$val$.getConfiguration() -> getConfiguration($val$)
and Expression type: TransitiveInfoCollection, applying constraint within type hierarchy. Had to clean up a few compile errors.
PiperOrigin-RevId: 190692493
|
|
|
|
|
|
| |
ConfiguredTarget#getConfiguration(). Add convenience methods in four Java test classes for use by refactoring tools to do this#getConfiguration(ConfiguredTarget) instead of ConfiguredTarget#getConfiguration.
PiperOrigin-RevId: 190684008
|
| |
|
|
|
|
|
|
|
|
|
| |
counters, optimized
for the use-case of hot keys.
RELNOTES: None
PiperOrigin-RevId: 190678987
|
|
|
|
|
|
| |
ConfiguredTarget#getConfiguration.
PiperOrigin-RevId: 190676253
|
|
|
|
|
|
|
| |
struct field on the j2objc fragment.
RELNOTES: None.
PiperOrigin-RevId: 190672475
|
|
|
|
|
|
|
|
| |
j$.** files.
RELNOTES: None.
PiperOrigin-RevId: 190667956
|
|
|
|
|
|
| |
cquery output callback logic
PiperOrigin-RevId: 190667120
|
|
|
|
| |
PiperOrigin-RevId: 190667019
|
|
|
|
|
|
|
| |
In preparation for removing all uses of the category field in Bazel options.
RELNOTES: None.
PiperOrigin-RevId: 190665669
|
|
|
|
|
|
| |
ConfiguredTargetKey#of(ConfiguredTarget)).
PiperOrigin-RevId: 190663565
|
|
|
|
|
|
| |
Closes #4916.
PiperOrigin-RevId: 190662077
|
|
|
|
|
|
|
|
|
| |
RELNOTES[INC]:
Variables PACKAGE_NAME and REPOSITORY_NAME are deprecated in favor of
functions `package_name()` and `repository_name()`.
https://docs.bazel.build/versions/master/skylark/lib/native.html#package_name
PiperOrigin-RevId: 190657188
|
|
|
|
| |
PiperOrigin-RevId: 190656902
|
|
|
|
|
|
| |
most elegant solution, but I don't have a better idea.
PiperOrigin-RevId: 190656869
|
|
|
|
|
|
|
|
|
| |
EventHandler is scoped to a commond, but SkylarkCustomCommandLine can outlive a single command. This constitutes a memory leak.
Any error messages caused by command line evaluation are still propagated to the user via a CommandLineExpansionException.
RELNOTES: None
PiperOrigin-RevId: 190650016
|
|
|
|
|
|
| |
This allows us to slightly simplify the renaming logic in StandaloneTestStrategy.
PiperOrigin-RevId: 190645674
|
|
|
|
|
|
| |
ConfiguredTargetFunction. The dep always has the right configuration, even in the case of an AliasConfiguredTarget.
PiperOrigin-RevId: 190642982
|
|
|
|
|
|
|
| |
It was removed from the java code 4 years ago, mentioning it causes the server to crash at startup.
RELNOTES: None.
PiperOrigin-RevId: 190636455
|
|
|
|
|
|
| |
ConfiguredTargetAndData into TargetCompleteEvent, which seems reasonable.
PiperOrigin-RevId: 190634162
|
|
|
|
|
|
|
|
|
| |
to use @SkylarkCallable instead."
expand_location.targets needed to be a named parameter.
RELNOTES: None.
PiperOrigin-RevId: 190624472
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 190617155
|
|
|
|
|
|
|
|
|
|
| |
The format of Truth's failure messages is about to change, which would break these tests.
Alternatively, I could modify these tests to accept both the old and new Truth message formats, but ideally most tests wouldn't rely on the exact message format at all.
(That suggests that an even better approach might be to just throw an exception whose message is a fixed string. That would avoid relying even on JUnit's message format, unlikely as I think that is to change.)
RELNOTES: None.
PiperOrigin-RevId: 190617095
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For CLIF it doesn't matter whether we use PIC or no-PIC, the important thing
is we get an output protobuf. Before https://github.com/bazelbuild/bazel/commit/35773928532c132e3229b490ad98f4ebfd3e5770, using no-PIC was hardcoded.
In this CL it was decided to generate PIC instead because the toolchains used
by CLIF targets appeared to all have needsPic. In b/73955395 it has been shown
not to be the case.
In this CL I'm changing the logic again to use no-PIC for CLIF and to
circumvent the logic that checks what the configuration and the toolchain say.
At the same time, SWIG also used the method setGenerateNoPic() after the
variable onlySingleOutput was removed in https://github.com/bazelbuild/bazel/commit/4e9c9f93b15dd2594097644c6b9ca5a579c712fb. In this CL I use the
enum to apply PIC and no-PIC in the same cases as before for SWIG.
This CL also refactors the methods and boolean variables used to determine whether to use PIC or not, hopefully making it clearer.
RELNOTES:none
PiperOrigin-RevId: 190615548
|
|
|
|
| |
PiperOrigin-RevId: 190611069
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remote cache.
The remote cache protocol only knows about regular files and
directories. Currently, during action output upload, symlinks are
resolved into regular files. This means cached "executions" of an
action may have different output file types than the original
execution, which can be a footgun. This CL bans symlinks from cachable
spawn outputs and fixes https://github.com/bazelbuild/bazel/issues/4840.
The interface of SpawnCache.CacheHandle.store is refactored:
1. The outputs parameter is removed, since that can be retrieved from the underlying Spawn.
2. It can now throw ExecException in order to fail actions.
Closes #4902.
Change-Id: I0d1d94d48779b970bb5d0840c66a14c189ab0091
PiperOrigin-RevId: 190608852
|
|
|
|
|
|
|
|
|
| |
They are not used anyway. optional_compiler_flag will be removed once internal
migration is finished.
RELNOTES: CppRules: Remove optional_*_flag fields from CROSSTOOL, they are not
used, and could be expressed using features.
PiperOrigin-RevId: 190600731
|
|
|
|
|
|
| |
*** Reason for rollback ***
PiperOrigin-RevId: 190600296
|
|
|
|
|
|
|
| |
Build variable global_whole_archive is not exposed in bazel anymore.
RELNOTES: None
PiperOrigin-RevId: 190598137
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 190591828
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a preparation work to expose Variables instance for all compile actions
to Skylark.
I didn't do linking variables in this cl, because this cl is already too big.
But they're coming shortly in a separate cl.
This is also in line with our goal to make build variables more discoverable and
better document.
RELNOTES: None.
PiperOrigin-RevId: 190591080
|
|
|
|
|
|
| |
Currently unnecessary
PiperOrigin-RevId: 190568226
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 190559240
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 190544948
|
|
|
|
|
|
| |
ConfiguredTargetAndData debugging check.
PiperOrigin-RevId: 190533522
|
|
|
|
| |
PiperOrigin-RevId: 190532114
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 190516662
|
|
|
|
|
|
|
| |
Also add tests for leading "+" in int(<string>) form.
RELNOTES: None
PiperOrigin-RevId: 190507678
|
|
|
|
|
|
|
| |
Missed this in https://github.com/bazelbuild/bazel/commit/8e9f4a8591d65c7972aea3957c57601570e0a39b.
RELNOTES: None.
PiperOrigin-RevId: 190506543
|
|
|
|
| |
PiperOrigin-RevId: 190502786
|
|
|
|
| |
PiperOrigin-RevId: 190500851
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Roll-forward with fix (equality and hashcode for relevant classes). Also add a bit more debugging info in case of failure.
PiperOrigin-RevId: 190492934
|
|
|
|
|
|
| |
holds a variety of strategy/context maps.
PiperOrigin-RevId: 190491357
|
|
|
|
|
|
| |
full content of native aspects.
PiperOrigin-RevId: 190489694
|