| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
This is in preparation of implementing dependency filtering correctly
for aspects.
--
MOS_MIGRATED_REVID=112721440
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112717648
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112713014
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112709717
|
|
|
|
|
|
|
|
|
|
| |
Package name comparison did not included the repository name which
leads to a crash when trying to build :* targets.
Fixes #792.
--
MOS_MIGRATED_REVID=112708531
|
|
|
|
|
|
|
| |
perform input discovery, there is no need to store the full set of edges in the action cache. This data is only used to formulate the set of input files for an action prior to checking the validity of a cache entry. For non-input-discovering actions, the set of input files is known statically and the action cache data is not used.
--
MOS_MIGRATED_REVID=112704382
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle more types:
* Boolean
* TriState
* SkylarkValue (eg. FileSetEntry)
* skip Licenses, Distribs.
--
MOS_MIGRATED_REVID=112690550
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112683298
|
|
|
|
|
|
|
|
|
| |
point to an existing directory.
This required fixing the worker strategy so that it reads params files not through said convenience symlinks, but from the execroot.
--
MOS_MIGRATED_REVID=112682485
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112681274
|
|
|
|
|
|
|
| |
on the local machine, too.
--
MOS_MIGRATED_REVID=112675289
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ExtraAction code assumed that it didn't need to list the runfiles
of its tools when running locally, but this isn't true with sandboxing.
I don't think fixing this will negatively affect anybody's performance
because they probably don't have any runfiles because they currently
can't use them, unless they're running actions remotely in which case
this change has no effect.
--
Change-Id: Ibeb3db9d31321912a7163d1bce0edf5f6288ea3e
Reviewed-on: https://bazel-review.googlesource.com/#/c/2520/
MOS_MIGRATED_REVID=112670586
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At first, this will only be used for emulating the planned implementation on Linux to validate it a little more before starting with the big work of porting everything to Windows in case it is doomed to failure.
In logging mode, the only places where we create symbolic links that we can't emulate with the plan (pointing to a non-existent file or to a file outside the output base and the source root, which are assumed to be writable):
- ExecutionTool.createOutputDirectoryLinks(). If we won't have the convenience symlinks on Windows, I won't shed a tear (I'm wondering why, though, because they are between the output base and the source tree)
- In the implementation of new_local_repository (Would need to be special-cased for Windows. No big deal.)
- In the implementation of the .tar.gz decompressor (doesn't seem to be serious, either.)
So this seems to be alright. Note, however, that we didn't check build-runfiles.cc, which might cause trouble. I don't remember any place where we create a link there that is illegal according to the above rules, though.
--
MOS_MIGRATED_REVID=112659070
|
|
|
|
|
|
|
|
|
|
| |
so it can operate on lists of classpath entries, instead of pre-joined
classpath strings.
Also improve error for missing .jdeps inputs.
--
MOS_MIGRATED_REVID=112634009
|
|
|
|
|
|
|
| |
require creation of CppCompileAction.
--
MOS_MIGRATED_REVID=112630562
|
|
|
|
|
|
|
| |
is a partial rollback of commit f1e257d because it turns out that loading sequentially can be a bottleneck.
--
MOS_MIGRATED_REVID=112628616
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an aspect has specified its configuration fragment dependencies,
use these in place of the rule's.
Note that the dynamic configuration support for this is yet to come.
Also in this CL:
* RuleContext is constructed with a ruleClassNameForLogging, which allows
error messages involving aspects to be clearer.
RELNOTES[NEW]: Skylark aspects can now specify configuration fragment
dependencies with fragments and host_fragments like rules can.
--
MOS_MIGRATED_REVID=112614357
|
|
|
|
|
|
|
|
|
|
| |
environment variable DEVELOPER_DIR to commands.
If $(DEVELOPER_DIR) is included in the genrule command, we bootstrap the XCODE_VERSION_OVERRIDE environment variable to the command.
The contract with the actual action executor is, if XCODE_VERSION_OVERRIDE is present in the environment, to additionally bootstrap the DEVELOPER_DIR absolute path to the command.
--
MOS_MIGRATED_REVID=112605616
|
|
|
|
|
|
|
|
| |
javac's bespoke zip implementation is now off by default:
https://bugs.openjdk.java.net/browse/JDK-7018859
--
MOS_MIGRATED_REVID=112600878
|
|
|
|
|
|
|
| |
its intended use.
--
MOS_MIGRATED_REVID=112598772
|
|
|
|
|
|
|
|
|
|
| |
This is part of removing the requirement of having base_workspace in your
package_path for bazel builds.
This also removes --experimental_objc_gcov_binary, since it doesn't seem to be needed anymore.
--
MOS_MIGRATED_REVID=112595137
|
|
|
|
|
|
|
|
|
| |
Previously the crashing logger would allow the server process to survive
which could leave things in a weird state if a crash was expected. Instead
of throwing an exception shut down the runtime.
--
MOS_MIGRATED_REVID=112589751
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updating the generate_workspace tool to:
- Respect dependency exclutions from the project object model (maven).
- Generate one rule per pom dependency or maven_jar source rule (using maven
group ID and artifact ID).
--
Change-Id: Ieb878f82be4352dcfb5755f8f71dfa7e592de78a
Reviewed-on: https://bazel-review.googlesource.com/#/c/2551/
MOS_MIGRATED_REVID=112574031
|
|
|
|
|
|
|
| |
what kind of performance we could get from how we imagine it would work under Windows.
--
MOS_MIGRATED_REVID=112572621
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The help message of this option had the effect inversed. The default
--block_for_lock setting makes the client block waiting for the lock
when needed, and the flag needs to be unset with --noblock_for_lock
to instead exit immediately.
Also rename the dummy noblock_for_lock variable to blockForLock to match
the naming convention. The variable is not used anywhere, as this class
only exists for the help messages.
--
MOS_MIGRATED_REVID=112566287
|
|
|
|
|
|
|
|
|
| |
Fixes #676.
--
Change-Id: I7474d3e3071c99452b6e1835d6f70671f34b1fd9
Reviewed-on: https://bazel-review.googlesource.com/#/c/2693
MOS_MIGRATED_REVID=112564791
|
|
|
|
|
|
|
| |
Fixes #790
--
MOS_MIGRATED_REVID=112563137
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112562308
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112561390
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112555666
|
|
|
|
|
|
|
| |
These are unnecessary because Bazel now carries these tools with itself in the @bazel_tools repository.
--
MOS_MIGRATED_REVID=112555031
|
|
|
|
|
|
|
|
| |
The avoids misleading "Building libfoo.jar (0 files)" progress messages for
sourcejar-only compilations.
--
MOS_MIGRATED_REVID=112512879
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112507181
|
|
|
|
|
|
|
| |
all so that custom implementations can have custom options passed around.
--
MOS_MIGRATED_REVID=112502778
|
|
|
|
|
|
|
|
|
|
|
| |
Also, don't require the :stl attribute to be defined by all rules that
use CcLibraryHelper.
This makes it possible for other languages to use CcLibraryHelper to
create a CppCompilationContext.
--
MOS_MIGRATED_REVID=112494452
|
|
|
|
|
|
|
|
| |
This is in preparation for removing the requirement that base_workspace be in
bazel's package_path.
--
MOS_MIGRATED_REVID=112489640
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112478681
|
|
|
|
|
|
|
|
| |
This is in preparation for removing the requirement that base_workspace be in
bazel's package_path.
--
MOS_MIGRATED_REVID=112477785
|
|
|
|
|
|
|
| |
Fixes #730.
--
MOS_MIGRATED_REVID=112475309
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112474631
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Refactored IntelliJSkylarkAspectTest. Eventually that test will be
merged with AndroidStudioInfoAspect test to validate implementation
equivalence.
2. Exposed ``root`` and ``is_source`` on Artifacts to Skylark.
3. Skylark aspect implementation outputs sources and dependencies
information.
--
MOS_MIGRATED_REVID=112473407
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112472854
|
|
|
|
|
|
|
| |
arguments (seems too messy for a family of functions).
--
MOS_MIGRATED_REVID=112472644
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112466264
|
|
|
|
|
|
|
|
|
|
|
| |
It is counter-intuitive to read ConnectToServer(false). By having
/*start=*/ in front of the boolean parameter the intention gets clear
(i.e., if it should or not start the Java server).
--
Change-Id: I74847deb6ec7daba62facd7a746d418943448182
Reviewed-on: https://bazel-review.googlesource.com/#/c/2680
MOS_MIGRATED_REVID=112466249
|
|
|
|
|
|
|
| |
The current set-up was overwriting the XML_OUTPUT_FILE of unittest_test, leading to weird error on ci.bazel.io.
--
MOS_MIGRATED_REVID=112462362
|
|
|
|
|
|
|
| |
It is currently unused and messes up IDEs because it requires a few dependencies that are not in the source tree (most notably, jimfs)
--
MOS_MIGRATED_REVID=112461226
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While BuildViewTestCase now has an update() function, it also has a lot of
legacy cruft that doesn't match how the code is used in production. This also
makes the test code a bit simpler.
Also add a couple missing fail() statements.
This is in preparation for adding a couple more tests; we don't have good
test coverage for interaction between Skylark aspects and native rules and
vice versa, especially for error scenarios.
I may reuse some of the AspectTest code, but that inherits AnalysisTestCase.
Inheriting AnalysisTestCase here also makes that easier.
--
MOS_MIGRATED_REVID=112460142
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- update some comments
- add some comments to make it easier to follow
- delete some dead code, in particular the SkyframeDependencyResolver can
never be null; remove an non-applicable @Nullable annotation
I'm trying to figure out how the error handling code works, in order to add
support for interleaved loading+analysis, which requires handling loading
errors in this code path.
--
MOS_MIGRATED_REVID=112456674
|
|
|
|
|
|
|
|
|
| |
This make those test target compatible with --nolegacy_bazel_java_test.
--
Change-Id: I2316c9aa53327b417ecce5fd5dab95ec726da11d
Reviewed-on: https://bazel-review.googlesource.com/#/c/2690
MOS_MIGRATED_REVID=112446514
|