aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Move FDO support to the analysis phase by wrapping FdoSupport in its own ↵Gravatar Lukacs Berki2016-04-07
| | | | | | | | | | | SkyFunction. This removes one of the two reasons for the existence of BuildConfiguration#prepareToBuild() which makes implementing dynamic configurations impossible and also makes FDO support halfway sane; now FDO is exactly as ugly as remote repositories, that is to say, reasonably okay. Ideally, we'd implement the zip extraction as an Action and make it a TreeArtifact, but support for TreeArtifacts is not mature yet enough, so it's not possible at the moment. -- MOS_MIGRATED_REVID=119150223
* Fix typo in doc stringGravatar Klaus Aehlig2016-04-07
| | | | | | | | | The ExperimentalStateTrackerTest tests the ExperimentalStateTracker, not itself. -- Change-Id: I182558bfa21881ae43e5c72161805c7045290551 Reviewed-on: https://bazel-review.googlesource.com/#/c/3260 MOS_MIGRATED_REVID=119149442
* Skylark docs: fix ctx.file and ctx.files.Gravatar Laszlo Csomor2016-04-07
| | | | | | | | | | | | | | | They were using "<ATTR>" which was parsed as a HTML tag. ctx.file appeared as: It is a shortcut for: list(ctx.attr..files)[0] ctx.files appeared as: It is a shortcut for: [f for t in ctx.attr. for f in t.files] -- MOS_MIGRATED_REVID=119149347
* Remove Aspect field from AspectKey.Gravatar Dmitry Lomov2016-04-07
| | | | | -- MOS_MIGRATED_REVID=119141878
* Mount whole directories into the sandbox when possibleGravatar Brian Silverman2016-04-07
| | | | | | | | | | | | | | | | | | | | This halves the overhead with sandboxing enabled vs disabled for a test that basically only mounts a bunch of files out of a directory, and slows that same test with a single extra file added to the directory (but not mounted) by only ~4%. The test is <https://gist.github.com/bsilver8192/10527a862ce16bb7f79a> with 30000 inputs moved to a subdirectory and only 10 genrules. This change means symlinks will be mounted directly as their target rather than as a symlink, but this solves some weird behavior with multi-level symlinks and will only break things which don't declare all of their dependencies. -- Change-Id: I1aa39dccb2e5fca2893bdab9065ee043d34019b2 Reviewed-on: https://bazel-review.googlesource.com/#/c/3220/ MOS_MIGRATED_REVID=119138157
* Use the correct Aspect in AspectFunction for Skylark aspects.Gravatar Dmitry Lomov2016-04-07
| | | | | | | | | | | | | Previously AspectFunction was using an Aspect from the SkyKey, which might have been stale. This CL fixes the bug as uncovered in the test (see SkylarkAspectsTest), but further refactoring is needed since SkylarkAspectClass equals() is incorrect, and in fact obtaining the Skylark aspect definition should always introduce Skyframe dependency. -- MOS_MIGRATED_REVID=119137636
* Fix the java compile for non-compatible type inference between java 7 and 8.Gravatar Googler2016-04-07
| | | | | -- MOS_MIGRATED_REVID=119116506
* cpp: fix the name of the function where |extracted_binaries| is populatedGravatar Thiago Farina2016-04-07
| | | | | | | | | | | There is no GetInstallDir() function that populates |extracted_binaries| vector. The one that exists and populates it, is called GetInstallBase() in src/main/cpp/blaze.cc. -- Change-Id: I09f951a132800e133197f5ec3206f436f90555f9 Reviewed-on: https://bazel-review.googlesource.com/c/3250/ MOS_MIGRATED_REVID=119107145
* Fix link to rust documentation.Gravatar Tom Prince2016-04-07
| | | | | | -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1119 MOS_MIGRATED_REVID=119104941
* Fix incremental dexing with bazel testGravatar Googler2016-04-07
| | | | | -- MOS_MIGRATED_REVID=119104560
* Override any existing watch stubs and watch application bundle artifacts ↵Gravatar Googler2016-04-07
| | | | | | | when copying. -- MOS_MIGRATED_REVID=119094214
* Add tests documenting the way rc-options are combinedGravatar Klaus Aehlig2016-04-07
| | | | | | | | | | | | | | | | Note that this patch does not change any semantics, it just adds tests. In this way, we have a machine-checkable (hence up to date) documentation of the semantics of how rc options are handled. In particular, our semantics is that - options get collected from all rc files, - more specific options take precedence over less specific ones, and - for equally specific options, the most specific rc file takes precedence. -- Change-Id: I6abadd15eb02a2f952debc3b005668e04dccd62a Reviewed-on: https://bazel-review.googlesource.com/#/c/3241 MOS_MIGRATED_REVID=119083139
* Make non-empty attribute checks happen during analysis of the target in ↵Gravatar Nathan Harmata2016-04-07
| | | | | | | question, rather than during loading of the target's package. This way a target's package won't be in error if e.g. an unrelated target has empty 'srcs'. -- MOS_MIGRATED_REVID=119079777
* Disable tree pruning for blacklisted annotation processorsGravatar Liam Miller-Cushon2016-04-07
| | | | | | | | | | Some annotation processors use non-standard APIs to examine the AST, and are broken by tree pruning. This change adds configuration to Turbine to allow a blacklist of processors to be provided, and disables tree pruning if any blacklisted processors are found. -- MOS_MIGRATED_REVID=119079114
* 4.25 of 5: Writing of UnwrittenMergedAndroidDataGravatar Googler2016-04-07
| | | | | | | | | | | Introduces the AndroidDataWriter and AndroidDataWritingVisitor to abstract the io operations from the data classes. Necessary refactoring to the stubbed write method on DataValue in DataAsset.writeAsset and DataResource.writeResource. New interface for the AttributeValues to reflect the simplifications of writing Resource Attributes. Of special note is the fact all xml is written into a single file, values.xml. This is following the Gradle convention and aapt has demonstrated a preference of only reading a values.xml and ignoring all other xml files in the values directory. Unless profiling demonstrates an advantage to writing multiple files (which I doubt), this merger carries on this convention. -- MOS_MIGRATED_REVID=119066611
* Removing left over debug warning.Gravatar Googler2016-04-07
| | | | | -- MOS_MIGRATED_REVID=119055012
* Description redacted.Gravatar Googler2016-04-07
| | | | | -- MOS_MIGRATED_REVID=119053259
* Clean up FancyTerminalEventHandlerGravatar Googler2016-04-07
| | | | | -- MOS_MIGRATED_REVID=119051781
* cpp: remove unnecessary visibility attribute from blaze_util targetGravatar Thiago Farina2016-04-05
| | | | | | | | | | | | | | | | Commit 5d737d642623: ("Some minor updates to the BUILD files.") made the default visibility for the whole package public, and thus setting it again in blaze_util target is rendundat. While at it remove blaze_util_platform.h from srcs attribute of client target, as it is already in hdrs list of blaze_util target and client already depends on it, and thus it is not necessary to list it again here. -- Change-Id: I995c3cd6e2f63384acef4b24b9a082e7cb59331a Reviewed-on: https://bazel-review.googlesource.com/#/c/3150/1 MOS_MIGRATED_REVID=119041634
* Add SMT detection for mac. Fixes #963.Gravatar Yue Gan2016-04-05
| | | | | | | -- Change-Id: Ib83af0d0a04dc6b173bef1df28d17abc7a3c824d Reviewed-on: https://bazel-review.googlesource.com/#/c/3120/ MOS_MIGRATED_REVID=119027507
* strip remote workspace path from java resourcesGravatar Steven Parkes2016-04-05
| | | | | | | | Resources in `java_library`s get the external repo path added to them, e.g., `foo` becomes `external/git_remote_repo/foo`. It needs to be removed, though I'm not sure this is the right way to strip it ... -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1085 MOS_MIGRATED_REVID=119024770
* Add the preinclude files to the mandatory input list of C++ compile actions.Gravatar Lukacs Berki2016-04-05
| | | | | | | Then less special-casing is needed and these files are always read by the compiler anyway, so we don't lose any incrementality. -- MOS_MIGRATED_REVID=119023956
* Add 'apple_watch1_extension' and 'apple_watch_extension_binary' to support ↵Gravatar Googler2016-04-05
| | | | | | | | | building watch OS 1 apps. RELNOTES: Support apple_watch1_extension and apple_watch_extension_binary rules for creating watch OS 1 extensions. -- MOS_MIGRATED_REVID=119000703
* transition to two blaze flags for incremental dexingGravatar Googler2016-04-05
| | | | | -- MOS_MIGRATED_REVID=118969066
* Remove shell quotes from javacoptsGravatar Liam Miller-Cushon2016-04-05
| | | | | -- MOS_MIGRATED_REVID=118967358
* Adds the output of -printconfiguration from proguard to the implicit outputs ofGravatar Alex Humesky2016-04-05
| | | | | | | | | | | android_binary (and java_binary). RELNOTES[NEW]: The output of -printconfiguration of proguard is available through an implicit "[target_name]_proguard.confg" output of android_binary (and java_binary). -- MOS_MIGRATED_REVID=118958246
* Introduce a seperate name to distinguish the objc provider passed from ↵Gravatar Cal Peyser2016-04-05
| | | | | | | native rules to skylark rules and that returned from skylark rules to depending native rules. This fixes a bug where a skylark rule that did not touch the objc provider would automatically pass up the objc provider it received from dependencies to dependant native rules, leading to duplicate symbol linking errors when the same objc provider was exported twice. -- MOS_MIGRATED_REVID=118947782
* Correctly generates the expected file names of the generated protos when the ↵Gravatar Googler2016-04-05
| | | | | | | names contain url, http or https. -- MOS_MIGRATED_REVID=118946808
* experimental UI: update progress bar on progress eventsGravatar Klaus Aehlig2016-04-05
| | | | | | | | | | | In the experimental UI, use progress events as an occasion to update the progress bar. However, to avoid unnecessary noise, only do so, if the progress bar potentially changes with time. -- Change-Id: I9bee093c29e0eb50e7fcce2fa6e941a02d615def Reviewed-on: https://bazel-review.googlesource.com/#/c/3206 MOS_MIGRATED_REVID=118944208
* Introduces action_config. Does this by:Gravatar Cal Peyser2016-04-05
| | | | | | | | | 1) Introducing the action_config message in the crosstool protobuf definition. The only part of that definition that are implemented in this CL is the "tool" section, other parts will be implemented in future CLs. The proto fields are here now to avoid being delayed by release cycles at each step of the implementation. 2) Refactoring the implementation of the "feature algebra" that computes the enabled features for a given toolchain. An interface called "CrosstoolActivatable" is used to represent any participant int the feature algebra, and can be either a feature or an action_config. -- MOS_MIGRATED_REVID=118943663
* Expose AppleToolchain to skylark.Gravatar Cal Peyser2016-04-05
| | | | | -- MOS_MIGRATED_REVID=118943054
* Add workspace name to module_space in python stub_template.txt fileGravatar Yun Peng2016-04-05
| | | | | | | | | Fixed #1040 RELNOTES:none -- MOS_MIGRATED_REVID=118941667
* Replace an exception message check with a class check. It's saner.Gravatar Lukacs Berki2016-04-05
| | | | | -- MOS_MIGRATED_REVID=118940625
* experimental UI: show run-time for long-running actions in the progress barGravatar Klaus Aehlig2016-04-04
| | | | | | | | | | | | Currently, the progress bar shows the 3 earliest started still running actions. While this might give some indication about which actions delay the build process, it lacks quantitative information about how long the delay is. By adding the current run time to the progress bar, at least some quantitative information is provided. -- Change-Id: Ib90eda67d87384a4372cda7779a09a44cea2b8dd Reviewed-on: https://bazel-review.googlesource.com/#/c/3205 MOS_MIGRATED_REVID=118933973
* Pass through the clock to the ExperimentalStateTrackerGravatar Klaus Aehlig2016-04-04
| | | | | | | | | | In this way, the ExperimentalStateTracker has access to all the information needed to provide information about the run-time of currently running actions. -- Change-Id: I0f4e48f39e9ebe63555e4bb1d70df2a6dbb65430 Reviewed-on: https://bazel-review.googlesource.com/#/c/3204 MOS_MIGRATED_REVID=118929758
* Dig out the builtin include file from the filegroup of libc_top instead of ↵Gravatar Lukacs Berki2016-04-04
| | | | | | | | | | | special-casing it in CppConfiguration. This seems to be the most reasonable solution. I was toying with the idea of adding a field to CROSSTOOL but that would fail if you set libc_top to something other than what was specified in that file. If I had a infinite amount of time, I'd create a custom rule called cc_libc where libc_top would point so that this file can be referenced by an attribute, but since I don't, this seems to be workable compromise. Also note that contrary to what you'd glean from the code, we don't actually have "compile" and "link" filegroups for libc. -- MOS_MIGRATED_REVID=118921101
* Point links for Skylark rule sets to the appropriate repositories.Gravatar David Chen2016-04-04
| | | | | | | Fixes #1087 -- MOS_MIGRATED_REVID=118919990
* Simplify some of the code around invoking proguard.Gravatar Alex Humesky2016-04-04
| | | | | -- MOS_MIGRATED_REVID=118819625
* Allow compilations to have an empty source listGravatar Liam Miller-Cushon2016-04-04
| | | | | | | for compatibility with JavaBuilder. -- MOS_MIGRATED_REVID=118802288
* Clarify that indirect deps are not necessarily transitiveGravatar Liam Miller-Cushon2016-04-04
| | | | | | | | | The compiler may implicitly load types that are direct dependencies but not referred to in source, e.g. in the case of package-info files where the package symbol is implicitly loaded to resolve annotations. -- MOS_MIGRATED_REVID=118800795
* *_test rules now return an .xctest.dSYM bundle.Gravatar Googler2016-04-01
| | | | | -- MOS_MIGRATED_REVID=118786316
* Remove BuildConfiguration#supportsIncrementalBuild , which is apparently unused.Gravatar Lukacs Berki2016-04-01
| | | | | | | BuildConfiguration.Fragment is much more complicated than it should be. Every little helps. -- MOS_MIGRATED_REVID=118783105
* Enable all Label instantiations to use a single intern pool to optimize ↵Gravatar Googler2016-04-01
| | | | | | | | | memory usage Label instances do not share a single intern pool today, as some other objects, such as SkyKey and PackageIdentifier. This change allows all Label instantiations to use a single intern pool for better memory usage. -- MOS_MIGRATED_REVID=118780952
* Make local_repository's interpretation of 'path' match the other rules'Gravatar Kristina Chodorow2016-04-01
| | | | | | | | | Noticed this while messing with remote runfiles. RELNOTES: local_repository can take a relative path. -- MOS_MIGRATED_REVID=118780775
* Make worker more defensive about NPEsGravatar Kristina Chodorow2016-04-01
| | | | | | | | | I was messing with filesystem dirtiness checkers and got an NPE, and I guess it was so early in the build that the buildRequest didn't have WorkerOptions yet, so I got a NPE from WorkerModule.buildComplete masking the actual NPE. -- MOS_MIGRATED_REVID=118780059
* Fix flaky process_wrapper_test and add some explanatory comments.Gravatar Philipp Wollermann2016-04-01
| | | | | -- MOS_MIGRATED_REVID=118775810
* Set shard_count to 2 to ↵Gravatar Damien Martin-Guillerez2016-04-01
| | | | | | | | | | | | | //src/test/java/com/google/devtools/build/lib:analysis_test This target is timeout flaky and internally we used 2 shard for it, let do the same for the OSS test suite now we have the java test launcher. Fixes #1112. -- MOS_MIGRATED_REVID=118768231
* Deduplicate annotation processor classesGravatar Liam Miller-Cushon2016-04-01
| | | | | | | Also rename the build method from add* to set*. -- MOS_MIGRATED_REVID=118746866
* Track which output files are writtenGravatar Liam Miller-Cushon2016-04-01
| | | | | | | | | instead of initializing all file objects to empty. Some annotation processors speculatively open files and handle FileNotFoundException, and we were always providing empty files. -- MOS_MIGRATED_REVID=118730162
* Allow .o files as sources for objc builds.Gravatar Cal Peyser2016-04-01
| | | | | -- MOS_MIGRATED_REVID=118727286
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 01:36:52 +0000