aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
...
* Make actual-less bind() rules work again.Gravatar Lukacs Berki2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122995313
* Replace the occurrences of Constants.PRODUCT_NAME for a call toGravatar Luis Fernando Pino Duque2016-05-23
| | | | | | | | | BlazeRuntime#getProductName() or a reference to TestConstants.PRODUCT_NAME for tests. This CL prepares the codebase in order to delete the constant. -- MOS_MIGRATED_REVID=122993568
* Uses "zip -@" to avoid arguments with too many files. Fixes #1303.Gravatar Yue Gan2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122990255
* Add framework support to ExperimentalObjcLibrary.Gravatar Cal Peyser2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122988772
* Use setLoadingOrWorkspacePhase instead of setLoadingPhase where relevant,Gravatar Damien Martin-Guillerez2016-05-23
| | | | | | | | | | | commit 3fedf9e618cbce3dbdd00559b2de0bb8e2d43171 introduced the distinction between the loading phase and the workspace phase. This check broke the use of native.existing_rule(s) in skylark remote repository, added a regression test for it. Fixes #1277 -- MOS_MIGRATED_REVID=122988569
* JavaLibraryHelper: when collecting transitive source jars, look in the ↵Gravatar Carmi Grushko2016-05-23
| | | | | | | | | targets that were added using addDeps(), instead of looking in the "deps" attribute. This is currently a no-op, because collectTransitiveJavaSourceJars() is only called if noProviders() hasn't been called, which never happens in the current code in Blaze. -- MOS_MIGRATED_REVID=122985812
* JavaLibraryHelper: do not handle jars in deps.Gravatar Carmi Grushko2016-05-23
| | | | | | | To use jars in deps, wrap them in java_import. -- MOS_MIGRATED_REVID=122985072
* Make alias targets keep their own configuration.Gravatar Lukacs Berki2016-05-23
| | | | | | | | | This prevents the case of a rule acquiring the null configuration in case the alias points to an input file. Which, in turn, makes "bazel build" work for these targets. The reason it breaks is that TargetCompletionValue instances are created from the associated ConfiguredTarget in SkyframeExecutor#buildArtifacts(), which means that if the configurations do not match, TargetCompletionFunction requests a different ConfiguredTargetValue than it was created from. Fixes #1297. -- MOS_MIGRATED_REVID=122973526
* Remove a bunch of unnecessary files from the Bazel binary.Gravatar Ulf Adams2016-05-23
| | | | | | | This reduces the size of the Bazel binary by ~25%. -- MOS_MIGRATED_REVID=122971740
* Rollback of commit d3cccae7b663d5defea2943509b0d9d245279830.Gravatar Googler2016-05-23
| | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Rolling forward with api tolerance. *** Original change description *** Automated [] rollback of commit 941ef4d96d85e114eb6cca2fc0f646578ab0ef27. *** Reason for rollback *** Breaks Bazel due to internal patch for Round qualifier. *** Original change description *** * Adds handling for anydpi and watch, two unsupported qualifiers in FolderConfiguration. * Handles resources nested in directories. * Makes the resource processing resilient to invalid qualifiers. -- MOS_MIGRATED_REVID=122910358
* Improve fidelity of proto configured attribute serializationGravatar Michajlo Matijkiw2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122889821
* Roll forward just the new unit test from commit ↵Gravatar Googler2016-05-23
| | | | | | | | | 8375185ee11d573562f98de14bed79a77fcfd728 that applies to already-existing code. -- MOS_MIGRATED_REVID=122869862
* When BuildOptions.get(Class<T> optionsClass) fails, include whichGravatar Greg Estren2016-05-23
| | | | | | | | | fragment was requested in the NullPointerException message. This helps diagnose dynamic configuration errors. -- MOS_MIGRATED_REVID=122855814
* Change the way protos report their output.Gravatar Googler2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122846987
* Add test coverage for label visitation over computed defaults in ↵Gravatar Greg Estren2016-05-23
| | | | | | | | | | | | | | | AggregatingAttributeMapper. Recall that computed defaults have the ability to read all nonconfigurable attributes and whatever configurable attributes they declare in their constructors. I mistakenly thought that AggregatingAttributeMapper.visitLabels was skipping computed defaults that didn't declare configurable deps. While everything was, in fact, fine, this cl properly enforces expectations. In the process, I created a custom rule class in AggregatingAttributeMapperTest, which forced AbstractAttributeMapperTest to inherit BuildViewTestCase. That offered some code cleanup opportunity that makes up the rest of this cl. -- MOS_MIGRATED_REVID=122838948
* Store the hash code of the Environment in the RuleClass object. When a ↵Gravatar Janak Ramakrishnan2016-05-23
| | | | | | | | | RuleClass is deserialized as part of a Skylark rule, the Environment is currently not present, but it is needed to detect changes to the rule. Also precompute and store the Environment's hash code, and do a drive-by clean-up of a bunch of warnings in the Environment code. -- MOS_MIGRATED_REVID=122838588
* Adds a translation layer for ObjcProvider values between java and skylark to ↵Gravatar Cal Peyser2016-05-23
| | | | | | | allow for the exposure of values that are not typed as skylark primatives. -- MOS_MIGRATED_REVID=122838580
* Remote worker to listen to a specific port for HazelcastGravatar Alpha Lam2016-05-20
| | | | | | | | | | | | This change allows starting remote worker with an embedded hazelcast server that listens to a specific port. This allows test to run reliably. Fixes #1271. -- Change-Id: I0bb36af5837f83cad3d76b8acb50f89cd599ee87 Reviewed-on: https://bazel-review.googlesource.com/c/3650/ MOS_MIGRATED_REVID=122829898
* Move the command line arguments for C++ preprocessor defines to a feature.Gravatar Lukacs Berki2016-05-20
| | | | | | | | | | | | This required a few assorted changes: - The FDO build stamp is not special-cased anymore, it is treated as a preprocessor define like any other. - When compiling a .pcm file, use interfaceContext instead of the regular context when setting up the build variables. This is a bit more consistent and would be a good cause for a future bug. This is a retry of commit 7841a6ab100fc35a67600f1ce1a70d293c51350e, which made some bold changes to LIPO that didn't work out well. -- MOS_MIGRATED_REVID=122829825
* Invalidate external repositories when their names changeGravatar Brian Silverman2016-05-20
| | | | | | | | | | | | | | Without this, old repositories are still cached across the change to give a name in the WORKSPACE file, which results in annoying warnings. This should have been included in a7fea8a1467a89adde75e67bc99bf0e040f71fe9. Fixes #1166. -- Change-Id: I831b842dc07b4ca7925f003b68f4838d083b1166 Reviewed-on: https://bazel-review.googlesource.com/c/3660/ MOS_MIGRATED_REVID=122829553
* Rollback of commit 8375185ee11d573562f98de14bed79a77fcfd728.Gravatar Philipp Wollermann2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122825908
* Change some weird formating.Gravatar Cal Peyser2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122824226
* Rollback of commit 7841a6ab100fc35a67600f1ce1a70d293c51350e.Gravatar Lukacs Berki2016-05-20
| | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** breaks [] *** Original change description *** Move the command line arguments for C++ preprocessor defines to a feature. This required a few assorted changes: - The LIPO compilation context is not merged anymore. Include paths for auxiliary files are apparently taken from the profile files, so it is not necessary. - The FDO build stamp is not special-cased anymore, it is treated as a preprocessor define like any other. - When compiling a .pcm file, use interfaceContext instead of the regular context when setting up the build variables. Th... *** -- MOS_MIGRATED_REVID=122823591
* experimental UI: improve message shorteningGravatar Klaus Aehlig2016-05-20
| | | | | | | | | | | | | | | | | When a progress message has to be shortened, as it does not fit in a line in the progress bar, add a new first attempt: if the message the path implicit to the label, only shorten that path within the message (if that gets short enough, leaving a reasonable part of the path); usually, the additional information is more useful than having a longer part of the path present. While there, also fix incorrect length computation in a different case of message shortening. -- Change-Id: Ied80e03cace1b249fc0f4e11bce41f2b4207b6ad Reviewed-on: https://bazel-review.googlesource.com/#/c/3670 MOS_MIGRATED_REVID=122818198
* Update Bazel native rule documentation to use new ${link} syntax.Gravatar David Chen2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122772973
* Use correct rule name for $java_import_base attribute documentation.Gravatar David Chen2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122772865
* Propagate Apple Watch extensions dSYMs to parent ios_application.Gravatar Dmitry Shevchenko2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122769355
* Accurately document java_*.depsGravatar Liam Miller-Cushon2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122755869
* Consider /src/ in the path when locating the java root directory,Gravatar Googler2016-05-19
| | | | | | | | | | to support cases like src/com/google/java, where the root is just src. Also check for nested /src/ directories. This allows "blaze analyze" to understand the classes provided by such "double src" rules and match them up to java imports. -- MOS_MIGRATED_REVID=122748028
* Rollback of commit 941ef4d96d85e114eb6cca2fc0f646578ab0ef27.Gravatar Googler2016-05-19
| | | | | | | | | | | | | | | *** Reason for rollback *** Breaks Bazel due to internal patch for Round qualifier. *** Original change description *** * Adds handling for anydpi and watch, two unsupported qualifiers in FolderConfiguration. * Handles resources nested in directories. * Makes the resource processing resilient to invalid qualifiers. -- MOS_MIGRATED_REVID=122747030
* ipa_post_processor for ios_extensions uses PlugIns directory instead of Payload Gravatar Googler2016-05-19
| | | | | | | CLEANUP=<fixing documentation> -- MOS_MIGRATED_REVID=122743083
* Make ide_build_info work again with targets that have configurable attributes.Gravatar Lukacs Berki2016-05-19
| | | | | | | This fixed some fallout from commit 7894c18dbaf237a1c02d76beabe6ca54faf5039a. I also audited all the sites that change introduced ImmutableMap.Builder at. -- MOS_MIGRATED_REVID=122738945
* Rollback of commit 9f046cba37de6088b2f81717bc263889a5146d86.Gravatar Googler2016-05-19
| | | | | | | | | | | | | *** Reason for rollback *** Rollback of commit e37c55eccbd4516b2db7aaf58ef95209dfad3ed4 is complete so rolling this semantically unrelated change forward again *** Original change description *** Automated [] rollback of commit b8946eabd60a199a66a1892701d52d9801c7fb1a. -- MOS_MIGRATED_REVID=122736257
* The link command line API can consume a feature configuration to configure ↵Gravatar Cal Peyser2016-05-19
| | | | | | | flags and environment variables. -- MOS_MIGRATED_REVID=122735641
* CommandLine: Add support for tree artifact expansions.Gravatar Rumou Duan2016-05-19
| | | | | | | ParameterFileWriteAction: Add support to write out CommandLine with tree artifact expansions. -- MOS_MIGRATED_REVID=122734422
* Take aliases into consideration when creating a LabelAndConfiguration from a ↵Gravatar Lukacs Berki2016-05-19
| | | | | | | ConfiguredTarget. -- MOS_MIGRATED_REVID=122729392
* experimental_ui: show number of packages loaded during analysisGravatar Klaus Aehlig2016-05-19
| | | | | | | | | | | After the initial loading phase, further packages are loaded during analysis. Show in the experimental UI the total number of packages loaded during analysis phase to indicate at least some progress. -- Change-Id: I345c6f806591e70e4397fc3e3365718dde95d7d2 Reviewed-on: https://bazel-review.googlesource.com/#/c/3645 MOS_MIGRATED_REVID=122728719
* Allow imports of dylib frameworks.Gravatar Peter Schmitt2016-05-19
| | | | | | | RELNOTES: objc_framework now supports dynamic frameworks. -- MOS_MIGRATED_REVID=122728042
* Remove the unused field CppConfiguration.execRoot.Gravatar Lukacs Berki2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122727524
* Make "blaze run" work with aliases.Gravatar Lukacs Berki2016-05-19
| | | | | | | Fixes #1290. -- MOS_MIGRATED_REVID=122726071
* Move the command line arguments for C++ preprocessor defines to a feature.Gravatar Lukacs Berki2016-05-19
| | | | | | | | | | | This required a few assorted changes: - The LIPO compilation context is not merged anymore. Include paths for auxiliary files are apparently taken from the profile files, so it is not necessary. - The FDO build stamp is not special-cased anymore, it is treated as a preprocessor define like any other. - When compiling a .pcm file, use interfaceContext instead of the regular context when setting up the build variables. This is a bit more consistent and would be a good cause for a future bug. -- MOS_MIGRATED_REVID=122725179
* LoadingPhaseStartedEvent: also provide the counter of packages loadedGravatar Klaus Aehlig2016-05-19
| | | | | | | | | | | Even during analysis, more packages will be loaded. However, those are not tracked by the LoadingProgressReceiver. Therefore, provide a reference to the AtomicInteger counting the total number of packages loaded already. -- Change-Id: Ia546a2fec4afe6fd1bd69448b14ba889c68ae12c Reviewed-on: https://bazel-review.googlesource.com/#/c/3644 MOS_MIGRATED_REVID=122722688
* Remove the "licenses" and "distribs" attribute from the alias rule.Gravatar Lukacs Berki2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122721164
* Simplify DependencySet.Gravatar Ulf Adams2016-05-19
| | | | | | | | | | - mark the addDependencies method as @VisibleForTesting, and don't round-trip through PathFragment - use Path.getRelative(String) instead of Path.getRelative(PathFragment), which may do additional optimizations -- MOS_MIGRATED_REVID=122720947
* Add an overview comment about how the analysis phase works and some pointers ↵Gravatar Lukacs Berki2016-05-19
| | | | | | | to it. -- MOS_MIGRATED_REVID=122718503
* * Adds handling for anydpi and watch, two unsupported qualifiers in ↵Gravatar Googler2016-05-19
| | | | | | | | | | FolderConfiguration. * Handles resources nested in directories. * Makes the resource processing resilient to invalid qualifiers. -- MOS_MIGRATED_REVID=122688529
* Write a -gensrc.jar even if the compilation failedGravatar Liam Miller-Cushon2016-05-19
| | | | | | | The generated sources are useful for debugging annotation processors. -- MOS_MIGRATED_REVID=122683781
* Use BufferedOutputStream for zipping / jar.Gravatar Googler2016-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | This is for the resources.zip and the srcjar and aar. For the srcjar this is only slightly faster (100ms), but we might as well? Perhaps this is because the files are quite large anyway. Not sure if there would be smaller writes with compression. For the resources.zip it seems to make a bigger difference: > 1s when run locally. Perhaps this is because there are more small files. Didn't benchmark aar at all, just noticed it. Kevin mentioned the Buffering on one of the issues, so I happened to notice this when using similar code for prototype of R.class jar creation (seemed to be > 1s faster in that case, but that was also compressing). -- MOS_MIGRATED_REVID=122663374
* For tests that check against output paths, provide the ability to strip out ↵Gravatar Greg Estren2016-05-19
| | | | | | | | | | | | | | | | | the C++-contributed fragment. e.g. provide the ability to translate: bazel-out/gcc-X-glibc-Y-x86-fastbuild/ to: bazel-out/fastbuild/ This applies to artifacts built with dynamic configurations for targets with no C++ fragments in their configuration. -- MOS_MIGRATED_REVID=122643518
* Fix #837: worker_verbose flag has no effect.Gravatar Philipp Wollermann2016-05-19
| | | | | | | Due to reusing an old Reporter instead of grabbing the current one for each build, verbose messages were lost and not printed to the console. Also adds a test for this feature. -- MOS_MIGRATED_REVID=122639383