| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
of directories and a file path containing more directories to blacklist. The current usage of PrecomputedValue#BLACKLISTED_PACKAGE_PREFIXES_FILE is overly general and is only meaningfully used by unit tests; in practice, the blacklist file path can never change over the lifetime of the Bazel server. Perform a minor simplifying refactor as a result of this.
RELNOTES: None.
PiperOrigin-RevId: 177164057
|
|
|
|
|
|
|
| |
CcToolchainProvider. Toolchain information must be removed from
CppConfiguration to allow the c++ rules to use hermetic platforms.
PiperOrigin-RevId: 177163880
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
//src/test/shell/bazel/android:android_sdk_integration_test PASSED in 75.4s
After:
//src/test/shell/bazel/android:android_sdk_integration_test PASSED in 30.2s
Stats over 3 runs: max = 30.2s, min = 16.0s, avg = 22.4s, dev = 5.9s
RELNOTES: None.
PiperOrigin-RevId: 177155880
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These enums were only used inside the class and
only to slighlty improve readability.
The Tokenize enum was a simple boolean.
The Options enum was implementing two boolean
flags, and it improved call-site readability at
the cost of implementation-site readability and
checking if the value is set via set-containment.
Change-Id: I3858ff0c67f89c8b2c5631e260ce79cd939c6eb1
PiperOrigin-RevId: 177155294
|
|
|
|
|
| |
Change-Id: I4bcc7c0024646b7d4372464f5290375d41702429
PiperOrigin-RevId: 177150713
|
|
|
|
|
|
|
| |
SIPUSH and *CONST_*.
RELNOTES: None
PiperOrigin-RevId: 177149410
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop using LocationExpander.Options in
LocationExpander constructors, because the Options
semantics are confusing.
I also need the refactoring in order to extend the
expansion semantics: to support expanding to
absolute paths on Windows, where $(location)
should not expand to the (non-existent) runfiles
path, but to the absolute path the runfiles
symlink would point to.
See https://github.com/bazelbuild/bazel/issues/4171
Change-Id: Ie4d47ec3807bc3c6e39156efa1746b666f69f99c
PiperOrigin-RevId: 177147372
|
|
|
|
| |
PiperOrigin-RevId: 177138150
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that the SUCCESS status is often misunderstood to mean "zero exit",
even though this is clearly documented. I've decided to add another status for
non-zero exit, and use success only for zero exit to avoid this pitfall.
Also, many of the status codes are set, but never used. I decided to reduce the
number of status codes to only those that are actually relevant, which
simplifies further processing. Instead, we should add a string message for the
error case when we need one - we're not using it right now, so I decided not to
add that yet.
PiperOrigin-RevId: 177129441
|
|
|
|
|
|
|
| |
so that integration tests can use them.
RELNOTES: None
PiperOrigin-RevId: 177113967
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 177113477
|
|
|
|
|
|
| |
Blaze now passes class paths as individual arguments, instead of a pre-joined.
PiperOrigin-RevId: 177112933
|
|
|
|
|
|
| |
This avoids bazelbuild/bazel#4108.
PiperOrigin-RevId: 177096864
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 177068047
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 177049661
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this CL with --runs_per_test=10 on 2015 Macbook Pro
INFO: Elapsed time: 622.222s, Critical Path: 314.33s
//src/test/shell/bazel/android:android_ndk_integration_test TIMEOUT in 10 out of 10 in 314.3s
Stats over 10 runs: max = 314.3s, min = 306.1s, avg = 308.9s, dev = 3.5s
After this CL with --runs_per_test=10 on 2015 Macbook Pro
INFO: Elapsed time: 875.356s, Critical Path: 148.11s
//src/test/shell/bazel/android:android_ndk_integration_test PASSED in 148.1s
Stats over 60 runs: max = 148.1s, min = 25.3s, avg = 70.2s, dev = 38.7s
RELNOTES: None
PiperOrigin-RevId: 177048666
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 177048616
|
|
|
|
| |
PiperOrigin-RevId: 177032673
|
|
|
|
|
|
|
|
|
| |
using FileValue, rather than FileStateValue, nodes as the roots of the rdep traversal.
This is incorrect e.g. when a .bzl file is a target of a symlink that is load'd from a BUILD file.
RELNOTES: None
PiperOrigin-RevId: 177018264
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks //javatests/com/google/devtools/intellij/blaze/plugin/aspect/java/soygenrule:SoyGenruleTest
*** Original change description ***
Create the output source jar in java_common.compile
and expose transitive source jars to Skylark.
Slightly refactor java classes to take in specific host javabase inputs and host java executable for creating the source jar, instead of always relying on fetching them from native java rules specific attributes.
Creating the output source jar in java_common.compile makes the behavior more similar to java_library.
Exposing the transitive_source_jars to Skylark helps with the Skylark migration fr...
***
RELNOTES: None.
PiperOrigin-RevId: 177015958
|
|
|
|
|
|
|
| |
I can't find whether ctx.run() actually exists. https://docs.bazel.build/versions/master/skylark/lib/ctx.html implies it doesn't.
RELNOTES: None.
PiperOrigin-RevId: 177005229
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 177004853
|
|
|
|
|
|
|
|
|
|
| |
Add CompactSkylarkInfo, which stores its values as an array instead of
a map. The space savings will probably not be dramatic because
providers usually have a limited amount of keys. But, there are a lot
of them!
Change-Id: Idd452a5e3982f773b1c5202c73f3d7031ec022c6
PiperOrigin-RevId: 176995376
|
|
|
|
|
|
|
| |
Split missing-docstring into missing-module-docstring and missing-function-docstring.
RELNOTES: None.
PiperOrigin-RevId: 176993716
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 176899549
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 176877525
|
|
|
|
|
|
| |
RELNOTES:
Add six to deps of has_services=1 py_proto_librarys.
PiperOrigin-RevId: 176873598
|
|
|
|
|
| |
RELNOTES:
PiperOrigin-RevId: 176844836
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and expose transitive source jars to Skylark.
Slightly refactor java classes to take in specific host javabase inputs and host java executable for creating the source jar, instead of always relying on fetching them from native java rules specific attributes.
Creating the output source jar in java_common.compile makes the behavior more similar to java_library.
Exposing the transitive_source_jars to Skylark helps with the Skylark migration from the old 'java' provider to JavaInfo.
Progress on #2614.
RELNOTES: transitive_source_jars is now exposed on JavaInfo.
PiperOrigin-RevId: 176844750
|
|
|
|
|
|
|
|
|
|
|
| |
to rules that use the $(JAVA) or the $(JAVABASE) Make variable.
This is necessary because a future Blaze version will require this for rules that use said Make variables. This incompatible change can be tested today by adding the --noexperimental_enable_jvm_configuration_make_variables command line option to Blaze.
This change is part of a large-scale change ([]
RELNOTES: None.
PiperOrigin-RevId: 176834987
|
|
|
|
|
|
| |
The "$singlejar" attribute was removed in unknown commit.
PiperOrigin-RevId: 176826579
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/0ebb3e54fc890946ae6b3d059ecbd50e4b5ec840.
PiperOrigin-RevId: 176774887
|
|
|
|
|
|
|
| |
Bazel is not reading its value anyway.
RELNOTES: None
PiperOrigin-RevId: 176768851
|
|
|
|
| |
PiperOrigin-RevId: 176759562
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 176700595
|
|
|
|
|
|
|
|
|
|
|
| |
CppHelper. In CppHelper, CcToolchainProvider and CppConfiguration are used
sepereately, allowing toolchain information to be removed from
CppConfiguration.
This is necessary to introduce hermetic toolchains, which require that
toolchain information be seperated from the configuration, into the c++ rules.
PiperOrigin-RevId: 176694160
|
|
|
|
|
|
| |
deduplicate code.
PiperOrigin-RevId: 176686795
|
|
|
|
|
|
|
|
|
| |
We already handle this properly in the normal case. However, when no attributes
from the new implementation of resource processing are specified, we fall back
to the old version, which didn't handle this.
RELNOTES: none
PiperOrigin-RevId: 176672081
|
|
|
|
|
|
|
|
|
| |
allowMultiple=true
Was filtering for the implicit options in SingleOptionValue, but forgot the check in RepeatableOptionValue. This is now fixed.
RELNOTES: None.
PiperOrigin-RevId: 176669853
|
|
|
|
|
|
|
| |
Part of #4128.
Change-Id: I1e043e7290912de5b246dbb8748cb2ad865ce38c
PiperOrigin-RevId: 176664440
|
|
|
|
|
|
|
|
|
| |
and #getDynamicMode to CcToolchainProvider and CppHelper.
Moving toolchain info out of CppConfiguration is required to use platform-based
toolchain resolution in the c++ rules.
PiperOrigin-RevId: 176662686
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 176659616
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 176659117
|
|
|
|
|
|
|
|
|
|
|
| |
Because CcProtoAspect.java also uses CcLibraryHelper.java to generate
linking action, but cc_proto_library doesn't have win_def_file
attribute.
Fix https://github.com/bazelbuild/bazel/issues/4126
Change-Id: I1b819c926c8025a49fea756bcaeb237824cb098e
PiperOrigin-RevId: 176653922
|
|
|
|
|
|
|
|
| |
The ResourceDependencies constructor takes in two NestedSet<Artifact> objects,
and I was putting them in the wrong order.
RELNOTES: none
PiperOrigin-RevId: 176648259
|
|
|
|
| |
PiperOrigin-RevId: 176647103
|
|
|
|
|
|
|
|
|
| |
So we actually test for override also from skylark repositories.
Fixes #3908.
Change-Id: I7650a17834a6915a73c89df46989f72aa2f56920
PiperOrigin-RevId: 176645218
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 176643685
|
|
|
|
|
|
|
| |
--experimental_enable_jvm_configuration_make_variables is not in effect.
RELNOTES: None.
PiperOrigin-RevId: 176641110
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 176635888
|