| Commit message (Collapse) | Author | Age |
|
|
|
| |
PiperOrigin-RevId: 186314781
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the skylark implementation of http_archive provides all
the features available in the native http_archive and a few
more (patching), there is no need to have to rule implementations
doing the same thing. Hence deprecate the native one as part
of our plan of moving more functionality to skylark.
RELNOTES: The native http_archive rule is deprecated. Use the
Skylark version available via load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
instead.
Change-Id: I107c2f25f5a37c67f56b4362e7c9d9ade8428c16
PiperOrigin-RevId: 186314624
|
|
|
|
|
|
|
|
|
|
| |
Add a test demonstrating how a repository can provide a rule with
an implicit dependency on a target in its own repository in a way
that works both, locally and remotely without the need to know
the name of the repository the rule resides in.
Change-Id: I2446be1ba16a382576800f8141da17331e64f8b1
PiperOrigin-RevId: 186314462
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/3904ac33a983fd8faebba1b52bcac5a3ff942029 (https://github.com/bazelbuild/bazel/commit/3904ac33a983fd8faebba1b52bcac5a3ff942029). Fix #4625 by running the test process in a sub-shell.
Apparently, nested background processes interfere with SIGINT handling in bash. I don't 100% understand why and how, but I do have a small bash script that demonstrates the problem: script A that spawns a background process, sends it a SIGINT, and verifies it was received. The script works, *unless* run in the background by a process B; this extra layer of backgrounding cause process A's logic to stop working. See experimental/users/olaola/shell/ for examples. See also https://stackoverflow.com/questions/48847722/nested-background-processes-and-sigint-handling
*** Original change description ***
Fixing test-setup.sh occasionally missing stdout/stderr, on systems where "tail --pid" is supported.
The solutions aren't mine, the new test was taken from Ola's unknown commit and the way to avoid race condition courtesy of sethkoehler@
Mitigates #4608 for compatible Linux systems.
TESTED=presubmits, manual shell tests on new bazel
RELNOTES: None
PiperOrigin-RevId: 186312008
|
|
|
|
| |
PiperOrigin-RevId: 186309181
|
|
|
|
|
|
| |
Closes #4646.
PiperOrigin-RevId: 186301842
|
|
|
|
| |
PiperOrigin-RevId: 186298405
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186297559
|
|
|
|
|
|
|
|
|
| |
Remove the static kAsciiPropertyBits data from
strings.cc and replace its only reference with
simpler code.
Change-Id: I95fb12b7d4bca4589ae64603b63019ee6e12bfc2
PiperOrigin-RevId: 186295165
|
|
|
|
|
|
|
|
|
|
|
| |
This will make protoc see as direct dependencies the .proto files that were included using the proto_source_root flag.
Until now, Bazel passed to protoc the direct dependencies of a target as the path relative to the WORKSPACE, which made it fail when a shorter path, relative to the package was used.
Progress on #4544.
RELNOTES: None.
PiperOrigin-RevId: 186294997
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have two places in internal code that require an ActionInput for an embedded
tool. The embedded tool is currently not declared as an input to the
corresponding actions, which in turn causes the remote execution to stat the
file directly through SingleBuildFileCache. I'm working on removing
SingleBuildFileCache, so this needs to be solved. This is the quick-and-dirty
fix. A more principled fix might be to check in the relevant tools instead of
embedding them into Bazel, but it's also significantly more work.
PiperOrigin-RevId: 186292203
|
|
|
|
|
|
|
|
| |
So far, nobody uses it, but I want to start using this field soon.
TESTED=unit test
RELNOTES: None
PiperOrigin-RevId: 186290375
|
|
|
|
|
|
|
|
|
| |
- Make sure that we correctly resolve symlinks starting with ./ and ../. This
is currently failing, although it's working at head.
From my reading, https://github.com/bazelbuild/bazel/commit/a729b9b4c3d7844a7d44934bf3365f92633c0a60 changes PathFragment.getRelative to always
normalize the return value, which it wasn't doing before.
PiperOrigin-RevId: 186289431
|
|
|
|
|
|
|
|
|
|
|
| |
...to ease transition from the native http_archive rule. In this way,
switching from the native http_archive rule to the skylark one literally
is only adding
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
Change-Id: I0d3a16ad9ab046b975ea64c97dd201e7a9d70a6a
PiperOrigin-RevId: 186285020
|
|
|
|
|
|
|
|
|
|
| |
CcToolchainProvider
As --fdo_optimize can point to a label, the path to the fdo profile can not be reliably determined in CppConfiguration.
In order to enable the fdo features (which depend on the path to the fdo profile), the logic from CppConfiguration.configurationEnabledFeatures() has been moved to CcCommon.configureFeatures(). The latter method has access to the fdo profile path through CcToolchainProvider.
RELNOTES: None.
PiperOrigin-RevId: 186278311
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186272858
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a series of tests verifying the assumptions about execroot layout
a user or rule author may rely on. This serves a double purpose: one
the one hand, we verify that these legitimate assumptions stay stable,
on the other hand, we document what assumptions may be made with the
implicit understanding that anything not asserted may change in the
future without warning.
This patch brings the first set of legitimate assumptions, those about
path that may unconditionally be used.
- Each target may refer to true source files in its own repository
via paths relative to its repository root.
- A library can be #inlcude'd via path relative to the root of the
repository it resides in.
In a follow-up patch, the legitimate assumptions about the portability
of paths obtained from Skylark will be documented.
Change-Id: I6d91fa4e6e3e2e8040a778fe07425bdd8532b94b
PiperOrigin-RevId: 186272067
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the runfiles library tests so adding the
upcoming C++ runfiles library's tests will be
easy.
See https://github.com/bazelbuild/bazel/issues/4460
Change-Id: Ib52a0ae1f20cc870fa1d45a15644ae1666600be2
PiperOrigin-RevId: 186268961
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 186220581
|
|
|
|
|
|
|
| |
Progress on #4544.
RELNOTES: None.
PiperOrigin-RevId: 186217057
|
|
|
|
| |
PiperOrigin-RevId: 186211672
|
|
|
|
|
|
|
|
|
| |
Expose AndroidNativeLibsInfo constructor to Skylark.
Marked as undocumented, since this provider will we replaced with a provider
implemented in Skylark once all rules are migrated.
RELNOTES: None
PiperOrigin-RevId: 186072410
|
|
|
|
|
|
| |
RELNOTES[NEW]: New Android device test rule: android_instrumentation_test.
PiperOrigin-RevId: 186067215
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186067158
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Unclassified general breakages in tests. Rolling back for further investigation.
*** Original change description ***
Normalized the serialization proto to save space and allow greater versatility in storage.
RELNOTES: None
PiperOrigin-RevId: 186057879
|
|
|
|
|
|
|
|
|
|
|
| |
DeviceBrokerInfo to AndroidDeviceBrokerInfo.
Expose AndroidDeviceBrokerInfo and AndroidDex2OatInfo constructor to Skylark.
Mark both as undocumented, since this provider will we replaced with providers
implemented in Skylark once all rules are migrated.
RELNOTES: None
PiperOrigin-RevId: 186049807
|
|
|
|
|
|
|
|
|
| |
provider keys.
This change only affects printing a rule target directly -- it intentionally does not affect the behavior of str(target), as we want to avoid skylark code being able to parse potentially-private provider keys.
RELNOTES: In skylark, print(target) now shows the provider keys of a target, as debug information.
PiperOrigin-RevId: 186046226
|
|
|
|
|
| |
RELNOTES:n/a.
PiperOrigin-RevId: 186043433
|
|
|
|
|
|
|
| |
versatility in storage.
RELNOTES: None
PiperOrigin-RevId: 186036607
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186036592
|
|
|
|
|
|
| |
package.
PiperOrigin-RevId: 186029598
|
|
|
|
|
|
| |
if we have them instead of re-computing them each time on a skyframe restart.
PiperOrigin-RevId: 186017079
|
|
|
|
| |
PiperOrigin-RevId: 186007056
|
|
|
|
|
|
|
| |
Armeabi is an old Android cpu and c-mobile-team is deprecating it (in line with the main NDK). The new default needs to should be armv7 (and can be fixed in blaze after this Cl).
RELNOTES: Updated default android_cpu value to armeabi-v7a
PiperOrigin-RevId: 186000507
|
|
|
|
|
|
|
| |
Fixes #4544.
RELNOTES: Add "proto_source_root" flag to proto_library.
PiperOrigin-RevId: 185997723
|
|
|
|
|
|
| |
aliasconfiguredtargets that are actually ruleconfiguredtargets.
PiperOrigin-RevId: 185996274
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
There's already a --test_tmpdir flag, and Java tests don't pick up this new one. More info: https://github.com/bazelbuild/bazel/issues/4621#issuecomment-366217321
*** Original change description ***
tmpdir,local-exec: implement --local_tmp_root
Add new flag called `--local_tmp_root`, which (if
specified) tells Bazel what temp directory should
locally executed actions use.
Fixes https://github.com/bazelbuild/bazel/issues/4621
Related to https://github.com/bazelbuild/bazel/issues/3215
RELNOTES[NEW]: The new "--local_tmp_root=<path>" flag allows specifying the temp directory for locally executed actions.
Change-Id: Ice69a5e63d0bf4d3b5c9ef4dbdd1ed1c5025f85e
PiperOrigin-RevId: 185982705
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 185978755
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling back after having come up with a more principled solution in b/73047818 that will add a more generic attribute called additional_linker_inputs so that users can depend on any file of any type and reference it from linkopts.
*** Original change description ***
C++: Allows adding linkopts through file.
The file can be generated during execution by a different rule.
RELNOTES:none
PiperOrigin-RevId: 185977745
|
|
|
|
|
|
| |
RELNOTES:
Removed flags `--incompatible_checked_arithmetic`, `--incompatible_dict_literal_has_no_duplicates`, `--incompatible_disallow_keyword_only_args`, and ` --incompatible_comprehension_variables_do_not_leak`.
PiperOrigin-RevId: 185977740
|
|
|
|
| |
PiperOrigin-RevId: 185959149
|
|
|
|
|
|
| |
RegisteredExecutionPlatformsFunction.
PiperOrigin-RevId: 185947540
|
|
|
|
| |
PiperOrigin-RevId: 185927949
|
|
|
|
|
|
| |
The resource busybox expects each library manifest in order to generate the resource.jar
PiperOrigin-RevId: 185917147
|
|
|
|
|
|
| |
Fixes #3911
PiperOrigin-RevId: 185912197
|
|
|
|
| |
PiperOrigin-RevId: 185908325
|
|
|
|
| |
PiperOrigin-RevId: 185906605
|
|
|
|
|
|
|
|
|
| |
lib.analysis.actions -> lib.actions.
These are fundamental types that want to sit alongside types like Spawn.
RELNOTES: None
PiperOrigin-RevId: 185887971
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We run ResourceCompiler#visitFile once per resource file being compiled. If the
file has qualifiers aapt2 doesn't support (es-419 or sr-latn), we copy the file
into a new directory with corrected qualifiers. However, Files.createDirectory
fails if the folder already exists (because, for example, we just copied
another file).
Instead, use Files.createDirectories, which allows the folder to already exist.
RELNOTES: none
PiperOrigin-RevId: 185887192
|
|
|
|
| |
PiperOrigin-RevId: 185883201
|