| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 182389876
|
|
|
|
|
|
|
|
| |
SkylarkAspectLoadingKey.
Also add a @VisibleForSerialization annotation to @AutoCodec, since we're going to need to increase serialization visibility a lot here, and clean up some unnecessary modifiers.
PiperOrigin-RevId: 182389162
|
|
|
|
|
|
|
|
|
|
|
|
| |
container, ConfiguredTargetAndTarget, that can be used to access Targets, and deprecate ConfiguredTarget#getTarget. ConfiguredAndTargetObjects are intended to be limited in scope, not being persisted to Skyframe.
The eventual plan is to remove the target field from ConfiguredTarget.
This CL is mostly straightforward, except for dealing with AliasConfiguredTargets, which cause some complications.
A significant cleanup is still needed before #getTarget can be removed, but I don't see any impossible blockers. We will may still need to store a Target-like object in ConfiguredTarget (that has the RuleClass, or at least a string representation of it, for instance), but that will let us avoid storing a full Target together with its associated Package.
PiperOrigin-RevId: 182371566
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before commit f47291ee3 [1],
FileSystemConcurrencyTest was part of
"foundations_test" which was marked as flaky.
After the change, this test is part of "vfs_test"
which is not marked as flaky.
Looking at the test code [2] it's clearly flaky,
so the modification is appropriate.
[1]
https://github.com/bazelbuild/bazel/commit/f47291ee35e01ebd58951e81b3e65be3243a5f13
[2] https://github.com/bazelbuild/bazel/blob/6f502ac12180973f4646c95d95e1516082b3c71c/src/test/java/com/google/devtools/build/lib/vfs/FileSystemConcurrencyTest.java#L46
RELNOTES: none
PiperOrigin-RevId: 182352485
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added tests for checking JavaExportsProvider state.
Refactored logic working with collection in favor of using Streams to improve readability.
All other providers will be implemented in next CLs.
previous CL with JavaCompilationArgsProvider implementation is https://github.com/bazelbuild/bazel/commit/32dff21d00ad7d1bdf50e8761d675a6e7e002de9,
JavaSourceJarsProvider : https://github.com/bazelbuild/bazel/commit/5bd53cb609480ca896ca2d011f415b424c63ce63
RELNOTES:none
PiperOrigin-RevId: 182342490
|
|
|
|
| |
Change-Id: I05fa85967317c4581081adfc620e24a7c6322669
|
|
|
|
|
|
|
|
| |
returned by the previous calls of the same method. Keep each such address in a
separate scope.
RELNOTES: Crash in OutputJar::Close has been fixed
PiperOrigin-RevId: 182286718
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 182272900
|
|
|
|
|
|
|
|
|
|
|
| |
This class represents a root (such as a package path or an output root) used for file lookups and artifacts. It is meant to be as opaque as possible in order to hide the user's environment from sky keys and sky functions.
Roots are used by RootedPaths and ArtifactRoots.
This CL attempts to make the minimum number of modifications necessary to change RootedPath and ArtifactRoot to use these fields. Deprecated methods and invasive accessors are permitted to minimise the risk of any observable changes.
RELNOTES: None
PiperOrigin-RevId: 182271759
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 182271042
|
|
|
|
|
|
|
|
|
| |
We've notified the top classic users by email that classic mode is deprecated.
As we are no longer actively supporting classic mode, we'd like users to move
over to skylark.
RELNOTES: None.
PiperOrigin-RevId: 182268733
|
|
|
|
|
|
|
|
|
| |
The bug also permitted For statements in BUILD files so long as they were contained within an If statement (i.e. not at the top level).
Also add minor guidance to error messages.
RELNOTES: None
PiperOrigin-RevId: 182236172
|
|
|
|
|
|
| |
iteration order so we should be okay.
PiperOrigin-RevId: 182235068
|
|
|
|
|
|
|
|
|
|
| |
Add a test verifying that changes to the patch file trigger a
a rebuild of the external repository.
Ensures soundness of the fix for Issue #3395.
Change-Id: Ida3823b7cddbe3bb54f0f0e24074e3854055f6e1
PiperOrigin-RevId: 182226112
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 182223038
|
|
|
|
|
|
|
|
|
|
|
|
| |
The http_archive command from @bazel_tools can add a BUILD file to an
external repository. Add a test ensuring that changes to that file, in
particular the addition of a previously missing file, are tracked
properly.
Provides a workaround for #3637.
Change-Id: Ibd6a3336834686a13eaa1f9ce7d4c6223410b222
PiperOrigin-RevId: 182221653
|
|
|
|
|
|
|
| |
This has the effect of documenting exposed struct fields on these providers.
RELNOTES: None.
PiperOrigin-RevId: 182221042
|
|
|
|
|
|
|
| |
Fixes #4443.
Change-Id: I8a30823eff87457e3ef2568efbe667f29c644ed4
PiperOrigin-RevId: 182208767
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 182145172
|
|
|
|
|
|
| |
* Moves SingletonCodec to third_party.
PiperOrigin-RevId: 182143153
|
|
|
|
| |
PiperOrigin-RevId: 182130131
|
|
|
|
|
|
|
| |
glob tasks.
RELNOTES: None
PiperOrigin-RevId: 182125500
|
|
|
|
|
|
| |
appears to be flaky in connecting to the JVM.
PiperOrigin-RevId: 182118581
|
|
|
|
|
|
|
|
| |
javac does not allow both -source and --release to be set, which makes it
difficult to migrate to --release when javacopts are combined from
multiple sources.
PiperOrigin-RevId: 182113897
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 182110722
|
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/4439.
Empty assets are handled by writing out an empty file named "assets/empty_asset_generated_by_bazel~", which will silently be ignored by AAPT.
RELNOTES: aar_import now supports assets.
PiperOrigin-RevId: 182110400
|
|
|
|
|
|
| |
We stopped treating empty files specially in the execution phase after unknown commit. So this code is mostly if not entirely orphaned. The only scenario in which this would lead to a semantic difference that I can think of is if the user is running with --nouse_action_cache and a running Bazel server, and they have an action they want to re-run when an empty input file changes, which isn't something we need to be concerned about.
PiperOrigin-RevId: 182109952
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 182100169
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 182099868
|
|
|
|
| |
PiperOrigin-RevId: 182099803
|
|
|
|
|
|
| |
Post to the Skyframe Environment instead.
PiperOrigin-RevId: 182096559
|
|
|
|
|
|
|
|
|
| |
dexbuilder action by default).
Binaries can opt in by adding "incremental_dexing = 1" attribute.
RELNOTES: Proguarded Android binaries can be built with incremental dexing.
PiperOrigin-RevId: 182092699
|
|
|
|
| |
PiperOrigin-RevId: 182087153
|
|
|
|
|
|
|
|
|
|
|
|
| |
test_android_ndk_repository_wrong_path presumes the wrong ndk path
'some_dir' to not exist. This test will work initially, but break if run
incrementally, because of the some_dir remaining in the TEST_SRCDIR (the
runfiles root for this test). Switching this over to use the ephemeral
TEST_TMPDIR instead.
Closes #4465.
PiperOrigin-RevId: 182083666
|
|
|
|
|
|
| |
This is slightly more descriptive, and we will potentially want to use the name Root for a broader concept shared between ArtifactRoot and RootedPath.
PiperOrigin-RevId: 182082367
|
|
|
|
|
|
|
| |
If two values compared equal (e.g., MethodLibrary#bool and SkylarkAttr#bool), we were dropping one of them in favor of the other.
RELNOTES: None
PiperOrigin-RevId: 182057611
|
|
|
|
|
|
|
| |
SerializationCodeGenerator, which is a generalization of Marshaller that
supports primitive and array values.
PiperOrigin-RevId: 182053617
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 182051418
|
|
|
|
|
| |
Change-Id: I5fa8412fe0673b71a6e17adb39be0a208ee54f63
PiperOrigin-RevId: 182048035
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 182044727
|
|
|
|
|
|
|
| |
can be attached to C++ compile actions without tickling the bug that makes Blaze crash when extra actions are attached to shared actions that do input discovery.
RELNOTES: None.
PiperOrigin-RevId: 182044169
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Bazel CI (https://ci.bazel.build/job/bazel-tests/1722/)
*** Original change description ***
Report unsuccessful error code if bazel fetch fails in "keep going" mode.
Fixes #3234.
PiperOrigin-RevId: 182042503
|
|
|
|
|
|
|
|
|
|
|
| |
Support applying a sequence of commands to an http_archive,
after the patch files are applied. In this way, tasks like
shebang-fixes can easily be added.
Fixes #3395.
Change-Id: Ifdad584a852efd425c436d57ef71a0d681488629
PiperOrigin-RevId: 182037265
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 182033773
|
|
|
|
|
|
|
| |
Fixes #3234.
Change-Id: I1bfbe856d35b98995f5a0684fe47c7566b8dd093
PiperOrigin-RevId: 182029085
|
|
|
|
|
|
|
|
|
|
| |
Added tests for checking JavaSourceJarsProvider state.
All other providers will be implemented in next CLs.
previous CL with JavaCompilationArgsProvider implementation is https://github.com/bazelbuild/bazel/commit/32dff21d00ad7d1bdf50e8761d675a6e7e002de9
RELNOTES:none
PiperOrigin-RevId: 182028182
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also make most targets in `//src/tools/runfiles`
private. The user should depend on
`@bazel_tools//tools/runfiles:$LANG-runfiles`
instead.
See https://github.com/bazelbuild/bazel/issues/4460
RELNOTES[NEW]: java,runfiles: You can now depend on `@bazel_tools//tools/runfiles:java-runfiles` to get a platform-independent runfiles library for Java. See JavaDoc of https://github.com/bazelbuild/bazel/blob/master/src/tools/runfiles/java/com/google/devtools/build/runfiles/Runfiles.java for usage information.
Change-Id: Iba9113453222ae74ce42a324272711f613104891
PiperOrigin-RevId: 182022851
|
|
|
|
|
|
|
|
| |
This method violates the invariant that derived roots are never equal to the exec root. Only source roots can be equal to the exec root.
Note that this method was only used in tests, so this CL should be completely safe as long as its tests pass.
PiperOrigin-RevId: 181998483
|
|
|
|
|
|
| |
In this case, the invariant violated is creating derived roots at the exec root.
PiperOrigin-RevId: 181994080
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 181990193
|