aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Blaze/bazel modifications to command line flags used when dead-stripping.Gravatar Googler2017-02-13
| | | | | | | | | | | | | | - Passing -g to the compiler is no longer required. - Instead of detecting test rules, detect "-bundle" in the command line. - In that case, pass "-x", not "-S", to strip. - Do not inhibit dead-code stripping for tests. RELNOTES: Modifications to command line flags used for dead-stripping. -- PiperOrigin-RevId: 147171780 MOS_MIGRATED_REVID=147171780
* Install support for checking for 'one version' correctness of java_binaryGravatar Googler2017-02-10
| | | | | | | | | | | | | | | | rules: If the collection of jars for a java_binary contain more than one instance of the same class, one of them will be arbitrarily loaded at runtime. This is problematic if the instances of the class are not identical, as methods or fields from one class version might be missing in the other, leading to runtime failures when methods are missing. This change adds an experimental flag to enable one version enforcement. The actual enforcement tool will come later. -- PiperOrigin-RevId: 147166361 MOS_MIGRATED_REVID=147166361
* Switch from protobuf_clib to protobuf, and protobuf-util to protobuf_java_util.Gravatar Carmi Grushko2017-02-10
| | | | | | | | The latter are the names in the upstream protobuf repo. -- PiperOrigin-RevId: 147163206 MOS_MIGRATED_REVID=147163206
* Introduce CppCompileActionTemplate, which expands into a list of ↵Gravatar Rumou Duan2017-02-10
| | | | | | | | CppCompileActions that to be executed at execution time. -- PiperOrigin-RevId: 147163077 MOS_MIGRATED_REVID=147163077
* Apply --symlink_prefix to the output and exec root symlinks.Gravatar Luis Fernando Pino Duque2017-02-10
| | | | | | | | | | | | | | | | | | | Turns out --symlink_prefix is not applied to the bazel-{out,workspace} unlike bazel-{bin,genfiles,testlogs} thus breaking the semantics of --symlink_prefix. This CL fixes the problem by using the symlink prefix instead of the product name when building the output and exec root symlinks. The bazel-out symlink is still created for backwards compatiblity but will be removed eventually. RELNOTES[INC]: Using --symlink_prefix is now applied to the output symlink (e.g. bazel-out) and the exec root symlink (e.g. bazel-workspace). -- PiperOrigin-RevId: 147161547 MOS_MIGRATED_REVID=147161547
* Move the JUnit runner tests to the same location as the Internal Repo.Gravatar Kush Chakraborty2017-02-10
| | | | | | -- PiperOrigin-RevId: 147159416 MOS_MIGRATED_REVID=147159416
* Fixed java_stub_template substitution: %runfiles_manifest_only% was not ↵Gravatar Yun Peng2017-02-10
| | | | | | | | | | substituted when runfiles is enabled. This caused wrong rlocation function being defined on Linux and Mac. -- PiperOrigin-RevId: 147154028 MOS_MIGRATED_REVID=147154028
* BEP: Provide more useful data in TestResult events Gravatar Klaus Aehlig2017-02-10
| | | | | | | | | | | | | | | | | | | | | For individual test actions, more useful data can be provided than just the success status. Do so. Also, to keep each log reported only once, send a new TestAttempt event for the final test attempt, but don't have the TestResult (which contains to union of all test files) an instance of the BuildEvent. As we now report test results in a separate object, drop the test data and directly pass in the files created. In this way, we also get all the moved files reported correctly in the individual attempts. -- Change-Id: Ic04b7bad4f92a381bd4d1b4ec91f743b89f81f84 Reviewed-on: https://cr.bazel.build/8694 PiperOrigin-RevId: 147149025 MOS_MIGRATED_REVID=147149025
* Standalone Skylark binary: now accepts a file as argumentGravatar Laurent Le Brun2017-02-10
| | | | | | | | | Usage: Skylark file.sky -- PiperOrigin-RevId: 147148097 MOS_MIGRATED_REVID=147148097
* Rollback of commit 49d97f9bb4dd04ef62198ded7b53b2a8f8c603db.Gravatar Luis Fernando Pino Duque2017-02-10
| | | | | | | | *** Reason for rollback *** -- PiperOrigin-RevId: 147146321 MOS_MIGRATED_REVID=147146321
* Fix java_stub_template.txt on Windows Gravatar Yun Peng2017-02-10
| | | | | | | | | | | | | To define a associative arrary in bash, we need `declare -A` instead of `declare -a`, but `declare -A` is not supported on macOS, so fall back to the old implementation of rlocation on macOS. Related issue: #2426 -- Change-Id: Ifd42eea0faa5cdbe73b26c9b52437ef6c771f71c Reviewed-on: https://cr.bazel.build/8790 PiperOrigin-RevId: 147144803 MOS_MIGRATED_REVID=147144803
* Adds arguments --version_between --time_between --versions to the benchmark ↵Gravatar Yue Gan2017-02-10
| | | | | | | | as version filters. -- PiperOrigin-RevId: 147141691 MOS_MIGRATED_REVID=147141691
* Update docs about built-in attributes of rules.Gravatar Googler2017-02-10
| | | | | | | | Historically built-in attributes were possible to override, but it's not the case anymore. This feature caused issues. -- PiperOrigin-RevId: 147138115 MOS_MIGRATED_REVID=147138115
* Fix building python zip when middleman runfile is used Gravatar Yun Peng2017-02-10
| | | | | | | | | | | | | | When adding a binary A into data attribute of a py_bianry B, a middleman runfile is used to ensure B's runfiles includes A's runfiles. But this middlman runfile is not really created, so it should not be zipped. Fixed: https://github.com/bazelbuild/bazel/issues/2088 -- Change-Id: Id1a99c66cd8027e945883cf4367f003bccd73473 Reviewed-on: https://cr.bazel.build/8772 PiperOrigin-RevId: 147137055 MOS_MIGRATED_REVID=147137055
* Bazel client, Windows, tests: `rm -rf TEST_TMPDIR`Gravatar Laszlo Csomor2017-02-10
| | | | | | | | | | | | Add test helpers to recursively delete the TEST_TMPDIR in the TearDown method of tests, to ensure each test sees a fresh temp directory. Also add tests for these test helpers. -- PiperOrigin-RevId: 147135561 MOS_MIGRATED_REVID=147135561
* Tighten a precondition check during action execution.Gravatar Lukacs Berki2017-02-10
| | | | | | | | Input discovery is handled somewhere else, so the same Action instance should never be put twice into buildActionMap . -- PiperOrigin-RevId: 147132869 MOS_MIGRATED_REVID=147132869
* Change CppCompileAction to store execution info as a mapGravatar Ulf Adams2017-02-10
| | | | | | | | Update the builder to allow setting arbitrary execution info. -- PiperOrigin-RevId: 147130533 MOS_MIGRATED_REVID=147130533
* Open source java 8 desugarer.Gravatar Adam Michael2017-02-10
| | | | | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/2222. RELNOTES: Support for Java 8 lambdas, method references, type annotations and repeated annotations in Android builds with --experimental_desugar_for_android. -- PiperOrigin-RevId: 147109786 MOS_MIGRATED_REVID=147109786
* --Gravatar Carmi Grushko2017-02-10
| | | | | PiperOrigin-RevId: 147105048 MOS_MIGRATED_REVID=147105048
* Remove unused dep from android_integration_test and clarify comment about ↵Gravatar Adam Michael2017-02-10
| | | | | | | | this mess that we have gotten ourselves into. -- PiperOrigin-RevId: 147097283 MOS_MIGRATED_REVID=147097283
* Emphasize that java_xxx_proto_library.strict_deps should not be used for new ↵Gravatar Carmi Grushko2017-02-10
| | | | | | | | code. -- PiperOrigin-RevId: 147096200 MOS_MIGRATED_REVID=147096200
* Use AliasProvider for DexArchiveAspect to "see through" alias targets until ↵Gravatar Googler2017-02-10
| | | | | | | | [] can be fixed. -- PiperOrigin-RevId: 147094979 MOS_MIGRATED_REVID=147094979
* Make aar_import fail fast if no android_sdk is set up.Gravatar Adam Michael2017-02-10
| | | | | | | | https://github.com/bazelbuild/bazel/issues/2500 -- PiperOrigin-RevId: 147089163 MOS_MIGRATED_REVID=147089163
* --Gravatar Carmi Grushko2017-02-10
| | | | | PiperOrigin-RevId: 147080281 MOS_MIGRATED_REVID=147080281
* Use //third_party/protobuf:protobuf_java instead of ↵Gravatar Carmi Grushko2017-02-09
| | | | | | | | | | | | //third_party/protobuf:protobuf to refer to the Java proto runtime. (second attempt) This is the name in the upstream protobuf repo. -- PiperOrigin-RevId: 147057949 MOS_MIGRATED_REVID=147057949
* Search for Test classes within the classpath used by the current ↵Gravatar Kush Chakraborty2017-02-09
| | | | | | | | classloader, instead of the system classpath. -- PiperOrigin-RevId: 147045814 MOS_MIGRATED_REVID=147045814
* Using os.pathsep in python stub template.txtGravatar Yun Peng2017-02-09
| | | | | | | | See https://github.com/bazelbuild/bazel/commit/7093b97ec3f332016822ed154e81bd86bc7ca645#commitcomment-20814099 -- PiperOrigin-RevId: 147043323 MOS_MIGRATED_REVID=147043323
* Generated files directory is passed to dependers as a user header search ↵Gravatar Cal Peyser2017-02-09
| | | | | | | | path. In the process, rename and replace the incorrectly named ObjcCommon.Builder#addUserHeaderSearchPaths -- PiperOrigin-RevId: 147038434 MOS_MIGRATED_REVID=147038434
* Add bootstrapping test to CI Gravatar Damien Martin-Guillerez2017-02-09
| | | | | | | | | | | Put it only as JDK-8, the generation of the distribution artifact is incorrect with JAVA_VERSION=1.8 -- Change-Id: I87a5f8ec4b12d3aa22a3360fcb9d488757e79461 Reviewed-on: https://cr.bazel.build/8575 PiperOrigin-RevId: 147037944 MOS_MIGRATED_REVID=147037944
* Test output directory presence for skylark repositories without a FileValue Gravatar Damien Martin-Guillerez2017-02-09
| | | | | | | | | | | | Using a FileValue depenendency was not needed and create over-invalidation of the repository. On a cold server, this duplicate the call to the repository function, including potential slow operation like downloads. -- Change-Id: Ie09fa45b2d77f8986f4a4e95d06e8133481aff50 Reviewed-on: https://cr.bazel.build/8138 PiperOrigin-RevId: 147032408 MOS_MIGRATED_REVID=147032408
* Java template windows performanceGravatar Yun Peng2017-02-09
| | | | | | | | | | Address issue #2426 Closes #2427. -- PiperOrigin-RevId: 147031246 MOS_MIGRATED_REVID=147031246
* Remove the first argument of TestStrategy.getArgs.Gravatar Ulf Adams2017-02-09
| | | | | | | | | All callers were performing identical steps before calling getArgs - move the functionality into getArgs instead. -- PiperOrigin-RevId: 147028753 MOS_MIGRATED_REVID=147028753
* Replace PackageProvider with TargetProvider where possibleGravatar Ulf Adams2017-02-09
| | | | | | | | | | I was trying to simplify GenQuery, and found this during an audit of the code; it's not sufficient to make any larger changes, but it may help eventuall. -- PiperOrigin-RevId: 147023626 MOS_MIGRATED_REVID=147023626
* Remove dead code - unused method in PackageManager interfaceGravatar Ulf Adams2017-02-09
| | | | | | -- PiperOrigin-RevId: 147018240 MOS_MIGRATED_REVID=147018240
* Fix int*list binary operator.Gravatar Laurent Le Brun2017-02-09
| | | | | | | | [2] * 3 should return [2, 2, 2] and not [2, 2, 2, 2]. -- PiperOrigin-RevId: 147017581 MOS_MIGRATED_REVID=147017581
* Bazel client, Windows: use more of AutoHandleGravatar Laszlo Csomor2017-02-09
| | | | | | -- PiperOrigin-RevId: 147008328 MOS_MIGRATED_REVID=147008328
* Add "CLEAN_UP" as a reason for retrieving a node.Gravatar Shreya Bhattarai2017-02-09
| | | | | | -- PiperOrigin-RevId: 146982656 MOS_MIGRATED_REVID=146982656
* Pass 'main_class' attribute value through in the IntelliJ aspect.Gravatar Googler2017-02-09
| | | | | | | | Then use it in the blaze plugin's main class run configuration producer. -- PiperOrigin-RevId: 146980092 MOS_MIGRATED_REVID=146980092
* make DexArchiveAspect propagate through alias targetsGravatar Googler2017-02-09
| | | | | | | | RELNOTES: n/a -- PiperOrigin-RevId: 146968274 MOS_MIGRATED_REVID=146968274
* experimental_objc_library excludes non-.h headers, as does objc_library.Gravatar Cal Peyser2017-02-09
| | | | | | -- PiperOrigin-RevId: 146958087 MOS_MIGRATED_REVID=146958087
* Use //third_party/protobuf:protobuf_java instead of ↵Gravatar Carmi Grushko2017-02-09
| | | | | | | | | | //third_party/protobuf:protobuf to refer to the Java proto runtime. This is the name in the upstream protobuf repo. -- PiperOrigin-RevId: 146949832 MOS_MIGRATED_REVID=146949832
* Fix spelling mistake.Gravatar Nathan Harmata2017-02-09
| | | | | | -- PiperOrigin-RevId: 146949259 MOS_MIGRATED_REVID=146949259
* Rollback of commit 602a98cbebeff2ba1c2d8605a9552b2c8f5622ae.Gravatar Googler2017-02-09
| | | | | | | | | | | | | | | | *** Reason for rollback *** Rolling forward with fixes for the incremental tool. *** Original change description *** Automated [] rollback of commit d11d510c571b10787856395709f9ad945ca70bb2. *** Reason for rollback *** -- PiperOrigin-RevId: 146940409 MOS_MIGRATED_REVID=146940409
* --Gravatar Carmi Grushko2017-02-09
| | | | | PiperOrigin-RevId: 146926312 MOS_MIGRATED_REVID=146926312
* Introduce a new SkyValue that merely contains the workspace name. The ↵Gravatar Nathan Harmata2017-02-09
| | | | | | | | | | | | workspace name is needed for package loading, and so splitting out this computation into a separate skyframe node that can be change-pruned gives us better incrementality; previously we'd need to reload all packages on a WORKSPACE file change. N.B. (i) This CL doesn't solve all the other performance issues with //external in Bazel/Blaze since it's still inefficiently used for resolving labels like @foo//bar:baz. (ii) This CL doesn't address the wasteful invalidation + change pruning of all the packages. -- PiperOrigin-RevId: 146925369 MOS_MIGRATED_REVID=146925369
* Bazel client, Windows: implement SetupStdStreamsGravatar Laszlo Csomor2017-02-09
| | | | | | | | See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 146921464 MOS_MIGRATED_REVID=146921464
* Rollback of commit 6521cb22788adc2a74f6c26221dbe302dc9ccc14.Gravatar Damien Martin-Guillerez2017-02-08
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** Break JDK 7 build on ci.bazel.io Found out by downloading bazel 0.4.4 for JDK7 and `bazel test //src/test/shell/integration:stub_finds_runfiles_test --define JAVA_VERSION=1.7` This is due to JDK 7 using JavaBuilder that comes with version 0.1 of Bazel, which is not fixed for that issue. *** Original change description *** Don't add the class output dir to the classpath -- PiperOrigin-RevId: 146920718 MOS_MIGRATED_REVID=146920718
* Stop retrieving CcToolChainProvider statically from hard-coded attribute ↵Gravatar Rumou Duan2017-02-08
| | | | | | | | | | ":cc_toolchain" in RuleContext, instead take the provider from users and pass it around to where it is used. This gives J2ObjcAspect the ability to specify the C++ toolchain attribute under a different name to avoid attribute conflicts with attached rules that have already declared attribute ":cc_toolchain". -- PiperOrigin-RevId: 146920294 MOS_MIGRATED_REVID=146920294
* Make bazel test suites fail without a real test, by no longer adding an ↵Gravatar Kush Chakraborty2017-02-08
| | | | | | | | | | | | empty test in the TestSuiteBuilder. The current scenario can be bug-prone since changes to the TestSuiteBuilder code may bypass all tests, and in the absence of test failures, our tests will signal success. RELNOTES: Make it mandatory for Java test suites in bazel codebase, to contain at least one test. -- PiperOrigin-RevId: 146919833 MOS_MIGRATED_REVID=146919833
* Introduce a Skyframe function: ActionEnvironmentFunction Gravatar Damien Martin-Guillerez2017-02-08
| | | | | | | | | | | | | | | | | | ActionEnvironmentFunction returns the list of environment variable with the one overwritten by --action_env being replaced. This let other Skyframe function declares dependency to any value of the environment and being influenced by the --action_env flag. This will be used to declare dependency of remote repositories on environment variables (step 3 of https://bazel.build/designs/2016/10/18/repository-invalidation.html) -- Change-Id: I1ed3fb6f48e8e17d4d64c903fccecb6ed7596350 Reviewed-on: https://cr.bazel.build/7974 PiperOrigin-RevId: 146918603 MOS_MIGRATED_REVID=146918603