aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Allow CustomCommandLine's mapFn to expand each object into multiple items.Gravatar tomlu2018-02-01
| | | | | | This is needed to migrate JavaCompileAction away from CustomMultiArgv. PiperOrigin-RevId: 184136486
* http_archive: allow top-level BUILD files to be overriddenGravatar Klaus Aehlig2018-02-01
| | | | | | | | | ..by the `build_file` parameter, even if the external repository contains a top-level BUILD file. While there, also add a test verifying that this is also possible via the `build_file_content`. Change-Id: I1b875c147cfcd6f1c70b8efeb10c2b406eeacf6a PiperOrigin-RevId: 184134041
* Automated rollback of commit 7e6837cc1d1aa4259f5c27ba3606b277b5f6c3e9.Gravatar aehlig2018-02-01
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks on our CI Linux machines (but works on our work desktop Linux machines); apparently, even our own Linux machines are too different from each other... Fixes #4557 *** Original change description *** http_archive: verify that unicode characters are OK in tar archives Add a test verifying that http_archive can extract a tar archive containing unicode characters. While such files cannot be referred to by labels, it is still important that the archive can be extracted. Also fix that use case on Darwin, by appropriately reencoding the string, so that the Files java standard library can encode it back to what we had in the first place. Work-around for #1653, showing that http_archive from @bazel_tools can be used; however, the issue still remains for zip archives. *** PiperOrigin-RevId: 184132385
* AbstractSpawnStrategy should not crash when executing actions with a null owner.Gravatar tomlu2018-02-01
| | | | | RELNOTES: None PiperOrigin-RevId: 184127422
* Renamed android_instrumentation_test.instrumentation to ↵Gravatar jingwen2018-01-31
| | | | | | | android_instrumentation_test.test_app RELNOTES: None PiperOrigin-RevId: 184063294
* Improve safety of NestedSetFingerprintCache by detecting multiple instances ↵Gravatar tomlu2018-01-31
| | | | | | | | | | | | of the same mapFn class. This code tries to add protection against the user creating new mapFn instances per-rule. This would cause the nested set cache to be computed per-rule instead of shared across rule instances, causing memory bloat and slowdowns. Since this can only happen in native code, we can get away with detecting this and crashing blaze. I think this is a better choice than silently allowing it / falling back to slow computations. The user can override this behaviour by inheriting from CommandLineItem.CapturingMapFn, in which case the user is explicitly saying they assume responsibility for the number of instances of the mapFn the application will use. PiperOrigin-RevId: 184061642
* Cleaning up a missed reference to getTarget in ↵Gravatar mjhalupka2018-01-31
| | | | | | ConfiguredTargetQueryEnvironment. Follow up to https://github.com/bazelbuild/bazel/commit/426ab9067374bfe5af033e22153507c3f38e7221 PiperOrigin-RevId: 184049987
* Change ConfiguredAspectFactory.create signature to take in aGravatar mjhalupka2018-01-31
| | | | | | | ConfiguredTargetAndTarget instead of a ConfiguredTarget. This is to assist in deprecating ConfiguredTarget.getTarget(). PiperOrigin-RevId: 184043491
* Remove references to ConfiguredTarget.getTarget() in CompletionFunction.Gravatar mjhalupka2018-01-31
| | | | PiperOrigin-RevId: 184040834
* Remove references of ConfiguredTarget.getTarget() from ToolchainUtil.Gravatar mjhalupka2018-01-31
| | | | PiperOrigin-RevId: 184032456
* Make CcToolchainProvider structField methods resilient to null fieldsGravatar cparsons2018-01-31
| | | | | | | | structField methods must not throw an exception in all cases. Null fields were technically used for incomplete toolchain objects (such as the EMPTY_TOOLCHAIN_IS_ERROR object). RELNOTES: None. PiperOrigin-RevId: 184031908
* Add DeviceBrokerInfo to Skylark top level.Gravatar ajmichael2018-01-31
| | | | | | | This allows writing Android testing rules that consume DeviceBrokerInfo. RELNOTES: None PiperOrigin-RevId: 184026202
* Add memory-efficient map for storing nested set -> digest.Gravatar tomlu2018-01-31
| | | | | | | | | Instead of using ConcurrentHashMap, we use a dead-simple open addressed hash hable with a giant byte array with 16-byte slots. We then read or write fingerprints straight into and out of the array, obviating the need to generate intermediate garbage. Locking mechanism is a read-write lock. This should be faster than full synchronisation for read-heavy loads. RELNOTES: None PiperOrigin-RevId: 184019301
* Add neverlink support to java_common.compile.Gravatar elenairina2018-01-31
| | | | | | | Fixes #3735. RELNOTES: java_common.compile supports neverlink PiperOrigin-RevId: 184017410
* Fix string_list_dict values to be skylark lists in all casesGravatar cparsons2018-01-31
| | | | | RELNOTES: None. PiperOrigin-RevId: 184016150
* Generalize QueryExpressionVisitor's visitation by permitting an arbitrary ↵Gravatar nharmata2018-01-31
| | | | | | | "context" object to be passed along. Also make some query internals public, for use in fancy QueryExpressionVisitor implementations. RELNOTES: None PiperOrigin-RevId: 184014063
* Order the input-output map keys before processing its elements. This fixes ↵Gravatar kaipi2018-01-31
| | | | | | non-determinism in how the protos get bundled into the BundledProtos_X archives. PiperOrigin-RevId: 184009755
* Remove unnecessary debugging code.Gravatar philwo2018-01-31
| | | | PiperOrigin-RevId: 183995676
* Move BazelRuleClassProvider.LIPO_DATA_TRANSITION to its own class.Gravatar lpino2018-01-31
| | | | PiperOrigin-RevId: 183990860
* http_archive: verify that unicode characters are OK in tar archivesGravatar Klaus Aehlig2018-01-31
| | | | | | | | | | | | | | | Add a test verifying that http_archive can extract a tar archive containing unicode characters. While such files cannot be referred to by labels, it is still important that the archive can be extracted. Also fix that use case on Darwin, by appropriately reencoding the string, so that the Files java standard library can encode it back to what we had in the first place. Work-around for #1653, showing that http_archive from @bazel_tools can be used; however, the issue still remains for zip archives. Change-Id: If944203bf618c21705af676347d8591ab015d559 PiperOrigin-RevId: 183987726
* Fix py_tests.py with Python3Gravatar pcloudy2018-01-31
| | | | | RELNOTES: None PiperOrigin-RevId: 183978326
* Automated rollback of commit db65f80cc83d562c0f63c34ce9d9a58fad0e3b0c.Gravatar pcloudy2018-01-31
| | | | | | | | | | | | | | | *** Reason for rollback *** This CL is breaking src/test/shell/bazel/srcs_test https://ci.bazel.build/blue/organizations/jenkins/bazel-tests/detail/bazel-tests/1884/tests Fix https://github.com/bazelbuild/bazel/issues/4548 *** Original change description *** Verbatim, initial checkin of Kryo files for @AutoCodec Runtime. PiperOrigin-RevId: 183977098
* Verbatim, initial checkin of Kryo files for @AutoCodec Runtime.Gravatar shahan2018-01-30
| | | | PiperOrigin-RevId: 183904648
* Don't use null EvaluationProgressReceiver in MemoizingEvaluator (it was only ↵Gravatar janakr2018-01-30
| | | | | | null in AbstractPackageLoader and tests). PiperOrigin-RevId: 183896826
* Replace ConfiguredTarget.getTarget() with a call to the environment's packageGravatar mjhalupka2018-01-30
| | | | | | manager. PiperOrigin-RevId: 183889147
* Adds CodecScanner to help automate building a codec registry.Gravatar shahan2018-01-30
| | | | | | Scan takes 1-2s. PiperOrigin-RevId: 183881368
* Handle the case where platformConfiguration isn't present.Gravatar John Cater2018-01-30
| | | | | | | Part of #4442. Change-Id: I44f52d4200f50af0281735fbba326dce5960e950 PiperOrigin-RevId: 183874104
* Remove the CppConfiguration field from CppCompileAction. MakingGravatar cpeyser2018-01-30
| | | | | | CppCompileAction smaller improves serialization. PiperOrigin-RevId: 183871454
* Add a way to get a Target from the WalkableGraph instead of usingGravatar mjhalupka2018-01-30
| | | | | | | | | ConfiguredTarget.getTarget(). Might have reduced performance because we're doing some more lookups in the accessor now. PiperOrigin-RevId: 183864924
* Rename Transition to ConfigurationTransition.Gravatar gregce2018-01-30
| | | | PiperOrigin-RevId: 183859414
* Obsolete and begin removing the toolchain_resolution_override flag.Gravatar John Cater2018-01-30
| | | | | | | | | It is not compatible with multiple execution platforms. Part of #4442. Change-Id: I683beaae1624130352a6f02bae3f4dfff263ea00 PiperOrigin-RevId: 183855561
* Add tests for execution platforms to ExternalPackageUtilTest.Gravatar John Cater2018-01-30
| | | | | | | Part of #4442. Change-Id: Ia9c4403817d9c1e6497212712f96dbf6618138e9 PiperOrigin-RevId: 183855255
* Drop CppCompileAction.actionContextGravatar ulfjack2018-01-30
| | | | | | It always set to the same value. PiperOrigin-RevId: 183843518
* Bazel client: address very subtle race condition during self extraction.Gravatar nharmata2018-01-30
| | | | | | | | | Fail fast if we are about extract the Bazel binary for version V into the predetermined install_base directory for version V'. This fixes Bazel's weakness to a race condition that puts it in a stable inconsistent state where all current and future attempts to use Bazel at version V will actually use V'. A rerun of the Bazel client will be able to successfully use version V'. This race condition occurs when the Bazel binary is replaced after determine the install directory (via the install_base_key file in the Bazel zip) but before we extract the files in the zip into the directory. RELNOTES: None PiperOrigin-RevId: 183843099
* Some simplifications for package serialization.Gravatar cpeyser2018-01-30
| | | | PiperOrigin-RevId: 183842057
* Add a simple Python integration test written in Python.Gravatar lberki2018-01-30
| | | | | RELNOTES: None. PiperOrigin-RevId: 183839976
* Fix RegularFileArtifactValue.equalsGravatar ulfjack2018-01-30
| | | | | | | | If two SkyValue objects are equal, then Skyframe caches and returns the old one, instead of the new one. That's a problem for the detection of file changes, which uses the FileContentsProxy, which wasn't part of the equals check before this change. Progress on #3360. PiperOrigin-RevId: 183834897
* Stop warning about resource filters with "deprecated" qualifiersGravatar Googler2018-01-30
| | | | | | | | | | | | | | | Resource qualifiers of the form "en_US" are deprecated for resources (in favor of qualifiers of the form "en-rUS") but are apparently the recommended (if not only) way of specifying locales in resource filter strings. Removing the warning (and reverting any changes that tried following it) should solve this problem - the original filter strings from the rule are passed unmodified to aapt, but these filters are still "fixed" so that android_ide_common (which doesn't support the "deprecated" qualifier form) can still be used to filter resources in analysis. RELNOTES: none PiperOrigin-RevId: 183830253
* Remove flaky attribute from toolchain_test.Gravatar jcater2018-01-30
| | | | | | Ran test 1000 times, no failures. PiperOrigin-RevId: 183828896
* Remove DynamicTransitionMapper, ConfigurationTransitionProxy.Gravatar gregce2018-01-30
| | | | PiperOrigin-RevId: 183826311
* C++: Removes last calls to CCLibraryHelper.build().Gravatar plf2018-01-30
| | | | | | | | | | In a follow-up CL, CcLibraryHelper will be split in two classes, one for compilation and one for linking. SKIP_KOKORO=mac-flakes RELNOTES:none PiperOrigin-RevId: 183824395
* Add universal transform function. Small refactoring to eliminate duplication.Gravatar dbabkin2018-01-30
| | | | | RELNOTES:none PiperOrigin-RevId: 183806762
* Migrate DependencyModule to use jarToTarget/directJarsGravatar cushon2018-01-29
| | | | | | instead of directJarsToTargets/indirectJarsToTargets. PiperOrigin-RevId: 183780563
* Remove ConfiguredTarget.getTarget() call in TopLevelConstraintSemantics.Gravatar mjhalupka2018-01-29
| | | | | | Replace it with PackageManager.getTarget(). PiperOrigin-RevId: 183736074
* Remove Skylark ConfigurationTransition.DATA references.Gravatar gregce2018-01-29
| | | | PiperOrigin-RevId: 183733621
* Remove unused "pattern" feature in RecursiveFilesystemTraversalFunction.Gravatar felly2018-01-29
| | | | PiperOrigin-RevId: 183731563
* Use nested set cache in key computation for CustomCommandLine.Gravatar tomlu2018-01-29
| | | | | RELNOTES: None PiperOrigin-RevId: 183727976
* Add alternative interface for LIPO data transitions, opt in native rules.Gravatar gregce2018-01-29
| | | | | | | | | | | This removes the need for ConfigurationTransitionProxy.DATA by providing a way for the C++ rule defs to directly inject the transition for all rules to use. Skylark attributes work differently, so they'll be addressed in another change. PiperOrigin-RevId: 183721293
* Expose ApkInfo and AndroidInstrumentationInfo to Skylark.Gravatar ajmichael2018-01-29
| | | | | | | This will enable us to write testing rules in Skylark. RELNOTES: None PiperOrigin-RevId: 183719720
* Remove -Xbootclasspath/p for JDK 9.Gravatar cnsun2018-01-29
| | | | | RELNOTES:none PiperOrigin-RevId: 183714603