| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208837641
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208831294
|
|
|
|
|
|
|
|
|
|
| |
Skyframe.
This avoids some unnecessary iteration over already-emitted events that can show up in profiles, and allows us to store execution-phase values a bit more compactly, since we don't need to carry around wrapper objects and nested sets everywhere.
This crucially depends on the fact that we can't build a target in the execution phase without first having analyzed it in a separate Skyframe call. Skyframe normally propagates all events/posts up the graph because it must be able to emit them if a user requests a node that only transitively depends on the node that emitted an event. However, because we do analysis in a separate Skyframe call, any warnings/posts associated with the analysis nodes will be emitted then, and we don't need to propagate them into execution.
PiperOrigin-RevId: 208767078
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rollforward with fix: Don't use Immutable map builder to agggregate Filesets. We may reach the same one via direct and indirect runfiles, so we need to allow for duplicate entries.
*** Original change description ***
Automated rollback of commit 3bace1b937934fb2cea6260067ecc1cdbe526847.
*** Reason for rollback ***
b/112583337
RELNOTES: None
*** Original change description ***
Track Fileset in artifact expansion.
PiperOrigin-RevId: 208748163
|
|
|
|
|
|
|
|
|
|
| |
It's better to not add `self` positional argument if it's not needed, instead
of adding it and removing it laster on. `subList` invoaction results in more
allocations and CPU overhead when using positional args.
Closes #5812.
PiperOrigin-RevId: 208687360
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 208683453
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208676674
|
|
|
|
|
|
|
|
|
|
| |
descriptor objects.
Build settings are units of configuration i.e. a key/value pair of a setting (e.g. cpu) and a value (e.g. ppc). A build setting descriptor is used to describe what kind of build setting a skylark rule is (if any at all). The BuildSettingDescriptor implementation of the API describes two facets of the build setting rule: the type of the value and whether or not the setting is settable on the command line.
The methods exposed here will eventually be hooked up to a new parameter in the <code> rule() </code> function. Validation for these restrictions will also happen in a later CL attached to the same bug.
PiperOrigin-RevId: 208669663
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208666806
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
b/112583337
RELNOTES: None
*** Original change description ***
Track Fileset in artifact expansion.
PiperOrigin-RevId: 208658921
|
|
|
|
|
|
|
| |
This CL also includes a fix for constructor names from the "Provider" module. Naming does not include the module's name now. (Provider.AndroidAssetsInfo() -> AndroidAssetsInfo())
RELNOTES: None
PiperOrigin-RevId: 208658905
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds:
- the skeleton implementation of the Windows
native test wrapper
- a depenency on the native test wrapper from test
rules, through the new $test_wrapper rule
attribute
- the --windows_native_test_wrapper Bazel flag,
which is currently a no-op
See https://github.com/bazelbuild/bazel/issues/5508
Change-Id: I8df95c8ce8bab53c51c257698ec95416065a836e
Closes #5854.
Change-Id: I2ffc78bceec5dd867af775b5878f105fa87c3dba
PiperOrigin-RevId: 208650699
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208647642
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:nonincremental_builds_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I06fcc0ca713cbc65c677f23dee4171b9be4d7b11
Closes #5884.
Change-Id: I06fcc0ca713cbc65c677f23dee4171b9be4d7b11
PiperOrigin-RevId: 208646495
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208646319
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works around the following error:
java.lang.NoSuchMethodError: java.nio.ByteBuffer.clear()Ljava/nio/ByteBuffer;
at com.google.devtools.build.lib.profiler.Profiler$BinaryFormatWriter.run(Profiler.java:949)
at java.lang.Thread.run(Thread.java:748)
JDK 9 introduced an overloaded methods with covariant return type.
Closes #5886.
PiperOrigin-RevId: 208642556
|
|
|
|
|
|
|
|
| |
removed "sychronized" from Reporter.handle() as we want to be able to let
EventHandlers care about their own synchronization.
RELNOTES: None.
PiperOrigin-RevId: 208628638
|
|
|
|
|
|
|
| |
Cleaning up all references to in-memory tools/defaults:* package.
RELNOTES:none
PiperOrigin-RevId: 208610485
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:skylark_flag_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: Ib698ddcfb2106fe4b9830da9b969e51271e91f58
Closes #5871.
Change-Id: I382c01d4dd8d9ee030dc8fe190a50bd7a57f8ee4
PiperOrigin-RevId: 208606660
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:incompatible_changes_conflict_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I9f599b3ac8e85f394320989a71c00547b493efca
Closes #5870.
Change-Id: I7fa6db3df8d5d06ac2849d538ed6d84030cb1069
PiperOrigin-RevId: 208604220
|
|
|
|
|
|
|
| |
Note that it is currently only used by the java_proto_library family of rules (if enabled per flag).
RELNOTES: None
PiperOrigin-RevId: 208601730
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Continuous build failure
*** Original change description ***
Enable proto based resource shrinking.
RELNOTES: None
PiperOrigin-RevId: 208572831
|
|
|
|
|
|
| |
getNestedArtifact).
PiperOrigin-RevId: 208565138
|
|
|
|
|
|
|
|
| |
node having the same priority, later enqueueings having higher priority, re-enqueued nodes having highest priority, and new root nodes having lowest priority. Experimentally, this can save significant RAM (1.4G in some builds!) while not affecting speed.
Also do a semi-drive-by deleting ExecutorFactory parameter to AbstractQueueVisitor, since it was always AbstractQueueVisitor.EXECUTOR_FACTORY.
PiperOrigin-RevId: 208560889
|
|
|
|
|
|
|
|
|
| |
We use a fixed version of the previous algorithm. See the comments for details.
Fancier algorithms exist. I thought of a cool one that makes use of BatchKeyedLocker (would give me an excuse to revive it, heh), but fancy algorithms would be overkill. As noted in the initial commit of NaiveMultisetSemaphore, performance isn't critical.
RELNOTES: None
PiperOrigin-RevId: 208560559
|
|
|
|
|
|
|
| |
to ensure output contains valid stack map tables.
context: https://github.com/bazelbuild/bazel/issues/5855
PiperOrigin-RevId: 208555048
|
|
|
|
| |
PiperOrigin-RevId: 208554171
|
|
|
|
|
|
| |
This is to allow OptionsProviders to access the new skylark options which aren't held in a fragment class like native options and thus can't be accessed with the traditional <code>get</code> method. Currently this function isn't called anywhere and would just return an empty map. But in the future it will return a map of skylark flag names to values.
PiperOrigin-RevId: 208552510
|
|
|
|
| |
PiperOrigin-RevId: 208549418
|
|
|
|
|
|
|
|
|
| |
This brings 1.2x speedup to clean local Android builds.
Fixes https://github.com/bazelbuild/bazel/issues/5771
RELNOTES: For Android incremental dexing actions, Bazel now persists its DexBuilder process across individual actions. From our benchmarks, this results in a 1.2x speedup for clean local builds.
PiperOrigin-RevId: 208546936
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208532627
|
|
|
|
|
|
|
|
|
| |
Move finding used resources to ProtoResourceUsageAnalyzer for correctness and memory improvements.
New report format: now records the kept resource along with the resource that keep it, as well maintaining the root status for each resource.
Example line: {number/foo[isRoot: false] = 0x07f...} => [{array/foos[isRoot: true] = 0x...}...]
RELNOTES: None
PiperOrigin-RevId: 208529350
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208525880
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208523963
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208509424
|
|
|
|
|
|
|
| |
Move the message-digest cloning to DigestHashFunction and out of Fingerprint, to make it possible to configure Fingerprint to use different hash functions. We keep the default MD5 for now, we'd like it to use the global default but want to isolate the configuration change from any change adding potential contention.
RELNOTES: None.
PiperOrigin-RevId: 208502993
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:cpp_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I7dd4ce2b5702e5853ee357ab4f2a728af7d3018d
Closes #5874.
Change-Id: I7dd4ce2b5702e5853ee357ab4f2a728af7d3018d
PiperOrigin-RevId: 208484274
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:rc_options_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I1fe42e1477e9ebfb94ccfb896de4af5a72e3bb61
Closes #5873.
Change-Id: I1fe42e1477e9ebfb94ccfb896de4af5a72e3bb61
PiperOrigin-RevId: 208479907
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Using a thread-safe container to store handlers.
- Using a ThreadLocal NumberFormat to produce readable action counts.
NumberFormat (or rather the default implementation DecimalFormat) use
internal state and locking.
- Adding a lock-free fast path for START and FINISH events in
ExperimentalEventHandler.
RELNOTES: None.
PiperOrigin-RevId: 208479896
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:ui_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I6667e55f26b9f87437234ba949a521760cfaaa18
Closes #5872.
Change-Id: I6667e55f26b9f87437234ba949a521760cfaaa18
PiperOrigin-RevId: 208476786
|
|
|
|
|
|
|
|
|
| |
Add a test verifying that bazel sync can be used to follow a branch
of an upstream git repository. As this is a standard use case for
bazel sync, we better verify it works properly.
Change-Id: Ia08686376e6c7a89e7f1c130129b46764e43918b
PiperOrigin-RevId: 208464247
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 208462186
|
|
|
|
|
|
|
|
|
|
| |
files and C++ headers
This change completes the handling of proto_src_root when it comes to inclusion of protos, generating the proto files in the right place and adding the generated headers to the include paths.
WANT_LGTM=elenairina
RELNOTES: None.
PiperOrigin-RevId: 208457740
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:configured_query_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I51990b2b1d675dabb4d9e82bbaf6c8c0f26c4baf
Closes #5845.
Change-Id: I51990b2b1d675dabb4d9e82bbaf6c8c0f26c4baf
PiperOrigin-RevId: 208438117
|
|
|
|
|
|
| |
TransitiveVersionTable uses futures.
PiperOrigin-RevId: 208402465
|
|
|
|
|
|
|
|
| |
computeTransitivelyUsedModules to return early on missing values instead of
starting to create datastructures.
RELNOTES: None.
PiperOrigin-RevId: 208351193
|
|
|
|
|
|
|
| |
need them later.
RELNOTES: None.
PiperOrigin-RevId: 208345603
|
|
|
|
|
|
|
|
|
|
|
|
| |
when they're actually being put into a committed value. The previous behavior submitted deps' events twice, when the dep was added and when the node finished building.
The intention is to build on this refactoring to cut off events/postables across the analysis-execution boundary, so that actions are not carrying around nested sets of warnings coming from their configured targets. This will be safe because to execute an action, we must already have analyzed its configured target, so the warning would have been emitted there.
As can be seen from the changed test, this is not a pure behavior no-op. We will now emit cached events slightly later, on value committal, rather than on first dep declaration. This should not be an issue: since the events are cached, the user must have already seen them on a prior build, so the delay should not be important.
Inversely, we now report events slightly more quickly during bubbling up, since we report them at each stage, as opposed to just at ParallelEvaluator evaluation completion.
PiperOrigin-RevId: 208316502
|
|
|
|
|
|
| |
Closes #5770.
PiperOrigin-RevId: 208269268
|
|
|
|
|
|
|
| |
This CL updates the data binding to the latest public release.
RELNOTES: update data binding to 3.2.0
PiperOrigin-RevId: 208267702
|