| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
| |
If the system python interpreter is set to python3, some tests fail
because python3 requires parenthesies for the print statement.
Fix this by adding the required parenthesies, which are a no-op for
python2.
--
Reviewed-on: https://github.com/google/bazel/pull/282
MOS_MIGRATED_REVID=97571926
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97476421
|
|
|
|
|
|
|
| |
User-specific flags need to be before system include paths.
--
MOS_MIGRATED_REVID=97425471
|
|
|
|
|
|
|
|
|
| |
instead of just putting the message into an IOException.
This allows us to more fine-grainly consider printing just the error message (which is the right thing to do in case of compilation errors due to Java syntax errors, wrong command-line arguments, ...) or a stack trace (which is interesting in case the JavaBuilder really hit an IOException or something worse).
--
MOS_MIGRATED_REVID=97413024
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97407601
|
|
|
|
|
|
|
|
|
| |
vanilla implicit dependencies (and not configuration-dependent ones).
Fixes #249.
--
MOS_MIGRATED_REVID=97407144
|
|
|
|
|
|
|
| |
As a drive-by fix, add correct deps to //src/test/java:skylarkshell . Why don't we build that in our tests?
--
MOS_MIGRATED_REVID=97404777
|
|
|
|
|
|
|
|
|
|
| |
Also upped the byte buffer size (as suggested at
http://stackoverflow.com/questions/236861/how-do-you-determine-the-ideal-buffer-size-when-using-fileinputstream)
and made the SkyKey for downloads not hold a URL (since URL equality comparison
is terrible.)
--
MOS_MIGRATED_REVID=97338908
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97334994
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97334001
|
|
|
|
|
|
|
| |
duplicated code and may lead to cleaner tests.
--
MOS_MIGRATED_REVID=97326780
|
|
|
|
|
|
|
| |
quotation marks
--
MOS_MIGRATED_REVID=97320494
|
|
|
|
|
|
|
|
|
|
|
| |
//external:android/sdk anywhere so that no Android-specific package is loaded when the user doesn't use an android_sdk_repository rule.
To this end, SkyframePackageLoaderWithValueEnvironment.getLoadedTarget() doesn't resolve //external: labels anymore. This was only needed for JVM resolution, which was dealt with by adding and extra RedirectChaser.followRedirect() call to JvmConfigurationLoader. One hack less.
On the flip side, BazelConfigurationCollection.collectTransitiveClosure() grew a hack to handle bind(), but that method is awful enough as it is anyway.
--
MOS_MIGRATED_REVID=97307779
|
|
|
|
|
|
|
|
|
|
| |
Adds SkyFunctions and assorted values that implement interleaved
loading of packages and their targets' transitive dependencies.
They are not hooked up to any graph loading components, yet.
--
MOS_MIGRATED_REVID=97278368
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97271109
|
|
|
|
|
|
|
|
|
| |
our tools (ibtool, actool etc) to shell scripts which should be faster and easier to maintain.
RELNOTES:
--
MOS_MIGRATED_REVID=97263085
|
|
|
|
|
|
|
|
|
| |
included in the action's inputs as found during the input discovery phase.
We still require that no new metadata be discovered -- in other words, the "new" inputs are likely just symlinks to old inputs, with different nominal paths.
--
MOS_MIGRATED_REVID=97257026
|
|
|
|
|
|
|
| |
This means that we will not declare additional dependencies if the action fails to execute, but that's correct -- if the action fails to execute, its inputs aren't updated, so there's nothing we'd discover.
--
MOS_MIGRATED_REVID=97255120
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97245351
|
|
|
|
|
|
|
|
|
|
| |
For the purpose of package serialization (that will be necessary for caching),
only accept to use RuleFunction-s (as defined by skylark's rule() function)
that have been exported from a .bzl file with foo = rule(...), using
a finalization pass that walks exported identifiers and blesses RuleFunction-s.
--
MOS_MIGRATED_REVID=97236441
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97236025
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97234432
|
|
|
|
|
|
|
|
|
|
| |
RecursivePkgFunction has a nice framework for doing work across a
directory structure that would be nice to have access to when writing
other similar SkyFunctions. This extracts that general framework, and
changes RecursivePkgFunction into a specialization of it.
--
MOS_MIGRATED_REVID=97231974
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97227161
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97224936
|
|
|
|
|
|
|
| |
This stubs out all Android support, but that's okay, because in order to test Android stuff, we need a way to get the NDK and the SDK somehow, which we don't know yet how to do.
--
MOS_MIGRATED_REVID=97222940
|
|
|
|
|
|
|
| |
and aar_generator.sh to the tools directory and make stub applications proper android_library rules instead of stub filegroups.
--
MOS_MIGRATED_REVID=97206853
|
|
|
|
|
|
|
| |
It would have been nice to also remove JavaCpuSupplier, but that does not work for two reasons: Bazel relies on it always being "default".
--
MOS_MIGRATED_REVID=97202267
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a -XepDisableWarningsInGeneratedCode flag, which if set suppressings
warnings from being emitted inside code annotation with @Generated. Error are
not affected.
Fixes #329
--
MOS_MIGRATED_REVID=97185343
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks 'blaze query'
*** Original change description ***
Skylark: write labels readably
Write a label as Label("//x:x") instead of merely "//x:x", so it can be read
and evaluated back, as per the Python convention. However, the OutputFormatter
for BUILD files still needs to output "//x:x".
--
MOS_MIGRATED_REVID=97156166
|
|
|
|
|
|
|
| |
XcodeGen.
--
MOS_MIGRATED_REVID=97145288
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97140679
|
|
|
|
|
|
|
| |
Otherwise this may cause collisions in the final bundle.
--
MOS_MIGRATED_REVID=97132278
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97131151
|
|
|
|
|
|
|
| |
This was only used in error reporting, and the interface of BuildConfiguration could use some more simplicity. The comment on BuildConfiguration.getShortName() was confusing: that field is *not* actually used to compute the output directory name, which took me a few minutes to realize.
--
MOS_MIGRATED_REVID=97128287
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97126283
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97125970
|
|
|
|
|
|
|
| |
interrupted result implies that the thread pool is idle.
--
MOS_MIGRATED_REVID=97125559
|
|
|
|
|
|
|
| |
"local" spawn strategy.
--
MOS_MIGRATED_REVID=97124055
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97121724
|
|
|
|
|
|
|
|
|
| |
Bazel unconditionally loads all the labels in configurations for now, and we don't want Android stuff to be loaded if the build doesn't have anything to do with Android. The alternative would be to fix this by not loading all configuration fragments, but this is the more expedient solution.
The SDK will be dealt with by binding //external:android/sdk to a dummy SDK unless overridden by an android_sdk_repository rule.
--
MOS_MIGRATED_REVID=97116824
|
|
|
|
|
|
|
|
|
|
|
| |
.checksum() method that is computed from the checksum of the build options. Also remove Fragment.cacheKey() and Fragment.getName().
The reasoning is that within a single build, if two BuildConfigurations share the same BuildOptions, they must be the same because BuildConfiguration can only be a function of BuildOptions, specific targets (which stay the same during a build) and BlazeDirectories (which stay the same during the lifetime of a server). Between different builds if the configurations are recreated, they will always be considered different because Java reference equality (==) is used for comparing BuildConfigurations.
Also remove "Serializable" tags from configuration-related things.
--
MOS_MIGRATED_REVID=97107881
|
|
|
|
|
|
|
| |
Creating the split configurations in Bazel uncovered an incrementality issue: ConfigurationFactory.hostConfigCache kept state between builds untracked by Skyframe, which is not good, and therefore had to be fixed.
--
MOS_MIGRATED_REVID=97106917
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97022077
|
|
|
|
|
|
|
|
|
| |
Dynamic configuration transitions require access to Skyframe (since they instantiate BuildConfigurations as Skyframe nodes). There are various places in Bazel where static transitions are done with no convenient Skyframe access. This cl shuffles host transitions, in particular, to places that are more amenable.
This change also assumes one host configuration per invocation. While this isn't strictly true (each target configuration can have its own host, and multiple target configurations are possible per build), we don't leverage that functionality in any meaningful way today. So until we have a proper interface for multiple host configurations, let's not block dynamic config progress on it.
--
MOS_MIGRATED_REVID=97008479
|
|
|
|
|
|
|
| |
by reducing the size of the final dwp action.
--
MOS_MIGRATED_REVID=97004508
|
|
|
|
|
|
|
|
|
| |
concurrency abstractions.
Care is taken to maintain the invariant that the glob result returns after all of the work is done, even if there was an exception that cuts the task short. Interruption is an exception to this: In this case, the GlobCache later cancels the task and ensures it is done.
--
MOS_MIGRATED_REVID=97000506
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96991829
|
|
|
|
|
|
|
| |
This CL makes me so unhappy. As a follow up, I may rename BaseRule and/or RuleBase. Because seriously, you guys, naming.
--
MOS_MIGRATED_REVID=96990894
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96989486
|