| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113556731
|
|
|
|
|
|
|
|
| |
This exposes an issue with the new Skyframe-based implementation, which is
fixed here as well.
--
MOS_MIGRATED_REVID=113556169
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks many targets, see []
*** Original change description ***
Reinstate mutable SkylarkDict
Add <String, Object> annotation to optionMap invocation in SkylarkAttr,
to make JDK 1.7 happy.
Give the visible name "aspect" to class SkylarkAspect.
--
MOS_MIGRATED_REVID=113543873
|
|
|
|
|
|
|
| |
--
Change-Id: I86b90ff6eda6a16c2efeb8fffca301e2594c254e
Reviewed-on: https://bazel-review.googlesource.com/#/c/2784/
MOS_MIGRATED_REVID=113529297
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113527098
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113524029
|
|
|
|
|
|
|
| |
Fix a minor bug in the process.
--
MOS_MIGRATED_REVID=113519574
|
|
|
|
|
|
|
|
| |
Add test coverage by re-running BuildViewTest with the new Skyframe loading
phase runner.
--
MOS_MIGRATED_REVID=113517509
|
|
|
|
|
|
|
| |
anymore.
--
MOS_MIGRATED_REVID=113512761
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will fix some issue with loading skylark rules from @bazel_tools.
Tested with ./compile.sh all and also a project that use pkg_tar from
@bazel_tools (which is broken at HEAD).
--
Change-Id: Iffbb7134ef5fee497890c4d01b85084973d45ad0
Reviewed-on: https://bazel-review.googlesource.com/2800
MOS_MIGRATED_REVID=113508661
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113492679
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure to wrap a GlobList into a MutableList in convertToSkylark.
Indeed, GlobList is somehow a SkylarkValue, but is not actually acceptable
as a Skylark value. Until this is cleaned up, tweak convertToSkylark.
Also, robustify ClassObject by eagerly calling convertToSkylark on values.
--
MOS_MIGRATED_REVID=113421790
|
|
|
|
|
|
|
| |
the threshold to 100 ms for two common local actions to avoid spamming the INFO log too much. I would be happy to set the threshold even higher.
--
MOS_MIGRATED_REVID=113413914
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the immutability interfaces of existing implementations.
Eventually we want all implementations to comply, but right now CppConfiguration
is a glaring exception due to FDO/LIPO support.
We don't want more exceptions to arise.
This is prep work for pre-trimming ConfigurationFragment.key's BuildOptions input
to just the options needed by the fragment. That implies fragments can be shared across configurations, so that needs to be safe.
--
MOS_MIGRATED_REVID=113408041
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113407051
|
|
|
|
|
|
|
| |
didn't include the reason why the target was missing, and it also spammed Blaze users with a "tip" that's only relevant to Blaze developers debugging newly written integration tests.
--
MOS_MIGRATED_REVID=113401767
|
|
|
|
|
|
|
| |
instead of target depss
--
MOS_MIGRATED_REVID=113398355
|
|
|
|
|
|
|
|
|
|
| |
Add <String, Object> annotation to optionMap invocation in SkylarkAttr,
to make JDK 1.7 happy.
Give the visible name "aspect" to class SkylarkAspect.
--
MOS_MIGRATED_REVID=113394826
|
|
|
|
|
|
|
| |
"--includes_prioritize_system_libs" flag.
--
MOS_MIGRATED_REVID=113387488
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The JAVAC "Make" variable is the javac packaged with the host JDK, which is not
necessarily the same version used to compile java_library rules.
Users should typically use java_library directly. If a manual javac invocation
is required, BazelJavac uses the same javac version and flags as java_library.
In the rare cases where the host JDK's compiler is actually desired, prefer
`$(JAVABASE)/bin/javac` to `$(JAVAC)` for clarity.
--
MOS_MIGRATED_REVID=113386241
|
|
|
|
|
|
|
|
|
|
| |
not useful in the general case and just contributes to Android build logspam.
R_FUTURE=apell
CC=blaze-devel+cl
--
MOS_MIGRATED_REVID=113379242
|
|
|
|
|
|
|
|
|
| |
current rule's configuration.
The bundling object may be for a child rule which had different configuration values than in the current rule context.
--
MOS_MIGRATED_REVID=113377636
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113369821
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113366155
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Break Java 1.7 builds of Bazel.
See http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=linux-x86_64/327/console
Test:
git clone ... && git revert c0a8c58 && export JAVA_VERSION=1.7 && export BAZEL_COMPILE_TARGET=compile && bash -c "source scripts/ci/build.sh; bazel_build"
*** Original change description ***
Make Skylark dicts mutable
Represent Skylark dict using a new subclass SkylarkDict<K, V> of Map<K, V>.
Back it with a TreeMap to provide a deterministic iteration order.
Also make SkylarkList generic in its element type <E>.
Have Artifact implement Comparable<Object> so it can be used as TreeMap key.
--
MOS_MIGRATED_REVID=113359718
|
|
|
|
|
|
|
|
|
| |
Moved RepositoryValue to RepositoryDirectoryValue so that it could be cached
(and not re-downloaded) even if the WorkspaceAST caused a Skyframe restart
(as mentioned in https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java#L130-L133).
--
MOS_MIGRATED_REVID=113358489
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113350910
|
|
|
|
|
|
|
|
|
| |
changes between his branch and HEAD.
This code will need some JNI to make it work properly, but for now, it will do.
--
MOS_MIGRATED_REVID=113349143
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113349046
|
|
|
|
|
|
|
|
|
|
|
|
| |
v13 library doesn't have resources like v4 library. So adding only the jar
dependency should work.
That fixes https://github.com/bazelbuild/bazel/issues/827
--
Change-Id: I1b8e5e2a359472ab9525a1910ac5050c4fb2c9a7
Reviewed-on: https://bazel-review.googlesource.com/#/c/2790/
MOS_MIGRATED_REVID=113344673
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113338481
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113313675
|
|
|
|
|
|
|
| |
type-safety, we now must pass in the exception type of the callback.
--
MOS_MIGRATED_REVID=113313312
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
The new test apparently breaks some targets. Rolling back to fix the build.
*** Original change description ***
Include .dwp file in the runfiles for cc_test when building with Fission.
--
MOS_MIGRATED_REVID=113310353
|
|
|
|
|
|
|
|
|
| |
Also add some TODOs for potentially improving package loading performance.
This CL has no semantic impact.
--
MOS_MIGRATED_REVID=113301656
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113295790
|
|
|
|
|
|
|
|
|
|
| |
third_party/bazel/src/tools/generate_workspace/src/test/java/com/google/devtools/build/workspace, and use regular java_test instead.
I argue that these targets don't add anything, but require code and maintenance.
Hudson just runs all JUnit tests it can find.
--
MOS_MIGRATED_REVID=113286294
|
|
|
|
|
|
|
|
|
|
| |
Represent Skylark dict using a new subclass SkylarkDict<K, V> of Map<K, V>.
Back it with a TreeMap to provide a deterministic iteration order.
Also make SkylarkList generic in its element type <E>.
Have Artifact implement Comparable<Object> so it can be used as TreeMap key.
--
MOS_MIGRATED_REVID=113277489
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Issue that caused the rollback (#819) is resolved
*** Original change description ***
Automated [] rollback of [].
*** Reason for rollback ***
Breaks genrule referencing //pkg from @bazel_tools
*** Original change description ***
Add @bazel_tools prefix to objc tools
This is in preparation for removing the requirement that base_workspace be in
bazel's package_path.
--
MOS_MIGRATED_REVID=113259199
|
|
|
|
|
|
|
|
|
| |
This should never be triggered in production, where we always run a loading
phase first and only analyze targets that load successfully. I.e., this is
just plumbing which will be hooked up in a subsequent change.
--
MOS_MIGRATED_REVID=113258593
|
|
|
|
|
|
|
|
|
|
|
| |
Using $(location //foo) from an external repository was resolving to @//foo, not
@repo//foo, which generally wouldn't be in the main repository. This may also
fix other cases where getRelative was resolving incorrectly.
Fixes #819.
--
MOS_MIGRATED_REVID=113256854
|
|
|
|
|
|
|
|
| |
Fix convertToSkylark that was wrapping List-s into new MutableList-s,
which became wrong since SkylarkList now implements List.
--
MOS_MIGRATED_REVID=113256638
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113251721
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to avoid confusion between rule(), which declares a new build
rules, and native.rule(), which can only be used in macros to inspect
the BUILD file processed so far.
native.{rule,rules} is maintained and marked deprecated to smooth the
transition for early adopters.
--
MOS_MIGRATED_REVID=113250194
|
|
|
|
|
|
|
|
|
|
| |
This variable is no longer used because the docgen template directly calls
RuleDocumentationAttribte.getSynopsis() instead of using the SYNOPSIS variable,
and RuleDocumentationAttribute.getHtmlDocumentation() resolves the SYNOPSIS
variable to the empty string.
--
MOS_MIGRATED_REVID=113249993
|
|
|
|
|
|
|
|
|
|
|
| |
using Constants.java
It also includes one example on how to use the new mechanism in BazelCppRuleClasses.
This is the first phase for the removal of the TOOLS_REPOSITORY constant.
--
MOS_MIGRATED_REVID=113244399
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113200224
|
|
|
|
|
|
|
| |
...and this documentation is incorrect.
--
MOS_MIGRATED_REVID=113198846
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113197641
|
|
|
|
|
|
|
| |
RELNOTES: Repository rules must use names that are valid workspace names.
--
MOS_MIGRATED_REVID=113197588
|