| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 157857216
|
|
|
|
|
|
|
| |
thrown when PackageFunction encounters such an IOException when reading the contents of a BUILD file.
RELNOTES: None
PiperOrigin-RevId: 157853283
|
|
|
|
|
|
| |
ObjcProvider.
PiperOrigin-RevId: 157850516
|
|
|
|
|
|
|
| |
This is consistent with other usage.
RELNOTES: NONE.
PiperOrigin-RevId: 157849696
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 157847930
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 157837746
|
|
|
|
|
|
| |
The C++ implementation of SingleJar, which is available in Bazel, but not yet the default, doesn't support persistent worker mode, so this causes issues when you try to use it.
PiperOrigin-RevId: 157831362
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows `bazel clean` to delete this file.
See https://github.com/bazelbuild/bazel/issues/1586
See https://github.com/bazelbuild/bazel/issues/1906
See https://github.com/bazelbuild/bazel/issues/2480
See https://github.com/bazelbuild/bazel/issues/3043
Change-Id: I245f368c2f2564511bbe6f06193a3ead49724d7b
PiperOrigin-RevId: 157818284
|
|
|
|
|
| |
Change-Id: I45d0cf8e5096ad4ab516af5ddaa98eea8d516c04
PiperOrigin-RevId: 157788771
|
|
|
|
|
|
|
| |
in the transitive closure of robolectric tests.
RELNOTES: None
PiperOrigin-RevId: 157762190
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interrupted eagerly
The original code swallows the InterruptedException, sets the interrupt bit and
stops new tasks from being submitted. However it does not actively send an
interrupt signal to all running and pending tasks already in the pool. It is
partly due to the misleading syntax of awaitTermination, which actually quitely
waits for all tasks to exit even if interruptWorkers is set to true. Both
errors are fixed in this change.
RELNOTES: None
PiperOrigin-RevId: 157762029
|
|
|
|
|
|
|
| |
These do not make sense since aar_import does not compile any java but are inherited from JavaBaseRule.
RELNOTES: None
PiperOrigin-RevId: 157751090
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a subtle integration bug between PatchTransition, ConfiguredTargetFunction, and DependencyResolver.
Short story: ConfiguredTargetFunction.getDynamicConfigurations assumes at most one <Attribute, Label, Transition> entry per configured target dep. DependencyResolver.dependentNodeMap faithfully supplies this by returning an OrderedSetMultimap<Attribute, Dependency>, where each Dependency is a <Label, Transition>. OrderedSetMultimap guarantees no <key, value> repeats, but if you have two semantically equal EnableLipoTransition instances that don't satisfy .equals(), deduping fails.
Most PatchTransitions don't have this problem because they're singletons. But each EnableLipoTransition is instantiated with a Rule, so singletons don't work here.
This problem can only happen when a rule has multiple instances of the same C++ dep under the same attribute. But this isn't actually possible for normal attributes like "deps" because they don't allow duplicates (see RuleClass#checkForDuplicateLabels). Only non-LABEL_LIST attributes can trigger this.
PiperOrigin-RevId: 157733284
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Use Java implementation of singlejar on FreeBSD, and roll forward change 157473007.
*** Original change description ***
Automated g4 rollback of commit d894345ed88f8adce600b66a310b5210d0bcb59c.
*** Reason for rollback ***
Breaks Bazel on FreeBSD: http://ci.bazel.io/view/Dashboard/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=freebsd-11/1542/console
*** Original change description ***
Use cc implementation of singlejar except on Windows.
Change-Id: Ie4a2db2a6fa1ea86f4bdd42cd806f6804a0c56d4
PiperOrigin-RevId: 157729503
|
|
|
|
|
|
|
|
|
|
| |
It was already effectively mandatory. The build would fail if you did not have
the manifest attribute set, but this provides a better error message.
Fixes https://github.com/bazelbuild/bazel/issues/3090.
RELNOTES: None
PiperOrigin-RevId: 157719024
|
|
|
|
|
|
|
|
| |
The src/test/java/c/g/dt/build/lib/skyframe/packages was not included in the srcs
and we were not seeing it because the test was dropped at some point from ci.bazel.io.
Change-Id: Ief0f1ce0937e745193f76a3a8942c2049ed66ef5
PiperOrigin-RevId: 157708941
|
|
|
|
|
|
|
|
|
|
|
| |
If console output limiting is enabled in the actual output stream
is wrapped in a CountingOutputStream to hard-limit the number of
bytes written. As on the console, the two streams, stdout and stderr,
might interleave, proper flushing of writes is important. Therefore,
make sure flushing is propagated through the CountingOutputStream.
Change-Id: I591a2a1ae798a9d8ef704118b22960ff9773a59e
PiperOrigin-RevId: 157707049
|
|
|
|
|
|
|
|
|
|
|
| |
When building with timestamps enabled, it is useful to know the date
as well, e.g., when later looking at logs. This, however, is not the
case if the command does not build (e.g., "bazel help", "bazel query"),
or, in general, if the first output is only produced after the command
is completed.
Change-Id: I75ef38fbb98e886b1dc38899efa10188055f87e2
PiperOrigin-RevId: 157700578
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Unix system, `ln -s foo bar` will create an dangling symlink bar -> foo
even foo doesn't exist. The current implementation of createSymbolicLink for
Windows fails in this situtation. And this lead to #2474.
In this change, we create a dangling junction when the target doesn't exist
which mimics the behavior on Unix.
Fixed https://github.com/bazelbuild/bazel/issues/2474
Change-Id: I442ca3e2fb20b76c9b5bbfee903299fe51481f43
PiperOrigin-RevId: 157694631
|
|
|
|
|
| |
RELNOTES: Use action_config in crosstool for static library archiving, remove ar_flag.
PiperOrigin-RevId: 157685703
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 157685150
|
|
|
|
|
|
|
|
| |
The only call site passes single artifacts. Some of the read sites assert that
the NestedSet contains only one element.
RELNOTES: None
PiperOrigin-RevId: 157635897
|
|
|
|
|
|
|
|
| |
The no_ prefix was initially undocumented, but its support has over time
lead to a number of inconsistencies.
RELNOTES: --no_ prefix no longer recognized.
PiperOrigin-RevId: 157631435
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 157630000
|
|
|
|
|
|
|
| |
- Remove reference to SelectorValue: an internal Bazel definition
- Clarify that "select" means configurable attributes
PiperOrigin-RevId: 157629959
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to add some tests and targets to the Bazel codebase that build and run successfully when android_sdk_repository is in the WORKSPACE and silently skip if it is not.
Example deps of a library that links against dx.jar:
```
deps = select({
"//external:has_androidsdk": ["//external:android/dx_jar_import"],
"//conditions:default": [],
}),
```
Also adds tests that config_setting works as expected when propagated through an alias or bind rule.
RELNOTES: None
PiperOrigin-RevId: 157627472
|
|
|
|
|
|
|
|
| |
This also guarantees consistency between toString()
calls to lib.syntax.SelectorList and
lib.packages.BuildType.SelectorList.
PiperOrigin-RevId: 157617509
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #3004.
Change-Id: I6dcef92e9f23df574e0874a81b2901754042cf9a
Closes #3085.
Change-Id: I6dcef92e9f23df574e0874a81b2901754042cf9a
PiperOrigin-RevId: 157612661
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new docs/ directory in the bazel source tree will only contain the Bazel
docs site, which is hosted at docs.bazel.build. This change deletes the
marketing site and blog, which have been migrated to the bazel-website and
bazel-blog GitHub repositories respectively.
This change also updates the serve-docs.sh and ci/build.sh under scripts/ in
preparation for publishing the docs site.
Note that to help make reviews more manageable, this change is limited to
moving files to their new locations. Here are the follow-up changes:
* Update all links in docs to remove versions/master in paths and to add
correct bazel.build subdomain when linking to pages on the marketing site
or the blog.
* Set up versioned directories on GCS bucket and add tooling for versioning
docs
This change is also coordinated with
https://bazel-review.googlesource.com/c/11568/ to have the PublishSite job
publish to docs.bazel.build rather than www.bazel.build.
Issue #2397
RELNOTES: None
PiperOrigin-RevId: 157612651
|
|
|
|
|
|
| |
Fixes #2960.
PiperOrigin-RevId: 157604844
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Aliases mess with the assumption that
attributeValue.containsKey(target.getLabel())
for every target in the prerequisites of a LABEL_KEYED_STRING_DICT
attribute.
The solution is to use AliasProvider.getDependencyLabel(target) instead.
This fixes it for all current users, including SkylarkRuleContext.
This also adjusts config_setting flag_values and Android feature_flags
to do intelligent things with aliases in their respective attributes.
RELNOTES: None.
PiperOrigin-RevId: 157594095
|
|
|
|
|
|
|
|
|
| |
Setting this flag to false makes Bazel exit with an error on undefined configs. The default value is true, so this change has no impact unless users explicitly pass --noallow_undefined_configs.
This change supersedes an unmerged one, I'm taking the problem from fkp@.
Credit to him for the original change.
PiperOrigin-RevId: 157593338
|
|
|
|
|
|
|
|
| |
On finding a visibility error, report it directly for that target, instead of
relying on the implict "abort" message for targets that have not been built.
Change-Id: I5e45722a1117afca3bc8eeebd05179425b995172
PiperOrigin-RevId: 157592518
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 157578255
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 157576492
|
|
|
|
|
|
|
|
|
|
| |
As SkyFunctions are supposed to be restartable, e.g., if prerequisites are
missing, events generated by them are temporarily stored. So are BuildEvents
posted by them. However, once the evaluation of a SkyFunction is finalized,
the stored posts need to be reposted. Do this.
Change-Id: I4ce20266fbfcbb298e93eb53086fa9916874f5d8
PiperOrigin-RevId: 157575119
|
|
|
|
|
|
|
|
| |
VS2015.
This makes our Windows shell tests work on Windows systems where only VS2017 is installed.
PiperOrigin-RevId: 157573095
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 157569836
|
|
|
|
|
| |
RELNOTES: '--aspects' can occur more than once on the command line.
PiperOrigin-RevId: 157568229
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Bazel on FreeBSD: http://ci.bazel.io/view/Dashboard/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=freebsd-11/1542/console
*** Original change description ***
Use cc implementation of singlejar except on Windows.
Change-Id: Ie4a2db2a6fa1ea86f4bdd42cd806f6804a0c56d4
PiperOrigin-RevId: 157567871
|
|
|
|
|
|
|
|
|
|
| |
if (result != count) {
~~~~~~~^~~~~~~~
Of course, problems arising from this are only theoretical.
Change-Id: Id045a97623026e005d40940eb4a7d30d73f4ce32
PiperOrigin-RevId: 157561218
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/3077
Change-Id: I5f29fdec1f69bdda51fa62be695b8791a45240e9
PiperOrigin-RevId: 157559455
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Reduce scope of try-catch blocks
- Handle non-zero exit the same as zero exit
- Basic infrastructure to handle time outs, currently hard-coded to 15 mins
Some of this code is copied from LocalSpawnRunner. Ideally, we'd reuse that
implementation instead of writing yet another one, but that will have to wait
for some more refactoring.
PiperOrigin-RevId: 157506934
|
|
|
|
|
|
|
| |
and fixes some of J2ObjC's implicit deps to correctly reference the embedded tools.
RELNOTES: Partially fixes external J2ObjC support.
PiperOrigin-RevId: 157503022
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If all resources from a directory are filtered out, the resource processing
action should not receive a reference to that directory.
Filtering the entire contents of a directory is uncommon but not impossible. It
may be indicative of an error (if the user filters on a language, but only
provided resources in other languages - in this case, the build should and will
fail during Java compilation when the requested resource does not exist) or of
weird but acceptable behavior (placing resources for some default language in
one resource directory and resources for all other languages in some other
directory, then inheriting both directories and filtering on language) that
should be correctly handled.
RELNOTES: none
PiperOrigin-RevId: 157499745
|
|
|
|
| |
PiperOrigin-RevId: 157494773
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 157490771
|
|
|
|
| |
PiperOrigin-RevId: 157479936
|
|
|
|
|
| |
Change-Id: Ie4a2db2a6fa1ea86f4bdd42cd806f6804a0c56d4
PiperOrigin-RevId: 157473007
|
|
|
|
|
|
|
|
| |
Move AuthAndTLSOptions to its own package, so that tests/remote no longer
depends on lib:runtime.
RELNOTES: None.
PiperOrigin-RevId: 157469629
|