aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Actions now have the option of returning an ActionResult, containing a ↵Gravatar ruperts2017-10-18
| | | | | | | (possibly empty) set of SpawnResults created during execution of the Action. RELNOTES: None. PiperOrigin-RevId: 172529328
* Remove feature to allow expansion flags to have values.Gravatar ccalvarin2017-10-18
| | | | | | | | | It was added as a potential fix for --config (an expansion flag with values), but this would have required forcing the parser to know the config's expansions at parsing time, which is not currently possible. Instead, we will use the new addition of option-location tracking to make sure we expand options at a the correct place, even if the expansion is triggered after the fact. This is mostly a straight forward undoing of https://github.com/bazelbuild/bazel/commit/7c7255ec8d6da20526c2c4078c57aadaf3dd3612, except where the context has changed. Notably, implicit requirements are effectively treated like expansion flags, so special casing in OptionDescription could be removed. RELNOTES: None. PiperOrigin-RevId: 172514997
* Fall back on basic StringCodec if FastStringCodec isn't availableGravatar michajlo2017-10-18
| | | | | | | Also adds a method which can be used to tell if this behavior actually applied, for more performance-sensitive users. PiperOrigin-RevId: 172512011
* Make cc_toolchain put the files comprising the toolchain into its FileProvider.Gravatar lberki2017-10-18
| | | | | | | Note that cc_toolchain_suite is not changed this way, but that rule doesn't currently serve as a proxy for cc_toolchain (unlike java_runtime_suite for java_runtime), so that's OK. RELNOTES: None. PiperOrigin-RevId: 172502279
* Migrate ResourceProcessorBusyBox Android actions to using SHELL_QUOTED param ↵Gravatar apell2017-10-18
| | | | | | | files. RELNOTES: None. PiperOrigin-RevId: 172485548
* Migrate all users of OptionsParser.enableParamsFileSupport to use the ↵Gravatar apell2017-10-18
| | | | | | | ShellQuotedParamsFilePreProcessor. This covers all of the tools packaged in the ResourceProcessorBusyBox. RELNOTES: None. PiperOrigin-RevId: 172485486
* PiperOrigin-RevId: 172480513Gravatar juliexxia2017-10-18
|
* Start process of making auto_cpu_environment_group non-experimental.Gravatar jcater2017-10-18
| | | | | | | | Adds a legacy flag so clients can continue to use both experimental_auto_cpu_environment_group and auto_cpu_environment_group until uses can be cleaned up. PiperOrigin-RevId: 172470616
* Only run cpp_darwin_integration_test on darwinGravatar hlopko2017-10-18
| | | | | | | | | | | | This test assumes linking and loading behavior only present on darwin, it doesn't make sense to run this test on other platforms. But our CI does. This cl makes the test pass without executing anythign when run on a non-darwin platform. E.g. of failure: http://ci.bazel.io/blue/organizations/jenkins/bazel-tests/detail/bazel-tests/1088/pipeline/26 RELNOTES: None. PiperOrigin-RevId: 172446997
* Skylint: don't warn for unused initialization with 'None'.Gravatar fzaiser2017-10-18
| | | | | | | | | | | | | | | | | | | | It's good practice to place a "declaration" of a variable in a location that dominates all its uses, especially so if you want to document the variable. Hence we want no warning saying this declaration is unused. Example: var = None # don't warn about the unused declaration here if condition: var = 0 else: var = 1 As noted in the code, this also has the undesired side-effect of suppressing the warning here: var = None # doesn't warn either but ideally should var = 0 Fixing the latter problem is not worth the increased code complexity, in my opinion. RELNOTES: none PiperOrigin-RevId: 172442402
* build_windows_jni: fix @cd callGravatar Laszlo Csomor2017-10-18
| | | | | | | | | | | | In cmd.exe it's not enough to `cd` into a directory to change the shell's current working directory: you also have to change to the right drive. Fixes https://github.com/bazelbuild/bazel/issues/3906 Change-Id: I4dd1a17e8b6b4a0db8fb7a56239ed78de3efae95 PiperOrigin-RevId: 172437822
* Stream rest cache file uploads.Gravatar Benjamin Peterson2017-10-18
| | | | | | | | | | | | | | | This means we no longer keep large action inputs or outputs in memory during upload. I adjusted the SimpleBlogStore interface to require clients to pass in the InputStream length. That allows us to always set Content-length on uploads. It's polite to do so, so that the server may, e.g., preallocate space for the blob. Fixes https://github.com/bazelbuild/bazel/issues/3250. Change-Id: I944c9dbc35fa2fa80dce523b0133ea9757bb3973 PiperOrigin-RevId: 172433522
* Enable experimental UI by default.Gravatar twerth2017-10-18
| | | | | RELNOTES: Enable experimental UI by default. PiperOrigin-RevId: 172432464
* Remove the target_apple_env and the apple_host_system_env methods from ↵Gravatar lberki2017-10-18
| | | | | | | | | | ctx.fragments.apple . Progress towards #3424. RELNOTES[INC]: the target_apple_env and apple_host_system_env methods on ctx.fragments.apple are not supported anymore. The same information is accessible through apple_common.target_apple_env and apple_common.apple_host_system_env . They need the Xcode configuration as an argument, which can be obtained by declaring an implicit dependency on it (i.e. attr.label(default=Label("@bazel_tools//tools/osx:current_xcode_config")) and then calling e.g. apple_common.apple_host_system_env(ctx.attr._xcode_config[apple_common.XcodeVersionConfig]). PiperOrigin-RevId: 172430475
* Fixing #3834, making sure test.log always exists.Gravatar olaola2017-10-18
| | | | | | | | Even if the test action produced no output, which it really shouldn't, Bazel should create an empty test.log file. TESTED=unit tests RELNOTES: Fixes #3834 PiperOrigin-RevId: 172412615
* Removing local fallback on failed action commands.Gravatar olaola2017-10-18
| | | | | | | | We should only fall back if a remote execution error occurred, not if the command itself failed. TESTED=better unit tests RELNOTES: None PiperOrigin-RevId: 172406687
* Relax SplitTransitionProvider interface to use AttributeMapGravatar cparsons2017-10-18
| | | | | RELNOTES: None. PiperOrigin-RevId: 172394552
* Extend from an abstract base class to avoid duplication of utility methods ↵Gravatar ruperts2017-10-18
| | | | | | | in RuleErrorConsumers RELNOTES: None. PiperOrigin-RevId: 172387755
* Track Option placement within a priority category.Gravatar ccalvarin2017-10-18
| | | | | | | | | An option has precedence over previous options at the same enum-valued priority. Track its placement in this ordering explicitly. This will allow after-the-fact expansion of expansion options such that they correctly take precedence or not compared to other mentions of the same flag. This is needed to fix --config's expansion. RELNOTES: None. PiperOrigin-RevId: 172367996
* Make BazelJavaCompiler aware of the platform classloaderGravatar cushon2017-10-18
| | | | PiperOrigin-RevId: 172365313
* Optimize trusted MutableList constructionGravatar michajlo2017-10-18
| | | | | | | | | | | | Cuts back a lot of unnecessary copying. All construction is funneled through copyOf and wrapUnsafe. copyOf is the traditional construction mechanism, taking defensive copies of the input and determining if GlobList information needs to be retained. wrapUnsafe takes full ownership of the supplied ArrayList, allowing us to skip a lot of copies in trusted situations. This is particularly useful for common built in functions which return a list, range() being one common example. RELNOTES: None PiperOrigin-RevId: 172361367
* Delayed rollforward of commit 8fb311b4dced234b2f799c16c7d08148619f4087.Gravatar kush2017-10-18
| | | | | | | | | | | | | | | This was rolled back due to Tensorflow breakage but the patch I exported to gerrit (https://bazel-review.googlesource.com/c/bazel/+/18590) passed Tensorflow (https://ci.bazel.io/job/bazel/job/presubmit/52/Downstream_projects/). Confirmed with jcater@ that the "newly failing" projects in the Global Tests are known issues. I think we can check this in now. Additionally I had attempted to reproduce any tensorflow issues with this by building and testing TensorFlow locally with this patch, and all tests which passed with the released bazel had also passed with this patch. ================= Original change description ========================== Reinstate idleness checks where the server self-terminates when it's idle and there is either too much memory pressure or the workspace directory is gone. Arguably, it should kill itself when the workspace directory is gone regardless of whether it's idle or not, but let's first get us back to a known good state, then we can think about improvements. RELNOTES: None. PiperOrigin-RevId: 172361085
* Fall back to guessing available memory on Linux machines running kernels ↵Gravatar Googler2017-10-18
| | | | | | | older than 3.14-rc1 (2014-02-02). RELNOTES: N/A PiperOrigin-RevId: 172356826
* Accept command lines from tools invoking Bazel.Gravatar ccalvarin2017-10-18
| | | | | | | | | | | For tools that wrap Bazel in some way, the original way that the tool was invoked can be a useful piece of information to track when logging what Bazel did and why. In order to output this information in the same way that Bazel outputs its command lines, we accept --tool_command_line in the structure command line format that Bazel uses in the BEP. These structured command lines are protos that we expect as a base64 encoded byte array. For simple scripts that wish to use this feature without compiling the proto, we will also accept any old string (that cannot be interpreted as a base64 encoding) as a single "chunk" in a structured command line. This is experimental for now and users should not get attached to the format. We will remove the experimental_ prefix when it is stable. RELNOTES: None. PiperOrigin-RevId: 172341216
* Make tests independent of the default value for --experimental_uiGravatar Klaus Aehlig2017-10-18
| | | | | | | | | In preparation of experimental UI becoming the default UI for bazel, change some tests that depend on specifics of the current UI to explicitly specify the UI to use. Change-Id: If976c3eccd19c4a523c7eb1b4c4355ab2e5f9371 PiperOrigin-RevId: 172340189
* Make tests more independent of default valuesGravatar Klaus Aehlig2017-10-18
| | | | | | | | | | | | Some tests depend on the target pattern evaluation strategy used. Make them specify the target pattern evaluator they need. Same, if the tests depend on a particular human-readable output stream. While there, also increase shard count for the bazel_repository_cache_test to speed it up. RELNOTES: None PiperOrigin-RevId: 172328801
* Actions now have a temp envvar.Gravatar László Csomor2017-10-16
| | | | | | | | | | | | | | | | | | | | | Every build and test action that creates a Spawn will now have platform-specific environment variables for temp directories: - on Windows: TMP and TEMP - on Linux/Darwin: TMPDIR This is particularly important on Windows where e.g. Java programs cannot create temp directories unless there's a valid TMP or TEMP environment variable set. Fixes: - https://github.com/bazelbuild/bazel/issues/1590 - https://github.com/bazelbuild/bazel/issues/2349 - https://github.com/bazelbuild/bazel/issues/2870 Change-Id: Ib758307daf6b3a51b0f71ae5e65e5bb564dad643 PiperOrigin-RevId: 172326371
* Move min/max tests to new test suiteGravatar laurentlb2017-10-16
| | | | | RELNOTES: None. PiperOrigin-RevId: 172325367
* Skylint: allow docstrings for global variables.Gravatar fzaiser2017-10-16
| | | | | | | | | | | | | | | | Global variables can have docstrings that are placed under their initialization. Example: variable = 0 """Documentation for the variable. Deprecated: This variable is deprecated. """ Note that docstrings are not required, even for public variables. Hence there are no changes to the DocstringChecker. RELNOTES: none PiperOrigin-RevId: 172324350
* Clean up FindModuleSpace.Gravatar Benjamin Peterson2017-10-16
| | | | | | | | | | - Delete "infinite" loop that always ran once. - Remove erroneous comment about resolving symlinks. This hasn't been true since 58ee85afcab07374dabc5493c780cbe3369b644f ("Don't follow symlink when looking for python module space") Change-Id: Ibfaddc3aa2b3f89b180c74f86796c0d39f4092d3 PiperOrigin-RevId: 172321824
* In CppToolchainInfo, use the label of the cc_toolchain instead of ↵Gravatar cpeyser2017-10-16
| | | | | | --crosstool_top to find the crosstool package. PiperOrigin-RevId: 172320513
* Skylint: docstring format: mandatory order of description and sections.Gravatar fzaiser2017-10-16
| | | | | | | | | | | | | | | | Each docstring should include 1. a summary line 2. a more extensive description (optional) 3. an 'Args' section (if there are parameters) 4. a 'Returns' section (if there is a return value) 5. a 'Deprecated' section (if it is deprecated) in this order. If the order is different, there will be a warning. The same order is recommended for Java (http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#orderoftags). RELNOTES: none PiperOrigin-RevId: 172313475
* run_test: fix portability issueGravatar Klaus Aehlig2017-10-16
| | | | | | | | | | There are different versions of sed, some implicitly add a newline character to the last line, some don't. To work around, add an additional newline character (so that the file for sure is newline-terminated) to all the files we're editing/comparing. Change-Id: I83e829f26dae839a965349fa137909249b581105 PiperOrigin-RevId: 172312277
* BuildEventStreamer: clear a pending BuildStarted event firstGravatar Klaus Aehlig2017-10-16
| | | | | | | | | | | | | | | | | | | | If we receive an event indicating that the build is over, we first post that event and then clear up all pending event by stating that their prerequisite event was aborted (which we can safely assert, as we know we will not process any further events). Now, if a build is aborted (e.g., user interruption) before the build starting event is generated, the streamer can receive a build-finished event while still having an event (e.g., the raw command line) blocked on the build-starting event. So the canonical order of clearing the stream would send a build-finished event before the build-starting event, which can be confusing to consumers of the stream. Therefore, if have to generate an artificial aborted build-starting event, do so first (including clearing the events blocked on the build-starting event) and only afterwards post the build-finished event in the stream. Change-Id: Ib33f16f74b7bee7a963df94bbcad7a56db9f07e3 PiperOrigin-RevId: 172305114
* BEP: explicitly report failures associated with a label as suchGravatar Klaus Aehlig2017-10-16
| | | | | | | | | | There is a conceptual difference between the (maybe unsuccessful) completion of a top-level target and a label as the root cause for a failure (i.e., a missing source file). Indicate that difference as such, by having a separate message for failures associated with an unconfigured label. Change-Id: I3f2e20d4dc85782eb11b104a7baf089e66d972e7 PiperOrigin-RevId: 172299938
* Export apple_host_system_env and target_apple_env through apple_common (as ↵Gravatar lberki2017-10-16
| | | | | | | | | opposed to only through ctx.fragments.apple) Progress towards #3424. RELNOTES: None. PiperOrigin-RevId: 172299240
* Some tests depend on the target pattern evaluation strategy used.Gravatar aehlig2017-10-16
| | | | | | | Make them specify the target pattern evaluator they need. RELNOTES: None PiperOrigin-RevId: 172296001
* Removing the USER variable from test environment, unless explicitly provided.Gravatar olaola2017-10-16
| | | | | | TESTED=added remote test RELNOTES: Fixes #2574 PiperOrigin-RevId: 172294781
* Remove the uses_protobuf attribute from objc_proto_library.Gravatar kaipi2017-10-16
| | | | PiperOrigin-RevId: 172199420
* Extract more RuleContext error-related methods into RuleErrorConsumerGravatar cparsons2017-10-16
| | | | | | | This will make it easier to pass only error-handling functionality into support classes. RELNOTES: None. PiperOrigin-RevId: 172148072
* Properly report errors as errors.Gravatar nharmata2017-10-16
| | | | | RELNOTES: None PiperOrigin-RevId: 172133468
* Add callcount system for blaze developers.Gravatar tomlu2017-10-16
| | | | | | | | | | | This simple system allows blaze developers to insert instrumentations in particular methods that they want to know: 1. How often are they called? 2. From which call sites are they called, with full call stack The output is a pprof file that can then be analysed offline. PiperOrigin-RevId: 172128440
* Make option conflicts less spammy.Gravatar ccalvarin2017-10-16
| | | | | | | Remove an unnecessary warning and make all warnings for option conflicts print only if the option values are not equal. RELNOTES: None. PiperOrigin-RevId: 172124261
* Fix src/test/shell/bazel/bazel_bootstrap_distfile_test.Gravatar tomlu2017-10-16
| | | | | | | | | We added a proto to third_party, and protos aren't compiled as per normal during bootstrapping. We add a pointer from our protobuf into third_party for pprof so bootstrapping can work. Verified that this fixes test by exporting a repo and running bazel test. PiperOrigin-RevId: 172122010
* Define protos for the Skylark debug server.Gravatar allevato2017-10-16
| | | | PiperOrigin-RevId: 172115471
* Flip the --incompatible_list_plus_equals_inplace flag by defaultGravatar vladmos2017-10-16
| | | | | | | | | RELNOTES[INC]: += on lists now mutates them. `list1 += list2` is now equivalent to `list1.extend(list2)` and not equivalent to `list1 = list1 + list2` anymore. Fixes #2350. PiperOrigin-RevId: 172111899
* Simplify ApplicationManifest by inlining createApk and simplifying the ↵Gravatar corysmith2017-10-16
| | | | | | | builder code. RELNOTES: None PiperOrigin-RevId: 172109520
* Update documentation on objc_proto_library rule, and disable the passing of ↵Gravatar kaipi2017-10-16
| | | | | | direct files into the deps attribute, only proto_library and objc_proto_library targets are allowed. PiperOrigin-RevId: 172107133
* Don't follow globs in rbuildfiles. Globs request the FILE node for symlinks ↵Gravatar shreyax2017-10-16
| | | | | | which causes the package containing the reference to be visited in rbuildfiles (which isn't the intended behaviour of rbuildfiles). Also add tests to guard against other types of inclusions. PiperOrigin-RevId: 172106051
* BEP: link structured command lineGravatar Klaus Aehlig2017-10-16
| | | | | | | | | | Change ceb1013c1ca0238188e2714442fcfb2efb16bc6a added an event for the structured command line to the BEP. Announce that event as a child of the build-starting event so that it gets properly chained and does not have to be chained in by a progress event. Change-Id: I6aeb46b748a536da58a916b9c4e0b1b66bbd40b0 PiperOrigin-RevId: 172100341
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-24 09:53:07 +0000