aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Add virtual destructor and override to BinaryLauncherBase and subclassesGravatar Loo Rong Jie2018-06-28
| | | | | | | | | | Class with virtual functions must have virtual destructor. Subclasses should annotate overriden functions as `override`. Found by Clang's `-Winconsistent-missing-override`. Closes #5474. PiperOrigin-RevId: 202445230
* Add parentheses to bool expr with && and ||Gravatar Loo Rong Jie2018-06-28
| | | | | | | | Boolean expression with *both* `&&` and `||` must use parentheses to prevent ambiguity. Closes #5475. PiperOrigin-RevId: 202445215
* Automated rollback of commit 1f319fffb8a577be95e8143c21755fe55156a0cb.Gravatar cushon2018-06-28
| | | | | | | | | | *** Reason for rollback *** fix forward *** Original change description *** PiperOrigin-RevId: 202441346
* Remove unused strict deps module parameter.Gravatar Googler2018-06-27
| | | | | RELNOTES: none PiperOrigin-RevId: 202404085
* Add --incompatible_disable_data_transition for 'cfg = "data"' Skylark callsGravatar gregce2018-06-27
| | | | PiperOrigin-RevId: 202400312
* Handles null value in createAggregatingValue env.getValues call.Gravatar shahan2018-06-27
| | | | PiperOrigin-RevId: 202389874
* Remove old (dead) SkylarkSignature-binding code from some classes.Gravatar cparsons2018-06-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 202386363
* Inspect post-evaluation exported variables to obtain rule names.Gravatar cparsons2018-06-27
| | | | | | | | | This is a much cleaner, more elegant approach than previous regex matching. This still leaves room for unknown-name rule definitions, in case, for example, a user namespaces their rule definition not at the top level. For example: "foo.bar = rule(...)" RELNOTES: None. PiperOrigin-RevId: 202380975
* Clarify purpose of golden-file-regeneration targetsGravatar cparsons2018-06-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 202364245
* Add Interners for CcToolchainFeatures$ActionConfig, Feature, andGravatar mjhalupka2018-06-27
| | | | | | FeatureConfiguration. PiperOrigin-RevId: 202363333
* Automated refactor of Label.parseAbsolute() to always pass a repository mappingGravatar dannark2018-06-27
| | | | | RELNOTES: None PiperOrigin-RevId: 202360925
* Fix docgen handling of multiple modules with the same nameGravatar cparsons2018-06-27
| | | | | | | | | | If there are multiple modules with the same name: - If only one is marked 'documented', that one takes precedence. - If one is a subclass of the others, the subclass takes precedence. - Otherwise, an exception is thrown. RELNOTES: None. PiperOrigin-RevId: 202359443
* Create a skydoc_test macro for ease of golden-file testing of skydocGravatar cparsons2018-06-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 202339577
* Remove obsolete function.Gravatar laurentlb2018-06-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 202325860
* Debug server logging: don't construct expensive debug-level log strings ↵Gravatar brendandouglas2018-06-27
| | | | | | unless necessary. PiperOrigin-RevId: 202317115
* Bazel,client: actually cache directory creationsGravatar Laszlo Csomor2018-06-27
| | | | | | | | | | | | | | | | | | | | Commit https://github.com/bazelbuild/bazel/commit/f5043d6831ea1c266104363b4e8911eb97f96fbc was incorrect in that it cached the file names, not the directory names. This commit fixes that. I verified that the number of calls to ExtractBlazeZipProcessor::Process is greater than the calls to MakeDirectories within (1038 vs. 172 on Linux). See https://github.com/bazelbuild/bazel/issues/5444 Change-Id: I314bdc9337c9782a5ceaed7aac785a552b222b1f Closes #5484. Change-Id: I314bdc9337c9782a5ceaed7aac785a552b222b1f PiperOrigin-RevId: 202314400
* Bazel client: add a simple profilerGravatar Laszlo Csomor2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | Add a simple profiler that can measure function call counts and durations, and report statistics by printing to stderr. Motivation: I recently needed a profiler for PR #5445 and PR #5448, so I'm adding the polished code now. Usage: 1. depend on //src/main/cpp/util:profiler 2. use StopWatch, Task, and ScopedTask objects as shown in profiler.h's class documentation See https://github.com/bazelbuild/bazel/issues/5444 Change-Id: I43f0afd124b486c694f451e8455a66ffca8137b6 Closes #5461. Change-Id: I43f0afd124b486c694f451e8455a66ffca8137b6 PiperOrigin-RevId: 202314319
* Windows,examples: //examples/shell now worksGravatar Laszlo Csomor2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | The targets in //examples/shell:* now use the Bash runfiles library in @bazel_tools//tools/bash/runfiles and work on Windows. Also undef the RUNFILES_* envvars in bazel_example_test::test_shell (which builds the shell example project) so that the runfiles library discovers its own runfiles instead of trying (and failing) to use the enclosing test's runfiles (which it shouldn't use, because the test executes "bazel run //examples/shell:bin" so that target's runfiles are independent of the enclosing test's runfiles). Fixes https://github.com/bazelbuild/bazel/issues/3839 Closes #5480. Change-Id: I44f9bf9b11f7fac0e1c0995a44c2336846dc2bc8 PiperOrigin-RevId: 202313105
* Add an interner for non source artifacts that are deserialized.Gravatar mjhalupka2018-06-27
| | | | PiperOrigin-RevId: 202311773
* C++: Makes Skylark CcCompilationInfo accept headersGravatar plf2018-06-27
| | | | | | | | | The Skylark constructor of CcCompilationInfo now accepts headers. This may be the last piece needed to get a working prototype of foreign C++ libraries. Next step would be open sourcing the sandwich. RELNOTES:none PiperOrigin-RevId: 202306252
* PiperOrigin-RevId: 202296332Gravatar twerth2018-06-27
|
* runfiles libraries: fix tests and commentsGravatar Laszlo Csomor2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | | - Update all runfiles libraries to have the same header comment format, including the build rule to depend on the namespace / header / module to import - Fix runfiles_test.cc to include the right files (recent refactoring commit has split src/main/cpp/util/path.cc from file_[platform].cc) - Change exported variable _rlocation_isabs_pattern in runfiles.bash to be upper-case, so it is visibly a variable and not a function. See https://github.com/bazelbuild/bazel/issues/4460 Change-Id: I17e18308506ab9f5c9f410ef6bc6b9df912d42a9 Closes #5481. Change-Id: I17e18308506ab9f5c9f410ef6bc6b9df912d42a9 PiperOrigin-RevId: 202291629
* PiperOrigin-RevId: 202265344Gravatar cushon2018-06-27
|
* Make DefaultInfo.default_runfiles return all runfiles if the runfiles field ↵Gravatar cparsons2018-06-26
| | | | | | | of DefaultInfo() was used. RELNOTES: None. PiperOrigin-RevId: 202192091
* Initial check-in of skydoc rewrite.Gravatar cparsons2018-06-26
| | | | | | | | | | | | | | This skydoc rewrite uses an actual skylark interpreter with a faked build API (implementing the actual build API that Bazel uses). There's a lot left to do here, this is a barebones start. For example, this does not yet handle: - load() statements - non-global build API elements (e.g. apple_common) - output of any rule information other than attribute names - markdown output format RELNOTES: None. PiperOrigin-RevId: 202187207
* Enforce that repository mapping is never null (it can be empty).Gravatar dannark2018-06-26
| | | | | RELNOTES: None PiperOrigin-RevId: 202167782
* Debug server debug logs: use EventHandler instead of Logger.Gravatar brendandouglas2018-06-26
| | | | | | | | Logger messages aren't printed to the console, they're written to /usr/local/google/tmp, and can be prohibitively large for these debug server logs. Instead I'm going with your original suggestion in https://github.com/bazelbuild/bazel/commit/b74922932b25a71c626b47ea9a9afb7dbc506cec, and selectively suppressing debug events by wrapping the EventHandler on the way in to SkylarkDebugServer. PiperOrigin-RevId: 202166571
* Flatten JavaCompilationAgs into JavaCompilationArgsProviderGravatar cushon2018-06-26
| | | | | | | | | Consolidate the creation of JavaCompilationArgsProviders, and avoid explicit handling of the 'direct' and 'recursive' cases in clients. Also add some higher-level methods to the builder API to support adding dependencies with dep/export/runtime_dep-like semantics. PiperOrigin-RevId: 202166383
* Add newline in Args docs.Gravatar tomlu2018-06-26
| | | | | RELNOTES: None PiperOrigin-RevId: 202162804
* Make sure we pass the correct -encoding options to javacGravatar cushon2018-06-26
| | | | PiperOrigin-RevId: 202162534
* Instead of depending on mutable inputs of upstream CppCompileAction instances,Gravatar shahan2018-06-26
| | | | | | | | | CppCompileAction.discoverInputsStage2 retrieves values of discovered modules from ActionExecutionValue. This addresses a possible a correctness issue. PiperOrigin-RevId: 202162180
* Fix concurrent modification exception while resuming all threads.Gravatar brendandouglas2018-06-26
| | | | PiperOrigin-RevId: 202151257
* Document LateBoundDefaultGravatar cparsons2018-06-26
| | | | | RELNOTES: None. PiperOrigin-RevId: 202150316
* Remove support for header preprocessingGravatar hlopko2018-06-26
| | | | | | | This was never used. We thought it will be useful, but it's not. RELNOTES: None. PiperOrigin-RevId: 202143524
* C++: Refactor WrapCcHelper.Gravatar plf2018-06-26
| | | | | | | Makes it non-instantiable so that it's easier to migrate SWIG rules to Skylark. RELNOTES:none PiperOrigin-RevId: 202136054
* Handle evaluation of statements, not just expressions.Gravatar brendandouglas2018-06-26
| | | | | | | | | | | | | | | Also handle statements in conditional breakpoints. This is more consistent with other common debuggers (e.g. java, python). Calls Parser#parseStatement with local parsing level, so some statement types aren't handled (e.g. load statements), which is broadly consistent with other debuggers. Assignment, augmented assignment, and return statements return a non-None value, and simple expression statements still return the result of evaluating the expression. TAG_CHANGE_OK=This proto has never yet been used TYPE_CHANGE_OK=This proto has never yet been used PiperOrigin-RevId: 202135678
* add helper JUnit TestWrapper class to do some action on test timeoutGravatar Irina Chernushina2018-06-26
| | | | | | | | | | | | add helper JUnit TestWrapper class to do some action on test timeout i.e. we want to dump the current state of the test on timeout before exit for the new junit integration test framework Closes #5436. PiperOrigin-RevId: 202123320
* Add convenience methods to check for flag existence and values in command lines.Gravatar twerth2018-06-26
| | | | | RELNOTES: None PiperOrigin-RevId: 202118168
* Specify that some resources in objc_bundle_library are post processed before ↵Gravatar Googler2018-06-26
| | | | | | | they are used on the phone. RELNOTES: None. PiperOrigin-RevId: 202117007
* create path utils for copying and deleting directories,Gravatar Googler2018-06-26
| | | | | | and for often required operations like creating file and its parent directories PiperOrigin-RevId: 202115025
* Replace //tools/defaults:jdk to //tools/jdk:*Gravatar dbabkin2018-06-26
| | | | | | | As //tools/defaults will be deprecated soon. All usages of //tools/defaults:jdk and //tools/defaults:java_toolchain should be replaced by corresponding targets in //tools/jdk/BUILD package RELNOTES:none PiperOrigin-RevId: 202114489
* Allow private headers to appear in directory artifactsGravatar hlopko2018-06-26
| | | | | | | | | | | | | | Before, Bazel expected that it can compile whatever appeared in cc_library.srcs directory artifacts. That is true for C/C++ source files, and for headers when the C++ toolchain supported header parsing/processing (which used CppCompileAction). When the toolchain doesn't support header parsing/processing, Bazel would crash. Addresses issue #5092. One part of it. Fixes #5372. RELNOTES: None. PiperOrigin-RevId: 202114286
* remote: enable previously ignored testsGravatar Jakob Buchgraber2018-06-26
| | | | | | | | | | | | | | | the tests had been disabled for flakyness due to timeouts. I think the right solution is remove the individual test timeouts as on a highly loaded machine fine grained timeouts typically don't make much sense. After removing the individual test timeouts no more flakyness was found in 1000 runs. Closes #5465. PiperOrigin-RevId: 202113697
* process runner for junit integration test frameworkGravatar Irina Chernushina2018-06-26
| | | | | | Closes #5435. PiperOrigin-RevId: 202100672
* C++: Remove call to initializeCcCompilationContext.Gravatar plf2018-06-26
| | | | | | | | | To get a CcCompilationInfo instance from Skylark it will either have to be through its constructor (not yet fully implemented) which will not schedule any actions or through a call to compile() which does schedule actions. RELNOTES:none PiperOrigin-RevId: 202099841
* Prefetch inputs in bazel workers.Gravatar Googler2018-06-26
| | | | PiperOrigin-RevId: 202092962
* Fix missing newline after repository_cache value in info command output.Gravatar Googler2018-06-25
| | | | PiperOrigin-RevId: 202023187
* Explicitly specify @SkylarkCallable parameters for cpp skylark modules.Gravatar cparsons2018-06-25
| | | | | RELNOTES: None. PiperOrigin-RevId: 202015490
* Explicitly specify @SkylarkCallable parameters for several skylarkbuildapi ↵Gravatar cparsons2018-06-25
| | | | | | | interfaces. RELNOTES: None. PiperOrigin-RevId: 201972439
* C++: Remove unnecessary runfiles providers.Gravatar plf2018-06-25
| | | | PiperOrigin-RevId: 201969238