aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Warn when code uses FileType(), which is deprecated.Gravatar laurentlb2018-04-11
| | | | | RELNOTES: None. PiperOrigin-RevId: 192472412
* Create a new proto output formatter for cquery. Also add flag ↵Gravatar juliexxia2018-04-11
| | | | | | --[no]proto:include_configurations which when used, makes cquery proto output appear exactly like query proto output so tools that are already using this can seamlessly transition. PiperOrigin-RevId: 192470626
* PiperOrigin-RevId: 192470493Gravatar cushon2018-04-11
|
* Enable testing stderr for import-deps-checker.Gravatar cnsun2018-04-11
| | | | | | RELNOTES: None. PiperOrigin-RevId: 192452316
* Fix NPE in action graph dump.Gravatar twerth2018-04-11
| | | | | RELNOTES: None PiperOrigin-RevId: 192445971
* Add a test that builds a Windows binary remotely and runs it locally, to ↵Gravatar Googler2018-04-11
| | | | | | | | | | | validate this key use case for remote Windows builds. This is a working test case, but I plan to add more in this style to demonstrate fixes to address #4962. Note that to run this test requires a build of Bazel that includes https://github.com/bazelbuild/bazel/commit/b4545ba2b1aa4079b09a346a6d441ffa1e1b7d20 since this changed the way runfile manifests are discovered. Bazel 0.11 doesn't include this. RELNOTES: None. PiperOrigin-RevId: 192444770
* Make --fdo_optimize paths be PathFragment instead of Path, and remove the ↵Gravatar Googler2018-04-11
| | | | | | now unused ConfigurationEnvironment#getBlazeDirectories() PiperOrigin-RevId: 192443323
* Add CommandLinesAndParamFiles class.Gravatar tomlu2018-04-11
| | | | | | | | | | | This class is currently unused. In order to keep CL sizes down we introduce this class prior to using it in the spawn runners. This class can manage an action's list of command lines and param files. For instance, SpawnAction will contain one of these instances (instead of keeping a single command line object and adding param file write actions to the action graph). At spawn execution time, the spawn runners will use this class to resolve the list of command lines and param files into a master argument list + some number of param files that need to be written. The local spawn runners can simply write the param files using a helper. In the distributed cases the param files are ready-made VirtualActionInputs that can be added to the Spawn's other inputs. RELNOTES: None PiperOrigin-RevId: 192439501
* Automated rollback of commit 3ab52e63079f1e43cb2c973425f615836a334082.Gravatar hlopko2018-04-11
| | | | | | | | | | | | | | *** Reason for rollback *** Breaks exoblaze, and there's a better way how to move forward with this. *** Original change description *** Flip default value of --experimental_shortened_obj_file_path to true RELNOTES: Flip default value of --experimental_shortened_obj_file_path to true, Bazel now generates short object file path by default. PiperOrigin-RevId: 192437958
* Introduce `--incompatible_disallow_slash_operator` to disable `/` operator.Gravatar laurentlb2018-04-11
| | | | | | | | RELNOTES: The `/` operator is deprecated in favor of `//` (floor integer division). Try the `--incompatible_disallow_slash_operator` flag to ensure your code is forward-compatible. PiperOrigin-RevId: 192430310
* analyze-profile: prevent bazel from crashing outside a workspaceGravatar Shmuel H2018-04-11
| | | | | | | | This commit closes #3256. Closes #4971. PiperOrigin-RevId: 192429422
* Deprecate BuildConfiguration.Fragment#getArtifactOwnerTransition().Gravatar lberki2018-04-11
| | | | | | | Not a lot of chance that this will accidentally get used for something, but let's keep our house tidy. RELNOTES: None. PiperOrigin-RevId: 192426276
* Fix typo in error message (incompatible_package_name_is_a_function).Gravatar laurentlb2018-04-11
| | | | | RELNOTES: None. PiperOrigin-RevId: 192425838
* Also prefetch label lists for repository rulesGravatar Klaus Aehlig2018-04-11
| | | | | | | | | | | ...so that a repository rule can access them in any order without being restarted. Restarting a repository rule can be expensive, if it already accessed the network or executed expensive commands. Improves on #4533. Change-Id: I618c25322511dab42a80c1dddb0798fc9aea3106 PiperOrigin-RevId: 192420257
* Remove BuildConfiguration.Fragment#setupActionEnvironment().Gravatar lberki2018-04-11
| | | | | | | This is accomplished by moving it to ConfiguredRuleClassProvider. This also suggests a neat way to get rid of logic in ShellConfiguration.Loader() by moving the determination of the shell executable, there, too, but not in this change. RELNOTES: None. PiperOrigin-RevId: 192411609
* Automated rollback of commit ca598fb9445627e9734c2900bc6b11430250d453.Gravatar dannark2018-04-10
| | | | | | | | | | | | | *** Reason for rollback *** breaks guitar tests *** Original change description *** Disallow labels of the form ////foo. RELNOTES: Labels of the form ////foo are disallowed. PiperOrigin-RevId: 192393660
* Add value constants to ObjectCodecRegistry. Value constants are to be used ↵Gravatar janakr2018-04-10
| | | | | | when there may not be a canonical instance of the object we want (or the canonical instance isn't available at registry construction time), but we can reasonably cheaply do value equality comparisons. Strings are a good example. PiperOrigin-RevId: 192354865
* Migrate apple_common.new_objc_provider to use @SkylarkCallableGravatar cparsons2018-04-10
| | | | | RELNOTES: None. PiperOrigin-RevId: 192350172
* Make the skyframe-native flag a no-op.Gravatar kush2018-04-10
| | | | | RELNOTES: None PiperOrigin-RevId: 192349971
* Add support for sandboxfs-based sandboxing to Linux.Gravatar jmmv2018-04-10
| | | | | | | This is essentially the same as https://github.com/bazelbuild/bazel/commit/3a7b8bc2abeaf8b8647c037bed1dd5fd73b8392b. RELNOTES: none. PiperOrigin-RevId: 192342039
* Migrate Info's skylark methods to @SkylarkCallableGravatar cparsons2018-04-10
| | | | | RELNOTES: None PiperOrigin-RevId: 192337555
* Simplify AbstractSkyFunctionEnvironment to more directly call ↵Gravatar shreyax2018-04-10
| | | | | | getValueOrUntypedExceptions. PiperOrigin-RevId: 192329649
* Disallow labels of the form ////foo.Gravatar carmi2018-04-10
| | | | | RELNOTES: Labels of the form ////foo are disallowed. PiperOrigin-RevId: 192329081
* Fix bug in SkyQuery's parallel allrdeps with --nohost_deps.Gravatar nharmata2018-04-10
| | | | | | | | | The was that the presence of invalid dependency edges would incorrectly cause 'allrdeps' to not visit targets. Concrete example: if --nohost_deps was set and T1 depended on T via a host edge and T2 depended on T via a non-host edge then 'allrdeps(T)' might incorrectly not contain T2. Along with fixing the bug, refactor ParallelVisitor's deduping logic: instead of deduping visitations inside #getVisitResult, dedupe them before adding them to #processingQueue. This should be a strict, small, performance win, especially for trivial visitations (e.g. RBuildFilesVisitor). RELNOTES: None PiperOrigin-RevId: 192327607
* Make some objects frequently encountered during serialization into ↵Gravatar janakr2018-04-10
| | | | | | | | constants. A lot of care is needed here because we're using reference equality. I plan to add value-equality constants in a follow-up. Add ImmutableSortedSet marshaller because I think it might have been needed, and hey, why not. PiperOrigin-RevId: 192326359
* Makes BlazeDirectories a serialization constant.Gravatar shahan2018-04-10
| | | | PiperOrigin-RevId: 192325937
* Fix handling of relative symlinks within sandboxfs.Gravatar jmmv2018-04-10
| | | | | | | | | | | | | | | | | | If an action expresses a symlink as an input, the target of the symlink does not necessarily appear as a file to map within the sandbox. This is a problem when the target of the symlink is relative because sandboxfs would expose the link verbatim and the target would be missing later on during resolution. To fix this, special-case the handling of symlinks: when trying to expose them via a sandboxfs mount point, resolve their final target instead of respecting the original contents. This loses the fact that the file was a symlink when running within the sandboxfs sandbox, but is easier to implement and slightly faster at runtime. We can reconsider this choice if this causes problems. RELNOTES: None. PiperOrigin-RevId: 192325932
* Bring startup_options to BAZEL_LOG.Gravatar ccalvarin2018-04-10
| | | | | RELNOTES: None. PiperOrigin-RevId: 192313667
* Allow codecs in ObjectCodecRegistry.Builder to be swapped out.Gravatar cpeyser2018-04-10
| | | | PiperOrigin-RevId: 192298198
* Make SkylarkCustomCommandLine support efficient fingerprint calculation.Gravatar tomlu2018-04-10
| | | | | | | | | | | When using nested sets, we reuse sub-fingerprint computations by using the nested set key cache. map_each is supported. All formats, before_each, join_with and so on are computed via adding a specific UUID to the fingerprint + the control string (eg. the format string) rather than performing the actual computation. In legacy mode (existence of old map_fn), it falls back to trivial (and slow) fingerprint calculation. RELNOTES: None PiperOrigin-RevId: 192288783
* Update documentation of RuleConfiguredTargetFactory to reflect recent ↵Gravatar janakr2018-04-10
| | | | | | refactorings of Target and BuildConfiguration out of ConfiguredTarget. Also use fully qualified imports as per style guide, since RuleConfiguredTargetFactory.java is in lib:build-base, and so has access to all the things. PiperOrigin-RevId: 192288463
* Remove lock around DiGraph in BlazeQueryEnvironmentGravatar dbabkin2018-04-10
| | | | | | | | | - New lock introduced around Node.succs and Node.preds. These locks always hold in direction Node.succs -> Node.preds that's why reordering deadlock never happens. - All logic related to changing collection implementation from ArrayList to CompactHasSet and vise versa encapsulated in dedicated class ConcurrentCollectionWrapper. - Remove some code related to removing node from DiGraph to Node. RELNOTES:none PiperOrigin-RevId: 192282628
* Remove traces of optional_flags from crosstoolGravatar hlopko2018-04-10
| | | | | | | AFAIK all uses have been migrated to features, so they are not needed anymore. RELNOTES: CppRules: optional_compiler_flag was removed from CROSSTOOL, use features instead. PiperOrigin-RevId: 192277764
* Improve documentation of genquery.Gravatar lberki2018-04-10
| | | | | RELNOTES: None. PiperOrigin-RevId: 192274504
* remote/http: properly complete user promiseGravatar Jakob Buchgraber2018-04-10
| | | | | | | | Fixes #4976, #4935 Closes #4991. PiperOrigin-RevId: 192269206
* python,runfiles: move to different packageGravatar Laszlo Csomor2018-04-10
| | | | | | | | | | | | | | | | | | | | Move the Python runfiles library from `@bazel_tools//tools/runfiles:py-runfiles` to `@bazel_tools//tools/python/runfiles:runfiles` Also rename the testdata runfiles.py to foo.py. This file was not a mock runfiles library, just a client file using the runfiles library that was also called runfiles.py Fixes https://github.com/bazelbuild/bazel/issues/4878 Change-Id: I874b230c93679d4454ac91e816932c8272ecc5c7 Closes #4981. Change-Id: I908e0ab7ec61225e82f70793b1a05432e7f0b07e PiperOrigin-RevId: 192256481
* Delete unused RunProgram function.Gravatar Benjamin Peterson2018-04-10
| | | | | | | Closes #4986. Change-Id: I81bbec801116ec1f45416bba7a724d7f00b9b00c PiperOrigin-RevId: 192253687
* Remove support for the --incompatible_disallow_three_arg_vardef command line ↵Gravatar lberki2018-04-10
| | | | | | | | | option. It was used for a migration, which is now done. RELNOTES: None. PiperOrigin-RevId: 192246659
* Fix Printer.getPrinter(boolean)Gravatar brandjon2018-04-09
| | | | | | | Also rename it to a separate function since boolean args are vague. RELNOTES: None PiperOrigin-RevId: 192201308
* Introduce extraPositonals and extraArguments to SkylarkCallable, to have ↵Gravatar cparsons2018-04-09
| | | | | | | | | parity with @SkylarkSignature. This is necessary for several builtin functions that still use @SkylarkSignature, such as string format. These will be migrated in a future CL. RELNOTES: None. PiperOrigin-RevId: 192200282
* Consume the rest of the response stream for Watch RPC before returning. This ↵Gravatar Googler2018-04-09
| | | | | | | | necessary for the call to close correctly (e.g. for listeners to receive Status/trailers). RELNOTES: PiperOrigin-RevId: 192185329
* Add a ruleError when one version enforcement is requested without the requisiteGravatar Googler2018-04-09
| | | | | | | | | one_version_whitelist attribution on the java_toolchain. Fixes bazelbuild/bazel#4682 RELNOTES: n/a PiperOrigin-RevId: 192181587
* Remove some dead code in SkyDocGravatar cparsons2018-04-09
| | | | | RELNOTES: None. PiperOrigin-RevId: 192178973
* Remove the Blaze strict java deps exemption for Android databinding. Use the ↵Gravatar Googler2018-04-09
| | | | | | JavaBuilder processor exemption list instead of disabling strict deps for the affected rules outright. This narrows the degree to which the exemption is applied, and prevents other strict deps violations from accruing on targets that enable databinding. PiperOrigin-RevId: 192176621
* Also explicitly log the filesystem in ArtifactFactory.validatePathGravatar shahan2018-04-09
| | | | PiperOrigin-RevId: 192167264
* Remove overly optimistic decoupled manifest processingGravatar asteinb2018-04-09
| | | | | | | | | | | | | In earlier changes, I introduced an idealised manifest processing pipeline that has no relation to what's currently being used. Instead, we should start with independent manifest processing that keeps the current behavior. We can migrate to new functionality later, time permitting. Keep some methods that will be the basis for a reasonable decoupled manifest processing implementation. RELNOTES: none PiperOrigin-RevId: 192164028
* Makes the decision to memoize at the SkyValue level.Gravatar shahan2018-04-09
| | | | PiperOrigin-RevId: 192158825
* Deletes KryoGravatar shahan2018-04-09
| | | | PiperOrigin-RevId: 192155942
* Fix Artifact.getPath() call in CppCompileAction.validateInclusionsGravatar shahan2018-04-09
| | | | PiperOrigin-RevId: 192153123
* Fix issue with filtered resourcesGravatar asteinb2018-04-09
| | | | | | | | | Apparently, I was using a flawed strategy to compute the filtered resource root paths. Instead, just recalculate those roots from scratch, replicating the behavior that existed before the change that caused problems. RELNOTES: none PiperOrigin-RevId: 192152306
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-09 08:49:18 +0000