| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87704425
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87698761
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87698104
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rarely, the raceConditionWithNoKeepGoingErrors_InflightError unit test
would timeout because the "errorKey" node's error caused
preventNewEvaluations to be called before the otherKey node started
evaluation. The "otherKey" node's function decrements a CountdownLatch
that the test waits on.
Usually both nodes' functions would start evaluating before
preventNewEvaluations was called, but this wasn't guaranteed.
This change makes the execution of the unit test deterministic. Both
nodes will begin evaluation before either finishes. The "otherErrorKey"
node will wait for "errorKey" to commit before trying to get its value.
The "otherErrorKey" compute function will get called exactly once
because its dependency on "errorKey" will not be registered because
"errorKey" errored first and in nokeep_going mode only the first
erroring node's dependencies are registered.
--
MOS_MIGRATED_REVID=87657504
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87622845
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87621601
|
|
|
|
|
|
|
| |
Change-Id: I83a280d53272972bace811b1493825b5dc48a4d2
--
MOS_MIGRATED_REVID=87608375
|
|
|
|
|
|
|
| |
This is a mock for java compilation. It can be used to do tests using the same configuration as when Bazel invoke javac.
--
MOS_MIGRATED_REVID=87608177
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87597808
|
|
|
|
|
|
|
|
| |
methods available doesn't seem to carry its weight, and this makes it easier
for us to migrate to JUnit 4.
--
MOS_MIGRATED_REVID=87597162
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87596401
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87595869
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87594852
|
|
|
|
|
|
|
|
|
| |
MethodLibraryTest#testEnumerate), it returns a SkylarkList of tuples.
MethodLibrary tests are cleaned up.
--
MOS_MIGRATED_REVID=87592639
|
|
|
|
|
|
|
| |
prefix names for generated protos.
--
MOS_MIGRATED_REVID=87539098
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87535290
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87519507
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87515939
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87513766
|
|
|
|
|
|
|
|
|
|
|
|
| |
legacy feature configuration.
This requires two fixes:
1. we want to mark the module_maps feature unsupported, if the toolchain itself
doesn't provide a module map
2. no legacy feature is allowed to imply the module_maps feature
--
MOS_MIGRATED_REVID=87511295
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This is not needed thanks to blaze query.
*** Original change description ***
Make xctest_app's .ipa an implicit output so that scripts external to Bazel can access it.
--
MOS_MIGRATED_REVID=87507266
|
|
|
|
|
|
|
| |
JavaToolchainDataParser is a parser that reconstruct a JavaToolchainData from the output of a 'bazel query --output=proto'.
--
MOS_MIGRATED_REVID=87502754
|
|
|
|
|
|
|
|
| |
It also caches files that it already processed, since that may legally happen
if there are multiple overlapping directory trees are specified as input.
--
MOS_MIGRATED_REVID=87492930
|
|
|
|
|
|
|
|
|
|
|
| |
Fix race condition in SkylarkType.of(), whereby .equals() but not same (==) types were created, by making Simple.of() synchronized.
Also make SkylarkType#includes() more robust by using .equals() instead of == (it's a little bit slower in the case of Simple types once fixed, but also works on complex types that don't hash-cons their values).
Also, distinguish SkylarkList (printed as list) and java.util.List (printed as List) and similarly for tuple vs Tuple, when printing types in debugging messages.
--
MOS_MIGRATED_REVID=87490176
|
|
|
|
|
|
|
| |
using both the associated Java target label and the binary/test target that generates the compilation action. This fixes a bug in which two binary/test targets containing the same Java target to translate leads to shared actions when users execute more than one such binary/test targets in a single Blaze invocation.
--
MOS_MIGRATED_REVID=87364125
|
|
|
|
|
|
|
| |
This is needed for taking the runfiles prefix from the WORKSPACE file instead of hardcoding it.
--
MOS_MIGRATED_REVID=87347883
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87345558
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87342725
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor SkylarkType, notably adding Union types and runtime typechecks.
These are pre-requisites to unifying all Skylark function calls to use the same
code path, that will check types (like SkylarkFunction currently does) as well
handle a more complete Python calling convention (like MixedModeFunction is
almost but not quite able to do).
A SkylarkType can be either
* a Simple type corresponding to a Java class, with special types TOP and BOTTOM
corresponding respectively to Object and EmptyType (similar to Void).
* a Combination of a generic class (LIST, MAP or SET) and an argument type
* a Union of a finite number of types
* a FunctionType associated with a name and a returnType (with ugly
validation-time side-effects that we should probably move out of the type)
Unions are necessary because:
1- the type of some builtin function arguments are actually the Union of some
type and a function type for a callback that computes the actual value.
2- the type of some builtin function arguments declared as "List" is actually
the Union of java List and SkylarkList.
3- instead of adding lots of special cases at the point of argument validation,
it's cleaner and more generally useful to have explicit Union types, that can
then be displayed to users for documentation or debugging purposes.
Validation-time "type inference" is re-expressed simply as type intersection.
None is treated specially as inferred into TOP instead of NoneType.
Combination types are printed as genericType of argTypes, e.g. "dict of ints". "type" and "generic1" become "genericType" and "argType". In SkylarkList and SkylarkNestedSet, genericType becomes contentType.
--
MOS_MIGRATED_REVID=87340881
|
|
|
|
|
|
|
| |
The default Xlint behaviors is not really practical: -Xlint:all -Xlint:none results in all warnings being enabled. This normalizer preprocesses javac options to achieve a command line that is sensitive to ordering (e.g., -Xlint:all -Xlint:none will results in no warning being enabled).
--
MOS_MIGRATED_REVID=87339357
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87337298
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87335844
|
|
|
|
|
|
|
| |
can be used in their stead.
--
MOS_MIGRATED_REVID=87334648
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87324093
|
|
|
|
|
|
|
|
|
| |
the resulting app.
This adds very basic run support for objc_binary targets. It simply launches them in iossim with the default device and SDK.
--
MOS_MIGRATED_REVID=87286604
|
|
|
|
|
|
|
|
| |
This is left over from the abstract rules refactor where I added this
attribute to objc_import but not actually any code to use it.
--
MOS_MIGRATED_REVID=87284690
|
|
|
|
|
|
|
| |
This is prep for replacing the prefix with one set in the WORKSPACE file.
--
MOS_MIGRATED_REVID=87282470
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87265401
|
|
|
|
|
|
|
|
|
| |
This environment eagerly preloads the transitive closure of a specified query "universe", and so may not be as efficient as the standard query for limited-scope queries. It is activated when the universe is specified and ordered results are not requested (since it is currently unable to order results).
Tests were modified/added to exercise this environment where deemed interesting. Some ugly hacks were done to add coverage in AbstractQueryTest and friends, because currently even if the full depot is loaded (using //...), individual target patterns most likely won't be present in the graph. A better way to deal with this situation, suggested by felly, is probably to extract target pattern resolution logic to an auxiliary function so that query is able to resolve target patterns without mutating the graph, and then call into the read-only graph with the resolved patterns. That may be done in a follow-up, in which case the "scope" of every query could be //... .
--
MOS_MIGRATED_REVID=87257028
|
|
|
|
|
|
|
|
|
|
|
| |
A recent change resulted in TopLevelArtifactHelper.getTopLevelArtifacts()
returning an empty result when passed TopLevelArtifactContext.DEFAULT.
This only happens in tests and wasn't caught because tests were never
fully checking the results. Update MultiGroupForgeResourceAccountantTest
to better consider/expose this failure and fixed.
--
MOS_MIGRATED_REVID=87254923
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87248208
|
|
|
|
|
|
|
| |
TestCase for it.
--
MOS_MIGRATED_REVID=87246613
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87244284
|
|
|
|
|
|
|
|
|
| |
Rewrite some examples that used internal labels to be safe for external
version. Also remove some obsolete parts such as no-longer existent Make
variables.
--
MOS_MIGRATED_REVID=87241538
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87235457
|
|
|
|
|
|
|
| |
exactly one segment.
--
MOS_MIGRATED_REVID=87234901
|
|
|
|
|
|
|
| |
genquery rule get output of a 'bazel query' inside a build.
--
MOS_MIGRATED_REVID=87234590
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=87231498
|
|
|
|
|
|
|
|
| |
It has been obsolesced by the 'javac-suppress-deferred-diagnostics' javac
feature.
--
MOS_MIGRATED_REVID=87212490
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this, its first incarnation this rule provides no new functionality - all
it does is take an objc_binary and perform any bundling the objc_binary
would have done anyhow. This will allow us to remove bundling functionality
from objc_binary and add multi-architecture transitions between ios_application
and objc_binary.
However, I did remove the requirement for the infoplist attribute on bundles. We
don't actually need it (a plist is generated automatically) and this removal
makes the transition much easier.
RELNOTES: Introduce ios_application_rule.
--
MOS_MIGRATED_REVID=87194403
|