aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Roll forward execroot changeGravatar Kristina Chodorow2017-02-16
| | | | | | | | | | | | | | | | | RELNOTES[INC]: Previously, an external repository would be symlinked into the execution root at execroot/local_repo/external/remote_repo. This changes it to be at execroot/remote_repo. This may break genrules/Skylark actions that hardcode execution root paths. If this causes breakages for you, ensure that genrules are using $(location :target) to access files and Skylark rules are using http://bazel.io/docs/skylark/lib/File.html's path, dirname, etc. functions. Custom crosstools that hardcode external/<repo> paths will have to be updated. Issue #1262. -- PiperOrigin-RevId: 147726370 MOS_MIGRATED_REVID=147726370
* Global cleanup change.Gravatar Liam Miller-Cushon2017-02-16
| | | | | | -- PiperOrigin-RevId: 147725849 MOS_MIGRATED_REVID=147725849
* --Gravatar Kristina Chodorow2017-02-16
| | | | | PiperOrigin-RevId: 147725837 MOS_MIGRATED_REVID=147725837
* Rollback of commit 686fde1b1aeb4e5d03dca7446cf39cd9f1114d79.Gravatar Dmitry Lomov2017-02-16
| | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks //src/test/shell/bazel:bazel_sandboxing_cpp_test on all platforms: http://ci.bazel.io/job/bazel-tests/567/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/ *** Original change description *** Disable .d input pruning My fix for input discovery is pending some changes by kchodorow, and this is blocking the next release. Temporary workaround for #2490. -- PiperOrigin-RevId: 147725685 MOS_MIGRATED_REVID=147725685
* Skip computing digests when --use_action_cache=false.Gravatar Googler2017-02-16
| | | | | | | | | | | | | Does this by delegating responsibility for constructing ActionCache.Entry instances to the ActionCache, and having the StubActionCache return null. Tests show a 1-2% elapsed-time reduction for clean builds: [] Doesn't use interface default methods, because we still need JDK7 for Mac. -- PiperOrigin-RevId: 147722062 MOS_MIGRATED_REVID=147722062
* Bazel client, Windows: implement MakeCanonical Gravatar Laszlo Csomor2017-02-16
| | | | | | | | | | See https://github.com/bazelbuild/bazel/issues/2107 -- Change-Id: I27a97881e3e19cbb7913e1248a24e9e631bc4f40 Reviewed-on: https://cr.bazel.build/8951 PiperOrigin-RevId: 147719277 MOS_MIGRATED_REVID=147719277
* Remove an unused throws clause, and make one more specificGravatar Ulf Adams2017-02-16
| | | | | | -- PiperOrigin-RevId: 147716435 MOS_MIGRATED_REVID=147716435
* Bazel client, Windows: implement ConvertPath Gravatar Laszlo Csomor2017-02-16
| | | | | | | | | | See https://github.com/bazelbuild/bazel/issues/2107 -- Change-Id: I7a325521f52bc4027b55df5451f549ac737242f8 Reviewed-on: https://cr.bazel.build/8953 PiperOrigin-RevId: 147715340 MOS_MIGRATED_REVID=147715340
* Clarify that package() comes after load()Gravatar Laurent Le Brun2017-02-16
| | | | | | -- PiperOrigin-RevId: 147714630 MOS_MIGRATED_REVID=147714630
* Activate the "dbg", "fastbuild", and "opt" features in the objc CROSSTOOL.Gravatar Googler2017-02-16
| | | | | | | | RELNOTES: Activate the "dbg", "fastbuild", and "opt" features in the objc CROSSTOOL. -- PiperOrigin-RevId: 147714395 MOS_MIGRATED_REVID=147714395
* Minor code cleanupGravatar Laurent Le Brun2017-02-16
| | | | | | | | Inlining the function makes the code more readable. -- PiperOrigin-RevId: 147711468 MOS_MIGRATED_REVID=147711468
* Disallow comparison of objects of different types in SkylarkGravatar Vladimir Moskva2017-02-16
| | | | | | | | | | RELNOTES[INC]: It's not allowed anymore to compare objects of different types (i.e. a string to an integer) and objects for which comparison rules are not defined (i.e. a dict to another dict) using order operators. -- PiperOrigin-RevId: 147710942 MOS_MIGRATED_REVID=147710942
* Ensure test results are also reported for cached test Gravatar Klaus Aehlig2017-02-16
| | | | | | | | | | | When a test is not run, because it was cached, we still expect the test to be reported and to find a test log reported in the build-event protocol. -- Change-Id: I806c757cdf8f46a5b687d29dec31ad4a289c4097 Reviewed-on: https://cr.bazel.build/8931 PiperOrigin-RevId: 147710591 MOS_MIGRATED_REVID=147710591
* Disable .d input pruningGravatar Ulf Adams2017-02-16
| | | | | | | | | | | My fix for input discovery is pending some changes by kchodorow, and this is blocking the next release. Temporary workaround for #2490. -- PiperOrigin-RevId: 147707001 MOS_MIGRATED_REVID=147707001
* Don't prefix the -l option with -force_load. It doesn't work and whole ↵Gravatar Lukacs Berki2017-02-16
| | | | | | | | | | archive linking of dynamic libraries doesn't make sense anyway. Fixes #2526 . -- PiperOrigin-RevId: 147693898 MOS_MIGRATED_REVID=147693898
* Make RuleClass non-final for testing.Gravatar Janak Ramakrishnan2017-02-16
| | | | | | -- PiperOrigin-RevId: 147656856 MOS_MIGRATED_REVID=147656856
* Fix a hypothetical issue with 'buildfiles' and 'loadfiles' with duplicate ↵Gravatar Nathan Harmata2017-02-16
| | | | | | | | | | | | | | | | | | targets. These two functions don't use a Uniquifier internally so if the same bzl file foo.bzl is loaded multiple ways in 'e' in 'loadfiles(e)' then 'f' in 'f(loadfiles(e))' will observe foo.bzl multiple times. This isn't observable in practice (i.e. I cannot write a black-box query test that would fail without this CL) because: (1) BlazeQueryEnvironment#eval(QueryExpression, VariableContext<Target>, Callback<Target>) uses an intermediate aggregating callback and thus doesn't use the streaming query evaluation model. This means that the internal deduping in BlazeQueryEnvironment#getBuildFiles is sufficient. (2) SkyQueryEnvironment uses an outer BatchStreamedCallback which internally uses a Uniquifier. Still, this CL is useful for SkyQuery because without we're doing wasted work (e.g. in my example above, 'f' will wastefully do duplicate work with the .bzl files from the inner loadfiles(e)) because the deduping happens on the final query result, not on the intermediate result from 'buildfiles'/'loadfiles'. For 'buildfiles', there's an additional wart with (1) above because FakeSubincludeTarget doesn't override Object#equals/hashCode. -- PiperOrigin-RevId: 147656183 MOS_MIGRATED_REVID=147656183
* Uniquify lambda body instance methods during lambda desugaring for androidGravatar Googler2017-02-16
| | | | | | -- PiperOrigin-RevId: 147637498 MOS_MIGRATED_REVID=147637498
* Don't manually set output jar timestampGravatar Googler2017-02-16
| | | | | | | | Setting the output jar timestamp to match the input jar confuses timestamp based build systems, and is unnecessary for bazel. -- PiperOrigin-RevId: 147621642 MOS_MIGRATED_REVID=147621642
* Give a more helpful error message on malformed regexes.Gravatar Nathan Harmata2017-02-16
| | | | | | -- PiperOrigin-RevId: 147621296 MOS_MIGRATED_REVID=147621296
* Revert "Add javac-9-dev-r3297-3"Gravatar Damien Martin-Guillerez2017-02-16
| | | | | | | This reverts commit efe4a6d889d6a6f563a1d492530f13351ce4eef7. This commit broke several downstream project with a bug in the Java compiler, see http://ci.bazel.io/job/intellij-clion/78/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/console
* Add javac-9-dev-r3297-3Gravatar Liam Miller-Cushon2017-02-16
| | | | | | https://github.com/google/error-prone-javac/archive/9-dev-r3297-3.zip Change-Id: I173e50f92f93009270c84ba90916e2696501f4de
* Bazel client: refactors, small bugfixes Gravatar Laszlo Csomor2017-02-15
| | | | | | | | | | | | | | | | | | | In this change: * Fix pdie and PrintError to acquire the last error string as the first thing the method does, otherwise we may display an error coming from pdie's/PrintError's own logic * Auto-close file handles in file_test in order to avoid leaking them in case an assertion fails (which means an early return from the function) -- Change-Id: Ia4392b42cbc93b931dcee76993db0ad264d0c147 Reviewed-on: https://cr.bazel.build/8932 PiperOrigin-RevId: 147610527 MOS_MIGRATED_REVID=147610527
* Add dependency on environment variable for android_{n,s}dk_repository Gravatar Damien Martin-Guillerez2017-02-15
| | | | | | | | | | | | | This adds the skyframe edge to invalidate the repository every time the enviroment variable change. Fixes #746. -- Change-Id: I0653bc759dbddb1a98f5e03d0eb3f92e1803e31b Reviewed-on: https://cr.bazel.build/8224 PiperOrigin-RevId: 147600103 MOS_MIGRATED_REVID=147600103
* Generate documentation for bool and int types.Gravatar Laurent Le Brun2017-02-15
| | | | | | | | | This improves consistency in the documentation (string and list already have their own page). -- PiperOrigin-RevId: 147599068 MOS_MIGRATED_REVID=147599068
* Windows: use JNI CreateJunction in Java code Gravatar Laszlo Csomor2017-02-15
| | | | | | | | | | | | | | | | Use the new CreateJunction in the Windows JNI code every time we need to create junctions. This means updating WindowsFileOperations and related tests. Add test for WindowsFileSystem.createSymbolicLink. See https://github.com/bazelbuild/bazel/issues/2238 -- Change-Id: I5827e2e70e8e147f5f102fabf95fa9a148b3bcdc Reviewed-on: https://cr.bazel.build/8896 PiperOrigin-RevId: 147598107 MOS_MIGRATED_REVID=147598107
* Bazel client, Windows, tests: use CreateJuction Gravatar Laszlo Csomor2017-02-15
| | | | | | | | | | | | | Use the JNI library's CreateJuction in file_windows_test. See https://github.com/bazelbuild/bazel/issues/2107 -- Change-Id: I4ef1536d43691fe7a2ae3ee457064d4e8f4ac6d7 Reviewed-on: https://cr.bazel.build/8895 PiperOrigin-RevId: 147594365 MOS_MIGRATED_REVID=147594365
* Bazel client, Windows, tests: remove cleanup code Gravatar Laszlo Csomor2017-02-15
| | | | | | | | | | | | | The TearDown method clears up after tests, so manual cleanup is unnecessary. See https://github.com/bazelbuild/bazel/issues/2107 -- Change-Id: Idf5d2b2bf012774171f1868d1341a7952015c35f Reviewed-on: https://cr.bazel.build/8894 PiperOrigin-RevId: 147591032 MOS_MIGRATED_REVID=147591032
* Bump up the time we are willing to wait for gRPC to start up in GrpcServerTests.Gravatar Lukacs Berki2017-02-15
| | | | | | | | Our Jenkins slaves are apparently slower than our workstations, thus, they are timeout-flaky. -- PiperOrigin-RevId: 147590913 MOS_MIGRATED_REVID=147590913
* Remove special-casing of the 'native' module.Gravatar Laurent Le Brun2017-02-15
| | | | | | | | | It should show up in the documentation in the same way as 'attr', another builtin module. -- PiperOrigin-RevId: 147589912 MOS_MIGRATED_REVID=147589912
* Fix a bug in parsing .afdo.imports files whereupon Blaze would crash if a ↵Gravatar Lukacs Berki2017-02-15
| | | | | | | | line in that file wasn't empty but also didn't contain a colon. -- PiperOrigin-RevId: 147589431 MOS_MIGRATED_REVID=147589431
* Bazel client, Windows: use CreateJunction Gravatar Laszlo Csomor2017-02-15
| | | | | | | | | | | | | Use the JNI library's CreateJunction function in blaze_util_windows, and delete the old code. See https://github.com/bazelbuild/bazel/issues/2107 -- Change-Id: I1cb027a7c7ceb559e590e89e93f9022607fc0cd5 Reviewed-on: https://cr.bazel.build/8893 PiperOrigin-RevId: 147587975 MOS_MIGRATED_REVID=147587975
* Rollback of commit d8eec343d238129ce8b5146c4177d207a6b3683b.Gravatar Dmitry Lomov2017-02-15
| | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** These tests break on Mac: http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=darwin-x86_64/561/console E.g.: ERROR: /Users/ci/workspace/bazel-tests/BAZEL_VERSION/HEAD/PLATFORM_NAME/darwin-x86_64/src/java_tools/junitrunner/javatests/com/google/testing/junit/runner/BUILD:64:1: Couldn't build file src/java_tools/junitrunner/javatests/com/google/testing/junit/runner/junit4_testbridge_integration_test.runfiles/MANIFEST: Creating runfiles tree bazel-out/local-fastbuild/bin/src/java_tools/junitrunner/javatests/com/google/testing/junit/runner/junit4_testbridge_integration_test.runfiles failed: build-runfiles failed: error executing command (cd /private/var/tmp/_bazel_ci/663aef0b024d9552f81e09f650e1ea55/execroot/darwin-x86_64 && \ exec env - \ PATH=/Users/ci/workspace/bazel-tests/BAZEL_VERSION/HEAD/PLATFORM_NAME/darwin-x86_64/.bin:/usr/bin:/bin:/usr/sbin:/sbin \ TMPDIR=/var/folders/3[]pdj48r577v5qqr3dqn58xq40000gn/T/ \ /private/var/tmp/_bazel_ci/663aef0b024d9552f81e09f650e1ea55/execroot/darwin-x86_64/_bin/build-runfiles bazel-out/local-fastbuild/bin/src/java_tools/junitrunner/javatests/com/google/testing/junit/runner/junit4_testbridge_integration_test.runfiles_manifest bazel-out/local-fastbuild/bin/src/java_tools/junitrunner/javatests/com/google/testing/junit/runner/junit4_testbridge_integration_test.runfiles) *** Original change description *** Open source the integration tests for BazelTestRunner and delete the internal versions. -- PiperOrigin-RevId: 147587929 MOS_MIGRATED_REVID=147587929
* Bazel client, JNI, Windows: impl. CreateJunction Gravatar Laszlo Csomor2017-02-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | Implement a CreateJunction function in the Windows JNI library. Also move a bit of code from file_windows to the JNI library, where it is (also) needed. This implementation is an improved version of `blaze_util::SymlinkDirectories` in blaze_util_windows: this version handles Windows paths as `name` and `target`, and performs more validation (e.g. on the length of `target`), plus has more comments explaining the logic. In a subsequent change I'll start using this new function in blaze_util_windows. This method will also be helpful in tests: we will no longer have to shell out to mklink. See https://github.com/bazelbuild/bazel/issues/2107 -- Change-Id: I7e9b085fdc2ba47be83da5319bded02bd323e71b Reviewed-on: https://cr.bazel.build/8892 PiperOrigin-RevId: 147585207 MOS_MIGRATED_REVID=147585207
* Early support for code generation directly from C++ module files. This canGravatar Googler2017-02-15
| | | | | | | | | | | | potentially reduce the linker input. The content of a C++ module (specifically the inline definitions) is currently put into every single .o file that uses them and thus can be input to the same final link many times. By generating a separate .o file for the module itself, we can avoid this unnecessary duplication of linker input. -- PiperOrigin-RevId: 147579947 MOS_MIGRATED_REVID=147579947
* Skylark repositories: add FileValue hash codes to the marker file Gravatar Damien Martin-Guillerez2017-02-15
| | | | | | | | | | | | | | So that change to those files are seen and cause a refetch. Design doc: https://bazel.build/designs/2016/10/18/repository-invalidation.html [step 5] Fixes #1022. -- Change-Id: Ic75f2c9c59a4c91ff3e937ca21b37e74332c03ec Reviewed-on: https://cr.bazel.build/8218 PiperOrigin-RevId: 147574856 MOS_MIGRATED_REVID=147574856
* Rollback of commit 1893c21f9f04acff4a3cc5cd20ddbf9fe89ae59a.Gravatar Yue Gan2017-02-15
| | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Fix CI build *** Original change description *** Automated [] rollback of commit 01aa7d6f177f3284b5fecc0397bf29a605b37df0. *** Reason for rollback *** Breaks the CI: http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=linux-x86_64/1270/console *** Original change description *** Adds support for pushing sites that don't need build, and build benchmark site. This should not affect CI for now. -- PiperOrigin-RevId: 147572787 MOS_MIGRATED_REVID=147572787
* Loosen visibility of ASTFileLookupValue.Gravatar Janak Ramakrishnan2017-02-15
| | | | | | -- PiperOrigin-RevId: 147559691 MOS_MIGRATED_REVID=147559691
* CrosstoolCompilationSupport can be used for multi-arch binaries by allowing ↵Gravatar Cal Peyser2017-02-15
| | | | | | | | | | | | | | | | | a configuration to be passed into the cc backend and used to scope output artifacts. Artifacts involved: (1) Object files: see change in CppHelper, CppModel, CppCompileActionBuilder (2) Archive files: see change in CppModel (3) Archive objfile list: see change in ObjcVariablesExtension. Other little things that needed to be cleaned up to enable this: (1) neverlink set on objc archive actions. Without neverlink, colliding solib artifacts are generated from the two archives arising from the multi-arch split. (2) Toolchain selection in CrosstoolCompilationSupport uses passed-in configuration instead of :cc_toolchain attribute. This allows for each of the compiles spawned from apple_binary.srcs to select the correct toolchain based on the child configuration. -- PiperOrigin-RevId: 147550618 MOS_MIGRATED_REVID=147550618
* Restrict aspects visible to other aspects according to their advertised ↵Gravatar Dmitry Lomov2017-02-15
| | | | | | | | providers. -- PiperOrigin-RevId: 147526961 MOS_MIGRATED_REVID=147526961
* Clarify documentation of PACKAGE_NAMEGravatar Laurent Le Brun2017-02-15
| | | | | | -- PiperOrigin-RevId: 147517743 MOS_MIGRATED_REVID=147517743
* Correct support for TreeArtifacts with ObjC header thinning feature.Gravatar Googler2017-02-15
| | | | | | -- PiperOrigin-RevId: 147515806 MOS_MIGRATED_REVID=147515806
* Remove type checking requirement from AttributeMap.has.Gravatar Greg Estren2017-02-15
| | | | | | | | | | | | | | This overrides the traditional has(String name, Type<>T> type) with has(String name) and removes the type check outright from isConfigurable. Ideally we'd remove the old version in this same change. But there are enough uses of it that that's not a risk-free change and is safer as followup changes. -- PiperOrigin-RevId: 147513593 MOS_MIGRATED_REVID=147513593
* Rollback of commit 03d1255df1805ed1e5f7512bf0336f71c595791b.Gravatar Googler2017-02-15
| | | | | | | | | | *** Reason for rollback *** Vanilla roll forward -- PiperOrigin-RevId: 147512649 MOS_MIGRATED_REVID=147512649
* Avoid putting objc linkopts and copts in Set, as their order and ↵Gravatar Chris Parsons2017-02-15
| | | | | | | | | | duplicate-args need to be preserved. (Example: "-iquote foo -iquote bar" is a legitimate series of flags) -- PiperOrigin-RevId: 147512419 MOS_MIGRATED_REVID=147512419
* Some minor logging improvements related to diff awareness:Gravatar Nathan Harmata2017-02-15
| | | | | | | | | | | | (i) Log [the first 100] external [non external-repo] file paths when we encounter them in skyframe [when externalFileAction is not ASSUME_NON_EXISTENT_AND_IMMUTABLE_FOR_EXTERNAL_PATHS]. These caveats are to prevent log spam. (ii) Fix grammar when logging the results of handleDiffsWithMissingDiffInformation in the case when all package paths have known diff information and we're merely checking external/output/external-repo files. (iii) Log the purpose of each skyframe graph scan we do (see (ii)). -- PiperOrigin-RevId: 147508404 MOS_MIGRATED_REVID=147508404
* Flips the default value of --explicit_jre_deps to true.Gravatar Googler2017-02-15
| | | | | | | | RELNOTES: Flips --explicit_jre_deps flag on by default. -- PiperOrigin-RevId: 147497803 MOS_MIGRATED_REVID=147497803
* BuildFileAST.eval() doesn't execute the code when there's a static error.Gravatar Laurent Le Brun2017-02-15
| | | | | | | | | | | This has no visible effect on Bazel (eval is used just for internal expressions that don't fail), and is therefore not tested. It will be tested when we add tests to the standalone Skylark interpreter. -- PiperOrigin-RevId: 147495990 MOS_MIGRATED_REVID=147495990
* Adds --[no]use_action_cache startup option to disable the action cache.Gravatar Googler2017-02-15
| | | | | | | | | Disabling the action cache is helpful in contexts where incremental builds are not required, or where actions need to be repeatedly executed for debugging. -- PiperOrigin-RevId: 147485055 MOS_MIGRATED_REVID=147485055
* Search for Test classes within the classpath used by the current ↵Gravatar Kush Chakraborty2017-02-15
| | | | | | | | | | | | classloader, instead of the system classpath. (2nd Attempt) Windows tests passed on Jenkins with this patch: http://ci.bazel.io/job/Gerrit-bazel-tests/380/, https://bazel-review.googlesource.com/c/8833 -- PiperOrigin-RevId: 147483103 MOS_MIGRATED_REVID=147483103
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 09:44:06 +0000