| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
Very large server instances can take >10 seconds for GC, and if they are hit at an inopportune moment, they may get killed needlessly.
RELNOTES: None.
PiperOrigin-RevId: 169905185
|
|
|
|
|
|
|
| |
Some of the arguments are not used or are always passed blank.
RELNOTES: None.
PiperOrigin-RevId: 169899161
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding
https://github.com/bazelbuild/bazel/commit/17214ac78ffaec369d5d5bafe62a39730473cfaa
with fixes to 'repository_ctx.download()' and
'repository_ctx.download_and_extract()'.
I reviewed other usages of @ParamType annotation - I do not think there
are more issues.
Fixes #3714.
Change-Id: I17087ef3fc2d28ab99224740a2164675a49847d3
PiperOrigin-RevId: 169896223
|
|
|
|
|
|
|
| |
All callers passed true, so there's no need to have the boolean there.
RELNOTES: None.
PiperOrigin-RevId: 169888322
|
|
|
|
|
|
|
|
| |
In https://github.com/bazelbuild/bazel/commit/b7a9ecd08c958e9513ea234b470a0f86e89e1acd I introduced a bug when linkstamping outputs would no longer be
stored in $TEST_TMPDIR. This cl fixes that.
RELNOTES: None.
PiperOrigin-RevId: 169882831
|
|
|
|
| |
PiperOrigin-RevId: 169874059
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 169792510
|
|
|
|
|
|
|
|
|
|
|
| |
In Skylark.java, fix line numbers to start at 1 instead of 2.
In Eval.java, go through maybeTransformException for consistency with expressions, even though no statement nodes use this feature.
In EvalExceptionWithStackTrace, fix style violation (non-consecutive overloads) and add TODO explaining an open issue.
RELNOTES: None
PiperOrigin-RevId: 169769928
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 169753517
|
|
|
|
|
|
| |
that were public because of skylark compilation.
PiperOrigin-RevId: 169739373
|
|
|
|
|
|
|
|
| |
remove all "precomputed values for analysis" from SkyframeExecutor. We use SkyframeExecutor#injectExtraPrecomputedValues these days.
This simplifies logic around when to inject precomputed values, and makes the graph more consistent.
PiperOrigin-RevId: 169733304
|
|
|
|
| |
PiperOrigin-RevId: 169728184
|
|
|
|
|
|
|
| |
nested.
RELNOTES: None
PiperOrigin-RevId: 169723791
|
|
|
|
| |
PiperOrigin-RevId: 169723724
|
|
|
|
|
|
|
|
|
| |
The test was not incorrect before, however it was unfortunate that we were both
expecting an AssertionError and also throwing an AssertionError to signal that
no AssertionError was thrown.
RELNOTES: None
PiperOrigin-RevId: 169721076
|
|
|
|
|
|
|
|
|
| |
and apple_static_library in objc unit tests.
These attributes are deprecated and being removed.
RELNOTES: None.
PiperOrigin-RevId: 169720318
|
|
|
|
|
|
|
|
| |
injected directly, which makes sense, because it's immutable over the lifetime of the server.
Step 3.
PiperOrigin-RevId: 169717587
|
|
|
|
|
|
| |
regarding the integrity of the structure to various operations.
PiperOrigin-RevId: 169715233
|
|
|
|
|
|
|
|
| |
of depending on a precomputed value. BlazeDirectories don't change over the lifetime of the Blaze server, and certainly not over the lifetime of a SkyframeExecutor instance, which already had a reference to them.
Step 2.
PiperOrigin-RevId: 169711443
|
|
|
|
|
|
|
|
| |
depending on a precomputed value. BlazeDirectories don't change over the lifetime of the Blaze server, and certainly not over the lifetime of a SkyframeExecutor instance, which already had a reference to them.
The goal is getting rid of the precomputed value entirely, but since this change necessitated a fair number of testing changes, I'm mailing this out as a first step.
PiperOrigin-RevId: 169705474
|
|
|
|
|
|
|
|
|
|
| |
"AndroidManifest.xml".
aapt requires the manifest to be named "AndroidManifest.xml" (unknown commit)
This allows users to provide manifests with custom names.
RELNOTES: Android rules no longer restrict the manifest file to be named "AndroidManifest.xml".
PiperOrigin-RevId: 169695062
|
|
|
|
|
|
|
| |
and apple_static_library no longer propagate ObjcProvider.
RELNOTES: None.
PiperOrigin-RevId: 169690934
|
|
|
|
|
|
|
| |
Tested manually (with a test that doesn't emit undeclared outputs), and added a test that failed before and passes after the test-setup.sh change.
RELNOTES: N/A
PiperOrigin-RevId: 169687782
|
|
|
|
|
|
|
|
|
| |
Before, linkstamping compile actions were hardcoded in bazel and assumed
gcc/clang and bash. This cl removes gcc/clang assumptions by using feature
configuration.
RELNOTES: None.
PiperOrigin-RevId: 169685949
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 169676866
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolled back commit enforces stricter parameter checks. Will fix and roll forward
This creates several failures on the nightly build of Bazel:
ERROR: /home/ci/workspace/Global/rules_closure-node=linux-x86_64/closure/protobuf/test/BUILD:23:1: no such package '@com_google_protobuf_protoc//': Cannot convert parameter 'url' to type string or sequence of strings, in method download_and_extract(List, string, string, string, string) of 'repository_ctx' and referenced by '//closure/protobuf/test:example_proto_gen'.
ERROR: Analysis of target '//closure/protobuf/test:example_lib' failed; build aborted: no such package '@com_google_protobuf_protoc//': Cannot convert parameter 'url' to type string or sequence of strings, in method download_and_extract(List, string, string, string, string) of 'repository_ctx'.
*** Original change description ***
Check parameter types for methods when multiple types are allowed.
Fixes #3714
RELNOTES: None.
PiperOrigin-RevId: 169669802
|
|
|
|
|
|
|
|
|
|
|
| |
When a timeout occurred, the current test case is interrupted and the others are cancelled. This was not reflected in any way and all tests were reported as success, even if there was a timeout and the tests were cancelled/interrupted.
Also add a status xml attribute to mark if the test was completed, cancelled or interrupted.
Fixes #3763
RELNOTES: None.
PiperOrigin-RevId: 169665622
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The legacy docker_build was removed from bazel_tools
but we need to use it for our integration test so refer
to the one in the main repository.
Also restore the visibility, just excluding it from
bazel_tools is enough and docker_pull needs to call it
from other repository.
Change-Id: I8a8a5781859960030ae996db95fbaf9c54ec596a
PiperOrigin-RevId: 169664916
|
|
|
|
|
|
|
| |
build.lib.actions.SpawnActionContext can import SpawnResult without creating a cyclic dependency.
RELNOTES: None.
PiperOrigin-RevId: 169642267
|
|
|
|
| |
PiperOrigin-RevId: 169631693
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 169624979
|
|
|
|
|
|
|
| |
Introduces the ResourcesZip class to more easily handle processing merged resources.
RELNOTES: None
PiperOrigin-RevId: 169622715
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 169582778
|
|
|
|
|
|
| |
multiple constraint_values from the same constraint_setting (re: #350)
PiperOrigin-RevId: 169577576
|
| |
|
|
|
|
| |
PiperOrigin-RevId: 169563077
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
executions and tests with multiple attempts. Previously, non-cached test execution would incorrectly only include test.log and test.xml.
Implement this by unifying test output list building in a static TestResult method.
For additional output files in multi-attempt tests, we follow the existing convention:
Existing example: test.xml => test_attempts/attempt_N.xml
New example (all new outputs done similarly): test.outputs/outputs.zip => test_attempts/attempt_N.outputs/outputs.zip
RELNOTES: All test output files included for cached, uncached, and multiple attempt tests.
PiperOrigin-RevId: 169556608
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/3742
Change-Id: Ibfa1909e387e9734040b00523cc9388a386e0bf4
PiperOrigin-RevId: 169538023
|
|
|
|
|
|
|
|
|
|
| |
The tests have become large so that the default 5 minutes timeout is no longer
enough for them. At the same point it doesn't look that the test requires more
resources, just a longer timeout.
Fixes #3774
PiperOrigin-RevId: 169532333
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 169518230
|
|
|
|
|
|
|
|
|
| |
A single instance of an option has a single origin, but the final value only has a single origin if it has a single value. For multi-valued options, it is wrong to expect that the final value of an option will have a single parent. Track the option parents (which option expanded to the current instance, if any) in the right place, with the ParsedOptionDescription.
Also fix some inconsistent spelling of 'dependent,' in favor of the American English standard.
RELNOTES: None.
PiperOrigin-RevId: 169487515
|
|
|
|
|
|
|
| |
In order to discourage new uses (there shouldn't be any, but just in case), make it illegal to set wrapperOption=true for non deprecated options.
RELNOTES: None.
PiperOrigin-RevId: 169477990
|
|
|
|
|
|
|
| |
Regardless of option type, have the OptionValueDescription track information about the parsed option. This does not yet change the values that we output as part of the GotOptionsEvent, as the expansion, implicit req, and wrapper options still don't actually track anything in their option value.
RELNOTES: None.
PiperOrigin-RevId: 169469793
|
|
|
|
|
|
|
|
|
| |
Options that expand to other options are expansion options and the options they expand to have values that were expansions. This can be a bit confusing. Removes the isExpansion() call that is somewhat ambiguous, and forces option users to explicitly check the option definition for this information.
Also provide a parallel boolean function for implicit requirements, so that we stop querying for the length of the implicit requirement all over the place.
RELNOTES: None.
PiperOrigin-RevId: 169461566
|
|
|
|
|
|
| |
This is on the way to making select() work with constraint_values re: #305.
PiperOrigin-RevId: 169454982
|
|
|
|
|
|
| |
Part of the effort to simplify ConfiguredTargetFunction.
PiperOrigin-RevId: 169453435
|
|
|
|
|
|
|
| |
formats specified in ParameterFile.ParameterFileType. Also maintain the currently used parsing style of whitespace split arguments that allows single and double quoting and whitespace and quote escaping. This style of parsing is for a format not currently generated and will be removed once all consuming actions have been converted to using a supported format explicitly.
RELNOTES: None.
PiperOrigin-RevId: 169437362
|
|
|
|
|
|
|
|
|
|
| |
For the time being, all C++ links will provide ObjC core libraries on the command line,
via having the link actions imply 'contains_objc_sources', which is a built-in feature
that is in the process of being enabled automatically when objective-C/C++ sources
are involved in the build. Once that happens, the 'imply' directives will be removed.
RELNOTES: Stop using --undefined dynamic_lookup in Apple links. Enables unresolved symbol errors.
PiperOrigin-RevId: 169437020
|
|
|
|
|
|
|
|
| |
configsetting rule class. This is a step in the process of integrating platforms with selects and works towards fixing #350.
Also allow the host platform to be empty/nullable to support clients without access to its default settings.
PiperOrigin-RevId: 169436155
|
|
|
|
|
|
|
|
| |
There's no need for it in the core configuration options, as it's used
exclusively by Python rules.
RELNOTES: None.
PiperOrigin-RevId: 169435643
|