| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134537085
|
|
|
|
|
|
|
|
|
|
|
| |
My previous change carefully checked that the file was a symlink before
removing it and added a test with local repositories... and it of course isn't
a symlink with downloaded repositories and crashes.
Fixes #1697.
--
MOS_MIGRATED_REVID=134536130
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update `select` statements in BUILD files with the
new config_setting.
This is a first step on a long path that leads to
us being able to compile bazel on Windows with
--cpu=x64_windows_msvc. Needless to say, we're not
there yet.
Tested: on Linux, Darwin, Windows/MSYS
--
MOS_MIGRATED_REVID=134534613
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, a non-trivial real-world build was measured to have about 20% analysis time overhead. After, that's theoretically down to 2.4%. But that's only the analysis phase, so the impact on full builds is smaller. And the impact on analysis-cached builds is zero. And practical tests show no obvious difference (JProfiler is probably overstating the impact since it excludes known heavyweight methods).
The improvements, in short:
- Optimize a sanity check that expects each <Attribute, Label> pair to only have one transition. This alone was over half the original performance penalty.
- Simplify logic for null configuration deps (of which there are many, e.g.: all source files)
- Skip a check for required fragments not available in the configuration. This is irrelevant for notrim mode.
There are still some places we could optimize. Dependency.withNullConfiguration in particular takes measurable time (I think from being constructed all the time and in its hashCode calls). But this doesn't seem pressing given the new numbers.
--
MOS_MIGRATED_REVID=134533452
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Throw an error if Bash-on-Windows is found instead of MSYS bash
2. Introduce BAZEL_VS environment variable
3. Output more information
Fix https://github.com/bazelbuild/bazel/issues/1847
--
Change-Id: Ic4571c6c792d9b81df4cd800b8f19d121cc44c33
Reviewed-on: https://bazel-review.googlesource.com/#/c/6330
MOS_MIGRATED_REVID=134531295
|
|
|
|
|
|
|
|
|
| |
empty, writable directory at a specified path when running actions. (Supported on Linux only for now.)
RELNOTES: Added a new flag --sandbox_tmpfs_path, which asks the sandbox to mount an empty, writable directory at a specified path when running actions. (Supported on Linux only for now.)
--
MOS_MIGRATED_REVID=134526345
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134523222
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel in the will provide a machine-readable stream of important build
events. These interfaces set up the framework and expectations about
the produced events and the entities distributing those events.
--
Change-Id: If2c3b2e11c31b0136b57eadeef2d2f8f8fe5e2e7
Reviewed-on: https://bazel-review.googlesource.com/#/c/6272
MOS_MIGRATED_REVID=134522369
|
|
|
|
|
|
|
|
|
| |
command line labels" sanity check.
It's only used for --libc_top and makes configuration creation much more heavyweight that it would otherwise be.
--
MOS_MIGRATED_REVID=134513058
|
|
|
|
|
|
|
|
|
|
|
|
| |
The access() check in the do-while loop is basically doing the same thing
that the InWorkspace() function provides. So lets just call that function
instead. It also has the effect of making the code easier to read and
understand.
--
Change-Id: I02495775a9c9aa262396261824359538ca650e36
Reviewed-on: https://bazel-review.googlesource.com/#/c/6230
MOS_MIGRATED_REVID=134509465
|
|
|
|
|
|
|
|
|
|
| |
Since commit 94d905836c167a21d2321d26c646fde07f5fc522 we no longer need JNI for WindowsFileSystem.isJunction.
This is a partial rollback of commit 4a249b6962d32ed4cfd4165dfdae4a555b00bb69.
Affects https://github.com/bazelbuild/bazel/issues/1680
--
MOS_MIGRATED_REVID=134506403
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of a SkylarkCallable.
CL already reviewed in commit 5972bee6ebfa53cf165befab9fa7962e19d5f620.
Rolled back due to casting error in Java 1.7. This is fixed now:
https://github.com/bazelbuild/bazel/issues/1832
Old:
matchingMethod =
new Pair<>(
method, argumentListConversionResult.getArguments());
New:
matchingMethod =
new Pair<MethodDescriptor, List<Object>>(
method, argumentListConversionResult.getArguments());
--
MOS_MIGRATED_REVID=134503884
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134499729
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134486526
|
|
|
|
|
|
|
|
| |
It's possible that there are multiple outstanding interrupts. When this
happens avoid interleaving their stack traces.
--
MOS_MIGRATED_REVID=134477540
|
|
|
|
|
|
|
| |
artifacts from AndroidSemantics.
--
MOS_MIGRATED_REVID=134475699
|
|
|
|
|
|
|
|
|
| |
action sees a different shared action that is in the midst of being an action cache hit.
Concretely, suppose that the user builds A, then requests C and D. C depends on A, D depends on B, which is a shared action with A. If B executes at just the right time, as C is finishing execution, C can think that it must add itself to B's execution path, which is incorrect.
--
MOS_MIGRATED_REVID=134475095
|
|
|
|
|
|
|
| |
in android_* targets (behind existing flag).
--
MOS_MIGRATED_REVID=134453743
|
|
|
|
|
|
|
| |
false.
--
MOS_MIGRATED_REVID=134452391
|
|
|
|
|
|
|
|
|
| |
This entails adding a read-locking mechanism to Mutability contexts.
RELNOTES[INC]: Updating list/dicts while they are being looped over is not allowed. Use an explicit copy if needed ("for x in list(mylist):").
--
MOS_MIGRATED_REVID=134442701
|
|
|
|
|
|
|
|
|
|
| |
Of course, the sources of the buildevent protos should be visible by
the including srcs targets.
--
Change-Id: I76f5155990dd767d5eb46ad7150980589050217e
Reviewed-on: https://bazel-review.googlesource.com/#/c/6290
MOS_MIGRATED_REVID=134414797
|
|
|
|
|
|
|
|
|
|
| |
EvaluationProgressReceiver objects have two common naming schemes
currently, and calling them invalidationReceiver is misleading, so to
make the naming convention standard, all object names are based on
"progressReceiver."
--
MOS_MIGRATED_REVID=134411011
|
|
|
|
|
|
|
| |
protos from linking into the final binary.
--
MOS_MIGRATED_REVID=134409481
|
|
|
|
|
|
|
|
|
| |
PackageCacheOptions as a bundle.
This will allow me to thread a new flag through more easily in the future.
--
MOS_MIGRATED_REVID=134406676
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the basic protocol buffers needed for an event stream. This will
eventually become a public interface, but is not complete yet. In
particular, users should expect it to be extended over time and handle
the following kind of changes should gracefully.
- New fields can be added to any protocol buffer, and
- new choices of event protocol buffers can be added to the payload.
--
Change-Id: Ie4d1fdaa4f1aec6c5002ad94da4ef14112f8303f
Reviewed-on: https://bazel-review.googlesource.com/#/c/6271
MOS_MIGRATED_REVID=134405277
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134403060
|
|
|
|
|
|
|
| |
As suggested by klimek in the review (I had already submitted at that point). I confirmed that this test fails if I undo commit 78b9cab45de2a32158cd4306cd40208045cf6f85.
--
MOS_MIGRATED_REVID=134400910
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134378592
|
|
|
|
|
|
|
| |
which allows propagation of keys to only the direct dependers of a provider.
--
MOS_MIGRATED_REVID=134337199
|
|
|
|
| |
MOS_MIGRATED_REVID=134334656
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134321948
|
|
|
|
|
|
|
| |
This should now get appropriately embedded into @bazel_tools.
--
MOS_MIGRATED_REVID=134319465
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134312343
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Break Bazel bootstrap on JDK7
*** Original change description ***
Skylark: Give more detailed errors when parsing the arguments
of a SkylarkCallable.
--
MOS_MIGRATED_REVID=134309621
|
|
|
|
|
|
|
| |
The planned replacement of the ApkBuilder with singlejar uses it.
--
MOS_MIGRATED_REVID=134290339
|
|
|
|
|
|
|
| |
sandbox directories could not be cleaned up.
--
MOS_MIGRATED_REVID=134286101
|
|
|
|
|
|
|
| |
...instead of pulling in symbols from indirect dependencies.
--
MOS_MIGRATED_REVID=134283492
|
|
|
|
|
|
|
| |
occasional hangs seen during builds and on Bazel CI.
--
MOS_MIGRATED_REVID=134279208
|
|
|
|
|
|
|
| |
SandboxExecRoot#copyOutputs could hide an earlier ExecException from SandboxRunner#run in the Darwin and Linux sandbox strategies.
--
MOS_MIGRATED_REVID=134273806
|
|
|
|
|
|
|
| |
of a SkylarkCallable.
--
MOS_MIGRATED_REVID=134266707
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134221884
|
|
|
|
|
|
|
|
|
|
|
| |
--experimental_dynamic_configs=notrim mode (since
the whole point of calling it is to figure out which fragments to trim).
This shaves a 25% analysis time penalty over static configs down to 19%.
--
MOS_MIGRATED_REVID=134130771
|
|
|
|
|
|
|
|
|
| |
places we wait for tasks (plural!) submitted to a ForkJoinPool to finish since we actually want to do so interruptibly.
As was to be expected, testing this was tricky :)
--
MOS_MIGRATED_REVID=134128019
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134120579
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134118816
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134116487
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134110312
|
|
|
|
|
|
|
| |
META-INF/). Unix 'file' utility uses it to distinguish jar file from zip file.
--
MOS_MIGRATED_REVID=134102453
|
|
|
|
|
|
|
| |
md5 repeatedly from bash is too slow.
--
MOS_MIGRATED_REVID=134087524
|
|
|
|
|
|
|
| |
Prevents overly large responses from overwhelming grpc.
--
MOS_MIGRATED_REVID=134083479
|