| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113789897
|
|
|
|
|
|
|
|
|
|
|
| |
This is the only variable we need to propagate to bootstrap Bazel.
We might need to have a more principled approach for this, e.g. for
MakeVariables.
Needed for #276.
--
MOS_MIGRATED_REVID=113777759
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes, sha1 values in the generated maven rules contains newlines as
shown in the example below, which breaks the build.
maven_jar(
name = "com_google_code_findbugs_jsr305",
artifact = "com.google.code.findbugs:jsr305:1.3.9",
sha1 = "40719ea6961c0cb6afaeb6a921eaa1f6afd4cfdf
",
)
This change fixes that.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/843
MOS_MIGRATED_REVID=113776575
|
|
|
|
|
|
|
| |
used to be .app)
--
MOS_MIGRATED_REVID=113775781
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113774246
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently for a library:
cc_library(name='a', hdrs=['a.cc'])
we compile a.cc into a.pic.o and link that into its reverse dependencies.
With this change, a .cc file in hdrs will be treated like a .inc file or
a file in textual_hd...
--
MOS_MIGRATED_REVID=113773418
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113772261
|
|
|
|
|
|
|
| |
Needed for #276.
--
MOS_MIGRATED_REVID=113766886
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113765603
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113764325
|
|
|
|
|
|
|
|
|
| |
Also removed some unused code while I was here.
Fixes https://github.com/bazelbuild/bazel/issues/726.
--
MOS_MIGRATED_REVID=113758464
|
|
|
|
|
|
|
|
| |
This makes it simpler to use jvm_flags to configure java agents, or set custom
bootclasspaths.
--
MOS_MIGRATED_REVID=113754498
|
|
|
|
|
|
|
|
|
| |
referenced via the rule class provider (using the RuleDefinitionEnvironment).
This is the second phase of the removal of the TOOLS_REPOSITORY constants.
--
MOS_MIGRATED_REVID=113734334
|
|
|
|
|
|
|
|
|
| |
methods, as we can simply pass an ActionStatusMessage to the EventBus instead. All SpawnActionContexts now send an appropriate message when they execute a Spawn.
This also gets rid of the idiom that an Action knows which strategy will be used to execute it - this decision and knowledge belongs to the executor, not the action.
--
MOS_MIGRATED_REVID=113731846
|
|
|
|
|
|
|
| |
parameter.
--
MOS_MIGRATED_REVID=113730588
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113718154
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interleaved case, loading errors can now also be discovered during the
analysis phase. Add a boolean flag to the SkyframeAnalysisResult to indicate
that such an error happened, and pass it through in BuildView.
Also refactor BuildView to simplify the code a bit - simply pass the
SkyframeAnalysisResult to the createResult method.
There is already an integration test for this - I'm adding a faster unit test
in BuildViewTest, as this is part of the BuildView contract.
--
MOS_MIGRATED_REVID=113716870
|
|
|
|
|
|
|
| |
several params-store into one.
--
MOS_MIGRATED_REVID=113708003
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113692613
|
|
|
|
|
|
|
|
|
| |
generate_workspace was previously leaving '.'s and '-'s in the generated
maven_jar names. This change replaces those characters with '_'s.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/840
MOS_MIGRATED_REVID=113684404
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113681840
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113665305
|
|
|
|
|
|
|
|
| |
We might revisit what the default toolchain for Windows should be, but
this CL uses msys to simplify bootstrapping.
--
MOS_MIGRATED_REVID=113665255
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113664915
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113664066
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113663618
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113660258
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113658912
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113651164
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113649677
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113648546
|
|
|
|
|
|
|
| |
freedom in generating the command line for aapt.
--
MOS_MIGRATED_REVID=113614675
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113608435
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
options actually needed by the fragment. This protects against, e.g.,
unnecessarily duplicating CppConfiguration instances when only Java flags
change.
This is a recommit of ca1b21ac6d8a58041db822725b42de151b163dee which was
rolled back because it broke LIPO.
This change is particularly important for dynamic configurations, which may
mix and match fragments arbitrarily throughout a build. This not only has
performance implications, but also correctness implications: code that
expects two configured targets to have the same fragment (value) shouldn't
break just because the second CT's configuration is a trimmed version of the
first's.
The original change breaks FDO/LIPO because CppConfiguration can't be
shared across configurations. That's because it mutates state when
prepareHook() is called, and each configuration calls prepareHook. We
should ultimately solve this by refactoring the FDO/LIPO implementation
but don't want to block dynamic configuration progress on that. So this
change only enables trimming for dynamic configurations.
--
MOS_MIGRATED_REVID=113570250
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks targets. See []
Manually verified this unbreaks the target mentioned in the bug.
*** Original change description ***
Do not compile source files mentioned in 'hdrs'.
Currently for a library:
cc_library(name='a', hdrs=['a.cc'])
we compile a.cc into a.pic.o and link that into its reverse dependencies.
With this change, a .cc file in hdrs will be treated like a .inc file or
a file in textual_hdrs.
--
MOS_MIGRATED_REVID=113568452
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
The change this relies on is to be rolled back.
--
MOS_MIGRATED_REVID=113564031
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113556731
|
|
|
|
|
|
|
|
| |
This exposes an issue with the new Skyframe-based implementation, which is
fixed here as well.
--
MOS_MIGRATED_REVID=113556169
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks many targets, see []
*** Original change description ***
Reinstate mutable SkylarkDict
Add <String, Object> annotation to optionMap invocation in SkylarkAttr,
to make JDK 1.7 happy.
Give the visible name "aspect" to class SkylarkAspect.
--
MOS_MIGRATED_REVID=113543873
|
|
|
|
|
|
|
| |
--
Change-Id: I86b90ff6eda6a16c2efeb8fffca301e2594c254e
Reviewed-on: https://bazel-review.googlesource.com/#/c/2784/
MOS_MIGRATED_REVID=113529297
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113527098
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113524029
|
|
|
|
|
|
|
| |
Fix a minor bug in the process.
--
MOS_MIGRATED_REVID=113519574
|
|
|
|
|
|
|
|
| |
Add test coverage by re-running BuildViewTest with the new Skyframe loading
phase runner.
--
MOS_MIGRATED_REVID=113517509
|
|
|
|
|
|
|
| |
anymore.
--
MOS_MIGRATED_REVID=113512761
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will fix some issue with loading skylark rules from @bazel_tools.
Tested with ./compile.sh all and also a project that use pkg_tar from
@bazel_tools (which is broken at HEAD).
--
Change-Id: Iffbb7134ef5fee497890c4d01b85084973d45ad0
Reviewed-on: https://bazel-review.googlesource.com/2800
MOS_MIGRATED_REVID=113508661
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113492679
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure to wrap a GlobList into a MutableList in convertToSkylark.
Indeed, GlobList is somehow a SkylarkValue, but is not actually acceptable
as a Skylark value. Until this is cleaned up, tweak convertToSkylark.
Also, robustify ClassObject by eagerly calling convertToSkylark on values.
--
MOS_MIGRATED_REVID=113421790
|
|
|
|
|
|
|
| |
the threshold to 100 ms for two common local actions to avoid spamming the INFO log too much. I would be happy to set the threshold even higher.
--
MOS_MIGRATED_REVID=113413914
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the immutability interfaces of existing implementations.
Eventually we want all implementations to comply, but right now CppConfiguration
is a glaring exception due to FDO/LIPO support.
We don't want more exceptions to arise.
This is prep work for pre-trimming ConfigurationFragment.key's BuildOptions input
to just the options needed by the fragment. That implies fragments can be shared across configurations, so that needs to be safe.
--
MOS_MIGRATED_REVID=113408041
|