| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
I imagine it was used at some point, can't find any usages now.
PiperOrigin-RevId: 189226615
|
|
|
|
| |
PiperOrigin-RevId: 189225279
|
|
|
|
|
|
| |
opposed to reporting errors
PiperOrigin-RevId: 189201637
|
|
|
|
|
|
|
|
|
|
| |
This extends the scalability fix in https://github.com/bazelbuild/bazel/commit/8c5e290dfab3cab378a9ca107ecdd6267403cd4b to apply to statically linked
libraries linked into dynamically linked tests. Otherwise we are still getting
the O(N*M) LTO backend job behavior for those libraries when invoking ThinLTO
on many targets.
RELNOTES: None
PiperOrigin-RevId: 189200150
|
|
|
|
|
|
|
| |
names to time.
RELNOTES: None.
PiperOrigin-RevId: 189198230
|
|
|
|
|
|
|
|
|
| |
here, also slightly restructure the code in #handleLabelsCrossingSubpackagesAndPropagateInconsistentFilesystemExceptions to make it more readable (and defer PackageIdentifier allocations).
Alternatives considered: Add a PathFragment#getParentDirectoryOfRelative(String other) instance method, and use it in PackageFunction#getContainingDirectory. I thought the approach in this CL would be preferable to adding a specialized method like that to PathFragment.
RELNOTES: None
PiperOrigin-RevId: 189197855
|
|
|
|
|
|
| |
Always handle AliasConfiguredTargets as separate nodes from their "actual" value. This is helpful in understanding certain query results e.g. somepath.
PiperOrigin-RevId: 189196863
|
|
|
|
|
|
|
|
|
|
|
| |
binding //external:android/crosstool to an alias in the NDK BUILD file.
This does not change existing behavior until r17 support is released.
https://github.com/bazelbuild/bazel/issues/4742
RELNOTES: None.
PiperOrigin-RevId: 189195669
|
|
|
|
|
|
|
|
|
|
| |
With only the filename the LTO Backend objects are hard to distinguish (i.e.
many files will share the same base filename, but have different paths.
Additionally, this change causes the target specific ".lto" or "shared.nonlto"
subdirectory to be included, which is useful for analysis.
RELNOTES: None
PiperOrigin-RevId: 189194070
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Android tools no longer modify output file
mtimes in hopes of achievening better action
cache hits.
Modifying the mtimes was confusing Bazel and
causing correctness bugs.
Modifying the mtimes is unnecessary because Bazel
is smart about picking up filesystem changes and
observes more signals than just the mtime, though
as the corresponding bug shows it's sadly not
bullet-proof.
Fixes https://github.com/bazelbuild/bazel/issues/4734
Change-Id: I4aa8abf29486841ba8133f927e2816d7f85881fe
Closes #4848.
Change-Id: I0615fae1f20d786771d742705ab4a6ddf7f2306e
PiperOrigin-RevId: 189183742
|
|
|
|
| |
PiperOrigin-RevId: 189181919
|
|
|
|
|
|
|
| |
Unconditionally inject the new values, and let skyframe change pruning avoid over-invalidation.
Change-Id: I3f478ea756121bde1078e9e79ddcfbeb54951cbb
PiperOrigin-RevId: 189156698
|
|
|
|
|
|
| |
Fixes bazelbuild/bazel#4846
PiperOrigin-RevId: 189123353
|
|
|
|
|
|
| |
Makes NestedSetCodec into a runtime codec instead of a Marshaller.
PiperOrigin-RevId: 189110883
|
|
|
|
|
|
|
| |
This change ensures that there is no duplicate aspect in AnalysisResult.
RELNOTES: None
PiperOrigin-RevId: 189086095
|
|
|
|
|
|
| |
Also have each method only test one CPU value, for easier debugging.
PiperOrigin-RevId: 189081488
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 189065642
|
|
|
|
|
|
|
|
| |
These are mostly tests. This is a step toward making the
ar_files/as_files attributes mandatory.
RELNOTES: None.
PiperOrigin-RevId: 189052327
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Causes https://github.com/bazelbuild/bazel/issues/4847
*** Original change description ***
windows: replace custom JunctionResolver
There's a realpath(3)-like Windows API function
called GetFinalPathNameByHandle{A,W}.
This commit removes JunctionResolver, implements
RealPath using GetFinalPathNameByHandleW, and
replaces JunctionResolver usages with RealPath.
PiperOrigin-RevId: 189031288
|
|
|
|
| |
PiperOrigin-RevId: 189023695
|
|
|
|
|
|
| |
instead of JavaCompilationArgsProvider and JavaPluginInfoProvider. This change facilitates the interaction of Java native and Java Skylark code, avoiding code duplication in the future.
PiperOrigin-RevId: 189011873
|
|
|
|
|
|
|
|
|
| |
Also, disallow BazelPackageLoader from fetching missing external repos.
Integration tests for BazelPackageLoader wrt external repos will be left for a follow-up CL.
RELNOTES: None.
PiperOrigin-RevId: 188967694
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As of unknown commit, internal_bootstrap_hack no longer appears
in any BUILD files, so once that CL is clearly landed (without
rollback) we should be able to submit this CL.
There are still some users who set
--experimental_js_proto_generate_js_even_for_bootstrap (including
tools/blaze.blazerc), so we can't remove that flag until all
references are removed.
RELNOTES: internal_bootstrap_hack has been deprecated and removed.
PiperOrigin-RevId: 188952693
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 188937449
|
|
|
|
| |
PiperOrigin-RevId: 188930446
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
large changes:
1. SerializationContext and DeserializationContext become the owners of the Memoizer if requested. They produce new versions of themselves on demand that are memoization-aware. Because of intricacies of Skylark that I do not fully understand, we inject a Mutability object when starting memoization, and so to be conservative, that injection starts up a new memoization frame, nested if we were already memoizing, just like before. It would be nice to decouple this injection from memoization in the future.
2. MemoizingCodec is deleted, but really ObjectCodec becomes MemoizingCodec, so it lives on. BaseCodec is deleted since it now has only one implementation.
3. The simplified model of registering MemoizingCodecs is adopted for ObjectCodecs: all codecs are registered based on their #getEncodedClass and #additionalEncodedSubclasses. This also allows us to register codecs that are defined using tricky parameter types, since we're no longer trying to reflectively examine them. This required a clean-up of such codecs, and the addition of ArrayListCodec to stop NullableListCodec from making lists unmodifiable when they shouldn't be.
4. @AutoCodec is extended to allow users to specify that memoization should start with this codec.
To ensure bit-equivalence, SkyKeySerializer disables memoization.
PiperOrigin-RevId: 188918251
|
|
|
|
|
| |
RELNOTES: Enable dependency checking for aar_import targets.
PiperOrigin-RevId: 188912126
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 188895880
|
|
|
|
|
|
|
|
|
| |
a toolchain type.
Closes #4832.
Change-Id: Ia4fce6dd7003dc441f81ea7ca65ce865ca222142
PiperOrigin-RevId: 188882041
|
|
|
|
|
|
|
|
|
| |
uses toolchains.
Closes #4833.
Change-Id: I9f58dc98cc00d0b2246d479d33a5086114d95073
PiperOrigin-RevId: 188882007
|
|
|
|
|
|
|
|
|
|
| |
The updated test cases in the InMemoryFileSystemTest make
the assumption that /a and /b are not prefixes of the
InMemoryFilesystemTest.workingDir field. This is not safe
and thus use a randomly generated directory name instead
of a hardcoded one.
PiperOrigin-RevId: 188872604
|
| |
|
|
|
|
|
|
|
|
|
| |
CcToolchainProvider instead of BuildConfiguration.
This is a step towards removing BuildConfiguration#getPlatformName().
RELNOTES: None.
PiperOrigin-RevId: 188862029
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently a test class annotated with `@Ignore` will cause the test
runner to fail with
```
Exception in thread "main" java.lang.IllegalArgumentException: Top test must be a suite
at com.google.testing.junit.runner.junit4.JUnit4TestModelBuilder.get(JUnit4TestModelBuilder.java:53)
```
This change treats classes with no tests (either no @Test annotations or
@Ignore at class level) as an empty test suite. The main motivation
behind this is allowing an entire test class to be ignored (e.g. to
quickly deal with a flaky test) without having to modify the BUILD file.
This is desirable in order to reduce the likelihood that a developer
forgets to update the BUILD file when removing the `@Ignore` annotation.
This pull request overrides the previous pull request
https://github.com/bazelbuild/bazel/pull/4073
Closes #4293.
PiperOrigin-RevId: 188850828
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new test utility class
TimestampGranularityUtils which offers methods to
wait for the filesystem timestamp granularity to
pass.
Such waiting is necessary if a test asserts
changes in a file's mtime or ctime.
This is a follow-up to comments on https://github.com/bazelbuild/bazel/commit/a31e035fb42aa8db9fd248ef2ebd665a411053b8.
PiperOrigin-RevId: 188847729
|
|
|
|
|
|
|
|
|
| |
reference, instead of potentially referring to a subtype.
Refactor desugar's class loading machinery and related code into a separate package for easier reuse in this tool.
RELNOTES: None.
PiperOrigin-RevId: 188825305
|
|
|
|
|
|
|
|
| |
This allows more flexibility in registering toolchains and execution
platforms, both in the WORKSPACE and from the command-line.
Change-Id: I6fe75507d1a74de74085b7c927fdf093c152b894
PiperOrigin-RevId: 188813688
|
|
|
|
|
|
|
| |
Removed null-checks since not expecting null. RootedPath's hashCode is called
enough that it's worth optimizing.
PiperOrigin-RevId: 188801280
|
|
|
|
| |
PiperOrigin-RevId: 188799934
|
|
|
|
|
|
|
|
| |
- use Guava to read zip entries
- Fix keep rules emitted for constructors
RELNOTES: None.
PiperOrigin-RevId: 188781547
|
|
|
|
|
|
|
|
|
| |
@AutoCodec. Remove Environment from SkylarkDefinedAspect.
Add a note to BuiltInFunction that we shouldn't need to serialize it because
all instances should be constant.
PiperOrigin-RevId: 188763259
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 188760099
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 188744724
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 188739970
|
|
|
|
|
|
|
| |
It is no longer meaningful since the vfs doesn't have an internal path tree to dump.
RELNOTES: Remove support for blaze dump --vfs. It is no longer meaningful.
PiperOrigin-RevId: 188739379
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 188735555
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Likely cause for non-determinism in skyframe
*** Original change description ***
Cache SkylarkLookupImportValues in memory so that we don't recompute them multiple times.
PiperOrigin-RevId: 188729929
|
|
|
|
|
|
|
|
|
|
|
| |
We don't need to separate them into 4 different flavours, all crosstools define
them identically anyway.
RELNOTES: CppRules: Unified action_configs for static libraries
From now on only c++-link-static-library is read.
PiperOrigin-RevId: 188726352
|
|
|
|
|
| |
RELNOTES:
PiperOrigin-RevId: 188712452
|
|
|
|
|
|
|
|
| |
Increase the connect timeout to 30 seconds Windows sometimes
seems to need more time.
RELNOTES: None
PiperOrigin-RevId: 188702864
|