| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
conflicting actions.
Currently Blaze outputs all mandatory inputs diffs between two actions if they result in conflictions. It is useful debugging information however could be quite large. This change sets the maximum number of records in the diff list to 5.
--
MOS_MIGRATED_REVID=117449664
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117446080
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117438482
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--java_langtools=@bazel_tools//tools/jdk:langtools
--javabuilder_top=@bazel_tools//tools/jdk:JavaBuilder_deploy.jar
--singlejar_top=@bazel_tools//tools/jdk:SingleJar_deploy.jar
--genclass_top=@bazel_tools//tools/jdk:GenClass_deploy.jar
--ijar_top=@bazel_tools//tools/jdk:ijar
--javac_bootclasspath=@bazel_tools//tools/jdk:bootclasspath
--javac_extdir=@bazel_tools//tools/jdk:extdir
--java_toolchain=@bazel_tools//tools/jdk:toolchain
--
MOS_MIGRATED_REVID=117437051
|
|
|
|
|
|
|
|
| |
AspectClass (also SkylarkApsectClass as its implementation) is a part of AspectKey.
DependencyResolver gets the definition of aspect (including
--
MOS_MIGRATED_REVID=117433907
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, this would get thrown when referring to the same package
from both the main and default repositories:
java.lang.IllegalArgumentException: Multiple entries with same key: tools/cpp=/home/brian/971-Robot-Code and tools/cpp=/home/brian/971-Robot-Code
at com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:136)
at com.google.common.collect.RegularImmutableMap.checkNoConflictInKeyBucket(RegularImmutableMap.java:98)
at com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:84)
at com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:295)
at com.google.devtools.build.lib.buildtool.BuildTool.transformPackageRoots(BuildTool.java:301)
at com.google.devtools.build.lib.buildtool.BuildTool.buildTargets(BuildTool.java:209)
at com.google.devtools.build.lib.buildtool.BuildTool.processRequest(BuildTool.java:334)
at com.google.devtools.build.lib.runtime.commands.TestCommand.doTest(TestCommand.java:119)
at com.google.devtools.build.lib.runtime.commands.TestCommand.exec(TestCommand.java:104)
at com.google.devtools.build.lib.runtime.BlazeCommandDispatcher.exec(BlazeCommandDispatcher.java:371)
at com.google.devtools.build.lib.runtime.BlazeRuntime$3.exec(BlazeRuntime.java:1016)
at com.google.devtools.build.lib.server.RPCService.executeRequest(RPCService.java:65)
at com.google.devtools.build.lib.server.RPCServer.executeRequest(RPCServer.java:434)
at com.google.devtools.build.lib.server.RPCServer.serve(RPCServer.java:229)
at com.google.devtools.build.lib.runtime.BlazeRuntime.serverMain(BlazeRuntime.java:975)
at com.google.devtools.build.lib.runtime.BlazeRuntime.main(BlazeRuntime.java:772)
at com.google.devtools.build.lib.bazel.BazelMain.main(BazelMain.java:55)
And this would get thrown for any packages in the main repository loaded
from other repositories:
java.lang.RuntimeException: Unrecoverable error while evaluating node 'PACKAGE:@//tools/build_rules/go/toolchain' (requested by nodes )
at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:982)
at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:499)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: Invalid BUILD file name for package '@//tools/build_rules/go/toolchain': /home/brian/bazel/tools/build_rules/go/toolchain/BUILD
at com.google.devtools.build.lib.packages.Package.finishInit(Package.java:299)
at com.google.devtools.build.lib.packages.Package$Builder.finishBuild(Package.java:1308)
at com.google.devtools.build.lib.skyframe.PackageFunction.compute(PackageFunction.java:501)
at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:933)
... 4 more
Sponsor's comment: note the abundance of new Label.resolveRepositoryRelative() calls. They are ugly, but it's only making existing ugliness explicit. Yes, we should fix it, especially in the implementation of configurable attributes.
Refs #940
--
Change-Id: I8bd7f7b00bec58a7157507595421bc50c81b404c
Reviewed-on: https://bazel-review.googlesource.com/#/c/2591
MOS_MIGRATED_REVID=117429733
|
|
|
|
|
|
|
| |
superfluous .toString() calls from Constants.java .
--
MOS_MIGRATED_REVID=117429096
|
|
|
|
|
|
|
| |
RELNOTES[INC]: Any project that depended on the objc_options rule will be broken. Can be fixed by adding attrs (infoplists,copts) directly to rules depending on the options.
--
MOS_MIGRATED_REVID=117393853
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also enables Jack support to compile with the Java bootclasspath
when running over non-Android rules. This is akin to how normal javac
support works - android_ rules are compiled with android.jar, while
java_libraries are compiled with special flags but the normal compile
time bootclasspath.
As of this change, the android_jack attribute on android_sdk is now
deprecated, and has no further effect. Because it was always optional,
this isn't really much of a change, it just means that now it does
nothing even if you DO specify it.
Because Jack support is still experimental, this should have no effect
on most users.
RELNOTES[INC]: android_sdk now compiles android_jack on the fly from
android_jar, which means android_jar must be a jar and android_jack is
now deprecated. The Jack tools (jack, jill, resource_extractor) must
be specified.
--
MOS_MIGRATED_REVID=117386373
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117383853
|
|
|
|
|
|
|
| |
This will set the default value for the iOS SDK version configuration value. Users can override this by specifying ios_sdk_version themselves.
--
MOS_MIGRATED_REVID=117377043
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117375231
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3a95f353704dc2f7061e2c0786c2459ac1db0fd1.
AbstractSet#removeAll has unexpected, yet oddly intentional (and documented), performance characteristics. Suppose we are evaluating 'set.removeAll(collection)' and 'collection.contains(x)' is 'O(e)'. Then 'set.removeAll(collection)' is 'O(set.size())' when 'set.size() <= collection.size()' and 'O(set.size()) * e' otherwise. When 'collection' is e.g. an ArrayList, 'e' is 'collection.size()' and so 'set.removeAll(collection)' is 'O(set.size() * collection.size())', which is bad.
This meant we had poor performance when the excludes patterns of a glob matched more files than the includes patterns.
Note that, while GlobCache#glob() *did* also use removeAll (potentially inefficiently), it was doing so for each list of exclude glob matches individually. So legacy globbing would have suboptimal performance for 'glob(includes=[i_1, i_2, ...i_k], excludes = [e_1, e_2, ..., e_j])' whenever the result of any e_i was larger than the union of all the includes matches. (But skyframe hybrid globbing has the performance issue when the union of the excludes matches is larger than the union of the includes matches, which is more likely to happen in practice.) I fixed this hypothetical problem too.
--
MOS_MIGRATED_REVID=117367755
|
|
|
|
|
|
|
|
|
|
|
|
| |
- add flag --sandbox_add_path, which takes a list of additional paths as argument and mount these paths to sandbox. Fixes #884.
- mount target of /etc/resolv.conf if it is a symlink. Fixes #738.
RELNOTES:
- add flag --sandbox_add_path, which takes a list of additional paths as argument and mount these paths to sandbox.
- mount target of /etc/resolv.conf if it is a symlink.
--
MOS_MIGRATED_REVID=117364211
|
|
|
|
|
|
|
|
| |
This prevents processors from seeing turbine's version of e.g. guava. javac is
still available becuase Blaze puts it on the bootstrap classpath.
--
MOS_MIGRATED_REVID=117363448
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117361388
|
|
|
|
|
|
|
| |
collectProguardSpecsFromAttribute work with attributes added by Aspects.
--
MOS_MIGRATED_REVID=117343880
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117340875
|
|
|
|
|
|
|
| |
--
Change-Id: Ib7d2e97a62fab06e47d3c1504f47c5e30933524e
Reviewed-on: https://bazel-review.googlesource.com/#/c/3073/
MOS_MIGRATED_REVID=117340155
|
|
|
|
|
|
|
| |
//third_party/protobuf.
--
MOS_MIGRATED_REVID=117336377
|
|
|
|
|
|
|
| |
getGeneratingSpawnAction.
--
MOS_MIGRATED_REVID=117290280
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117277091
|
|
|
|
|
|
|
|
|
| |
This makes it possible to isolate coverage runs for Apple platforms and perform a different set of operations.
RELNOTES:
--
MOS_MIGRATED_REVID=117269972
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117268295
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117262661
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117260412
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117238298
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One can now invoke native.bazel_version to get the version of Bazel from
the WORKSPACE file.
This can be used to do version check, for instance:
version.bzl:
def check_version(x):
if native.bazel_version < x:
fail("Current Bazel version is {}, expected at least {}".format(native.bazel_version, x))
WORKSPACE:
load("//:version.bzl", "check_bersion")
check_version("0.2")
Fixes #1014.
--
MOS_MIGRATED_REVID=117231557
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add end-to-end tests for very basic properties of the new
experimental UI.
- At some point during a successful build, we should see an
N / M actions progress bar status indicator.
- Curses are used to erase some lines.
- On a successful test, PASS is written in green.
- On a failed test, FAIL is written in red bold.
--
Change-Id: I0130017949330882ca6b33552cd288286a4f5b6f
Reviewed-on: https://bazel-review.googlesource.com/#/c/3080
MOS_MIGRATED_REVID=117230615
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117202268
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117186609
|
|
|
|
|
|
|
|
|
|
|
| |
This was a leftover from the global cleanup change to replace
the usages of static final fields on Guava's CharMatcher with
their equivalent static factory methods.
--
Change-Id: I9ee765a2545eabdd01b00e4ea924801b7a88898a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3060
MOS_MIGRATED_REVID=117160725
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117153381
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117151379
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117139503
|
|
|
|
|
|
|
| |
preserve order of glob matches: Parallelize fetches of symlink file values, subdirectory globs, and subdirectory package lookup values. This should improve change pruning speed when we have to check a glob. It also keeps GlobFunction closer to the contract of Skyframe, because in order to avoid quadratic restarts, it wasn't checking for missing deps between getValue calls.
--
MOS_MIGRATED_REVID=117139471
|
|
|
|
|
|
|
| |
referenced from the crosstool without crossing package boundaries.
--
MOS_MIGRATED_REVID=117137594
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117123912
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the experimental UI has the first properties we want to keep
in the long run, add a test asserting the following semantic
properties.
- Whenever only one action is running, it is shown somehow in the
progress bar.
- Completed actions should not be shown in the progress bar.
- The earliest-started still running action should be visible in
the progress bar.
While there, also drop the assumption in the ExperimentalStateTracker
that the ExecutionProgressReceiverAvailableEvent has to come before
any actions that has not been finished yet.
--
Change-Id: Ica52eb12546703e4f8f9d9c64928208621d19ced
Reviewed-on: https://bazel-review.googlesource.com/#/c/3048
MOS_MIGRATED_REVID=117121300
|
|
|
|
|
|
|
|
|
|
| |
Previously it was only collecting custom per-rule bootclasspaths (e.g. from
android_library, which uses android.jar instead of the default Java
bootclasspath). This allows the java.compilation_info.boot_classpath Skylark
provider to work for regular Java rules.
--
MOS_MIGRATED_REVID=117031832
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117018073
|
|
|
|
|
|
|
| |
java_toolchain.jvm_opts was being used instead of javac options.
--
MOS_MIGRATED_REVID=117016052
|
|
|
|
|
|
|
|
| |
This will avoid confusion with the normal Skylark rule context.
Also fixed indentation of cc_configure.bzl
--
MOS_MIGRATED_REVID=117011107
|
|
|
|
|
|
|
| |
Fixes #1030.
--
MOS_MIGRATED_REVID=117009021
|
|
|
|
|
|
|
|
|
| |
used to accept obc_binaries as well.
RELNOTES: You can no longer use objc_binary targets for the xctest_app attribute of an ios_test rule.
--
MOS_MIGRATED_REVID=117004358
|
|
|
|
|
|
|
| |
removed with unknown commit)
--
MOS_MIGRATED_REVID=117003728
|
|
|
|
|
|
|
| |
given application as there are cases where you want both.
--
MOS_MIGRATED_REVID=116998425
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Second in a sequence of CLs to deflake #simpleCounter. The condition,
commented out in a previous CL, was checking a property that wasn't
deterministic. The maxRunningConcurrently could be either one or two
depending on how quickly the AbstractQueueVisitor scheduled the
runnables.
Also added documentation to a confusing constructor call and removed
dead code.
--
MOS_MIGRATED_REVID=116995523
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116990273
|
|
|
|
|
|
|
|
|
|
| |
srcs instead of throwing an error.
Implicit exporting of the deps of an android_library rule that doesn't have srcs
is deprecated and will soon be removed.
--
MOS_MIGRATED_REVID=116988446
|