aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Remove some unused extension points.Gravatar Googler2017-11-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 177326265
* Add some minor debugging messages to discard_analysis_cache_test, ↵Gravatar janakr2017-11-29
| | | | | | | | purportedly to diagnose issue #4181. My real hope is to achieve the effect I got in discard_graph_edges_test, where the debugging messages seem to have made the flakiness go away, but since this is less multithreaded, I'm less hopeful. PiperOrigin-RevId: 177325229
* Move CcToolchainTypeRule to CPP_RULES, as opposed to PLATFORM_RULES. It ↵Gravatar cpeyser2017-11-29
| | | | | | more logically belongs with other c++ rule types. PiperOrigin-RevId: 177313718
* RestBlobStore: add missing CAS_PREFIXGravatar nicolov2017-11-29
| | | | | | | | | According to the SimpleBlobStore interface `containsKey` should look up blobs in the CAS. However, the URL it requests is missing `CAS_PREFIX`, so it will never find anything. Closes #4118. PiperOrigin-RevId: 177313658
* Create the output source jar in java_common.compileGravatar elenairina2017-11-29
| | | | | | | | | | | | | | | | | and expose transitive source jars to Skylark. Initial change was rolled back (unknown commit). java_common.compile wouldn't fill the JavaRuleOutputJarsProvider when there was only one input source jar. Fixed that and added test (there was one before, but didn't check this particular provider). Slightly refactor java classes to take in specific host javabase inputs and host java executable for creating the source jar, instead of always relying on fetching them from native java rules specific attributes. Creating the output source jar in java_common.compile makes the behavior more similar to java_library. Exposing the transitive_source_jars to Skylark helps with the Skylark migration from the old 'java' provider to JavaInfo. Progress on #2614. RELNOTES: transitive_source_jars is now exposed on JavaInfo. PiperOrigin-RevId: 177311138
* Fix strip-prefix typo in docsGravatar Ed Baunton2017-11-29
| | | | | | | | The usage is `strip_prefix` not `strip-prefix`. Closes #4162. PiperOrigin-RevId: 177311042
* Convert TestAspects to MockRule.Gravatar gregce2017-11-29
| | | | | | It'd be nice to go further and break out a bunch of this code into more generally useful places (especially for callers that don't care about aspects). But that's a big mess and beyond the scope of what I'm aiming for here. PiperOrigin-RevId: 177307854
* MockRule enhancements.Gravatar gregce2017-11-29
| | | | | | | | - Support custom ancestors and rule implementations. - Refactor defaults into MockRuleDefaults. - More thorough documentation. PiperOrigin-RevId: 177303642
* BEP: Extend TestResult to optionally contain meta dataGravatar aehlig2017-11-29
| | | | | | | | Extend the protocol to support also showing meta data about an action execution, if the underlying test action is able to report it. PiperOrigin-RevId: 177294531
* Implemented fix for case when 'use_testrunner' attribute works ↵Gravatar dbabkin2017-11-29
| | | | | | | | | | | | | | | | interconnected with 'main_class' in java_test rule. for manual testing I used BUILD file: java_test( name = "mytest", srcs = glob(["*.java"]), main_class = "com.test.Test", use_testrunner = 1, ) RELNOTES: java_tests no complain when use_testrunner is explicitly set to 1 and main_class is set. PiperOrigin-RevId: 177291746
* Add user and system time to CommandResults, and plumb them into SpawnResults.Gravatar ruperts2017-11-29
| | | | | RELNOTES: None PiperOrigin-RevId: 177290508
* Clean up ExecutionRequirementsGravatar ulfjack2017-11-29
| | | | | | | | | | | | | | | | | | | - remove BaseSpawn.Local; instead, all callers pass in the full set of execution requirements they want to set - disable caching and sandboxing for the symlink tree action - it does not declare outputs, so it can't be cached or sandboxed (fixes #4041) - centralize the existing execution requirements in the ExecutionRequirements class - centralize checking for execution requirements in the Spawn class (it's possible that we may need a more decentralized, extensible design in the future, but for now having them in a single place is simple and effective) - update the documentation - forward the relevant tags to execution requirements in TargetUtils (progress on #3960) - this also contributes to #4153 PiperOrigin-RevId: 177288598
* Minor fixes to spacing in help messagesGravatar Mike Morearty2017-11-29
| | | | | | | | A few help messages were missing a space after the period at the end of a sentence. Closes #4094. PiperOrigin-RevId: 177282132
* Various Shell Script Fixes and Improvements - Part OneGravatar Androbin2017-11-29
| | | | | | | | see #4023 Closes #4051. PiperOrigin-RevId: 177279457
* Change error on adding a directory to the remote cache to be non-fatalGravatar Rahul Malik2017-11-29
| | | | | | | | | | @ulfjack @buchgr - I'm resubmitting https://github.com/bazelbuild/bazel/pull/3984 on behalf of @mterring to get past CLA issues that are holding it up from merging. This is a temporary fix for the issue https://github.com/bazelbuild/bazel/issues/3891 while we wait for https://github.com/bazelbuild/bazel/pull/4011 to be reviewed and tested Closes #4188. PiperOrigin-RevId: 177276751
* Make process-wrapper output execution statistics for executed commands.Gravatar ruperts2017-11-28
| | | | | | | For example, it now outputs resource usage statistics like the amount of user time and system time used. RELNOTES: None PiperOrigin-RevId: 177263221
* Automatic code cleanup.Gravatar cushon2017-11-28
| | | | PiperOrigin-RevId: 177261837
* Update PathPackageLocator to take a list of potential build file names,Gravatar John Cater2017-11-28
| | | | | | | | | | | | | | instead of assuming BUILD. - Default the list to the same value as PackageLookupFunction: BUILD.bazel, BUILD. - Move BuildFileNames to the packages package, so it is more generally available. Part of #4056. Change-Id: Ie12512b492cd7d47a9e56ec3bc209f829feaf4b5 PiperOrigin-RevId: 177261295
* Remove process-wrapper duplication from RunCommand.Gravatar ruperts2017-11-28
| | | | | | | Also rename ProcessWrapperRunner to ProcessWrapperUtil, since it isn't really a Runner (it doesn't run anything). RELNOTES: None. PiperOrigin-RevId: 177260951
* Make turbine tests more compatible with WindowsGravatar cushon2017-11-28
| | | | | | See bazelbuild/bazel#4165. PiperOrigin-RevId: 177254510
* Ensure the argument to JarCreator.addDirectory existsGravatar cushon2017-11-28
| | | | | | Follow-up to https://github.com/bazelbuild/bazel/commit/0b2352de3101e87647d083f6089246079dda0f75 PiperOrigin-RevId: 177234776
* Extract CONTAINS_JAVA_PROVIDER to a shared constantGravatar cushon2017-11-28
| | | | | | Pre-factoring for unknown commit. PiperOrigin-RevId: 177232397
* Move CppConfiguration#getFullyStaticLinkOptions, #getMostlyStaticLinkOptions,Gravatar cpeyser2017-11-28
| | | | | | | | | | | and #getDynamicLinkOptions to CppHelper. This allows toolchain information needed by those methods to move to CcToolchainProvider. The migration of toolchain information from CppConfiguration to CcToolchainProvider is required to move the c++ rules to platform-based toolchain selection. PiperOrigin-RevId: 177230635
* Fix typo, remove stale commentGravatar brandjon2017-11-28
| | | | | RELNOTES: None PiperOrigin-RevId: 177224445
* Make check_fileset_dependencies_recursively flag a no-op. We will always ↵Gravatar kush2017-11-28
| | | | | | | behave as if this flag is true. RELNOTES: None PiperOrigin-RevId: 177219652
* Eliminate STATIC_FRAMEWORK_DIR as a separate field of ObjcProvider.Gravatar cparsons2017-11-28
| | | | | | | | | Infer those values from STATIC_FRAMEWORK_FILE. This correctly dedupes static frameworks between an app and its dylibs. RELNOTES: None. PiperOrigin-RevId: 177214770
* Document Android options.Gravatar ajmichael2017-11-28
| | | | | RELNOTES: None PiperOrigin-RevId: 177195468
* Update blazerc documentation in the blaze/bazel user mannuals.Gravatar ccalvarin2017-11-28
| | | | | | | Update the docs for clarity and to explain the --expand_configs_in_place alternate expansion behavior. RELNOTES: None. PiperOrigin-RevId: 177183524
* Print 'waiting for other blaze command' on its own line.Gravatar Googler2017-11-28
| | | | | | | | | | It now prints a newline char immediately, rather than waiting until the lock is released, and printing 'done!' at the end of the line. This allows per-line parsers (like IntelliJ) to display this progress notification without special-case hacks. PiperOrigin-RevId: 177180918
* Automated rollback of commit b64119807b014d9f3b99fb8a02e22daf1a8299b6.Gravatar nharmata2017-11-28
| | | | | | | | | | | | | *** Reason for rollback *** Tickles the shell integration test version of b/35042288 *** Original change description *** Change BlacklistedPackagesPrefixesFunction to take a pair of a hardcoded set of directories and a file path containing more directories to blacklist. The current usage of PrecomputedValue#BLACKLISTED_PACKAGE_PREFIXES_FILE is overly general and is only meaningfully used by unit tests; in practice, the blacklist file path can never change over the lifetime of the Bazel server. Perform a minor simplifying refactor as a result of this. RELNOTES: None. PiperOrigin-RevId: 177176068
* Migrate some Skylark tests outside of Blaze.Gravatar laurentlb2017-11-28
| | | | | RELNOTES: None PiperOrigin-RevId: 177169878
* Remove dead code from CompilationSupportGravatar cparsons2017-11-28
| | | | | RELNOTES: None. PiperOrigin-RevId: 177165649
* Change BlacklistedPackagesPrefixesFunction to take a pair of a hardcoded set ↵Gravatar nharmata2017-11-28
| | | | | | | of directories and a file path containing more directories to blacklist. The current usage of PrecomputedValue#BLACKLISTED_PACKAGE_PREFIXES_FILE is overly general and is only meaningfully used by unit tests; in practice, the blacklist file path can never change over the lifetime of the Bazel server. Perform a minor simplifying refactor as a result of this. RELNOTES: None. PiperOrigin-RevId: 177164057
* Migrate callsites of CppConfiguation#getCompiler, #getTargetLibc, #getCpu toGravatar cpeyser2017-11-28
| | | | | | | CcToolchainProvider. Toolchain information must be removed from CppConfiguration to allow the c++ rules to use hermetic platforms. PiperOrigin-RevId: 177163880
* Shard android_sdk_integration_test.sh. 45 seconds (60%) reduction.Gravatar jingwen2017-11-28
| | | | | | | | | | | | | | Before: //src/test/shell/bazel/android:android_sdk_integration_test PASSED in 75.4s After: //src/test/shell/bazel/android:android_sdk_integration_test PASSED in 30.2s Stats over 3 runs: max = 30.2s, min = 16.0s, avg = 22.4s, dev = 5.9s RELNOTES: None. PiperOrigin-RevId: 177155880
* refactor: remove unnecessary Enums from ExpanderGravatar L?szl? Csomor2017-11-28
| | | | | | | | | | | | | | | These enums were only used inside the class and only to slighlty improve readability. The Tokenize enum was a simple boolean. The Options enum was implementing two boolean flags, and it improved call-site readability at the cost of implementation-site readability and checking if the value is set via set-containment. Change-Id: I3858ff0c67f89c8b2c5631e260ce79cd939c6eb1 PiperOrigin-RevId: 177155294
* refactor: mv LocationExpander.Options to ExpanderGravatar L?szl? Csomor2017-11-28
| | | | | Change-Id: I4bcc7c0024646b7d4372464f5290375d41702429 PiperOrigin-RevId: 177150713
* Let to push lambda arguments not only with *LOAD instructions but with ↵Gravatar Googler2017-11-28
| | | | | | | SIPUSH and *CONST_*. RELNOTES: None PiperOrigin-RevId: 177149410
* refactor: add LocationExpander factoriesGravatar L?szl? Csomor2017-11-28
| | | | | | | | | | | | | | | | | | Stop using LocationExpander.Options in LocationExpander constructors, because the Options semantics are confusing. I also need the refactoring in order to extend the expansion semantics: to support expanding to absolute paths on Windows, where $(location) should not expand to the (non-existent) runfiles path, but to the absolute path the runfiles symlink would point to. See https://github.com/bazelbuild/bazel/issues/4171 Change-Id: Ie4d47ec3807bc3c6e39156efa1746b666f69f99c PiperOrigin-RevId: 177147372
* Prepare code using ASM for Java 9Gravatar cushon2017-11-28
| | | | PiperOrigin-RevId: 177138150
* Simplify SpawnRunner interfaceGravatar ulfjack2017-11-28
| | | | | | | | | | | | | | It turns out that the SUCCESS status is often misunderstood to mean "zero exit", even though this is clearly documented. I've decided to add another status for non-zero exit, and use success only for zero exit to avoid this pitfall. Also, many of the status codes are set, but never used. I decided to reduce the number of status codes to only those that are actually relevant, which simplifies further processing. Instead, we should add a string message for the error case when we need one - we're not using it right now, so I decided not to add that yet. PiperOrigin-RevId: 177129441
* Change Mock{Android,Java}Support to actually import test runner related jars ↵Gravatar dannark2017-11-27
| | | | | | | so that integration tests can use them. RELNOTES: None PiperOrigin-RevId: 177113967
* Remove unused flag.Gravatar Googler2017-11-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 177113477
* Stop splitting classpath argumentsGravatar cushon2017-11-27
| | | | | | Blaze now passes class paths as individual arguments, instead of a pre-joined. PiperOrigin-RevId: 177112933
* Use java.nio.file.Paths instead of strings in JavaBuilderGravatar cushon2017-11-27
| | | | | | This avoids bazelbuild/bazel#4108. PiperOrigin-RevId: 177096864
* Delete --experimental_use_manifest_from_resource_apk again.Gravatar ajmichael2017-11-27
| | | | | RELNOTES: None PiperOrigin-RevId: 177068047
* Revert unintentional increase in logging.Gravatar apell2017-11-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 177049661
* Shard android_ndk_integration_test.Gravatar ajmichael2017-11-27
| | | | | | | | | | | | | | | | | Before this CL with --runs_per_test=10 on 2015 Macbook Pro INFO: Elapsed time: 622.222s, Critical Path: 314.33s //src/test/shell/bazel/android:android_ndk_integration_test TIMEOUT in 10 out of 10 in 314.3s Stats over 10 runs: max = 314.3s, min = 306.1s, avg = 308.9s, dev = 3.5s After this CL with --runs_per_test=10 on 2015 Macbook Pro INFO: Elapsed time: 875.356s, Critical Path: 148.11s //src/test/shell/bazel/android:android_ndk_integration_test PASSED in 148.1s Stats over 60 runs: max = 148.1s, min = 25.3s, avg = 70.2s, dev = 38.7s RELNOTES: None PiperOrigin-RevId: 177048666
* Never allow local_resource_files in single-process testsGravatar Googler2017-11-27
| | | | | RELNOTES: None PiperOrigin-RevId: 177048616
* Support nested set serialization.Gravatar tomlu2017-11-27
| | | | PiperOrigin-RevId: 177032673
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-06 01:55:14 +0000